GitLab

https://webrtc.googlesource.com/src.git/+log/c8993d8b01c9..9923353600ea


git log c8993d8b01c9..9923353600ea --date=short --no-merges --format='%ad %ae %s'
2018-08-20 phoglund@webrtc.org Make ensure webcam script do nothing on linux.
2018-08-19 peah@webrtc.org AEC3: Loosen the echo removal requirements in conservative mode
2018-08-17 buildbot@webrtc.org Roll chromium_revision 77bf1926..63fab7f6 (584099:584203)
2018-08-17 peah@webrtc.org AEC3: Added parameters for bypassing the suppressor


Created with:
  gclient setdep -r src/third_party/webrtc@9923353600ea

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:875611,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I120d428033ba4318196ad043d88619445d150d26
Reviewed-on: https://chromium-review.googlesource.com/1180044Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584384}

Bug: none
Change-Id: I0504191f5ca6b16c36660a2d6de278d3205fc898
Reviewed-on: https://chromium-review.googlesource.com/1179822Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Drew Wilson <atwilson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584383}

Bug: 867488
Change-Id: I886f26467826aa4c2beda38785bd4961f375e338
Reviewed-on: https://chromium-review.googlesource.com/1174699Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584382}

This reverts commit 7ec7b146.

Reason for revert: The crash has now been fixed, really, by r580102 and r580149.

Original change's description:
> Revert "service worker: Remove instrumentation for ServiceWorkerObjectHost crash."
> 
> This reverts commit bdff024c.
> 
> Reason for revert:
> It turns out the crash was still happening up to 70.0.3501.2, before
> this was committed. The crash went away since 70.0.3502.0, but it's
> unclear whether that was because the instrumentation was removed or
> the "quick fix" was removed at the same time (r577435).
> 
> I'm removing the instrumentation to see if the crashes will return.
> 
> Original change's description:
> > service worker: Remove instrumentation for ServiceWorkerObjectHost crash.
> > 
> > Remove the instrumentation from issue 854993 (and duped issue 838410) as
> > it is now fixed.
> > 
> > This is mostly a straight revert of the CLs, but it retains some
> > checks as DCHECKs and other improvements like adding constness.
> > 
> > Bug: 866769, 854993
> > Change-Id: Id617e06e85e2b947258ba5f80c1d7aa0396888af
> > Reviewed-on: https://chromium-review.googlesource.com/1147888
> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> > Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577430}
> 
> TBR=falken@chromium.org,kinuko@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 866769, 854993
> Change-Id: I169f6c894d862008f4cfb0b778cd6f657b8351c0
> Reviewed-on: https://chromium-review.googlesource.com/1154740
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579004}

TBR=falken@chromium.org,kinuko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 866769, 854993
Change-Id: Ifacb8a30b851dc0d9808b26e01fecbd3dbbdb45d
Reviewed-on: https://chromium-review.googlesource.com/1180901Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584381}

https://chromium.googlesource.com/angle/angle.git/+log/5055fba5692f..f26b27e29535


git log 5055fba5692f..f26b27e29535 --date=short --no-merges --format='%ad %ae %s'
2018-08-20 oetuaho@nvidia.com Add some shared utilities for multiview tests


Created with:
  gclient setdep -r src/third_party/angle@f26b27e29535

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: Ie0b6d003ad7e4e3a845a972d4a35cabfa5ae70d6
Reviewed-on: https://chromium-review.googlesource.com/1180043Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#584380}

Language preferences are removed from the persistent storage list for
incognito mode.
After this CL, if this preference is changed from incognito mode,
it is only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Ia013aaf468aa29b2efcfcb670003f09535e2a060
Reviewed-on: https://chromium-review.googlesource.com/1174118Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584379}

This CL is the 5th step of the plan below aiming to eliminate the native
struct content::ServiceWorkerResponse defined in
content/common/service_worker/service_worker_types.h.

1st step:
https://chromium-review.googlesource.com/c/chromium/src/+/1134731

2nd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1149706

3rd step:
https://chromium-review.googlesource.com/c/chromium/src/+/1155999

4th step:
https://chromium-review.googlesource.com/c/chromium/src/+/1164848

5th step: (this CL)
- Remove content::ServiceWorkerResponse

Bug=789854

Change-Id: I527f76f79f8614acafd7e414f4c1044d8a7be64e
Reviewed-on: https://chromium-review.googlesource.com/1180738Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584378}

TabLifecycleUnitSource checked for an instance of PageSignalReceiver
both when subscribing and unsubscribing to/from it.  The
PageSignalReceiver::GetInstance() called its static IsEnabled()
method first; the latter returned false if
content::ServiceManagerConnection::GetForProcess() returned nullptr.

Normally, PageSignalReceiver is a static singleton with NoDestructor
wrapper, and TabLifecycleUnitSource is owned by the browser process, so
the above chain might result in that TabLifecycleUnitSource would not
unsubscribe because ServiceManagerConnection for process was already
destroyed.

The bug is subtle and fires sporadically in random unit tests.

R=haraken@chromium.org

Change-Id: I34827b3a598f39f38a05c8d68cb3953009454aac
Reviewed-on: https://chromium-review.googlesource.com/1180216Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Dunaev <voodoo@yandex-team.ru>
Cr-Commit-Position: refs/heads/master@{#584377}

Bug: 795989
Change-Id: Ieb5267a87b43f14a6ae3f3bc29b14402afd2e3ab
Reviewed-on: https://chromium-review.googlesource.com/1166277
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584376}

This patch moves IDBRequest::did_throw_in_event_handler_ to
Event::legacy_did_listeners_throw_flag_, which corresponds to
legacyOutputDidListenersThrowFlag in DOM standard:
https://dom.spec.whatwg.org/#concept-event-listener-inner-invoke
(See "Note: The legacyOutputDidListenersThrowFlag is only used by
Indexed Database API.")

There is no behavioral change. This is a small refactoring.

The reason is that it's smarter (and less fragile) to have a
bit flag inside Event to indicate exceptions than letting each
EventTarget maintain the flag. It's guaranteed that each Event
resets the bit flag, no dependency to EventTarget, ability to
detect whether any of listeners throws an exception, etc.

Change-Id: Ie37f9def9e37ac220ea755b1483656f922edfc37
Reviewed-on: https://chromium-review.googlesource.com/1179729Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584375}

In order to make "GetSource() == nullptr"
the single source of truth for whether "the script's script is null".

Bug: 686281
Change-Id: I517c22c38e0b2851722a1cb9211654216d459f13
Reviewed-on: https://chromium-review.googlesource.com/1179558
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584374}

It will be needed in BMO's TabHelper to start installation.

It is similar to extensions::IsValidBookmarkAppUrl
but:
- Doesn't use extensions/common/url_pattern.h
- Reports chrome-extension:// url scheme as invalid.
- Reports filesystem: and any inner URL schemes as invalid.

Bug: 875698
Change-Id: I627a8e47593c698ef7acfc286cc310181b095685
Reviewed-on: https://chromium-review.googlesource.com/1180825
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584373}

Use BookmarkAppHelper to perform all necessary steps to install a
Bookmark App based on a WebContents.

Bug: 864904

Change-Id: I3c243714236caf2b93c93adfc8c62e5ee0e69ae9
Reviewed-on: https://chromium-review.googlesource.com/1163417
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584372}

As a preparation for
https://chromium-review.googlesource.com/1179488,
this CL stops creating ClassicScript when ErrorOccurred() is true.

Instead of setting |error_occurred| bool, this CL makes
PendingScript::GetSource() return nullptr if an error occurred.
This is consistent with the spec:

- GetSource() corresponds to "the script's script".
- GetSource() == nullptr (previously |error_occurred| == true)
  corresponds to "the script's script is null".

Bug: 875153, 686281
Change-Id: I08d891ce2207894b4a8f8a2d1171f9912c79b8ce
Reviewed-on: https://chromium-review.googlesource.com/1179557Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584371}

Tab stats metrics preferences are moved to the persistent storage list
for incognito mode.
This CL does not make any behavioral change.

Bug: 861722
Change-Id: I052c8a62d4818a31451ff19baf815848bd3e3294
Reviewed-on: https://chromium-review.googlesource.com/1179145
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584370}

kCrossDevicePromo* preferences are removed.

Bug: 861722
Change-Id: Ica9b5aa7c0002479c57321aedde3e20ab33e25ca
Reviewed-on: https://chromium-review.googlesource.com/1179148Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584369}

BUG=873903

Change-Id: I2682b57782944dd61365d8f1b698aa53a604fb5c
Reviewed-on: https://chromium-review.googlesource.com/1177208
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584368}

Windows promotion preferences are removed from the persistent storage
list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: I2c806b403ecbcf25ce0aab7984e6c313dbc81912
Reviewed-on: https://chromium-review.googlesource.com/1179146Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584367}

This CL adds the HostedAppButtonContainer to GlassBrowserFrameView's
hit detection to ensure the correct mouse signal is sent to the OS.
This fixes a bug in Windows 10 causing certain mouse movements to
deactivate the page info dialog. See screencasts.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=352755&signed_aid=IbjUxm1YHiMINVDpeUwCXQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=352756&signed_aid=-NF8jWWjNwiA1KrUMeuVkQ==&inline=1

Bug: 864386
Change-Id: Ic706784026431d603b44c1a80302fe0f92ee5868
Reviewed-on: https://chromium-review.googlesource.com/1170664
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584366}

Media Router preferences are removed from the persistent storage
list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: Ice965ba421945c6408b6c13b248acafe4181c76f
Reviewed-on: https://chromium-review.googlesource.com/1179147
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584365}

clang-cl's diagnostics messages are different to clang++ or gcc. That is
not very convenient for the editor support like Emacs compilation mode.

This CL adds a configuration flag, use_clang_diagnostics_format, to use
clang/gcc style diagnostics.

Change-Id: I92599c6025d36af7eff74454d58e2f74e516c627
Reviewed-on: https://chromium-review.googlesource.com/1061034
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584364}

The function BridgedNativeWidget::SetBounds calls back into the
NativeWidgetMac to determine
- the minimum content size
- if the widget's position should be relative to the parent or the
  screen (and the offset to do that computation)
- if the widget is a modal sheet
This call will eventually be running in the app shim process, where
these values will not be available (without adding a synchronous IPC).

Change NativeWidgetMac::SetBounds to call BridgedNativeWidgetHostImpl::
SetBounds, and have that function pre-compute the required parameters,
- minimum content size
- offset necessary to be applied to compensate for position being
  relative to the parent or the screen
- (but not if the widget is a modal sheet, that's coming later)
and pass these as parameters to BridgedNativeWidget::SetBounds.

Split out the SetBounds calls made during initialization from
being within BridgedNativeWidget::Init to being made by its caller,
BridgedNativeWidgetHostImpl::InitWindow, to allow the additional
parameters to be passed in.

This is a re-land of crrev.com/584327 (reverted in crrev.com/584339)
with the logic for initial bounds setting separated out into the
BridgedNativeWidget::SetInitialBounds (merging the behaviors was too
ambitious).

TBR=ellyjones (original reviewer)

Bug: 859152
Change-Id: I98b6a5d419e586fb2697ef3b45fdc19c73f9c619
Reviewed-on: https://chromium-review.googlesource.com/1180715Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584363}

This CL fixes a reentrancy issue in MessagePopupCollection that might
cause crash on devices with small screen height.
We should set |is_updating_| to true when we call MessagePopupView::
UpdateContents(). Updating contents can change its height, and it might
cause the popup to be dismissed because the screen height might not be
enough to show the notification. The popup should be closed after the
update is finished, but we didn't set |is_updating_| to true, so the
popup could accidentally close during UpdateContents().

We didn't catch this until a11y related change
https://crrev.com/c/1166231 because |message_view_| was not used after
NotifyPopupResized() in MessagePopupView::UpdateContents().

TEST=MessagePopupCollection.UpdateContentsCausesPopupClose
BUG=874777

Change-Id: I29cfffec7e967254da0d880667e38805d0cded5a
Reviewed-on: https://chromium-review.googlesource.com/1179506
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584362}

There are three places that use |IDS_CONTROLLED_SETTING_POLICY|, but
AFAIK there's no need to change the other two places
(arc_support_host.cc and extensions_ui.cc).

Bug: 873946
Change-Id: I34e9fb0a20139b0aaca6380e949248745f50ed58
Reviewed-on: https://chromium-review.googlesource.com/1180526Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584361}

Have DemoModeResourcesRemover keep track of amount of time the user is
interacting with the device (using UserActivityDetector), and once the
total amount of active usage is over 8 hours, attempt demo mode
resources removal - substantial amount of active usage should be a good
signal that the device has been owned by a real user.

BUG=827368
TEST=unittests

Change-Id: Ib7b90da7da41bdcebbead0f0239579e727f07ae8
Reviewed-on: https://chromium-review.googlesource.com/1180603Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584360}

This test has been flaky on Mac10.13 Tests

TBR=weili@chromium.org

Bug: 875707
Change-Id: I71e1f70fb1e7628ba810dccf603d4d58885abb9c
Reviewed-on: https://chromium-review.googlesource.com/1180798Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584359}

When PreDispatchEventHandler is called, Event object was passed as a
parameter. and it is never nullptr.
so it can be changed to reference instead of pointer.

Bug: 871637
Change-Id: Id8f1b05c51024e6418eaf2e7517f6dfb2ec70699
Reviewed-on: https://chromium-review.googlesource.com/1179520Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#584358}

This brings us into alignment with the Fetch Standard as well as Firefox and
Edge.

Bug: 165083, 874536
Change-Id: Id06d07d301aeae8bd0c48bfe94df68cf1ed68db9
Reviewed-on: https://chromium-review.googlesource.com/1176263Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584357}

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iccd919105fd31fbe83b75d87f15f206e5ad30d36
Reviewed-on: https://chromium-review.googlesource.com/1179514
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584356}

Change-Id: I7d9700f70be42f30239d0b6c5a73a0c852ae416c
Reviewed-on: https://chromium-review.googlesource.com/1179723Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584355}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: Ief7b6878df09e6aae94c1ef3febbdad6cfc04f3a
Reviewed-on: https://chromium-review.googlesource.com/1180711Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584354}

This patch fixes the incorrect updating algorithm of |bytes_compared_|
in DoReadDataForCompareDone. This variable represents the amount of data
from the network which is confirmed to be identical with the cached data,
and is updated every time the comparison finishes for a chunk of data
from the network. Previously it was incremented only by the amount of
bytes read from the cache, which can be less than the size of the chunk
of data from the network in the cases where the cache writer does not
finish the comparison in single read from the cache because the network
data is too large.

Bug: 871655
Change-Id: Ie3e0f192713b5d38582628c72175e4f7aa6771da
Reviewed-on: https://chromium-review.googlesource.com/1172222Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Momoko Hattori <momohatt@google.com>
Cr-Commit-Position: refs/heads/master@{#584353}

Update FooEvent* arguments of functions called by DefaultEventHandler()
in core/html/.
The arguments of functions never be nullptr, so it need to be reference
instead of pointer.

Bug: 874385
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I65925d4cf194482dd7216347fcbbec15e7f31089
Reviewed-on: https://chromium-review.googlesource.com/1180627Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#584352}

Disables SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile
which is flaky on several platforms (and fails consistenly on linux/asan).

TBR=lukasza

Bug: 840063
Change-Id: I7ac546dcb8f4a60417e45ca9b7ce20667b31abcb
Reviewed-on: https://chromium-review.googlesource.com/1180709Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584351}

This reverts commit 28ac1ad7.

Reason for revert: Looks like this broke components_unittests on iOS:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/36547

Original change's description:
> [unified-consent] Refactor migration code and add settings updates
> 
> The migration code in the UnifiedConsentService is refactored:
>  - The migration state IN_PROGRESS_SHOULD_SHOW_CONSENT_BUMP is
>  extracted to it's own pref kShouldShowUnifiedConsentBump.
>  - The migration state kInProgressWaitForSyncInit is introduced
>  to be able to update the settings for migration when sync is
>  initialized.
> 
> Additional changes:
>  - ShouldShowConsentBump only returns true if the consent bump
>  feature is enabled.
>  - The rollback enables sync-everything now also when the user is
>  not syncing USER_EVENTS (which is disabled during the migration).
> 
> Users that previously had the unified consent feature enabled and
> for which ShouldShowConsentBump=true, will not be shown the consent
> bump anymore after this CL is landed. This will only affect a few
> users on Canary and Dev.
> 
> Bug: 863932
> Change-Id: I211805f9059cd26056ed81d01ff19470b8caed3c
> Reviewed-on: https://chromium-review.googlesource.com/1172690
> Reviewed-by: David Roger <droger@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Thomas Tangl <tangltom@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584341}

TBR=ellyjones@chromium.org,droger@chromium.org,tangltom@chromium.org

Change-Id: Ic50e5f7e4ac7d04be1c170b3811fd594980c71c3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863932
Reviewed-on: https://chromium-review.googlesource.com/1180682Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584350}

Changes in-process NavigableContentsView to work on any platform
supporting Views UI rather than restricting it to Aura platforms.

Adapts simple_browser to run in a non-Aura environment as well.

Bug: 855092
Test: Run DCHECK build of chrome --launch-in-process-simple-browser on Mac
Change-Id: Ibdf7ccd83a4c2f3d2c4d667898d3723166c257a3
Reviewed-on: https://chromium-review.googlesource.com/1178802
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584349}

Receiving the unmount error code will let Chrome properly handle various
types of errors, and produce better logging.

BUG=873903

Change-Id: I792a806440be6725ceba0663afc4b4ee3069d9bd
Reviewed-on: https://chromium-review.googlesource.com/1179109Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Anand Mistry <amistry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584348}

- PlatformAppBrowserTest.PictureInPicture consistently fails with a
  (apparently windows-only) use-after-free on win/asan. That code is new,
  so just revert it (see below), https://crbug.com/873234

- PDFExtensionHitTestTest.MouseLeave flakes fairly often on win/asan, so
  disable the test in that config, https://crbug.com/856169

- SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0
  fails fairly consistenly on win/asan (and elsewhere) in
  network_service_browser_tests, so don't enable that suite on the win/asan
  bot just yet (https://crbug.com/840063).

Bug: 869973

Revert "Enable Picture-in-Picture for chrome apps."

This reverts commit e031e566.

Reason for revert: Test has a use-after-free, https://crbug.com/873234

Original change's description:
> Enable Picture-in-Picture for chrome apps.
>
> This CL enables Picture-in-Picture in chrome apps by implementing
> EnterPictureInPicture and ExitPictureInPicture in AppDelegate.
>
> Bug: 863309
> Change-Id: Ib35e83b03373abe864b3a0674ab1e0b341ce291b
> Reviewed-on: https://chromium-review.googlesource.com/1156513
> Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580497}

TBR=beaufort.francois@gmail.com,rdevlin.cronin@chromium.org,jochen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 863309
Change-Id: Ib6eda55a3b0889646c43ea3e7bfccdb590cea0b2
Reviewed-on: https://chromium-review.googlesource.com/1180763
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584347}

suggest_owners.py looks at commit history and suggests chromium
developers to be added as owners to subdirectories in the repo.

Change-Id: Ia7f2df2dbf7d96dc9322532b4c5cdab1443c95b8
Reviewed-on: https://chromium-review.googlesource.com/1174701Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584346}

net::NetworkChangeNotifier and base::PowerObserver are not hooked to
correct platform code on Mac, thus make background download service not
working correctly.

This CL provides default implementation for device status monitoring on
Mac that always treat the device connected to internet and power source.

This is mostly a temporary solution before platform code is implemented
correctly.

Also pull out BatteryStatusListener and NetworkStatusListener to a
separate file.

Bug: 825878
Change-Id: If34d8eb0cbe5d0575920c4251eda5e5161695adf
Reviewed-on: https://chromium-review.googlesource.com/1178689Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584345}