- 07 Dec, 2020 40 commits
-
-
Liquan (Max) Gu authored
Context: Since SettingsAutofillAndPaymentsObserver is autofill logic and PaymentUiService is in charge of the autofill service, the observer class should go into PaymentUiService. Changes: Moved SettingsAutofillAndPaymentsObserver from: * CPRService#notifyPaymentUiOfPendingApps to PUiService#setPaymentApps * CPRService#close to PUiService#close Bug: 1025619 Change-Id: I224cf06276b26857775c26d2a030fd5fcc7d3295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574602Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#834449}
-
Jeroen Dhollander authored
UX has decided to pivot in another direction, and Bloom will not be released as a stand-alone feature. Bug: b/175052039 Test: Compiled Change-Id: Ib4ba7e2376be58a5bb54408c6504045ea8cb762f Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577897Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Cr-Commit-Position: refs/heads/master@{#834448}
-
Wan-Teh Chang authored
I just followed the instructions in this page and ran into this error message. The URL in the error message was different. Change-Id: Iba5be503a8d1bf8050435471a1de7f8323adffbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577881Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834447}
-
Nico Weber authored
This mostly doesn't work, so also add some documentation that tells people not to use it. (The documentation also has some other information.) No behavior change for regular builds. Bug: 1149587 Change-Id: I03f4f5b65a0d010636a499b043bfcf31b0cd34b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574601Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834446}
-
Tom Anderson authored
No behavior changes. This CL mostly moves code around. * Move all xcb_* calls to connection.cc * Move FutureBase into Connection and rename to FutureImpl * Future now uses composition instead of inheritance for FutureImpl * Move Future to future.h, which requires adding the header everywhere R=sky Bug: 739898 Change-Id: I396e985b67881b9cfd3536cd01629f5573b293aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575938Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#834445}
-
Shimi Zhang authored
This reverts commit fc868f17. Reason for revert: Please refer to crbug.com/1156244 Original change's description: > Batch CriticalPersistedTabData tests > > Apply batching to CriticalPersistedTabData tests so that they run > faster. > > Bug: 1152295 > Change-Id: I655e4ffe2f79a8549311b32a1f7ff760f3dda34e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556453 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: David Maunder <davidjm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833794} TBR=yusufo@chromium.org,wychen@chromium.org,davidjm@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1152295, 1156244 Change-Id: Ib206dd5cf731a64493b505374ca03d622f519498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577611 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#834444}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/816ffa4d4ef7..fa2c56d16d1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ellyjones@google.com,avi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141111 Tbr: ellyjones@google.com,avi@google.com Change-Id: I22b1e845da848ac7decba0fcc105b81d5038835d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574972Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834443}
-
Wez authored
Bug: 1154829 Change-Id: Icd469fee4847b04787096d14f366b0f84b4832c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577466 Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834442}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e79095f5335b..57c86890de5f 2020-12-07 leese@chromium.org Clean up type definition for RawLocation 2020-12-07 andoli@chromium.org Hides horizontal scrollbar in elements style panes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I64583c3abf4ea57aaba9d823ddbd5aaebbb3271e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577532Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834441}
-
Darren Shen authored
SendKeyEvent has an extra code parameter that is used when there is no keycode. However, we can just implement that logic upstream so that there is always a keycode and we can remove the `code` parameter. Bug: b/174612548 Change-Id: I98bb1be1c62fe141ed74f7243b8ac645f9a51963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566868Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#834440}
-
Cammie Smith Barnes authored
The overall project aims to expose CNAME aliases to the SubresourceFilter to aid in ad tagging and blocking. This change stores the aliases (which are already being extracted) in a new field of type std::vector<std::string> in net::AddressList called `dns_aliases_`. The first entry of this vector, if it exists, will be the canonical name, and so this change also removes the previous `canonical_name_` field and renames the canonical name getters and setters with camel case, making them no longer inline, as now they have compound logic. This CL moreover provides the ability to merge lists of aliases to the net::HostCache::Entry class, as well as some additional unit tests and updates to existing ones. Relevant tests: net:net_unittests --gtest_filter=*GetCanonicalNameWhenUnset* --gtest_filter=*DnsAliases* --gtest_filter=*CnameChain*TypeA* --gtest_filter=*MergeEntries* Bug: 1151047 Change-Id: Ie45cb4284df33053db36b364ea982cbfe3d6a618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561274 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b9d9529da93a..963b0a6bd915 2020-12-07 jophba@chromium.org Add presubmit check for unnecessary is_value checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I6d089d59b7ff366bae28016ba9ab9706f3b53a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577698Reviewed-by:
-
adamta authored
Doubled offset for Discover feed scroll-to-load trigger. Used to trigger at the ~9th article, will now trigger at the ~7th (depending on card sizes). Bug: 1156297 Change-Id: I13c836b4b504b55b64bc123d8a183ece58524ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577958Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#834437}
-
Anupam Snigdha authored
This patch adds some traces in the APIs that are called when the IME on Windows tries to position the candidate window and start a new composition. These traces would be really useful while trying to debug IME related issues which are also hard to debug in a debugger as they are sensitive to timings and focus loss. Bug: 1152893, 1151301 Change-Id: I1f0e36d4f9524190efb6b3404d0eb96ee5c85679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572800 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834436}
-
Brian Sheedy authored
Cleans up the unused and fully passing pixel test expectations based off the output of the unexpected pass finder script. Bug: 1155766, 653538, 1136742, 624256, 690277 Bug: 648369, 660461, 857578, 744658, 840394 Bug: 868596, 1068620, 997313, 1019462, 1028975 Bug: 1069339, 1033982, 1082769, 1097735 Change-Id: Ie559cebda155a6ea80065386e35c447ff1fa3db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575433 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#834435}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for some directories under //third_party. Bug: 1113033 Change-Id: I8d194fbc92282d01d7d1f7031d450587a743fd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577615 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
David Tseng authored
TBR=dtseng@chromium.org Change-Id: I5d1e0c4e07ff5bf3c5133a3330b7495c5c713677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578118Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834433}
-
Takuto Ikuta authored
-raw-cmd is no-op now. Bug: 1142713 Change-Id: Ib89afe7ffbfbdc1e303eb3b49da9bfd4ab8e4597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575779 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1502e7972cb..48b2aad780bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie1328bf85db56dc8283979cc69640d55232e8a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577723Reviewed-by:
-
Becca Hughes authored
Adds a method which will get newly discovered Media Feeds which will then be displayed to the user. When the user gives their consent then this will be stored. Change-Id: I70cc391e394d7c21334c3722526a33e30cf9c45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568290Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#834430}
-
Felipe Andrade authored
Add new HTML/JS files for the new Kerberos OS settings sections. Also, update BUILD files to include the new section. This new section is still behind the KerberosSettingsSection flag. The actual content for this section will be added in the future, reusing code from the OS people section. Bug: 983041 Change-Id: I21d1a2ad7be93c284d017492ee487d9c574f9fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558400Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#834429}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /ui/android. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=jaekyun@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Iaf4c1102c9b464887cd30ab3f47b6fe2d8b52294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575334 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#834428}
-
Kartik Hegde authored
To reduce memory overhead, swap all std::deque instances to base::circular_deque. BUG=b/172994051 TEST=unit_tests --gtest_filter=*RoutineTest.* Change-Id: I4a29a28ee0a81294efdca340814b81e2b9d0e68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577036Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#834427}
-
Tanmoy Mollik authored
As we're changing settings screen for MOBILE_IDENTITY_CONSISTENCY, it makes sense to keep these histograms related to settings for some more time. Bug: 1153770 Change-Id: I8b2d5c5db4007405322c7703393df9f4814faf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571364Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834426}
-
Thomas Guilbert authored
This CL converts the remaining uses of base::Callback and base::Bind in the chrome/browser/thumbnail folder, to their appropriate {Once|Repeating} counterparts. The changes are mostly in the write/compress portions of the code. The CL also removes the folder from the list of presubmit exceptions. Bug: 1152271 Change-Id: I05f2bc0bb1b754911f77d72a81ecdf86beb199c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573739 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#834425}
-
Tommy Steimel authored
This CL removes the module header from the wrapper and instead allows the modules to instantiate it instead. This makes the title and actions properties of the ModuleDescriptor obsolete, so this CL also removes those. Bug: 1152205, 1152216 Change-Id: Ib524a59c8c8a7cc69e130b31a8557b903233ab95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570390Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#834424}
-
Lei Shi authored
This CL partially implements the Pause and Resume feature in STS. It can only pause or resume at a user-selected region, without automatically continuing reading outside user-selected content. I will add the auto-continue feature and tests in a follow up CL. To enable this feature: 1. When pause triggered, we simply stop the current TTS. When resume triggered, we use startCurrentNodeGroup_ to read from the current index. 2. Refactored the update functions of floating panel. Creating one function (i.e.,updateNavigationPanel_) that updates the visibility and position of the panel. AX-Relnotes: When #select-to-speak-navigation-control chrome://flag enabled, when Select-to-speak is activated and speaking, pressing pause will pause the audio and resume will continue from the last stop position. Bug: 1143817 Change-Id: I4b28dfdfe1724e2b7cf138587d0b8818b7172966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558981 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#834423}
-
Norman Rosas authored
and removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: Ib6b69f929eaefe6d154f359ec283fe0953d5f6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570732 Auto-Submit: Norman Rosas <normando@google.com> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#834422}
-
David Maunder authored
This was determined to be necessary in cl/342061697. This is a reland of chromium CL 2548503. An explanation was provided in the commit description why loadNextTab() should be called on the UI thread instead of restoreTabs(false) on the background thread. I deep dived the issue created by that CL and found that a policy violation occurs when the directory for CriticalPersistedTabData is created/read. I change the policy and revert back after the directory is read (and created if necessary) like we do in several other parts of TabPersistentStore. Bug: 1151871 Change-Id: I306d4d2bc2ab2b074621d76d1926cc07d1b56b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574620 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#834421}
-
Austin Tankiang authored
Bug: 1126359 Change-Id: Ie422f123dbb15d4e7b9e2ffd5708be36f0eec142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577105 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#834420}
-
Melissa Zhang authored
This CL adds new typography contexts to ChromeTypography to be in the Sharesheet. This allows us to align typography with the mocks, linked in the bug. Bug: 1141744 Change-Id: Ic15e6f068d62919f71a7d5f89ac5e4ad6fe61fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525382Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Robert Sesek authored
This was only failing on 10.10 and Chromium no longer supports that version of macOS. Bug: 1047503, 1153883 Change-Id: Icf30557034eb5bcc5bde2a40763901e2d56104a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574621 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834418}
-
Melissa Zhang authored
To more closely align with mocks hide separator before expand. This prevents the two separators from overlapping when the expand occurs. Bug: 1148692 Change-Id: I3b0254b2da65d14907d0260c2e600f1bc8cf39c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574569Reviewed-by:
-
dpapad authored
Previously the "Choose name and picture" label was read twice by screen readers. cr-link-row already takes care of not having both the label and the button itself in the linear navigation order of screen readers. Bug: None Change-Id: I658ffdaaf3ca92dfb8bc88f878040704b9177e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574275Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834416}
-
Ryan Keane authored
This CL picks up a bugfix integrated into protobuf as part of commit: http://cl/342360226 This fix is responsible for fixing a bug in the serialization code when trying serialize/deserialize protobuf messages at the end of an iostream This change re-introduces the change first added as part of CL https://chromium-review.googlesource.com/c/chromium/src/+/2535667 and then later reverted due to Windows-specific failures. To fix this, Windows has been excluded from the newly-added BUILD target. Change-Id: I12cfe36ba9cbd9ddd4eb9df7c5f654ee144e03e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575321Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Ryan Keane <rwkeane@google.com> Cr-Commit-Position: refs/heads/master@{#834415}
-
Xing Liu authored
BookmarkUtils.showBookmarkManager currently needs a non null activity to show bookmark manager from most recently visited bookmark folder. For reading list, we need to open the bookmark UI and directly navigate to reading list page. Also when clicking from a notification, no activity is provided, we need to start the bookmark UI from application context. Bug: 1139073 Change-Id: I81bf5ce1e46c41c57c8b0f34ffdabe250540c515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576081 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b21fac24817a..011a77357ec4 2020-12-07 csmartdalton@google.com Use infinity to signal conics instead of NaN 2020-12-07 reed@google.com add new entry-points for drawImage[rect] with samplingoptions 2020-12-07 johnstiles@google.com Avoid unnecessary coercions in index expressions. 2020-12-07 ethannicholas@google.com remove incorrect line number from SkSL errors with no source information 2020-12-07 johnstiles@google.com Use a scoped helper class to push and pop CodeGenerator::fOut changes. 2020-12-07 johnstiles@google.com Check array bounds when a constant array index is used. 2020-12-07 reed@google.com Handling mipmapaccess failing 2020-12-07 robertphillips@google.com Pass GrMipMapped boolean down to GrResourceProvider::createTexture 2020-12-07 brianosman@google.com Tweak ParticlesSlide's resource provider to show how to use PathBinding If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I242a2655636de31470be46cb86c2cf528d8c6cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577583Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8970a3d2. With Chromium commits locally applied on WPT: 942f73a1 "Remove support for setting sandbox flags via "allow"" 8970a3d2 "[blinkpy] Re-enable four css-background/ tests that need fuzzy reftest" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-break NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ia64d6296fbcddca0304290923cce464e1f0e2d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575602Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834412}
-
Elly Fong-Jones authored
This reverts commit 8970a3d2. Reason for revert: one of the re-enabled tests (attachment-local-clipping-image-5.html) is failing: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93472 Original change's description: > [blinkpy] Re-enable four css-background/ tests that need fuzzy reftest > > Bug: 997202 > Change-Id: Ic14e10dfd0d4fbdc22c9b22289fb9a428eb3dbca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575453 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Auto-Submit: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834291} TBR=xidachen@chromium.org,schenney@chromium.org,smcgruer@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ib2c1fd75093b8727f19f812c86d356779f195a39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578000Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#834411}
-
Xiaoqian Dai authored
Otherwise, it may cause crash in splitview as described in crbug.com/1151060 comment#27. The reason for that is splitview assumes overview open on the destroyed window side of the screen if a snapped window is detached from splitview but overview can't be opened if splitview resizing is in progress. TODO: - The assumption may not always be valid, so splitview should handle the case when the overview can't open correctly. Bug: 1151060 Change-Id: Ic774d27ed8f48dc035901f3e2c7bbddfcc414c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575380 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
