- 17 Jan, 2021 16 commits
-
-
Ching-Kang Yen authored
Add the metrics to record the command code and system uptime when the TPM writing or reading commands timeout. The corresponding changes on the Chrome OS side is in crrev.com/c/2619447 BUG=b:176421411 Change-Id: I1803d90e74ab3b82358df30cf108085af50b5f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627652 Commit-Queue: Ching-Kang Yen <chingkang@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#844373}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101160600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/YNL0Lo1NPjtln2cK6MXj9Xw_pNW1UocLERdeu0clwWMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I2276bc4882c60bdde241c1179a06f138d880ecba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844372}
-
David Reveman authored
This makes Fuchsia behave more like Android memory pressure signals. MODERATE and CRITICAL pressure notifications are now sent periodically and not only when the level changes. This is important as components expect to be able to just respond to discrete events, which means we need periodic "refreshes" of MODERATE and CRITICAL pressure. Bug: 1166976 Change-Id: I829a3f3c6cd40e7753119ade19f2aac0d58a97ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633682 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#844371}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4374.0-1610361443-benchmark-89.0.4387.0-r1 to 89-4374.0-1610361443-benchmark-89.0.4389.2-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2573466ebd8f145ea824618590e6a5d44bbbfc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844370}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ie44d062c7e9c6aa0981e27242fbad496046b0636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634921Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844369}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4380.0-1610362181-benchmark-89.0.4387.0-r1 to 89-4380.0-1610362181-benchmark-89.0.4389.2-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7a89e1e33bd003d307add7436d39dba45f5cf579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633291Reviewed-by:
-
Keishi Hattori authored
In the commit below, we started to adjust a zero-sized allocation to a size of 1. https://chromium.googlesource.com/chromium/src/+/d5c951e819784cf240b0b85cbfd317563969bbc1 This caused the PartitionAllocTest.PartialPageFreelists test to fail. Change-Id: I42df204a083ad18bcc055aaf24e2946e1a67c2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624174Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844367}
-
Caitlin Fischer authored
The experiment launched. The feature was default enabled on the appropriate platforms in crrev.com/c/2340110. Bug: 1126640, 976583 Change-Id: I6142f21d207ab56cd127d3203aea1213f01104a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631930Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844366}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7acc2d9fe3a6..9c8dd8763605 2021-01-16 mbonadei@webrtc.org Fixing WebRTC/Chromium FYI build. 2021-01-16 mbonadei@webrtc.org Move iOS bundle data for tests inside rtc_include_test (take 2). 2021-01-16 asapersson@webrtc.org SimulcastEncoderAdapter: Add field trial for EncoderInfo settings. 2021-01-16 danilchap@webrtc.org In criket::BaseChannel replace AsyncInvoker with task queue functions 2021-01-16 mbonadei@webrtc.org Move iOS bundle data for tests inside rtc_include_test. 2021-01-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3c2d1e3b..da248227 (844134:844357) 2021-01-16 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-16T04:03:13). 2021-01-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 72fe6d7a..3c2d1e3b (844008:844134) 2021-01-15 jakobi@webrtc.org Reland "Default enable delay adaptation during DTX." 2021-01-15 danilchap@webrtc.org Reland "Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in c++ code" 2021-01-15 danilchap@webrtc.org In SVC controllers add support for frames dropped by encoder 2021-01-15 mbonadei@webrtc.org Reland "Refactor rtc_base build targets." 2021-01-15 jakobi@webrtc.org Revert "Default enable delay adaptation during DTX." 2021-01-15 jakobi@webrtc.org Default enable delay adaptation during DTX. 2021-01-15 sprang@webrtc.org Refactors SimulcastEncoder Adapter. 2021-01-15 sergio.garcia.murillo@gmail.com Set AV1E_SET_ERROR_RESILIENT_MODE on T1 and T2 enhanced layers 2021-01-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 42ab9dc8..72fe6d7a (843550:844008) 2021-01-15 danilchap@webrtc.org Replace RTC_WARN_UNUSED_RESULT with ABSL_MUST_USE_RESULT in audio_coding 2021-01-15 nisse@webrtc.org Update p2p/ to use C++ lambdas instead of rtc::Bind 2021-01-15 aleloi@webrtc.org Revert "Improve structuring of test for audio glitches." 2021-01-15 aleloi@google.com Revert "Add ability to load CreateDirect3DDeviceFromDXGIDevice from d3d11.dll" 2021-01-15 nisse@webrtc.org Update android jni code to use C++ lambdas instead of rtc::Bind 2021-01-15 nisse@webrtc.org Simplify FakeRtcEventLog, delete rtc::Bind usage 2021-01-15 landrey@webrtc.org Add cross trafic emulation api 2021-01-15 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-15T04:04:08). 2021-01-14 mbonadei@webrtc.org mb: Fully remove references to 'masters' in favor of 'builder_groups'. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1117773 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9674b3bf834e3b1b8e7d50e226f7f13bae91ed10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632812Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05e5446145a6..a799f6c37d4d 2021-01-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: Ib0abdee4255fc628367ad89792dbae8a96acea89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634801Reviewed-by:
-
Raphael Kubo da Costa authored
Remove some includes that were moved in r821296 ("generic_sensor: Extract Functions into PlatformSensorProviderLinuxBase") and drop a few unused ones. While here, explicitly include base/time/time.h for base::TimeDelta. Change-Id: Ibafea3f6714d6b74f481762f41d1745ad1584ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632948 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#844363}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ff5c7857d90c..cb01823177ba 2021-01-16 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I846add09ca908023fba2feb53a39099e23d69d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634315Reviewed-by:
-
Henrique Ferreiro authored
This CL is part of the Chrome OS source code directory migration: https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE. Bug: 1101837, 1164001 Change-Id: I3ad293f3a3b026d9a1f81b4cd86144f63ee2e207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625881 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Owners-Override: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#844361}
-
Theresa Sullivan authored
Exploration of changes these settings has been postponed; extending histogram collection. Bug: 1165004 Change-Id: Id3337f4e33882a106faec9dedf6b9fc43b7ac6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628013 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
-
Nico Weber authored
rsp files sometimes crash libtool too, at least in Xcodes older than 12.3 (see comments 16, 21, 22 on the linked bug). The bots currently use 12.2 and this being fixed in 12.3 isn't 100% confirmed . This basically reverts https://chromium-review.googlesource.com/c/chromium/src/+/2533546 Bug: 1147968 Change-Id: Iaebfb17de0c2053bd4feb9c6f421dca6c72777ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633928 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#844359}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I50e8f84b1aae89d3ddce6efdb11bc508f0f607d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633431Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844358}
-
- 16 Jan, 2021 24 commits
-
-
Findit authored
This reverts commit 02d1e955. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 844274 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAyZDFlOTU1YTczNjg0ZGI5ODU2Y2Q4MjAzYThjNGUzODRjOTIwZGMM Sample Failed Build: https://ci.chromium.org/b/8857990510232294496 Sample Failed Step: compile Original change's description: > Add GPayAppDynamicUpdate feature flag. > > The feature flag controls the GPay native app integration for dynamic update on Android. > If this feature flag is enabled, the GooglePayPaymentApp would enable a callback service and handle communications between the native GPay app and the browser for dynamic updates on shipping and payment data. > Design doc is go/dynamic-update-mweb. > > Bug: 1074423 > Change-Id: I898199446179d6c314b833c3ecb8f017481fc596 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628745 > Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844274} Change-Id: I72abe5615c0ee585679600e2b757c0d10ea60ca9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1074423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632842 Cr-Commit-Position: refs/heads/master@{#844357}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: Idf5cc4ed97c2a9b06d7927dd9114201a5047a971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633427Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610744388-21de24e38f072743f3bfcce061ea4b5afc98a448.profdata to chrome-win64-master-1610755196-7abba2cfdf73565a08dbdbba7efd11f1e8902293.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I14602678bd3ea9fc8900eee48b0cbee40af8dc0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634301Reviewed-by:
-
Min Qin authored
On small screen device, only 1 row of most visited tile should show when query tiles are enabled. However, TileSection hard coded the number of rows to 2. So even though Chrome reduced most visited tiles to 4, it could still end up showing in 2 rows if the screen can only accommodate 3 tiles in a row. BUG=1166388 Change-Id: I10dabcd0db1f56fa650ed999a9d353eabbf6ce5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630732 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844354}
-
Gordon Seto authored
Sets the default focus on each page in cellular setup. Fixes: 1010316 Change-Id: I743dd6eb3fad9d4cf311e699088f82b59e960b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634041Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#844353}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Iae55fb7a51b344b6cef9a3474ed7e2de96ff2365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634303Reviewed-by:
-
Azeem Arshad authored
This CL adds a getEuicc utility method that automatically selects the Euicc object to be used based on the useExternalEuicc flag. Fixed: 1166697 Change-Id: Ia6d962275365f6a347ee6687fe78a497eb5c79b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630739 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#844351}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8f5ca26678c1..ff170c6f508d 2021-01-16 timvp@google.com Tests: Add Real Gangster Crime trace 2021-01-16 timvp@google.com Revert "Vulkan: Generate gl_Position pre-rotation in SPIR-V" 2021-01-16 timvp@google.com Revert "Vulkan: Generate gl_Position.z correction in SPIR-V" 2021-01-16 timvp@google.com Revert "Vulkan: Move xfb position decl to translator in extension path" 2021-01-16 timvp@google.com Revert "Vulkan: Generate xfb support code in SPIR-V for extension path" 2021-01-16 timvp@google.com Revert "Cleanup translator option checks" 2021-01-16 syoussefi@chromium.org Cleanup translator option checks 2021-01-15 m.maiya@samsung.com Vulkan: Support EXT_clip_cull_distance extension 2021-01-15 syoussefi@chromium.org Vulkan: Translator pass to monomorphize problematic functions 2021-01-15 syoussefi@chromium.org Vulkan: Generate xfb support code in SPIR-V for extension path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*real_gangster_crime* Change-Id: Id66b57dc74e2dd05c7ebd1dd3e0b7572e70609ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634265Reviewed-by:
-
Eugene But authored
Recorded when iOS app has started after a crash caused by system signal or hang. Not recorded when app has started after UTE or XTE. See go/bling-stability-101 for imformation about signal crashes, hangs, UTEs and XTEs. This metric intends to compliment Stability.Counts. Stability.Counts does include UTEs / XTEs and thus is a noisy metric which significantly overcounts user-visible crashes. Stability.IOS.Experimental.Counts is not recorded on OOM crashes, so it does not represent all use-visible crashes, but OOMs are so rare in Chrome for iOS that Stability.IOS.Experimental.Counts is still a good proxy for user-visible crashes. IOS.MetricKit.ForegroundExitData includes OOM crashes and can be used in conjunction with this metric. Bug: 1166922 Change-Id: I390a2da2b8b9ed81d215ce58375911019c2228dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631287 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844349}
-
Yue Zhang authored
This CL replaces the close button in the module header with a three-dot menu button so that we can do two types of dismiss: temporarily hide and permanently remove. Bug: 1157892 Change-Id: I359c8a45a010ac1c5e89ad2bb291b70d9c17381b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626459 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844348}
-
Denis Nikitin authored
ThinLTO requires -gsplit-dwarf in ldflags. The flag was passed only in Android. Pass -gsplit-dwarf to ldflags with all targets except NaCL and Apple. Bug: chromium:1158215 Change-Id: Ica36d0ed0cb3382792b3f21b30af56638faf24ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618780Reviewed-by:
Bob Haarman <inglorion@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Denis Nikitin <denik@chromium.org> Cr-Commit-Position: refs/heads/master@{#844347}
-
WangHui authored
Match rects in subframe should be recomputed when the size of parent frame is changed since Find-in-page coordinates are represented as normalized fractions of the main frame document Bug:1147796 Change-Id: Iee446b54060b9977f0ed6db8b49c6bf63d1938c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531797 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#844346}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610733364-857d9e0d0931ba77d21c7c00c0f6edaa64750af0.profdata to chrome-win32-master-1610744388-5f878bc1b38d4c2e869a6a4ceb1a959431b1ffe7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I178fb338369bf986fe172ce7ccc187d4235c4927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633459Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610733364-fa73893da77d3e325227cfa68293cda0e1656c64.profdata to chrome-mac-master-1610755196-59a4a0c119004651094c88c9b6ab2bda6a695e2e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib13e0395896db6ff199036a54dc70879c6f1dbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634276Reviewed-by:
-
Thomas Lukaszewicz authored
This patch introduces a EmbedderHidden() method that enables bubble WebUIController subclasses to take appropriate action when their embedder is no longer visible. TabSearchUI overrides this to destroy the |page_handler_| when its embedding bubble is no longer visible to prevent background updates. Cleaned up use of member variables in WebUIBubbleManagerBase and WebUIBubbleManager<T>. Bug: 1099917, 1166967 Change-Id: I374dd74b5a1c3d37a53e7213e64c096adef35bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626114Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844343}
-
Takumi Fujimoto authored
Part 1 of MediaNotificationService refactoring. Create an interface and make CastMediaNotificationProvider and PresentationRequestNotificationProvider implement it. Bug: 1021643 Change-Id: I899d0430a59a7432ed2d55bcbc23af3cb8405a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606650 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#844342}
-
Yuheng Huang authored
Break up tabs related functionality to MultiTabStory to be more reusable in other features. Bug: 1099917 Change-Id: I7e1310ee4c680383b5347e1f046b7bb718e35837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631465 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844341}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610733364-157abbebfa8d67c9510c102888afbc9dd88135a0.profdata to chrome-linux-master-1610755196-61d932c6744ad62f0472d9ac776510bd42cd0a54.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I14ae8be6fe0c069c9897b5a445fa72c65a5a00f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634275Reviewed-by:
-
Owen Min authored
All channels load Chrome policies from the stable bundle id domain. So should the extension policies. Bug: 1163895, 831577 Change-Id: Id5bc4d5fcb0bffdc9444a53328d1ec9d20cb9008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630230Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844339}
-
WangHui authored
No logic changed. Bug:None Change-Id: Ib73cd10d6f7cffef67367f6da7ce26aefe0b2758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631515 Commit-Queue: HuiWang <wanghui210@huawei.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#844338}
-
Tomasz Wiszkowski authored
This change allows BaseCarouselSuggestion to show or hide the header text depending on whether it is desired to show it. Bug: 1166302, 1145685 Change-Id: If91da47ab1f121837d6c263dc6d217f2b4452b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634015 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#844337}
-
James Cook authored
This is causing my build to fail locally. I'm not sure why it's working on the bots. Bug: none Change-Id: I3d715d9ce69637329719ea944da68c7ed5830a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633200Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844336}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610733364-0048730fde812fecdb18597677d6c98bc22e5905.profdata to chrome-win64-master-1610744388-21de24e38f072743f3bfcce061ea4b5afc98a448.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie339537037586b105e19d6434c9ec13c36a7871d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633082Reviewed-by:
-
Aaron Krajeski authored
Our toblob metrics were all ending up in the overflow bucket: https://uma.googleplex.com/p/chrome/histograms?sid=bc11d3b58d816ec456478bd44834c192 Also, UmaHistogramMicrosecondsTimesUnderTenMilliseconds is deprecated: crbug.com/983261 Unfortunately I need to change their names in order to use the new macro without messing up old data. Bug: 1165901 Change-Id: I163a093ab055a989aded448a4b5ee0f69ec3582e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625291Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#844334}
-
