GitLab

Bug: 772031
Change-Id: I77eb7d669be38a1163260c3487e61c9541cdca8d
Reviewed-on: https://chromium-review.googlesource.com/748265Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513061}

TBR=anantha@chromium.org

Change-Id: I83c579841ff5690a6bf6f9d14b97ed34b4159bd6
Reviewed-on: https://chromium-review.googlesource.com/748581Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513060}

This has been running only with sparse histograms for some time now and
has been helpful in finding metrics that overflow.  Now extend this to
check the remaining bulk of histograms.

While the original CL looked for many different reasons of acquiring a
negative sample count, it's now known that there is only a single
reason and so that is the only reason checked for here.

Bug: 682680
Change-Id: I96785436468fdbe34f4221caf7a79da299edeca2
Reviewed-on: https://chromium-review.googlesource.com/741004Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513059}

This CL adds a custom menu model for hosted app which has only the items
that should be shown for a hosted app. It also adds 3 new commands which
are currently disabled and will be implemented in a future CL.

Bug: 762401
Change-Id: I7e53eb3d11042f267567e3773784c8594d7c7bee
TBR: erg@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/721226
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513058}

Bug: 
Change-Id: I96b5c9643c73a6ae37c40af1558f1520eb5201e4
Reviewed-on: https://chromium-review.googlesource.com/747513Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513057}

This is a reland of de566f6b

Relanding with relevant *_EXPORTs added to fix the component build.

Original change's description:
> Add support for protected gpu memory buffers and a secure mode to ArcVDA.
> 
> A protected gpu memory buffer is a buffer that can be referred to
> by a GpuMemoryBufferHandle, which does not provide access to the buffer's
> contents. Such handle can be shared with and received from clients that
> should not have access to the buffer's contents. When such handle is
> passed to the ProtectedGpuMemoryBufferManager service by its privileged
> client, it can be translated into another GpuMemoryBufferHandle, which
> allows access to the buffer.
> 
> Also, implement a ProtectedMemoryManager to provide an allocation and
> lookup service for such buffers for gbm.
> 
> Finally, add secure mode API to the ArcVideoAccelerator stack and integrate
> it with the above, to provide a secure codec mode implementation.
> 
> TEST=E2E video playback tests
> BUG=b:27174405,b:62575861,b:27204780
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I80259db35463f7ed0cc3acc28bf767e55e46c8b8
> Reviewed-on: https://chromium-review.googlesource.com/689818
> Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
> Reviewed-by: Owen Lin <owenlin@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
> Commit-Queue: Pawel Osciak <posciak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512797}

Bug: b:27174405, b:62575861, b:27204780
Change-Id: I147aee03c72ea0d04def1f17ba88ea3a5abd50f6
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=kcwu@chromium.org,owenlin@chromium.org,hidehiko@chromium.org,sky@chromium.org,rjkroege@chromium.org,reveman@chromium.org,dcheng@chromium.org,jorgelo@chromium.org

Change-Id: I147aee03c72ea0d04def1f17ba88ea3a5abd50f6
Reviewed-on: https://chromium-review.googlesource.com/748041Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513056}

TBR=meade@chromium.org

Bug: 771641
Change-Id: Ibeebf55dfb82c48d32b85a5b97209b1567641b10
Reviewed-on: https://chromium-review.googlesource.com/744311
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513055}

CSSStyleValue.parseAll is similar to CSSStyleValue.parse in that it
converts a string value into a CSSStyleValue. The main difference is
how it handles list-valued properties.

Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-cssstylevalue-parseall

To reduce duplication, we move the common logic between parse and
parseAll into a helper function.

We also change the tests for parseAll because they wrongly expected that
parseAll return a CSSStyleValue instead of a sequence of CSSStyleValues.

Bug: 775802
Change-Id: I4b6b05d3a164e34709839ca2e059ec3fbf18a993
Reviewed-on: https://chromium-review.googlesource.com/742822
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513054}

Migrate the remaining interfaces accessed via
WorkerThread::GetInterfaceProvider() to use
ExecutionContext::GetInterfaceProvider():
- PaymentManager
- PermissionService
- WebSocket

Bug: 734210
Change-Id: Ib33c8783bbb490bd4bda5dd31da2a72ab218d03b
Reviewed-on: https://chromium-review.googlesource.com/743102
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513053}

Changes:
1. Allowing the snapped window that next to the origin of the work area
   can be moved outside of the bounds of work area.
2. Delete RestackWindows in SplitViewController, since left and right
   snapped window will not overlap now.

Bug: 775236
Change-Id: Ib1d12443f8b9965544014590b8eff37ed8b3f665
Reviewed-on: https://chromium-review.googlesource.com/741489
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513052}

crrev.com/c/742354 broke DisplayItemTest.DebugStringsExist in
blink_platform_unittests. It seems caused by just forgetting to add a case to
DisplayItem.cpp, so this patch is to fix it.

TBR=wangxianzhu@chromium.org, trchen@chromium.org
NOTRY=true

Bug: n/a
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I4faf738cb3fabb91253283396fa46733bf287100
Reviewed-on: https://chromium-review.googlesource.com/748481
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513051}

No change in logic.

This adds @Override annotations to fix compile warnings in WebView's
glue layer.

Bug: 779716
Test: ninja system_webview_google_apk (rebuild glue, look for compile warnings)
Change-Id: I73096eaec795a9956993ed34f7d1508c0d19e01f
Reviewed-on: https://chromium-review.googlesource.com/744962Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513050}

Copy WebGL 1.0 Linux P400 expectations to WebGL 2.0; they weren't
being run on that configuration previously.

BUG=712469
NOTRY=true
TBR=jmadill@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iec9def1894e30ef95f1743b64483cf61798c5d2e
Reviewed-on: https://chromium-review.googlesource.com/748319
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513049}

This patch converts editing/pasteboard/copy-null-characters.html with
assert_selection
to promote the use of w3c testharness and improve code health.


Bug: 679977, 775701
Change-Id: Ib89e9f246b7c7ef559b0d67ac2a4937405524145
Reviewed-on: https://chromium-review.googlesource.com/746341
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513048}

There's a bug where the thumb in the Cocoa overlay
scrollbar becomes more narrow than the track width.

This bug is caused by
BaseScrollBarThumb::SetLength() which sets the
thumb's size according to its preferred size. Since
the CocoaScrollBarThumb::CalculatePreferredSize()
returns the thumb's minimum's size, SetLength()
would set the thumb's size to be too small.

This CL fixes this issue by returning the thumb's
current thickness instead of the minimum size in
CocoaScrollBarThumb::CalculatePreferredSize().

Additionally, this CL changes the logic so that the
thumb and track bounds and size won't be insetted.
Instead, the thumb's painting will be inset in the
OnPaint() function.

The kExpandedScrollbarThumbInset value is also
removed.

Bug:682466

Change-Id: I59411650df8acfb4e628efbb1a9f0646c2ce385b
Reviewed-on: https://chromium-review.googlesource.com/741039
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513047}

R=dpranke@chromium.org,hans@chromium.org

Bug: 780048
Change-Id: I124805ca7fc97ed1d04ab8af213a376540425b3f
Reviewed-on: https://chromium-review.googlesource.com/745810Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513046}

When painting composited overflow, kPaintLayerPaintingOverflowContents
is set to paint all content. When painting a nested, transformed
scroller, we need to ensure this flag is unset so the contents
are clipped.

Because root layer scrolling (RLS) paints the root layer as a regular
overflow scroller, this bug affected more tests with RLS. With this
patch, 5 more tests pass with root layer scrolling.

Bug: 779885
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I311cfa9e3244192b24ec3dd566aa2c65e9dba851
Reviewed-on: https://chromium-review.googlesource.com/748081
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513045}

This is the result of running
tools/metrics/histograms/update_policies.py in a clean branch. Both
of these changes appear to be correct based on the names in
components/policy/resources/policy_templates.json.

This allows future users of update_policies.py to get a clean diff.

Change-Id: I28245240d594e1c82481663aa17a9ff099a1864f
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/747691Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513044}

This CL moves the file v4l2_stub_header.fragment to
//media/gpu/v4l2/ folder.

This file is used in conjunction with the signature files
in the said folder, to produce an include file with the
functions used for v4l2 video acceleration. Right now having
the fragment in //media/gpu is unnecessary.

TEST= ** No new code added, if it compiles, we're good **
(Note that this code is compiled in the bot
chromeos_amd64-generic_chromium_compile_only_ng which is
part of the CQ).

This CL is kind-of a continuation of crrev.com/c/744462.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I11ea24e3feb27f53d06e3dcacccc2fdb0f0ac6fa
Reviewed-on: https://chromium-review.googlesource.com/747532Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513043}

https://skia.googlesource.com/skia.git/+log/4dbdc677affd..a44b013a328d

$ git log 4dbdc677a..a44b013a3 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=stani@chromium.org

Change-Id: I0319a822d0c0a4d0fbfb2e64ef0bb7788d325244
Reviewed-on: https://chromium-review.googlesource.com/748262Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513042}

The devices added in this CL are accountable for 80% of the crashes in
the attached bug. There is no good stack trace to investigate the crash
further, but all crashes seem to happen at MediaCodecBridgeImpl
destruction time.

Using the fallback path on those devices on JellyBean should mitigate
further crashes.

Bug: 693216
Change-Id: I58f5a1522105a87d48470452f28634dc9bf806c7
Reviewed-on: https://chromium-review.googlesource.com/748205Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513041}

Bug: 738065
Change-Id: Ia706f3a5edd451de462ab8c6a26abc394d493e9e
Reviewed-on: https://chromium-review.googlesource.com/731405
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513040}

This reverts commit fd502dfe.

Reason for revert: This patch seems causing interactive_ui_tests failures on Linux Chromium MSan/LSan Tests bots.
https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/3892

Original change's description:
> Make PendingWallpaper pass weak pointers with a default delay
> 
> After applying a default delay to PendingWallpaper, some tests
> failed (crbug.com/779504) or have memory leak [1].
> 
> These tests indirectly called SetUserWallpaper, but they do not
> care/know about this, so they do not actively wait until wallpaper
> loading is done, but start the destruction directly.
> 
> This used to be okay when SetUserWallpaper had zero delay.
> 
> But when it has the default delay, the timer is still running when
> the destruction starts, and the timer holds a reference to the shared
> pointer of PendingWallpaper, which results in memory leak.
> 
> What's worse, if the WallpaperManager already destructs itself,
> PendingWallpaper::ProcessRequest does not know it, and it crashes.
> 
> After changing the shared pointer to a weak pointer, WallpaperManager
> will be able to completely manage the lifetime of PendingWallpaper.
> 
> [1] https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/24405
> 
> Below are the description of the original CL:
> 
> 1) All the PendingWallpaper requests are now subject to a delay
> calculated from average loading time. However, in most cases the delay
> is still zero, and this change only affects corner cases that multiple
> requests coming together, which may result in wallpaper being stuck.
> 
> 2) Add the account_id update in PendingWallpaper. Did not modify
> the functionality of PendingWallpaper, except for some renaming.
> 
> TBR=oshima@chromium.org
> 
> Bug: 779504, 778451
> Change-Id: Iae943f88bbe046849c3afab75f35a253934fe75b
> Reviewed-on: https://chromium-review.googlesource.com/745022
> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
> Reviewed-by: Alexander Alekseev <alemate@chromium.org>
> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#512883}

TBR=oshima@chromium.org,alemate@chromium.org,wzang@chromium.org

Change-Id: I62ae0d91bc1cbe953de45a77402f38754de858cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 779504, 778451
Reviewed-on: https://chromium-review.googlesource.com/748381Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513039}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/32a6cc20..1facfc82

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I67d1e6588f934ae8682f6c630505780469987bf4
Reviewed-on: https://chromium-review.googlesource.com/747512Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513038}

These are pretty trivial, but possibly worth keeping.

Change-Id: I89866f829699ac597d44cd87e94f948211539174
Reviewed-on: https://chromium-review.googlesource.com/746365Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Chris Bentzel <cbentzel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513037}

R=vitalybuka@chromium.org

Bug: 676024
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2c1d8f28ffcce5e657e383ab70ad1dbb4ec9668e
Reviewed-on: https://chromium-review.googlesource.com/736669
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513036}

The main changes are in chromecast/chromecast.gni

The rest of the files were modified with these commands:

- Change source_set -> cast_source_set
git ls-files "chromecast/*.gn" | xargs sed -i 's/source_set(/cast_source_set(/g'

- Include chromecast.gni for any GN files missing it
git ls-files "chromecast/*.gn" | xargs grep -L '//chromecast/chromecast.gni' | xargs grep -l 'source_set' | xargs -L1 ~/src/scratch/add_line_after_first_comment.py 'import(' '"//chromecast/chromecast.gni")'

add_line_after_first_comment.py can be found under
chromecast/internal/tools

BUG=b/68723969
TEST=Build and run

Change-Id: I38a06ac4d8a45ebc7963b58e5a2db81fde84e635
Reviewed-on: https://chromium-review.googlesource.com/747894Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513035}

We're not actually going to use that particular config.

R=jbudorick@chromium.org
BUG=732531

Change-Id: I6ab1cda23fdb621cccd19418263a57e955d032f8
Reviewed-on: https://chromium-review.googlesource.com/744594
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513034}

Some of the partner customization logic is extracted to AppHooks,
so that it can be overriden in downstream.

Bug: 778805
Change-Id: I6dcd4b0a14ed76f7a9c447452ce313f59ca98a65
Reviewed-on: https://chromium-review.googlesource.com/741086Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513033}

GamepadHapticActuator receives haptics commands and forwards them to
GamepadDispatcher, which dispatches them to the device service. It also
manages the state of promises which have been returned to the user as
the result of haptics commands.

Haptics commands include playEffect, which plays a vibration effect on
the target gamepad, and reset, which stops vibration and resets any
vibration-related state on the gamepad. Both commands return a promise
that is resolved with a result code once the command is completed.

BUG=749295

Change-Id: I457c4b0e024c88adcaecdf6695959e06acb20a8e
Reviewed-on: https://chromium-review.googlesource.com/747050
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513032}

Add MeasureAs attributes for geolocation methods so usage of the feature
can be tracked through UseCounter.

BUG=780267

Change-Id: I8994be04aa750971204f515d66f5834ce38ab8c8
Reviewed-on: https://chromium-review.googlesource.com/747862Reviewed-by: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513031}

This patch devirtualizes calls to interface methods made through a
mojo::InterfacePtr<T> and mojo::AssociatedInterfacePtr<T> by making
get() and the -> and . operators return the proxy type directly and
marking the interface methods on the proxy as final.

The motivation of this change is performance and binary size. The non-
virtual call sites are slightly smaller but not enough to effect the
complete binary. Performance should be net-positive but as yet has not
been accurately measured.

Bug: None
Change-Id: I463bc32c1989853606d118f57ded5c9dd9f34e2f
Reviewed-on: https://chromium-review.googlesource.com/747884
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513030}

With a recent change we removed bounds parameter from drawing display
items, now all drawing display items are assumed to be bounded by its
owning client's visual rect. This does not necessarily hold true for
clip-path, because clip-path can be bigger than its reference box.

This CL expands the visual rect of a layout object with its clip-path's
bounding box (if one is present).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I117169b302c4574df4628ffe67496e9f95aab8fb
Reviewed-on: https://chromium-review.googlesource.com/742354
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513029}

The test
WebRtcAudioQualityBrowserTest.MANUAL_TestAutoGainControlOnLowAudio
sets up a WebRTC audio-only one-way connection between two Chrome
tabs. The first tab receives recorded audio from a fake microphone and
sends it to the second tab. The second tab plays the audio which is
then recorded.

The WebRTC connection is negotiated with constraints "{audio: true}",
which enable the AEC. The AEC affects audio levels, and changes in it
potentially cause alerts such as this one:
https://chromeperf.appspot.com/group_report?bug_id=779057

On some test settings (with '--single-process'), the AEC of one tab
sees the playout stream (reverse) of the other tab, causing it to
cancel the 'echo'. That leads to heavy speech distortion and often
test failure (see the bug chromium:779057).

This change disables AEC in the AGC tests.

Bug: chromium:779057
Change-Id: Ie774e2faba41f057e47fb2ed4ee402217da8aaf3
Reviewed-on: https://chromium-review.googlesource.com/746641Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Alex Loiko <aleloi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513028}

Before this fix, bottom sheet contents are not updated when creating new
tab in a different mode with a new tab already opened. It also causes
duplicate calls to destroy pref observers. OffTheRecordProfile is not
necessary for PrefChangeRegistrar, and to fix bottom sheet content
separately, we now remove BottomSheetContent when switching mode.

Bug: 779474
Change-Id: I263d9041184701c737cbada78e725a96ca9ade6b
Reviewed-on: https://chromium-review.googlesource.com/745221Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513027}

The tab navigation bar is now stretch across the page The table also
fit to the device width, and the "URL" column in the "Logs" tab is now
scrollable to make it nicer for longer hostnames on mobile

Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3MlA2bnNYNUhfdVU
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3RXQ3clFLRFBtaVU
Screenshot: https://drive.google.com/a/chromium.org/file/d/0B_MBksOU85S3THd0Q3JVcm44c00

Bug: 764419
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieba316275f2acfa60dea480be701995c68fb2f7a
Reviewed-on: https://chromium-review.googlesource.com/747865Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513026}

This CL adds a WasEverAudible method to WebContents which returns true
if audio has played since the last navigation. This is then used by the
Page Info bubble to decide whether or not to show the sound content
setting.

Bug: 779878
Change-Id: I66453161dfe17df6868e66f11e7fce0b3c3a87b8
Reviewed-on: https://chromium-review.googlesource.com/747069Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513025}

Use the MediaLog ID associated with each WebMediaPlayerImpl object as a
unique identifier, to allow the media metric to handle multiple media
playbacks in a single trace.

Bug: 775264
Change-Id: I412bbf5bf8ccab223c027cb5c936fac3de47251e
Reviewed-on: https://chromium-review.googlesource.com/741143Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513024}

The app shell (content shell) sets the default LOG setting to
have tick counts. This means a LOG(INFO) looks like:
[42745:775:1031/103842.350408:395648516798307:INFO:LocalFrameView.cpp(3456)] test

This patch updates the default setting to not have the tick
count so LOG is less verbose. I think this will promote more LOG usage
and happier developers. A LOG(INFO) now looks like:
[42846:775:1031/104021.499705:INFO:LocalFrameView.cpp(3456)] test

Change-Id: I37b27730114519e8f08f59bf076eb3b090bcb12e
Reviewed-on: https://chromium-review.googlesource.com/747363Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513023}

This is a continuation from crosreview.com/737056. When Stop() discovery
fails because Discovering property changes to false, that means all the
discovery sessions have been stopped bluez, so Stop() is expected to
fail and there is no need to log this as error.

BUG=777953
TEST=Reproduce the case and check that device event log is categorized
as DEBUG instead of ERROR.

Change-Id: I41f6e3e83e9f6377bf28f4bb2210be34bdf1c732
Reviewed-on: https://chromium-review.googlesource.com/747603Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513022}