GitLab

IntersectionObserver may require sticky position information, so if
a lifecycle update is forced by IntersectionObserver, make sure it
proceeds far enough to update sticky position.

As noted in the code comments, even if sticky position update is
moved up to the layout phase (which is planned, I think), if the
document is servicing any IntersectionObservers with
track_visibility=true (i.e. V2 features), then we will still need to
force the lifecycle update to continue far enough to enable hit
testing. That's the root cause of the bug.

Bug: 1156937
Change-Id: I809d822d7abf0789aea97113bc87907fdd11b345
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583159
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836900}

TBR=kbabbitt@microsoft.com

Bug: None
Change-Id: I14d580e7e20409fdf2ecc4d8a9294076f11ec07d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584562Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836899}

This CL makes sure that when sharing is initiated from the
sharesheet action, the feature is silently enabled and the user
is taken to the discovery page if they've already completed
the onboarding flow once.

Fixed this by exposing the onBoardingCompletePref value in
nearby share settings mojo interface and checking this value
in the send flow.

Fixed: 1157142
Change-Id: Ie65aa9ce22d8e8a38ce06e299b446865837ca60d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586099Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836898}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9c7f6c25c004..cf06cad1be4f

2020-12-14 ehmaldonado@google.com [subprocess2] Replace VOID with DEVNULL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: Ifa44c11ad8d266718eb99b3989de0de261ba3a52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591453Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836897}

Replace the deprecated DISALLOW_COPY_AND_ASSIGN macro with deleted
copy constructor and assignment operator.

Change-Id: I63c8719a9ee49b602d3a6e5e9c74925f2699551a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590690
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836896}

Bug: b/163064897
Change-Id: I796a1f8efdb4d14d07cca102257413bf46aac429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586018
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836895}

Currently, the discovery page might show multiple share targets
corresponding to the same physical device. This can happen if the
receiving device goes in and out of high-visibility mode, locks/unlocks
the screen, etc. The endpoint ID and share target ID change after
these events, and the stale share target records are not reported as
"lost" until a timeout occurs after ~30s.

For contact-based sharing, a share target has an immutable device ID
corresponding to a physical device. In this CL, we remove stale,
previously discovered share target records that have the same device ID
as the most recently discovered share target.

Note: If the receiving device is not using contact-based sharing or is
not a contact of the sending device, there is no device ID available
in the share target to dedup on. A different solution, if one exists,
will need to be considered for that scenario.

Fixed: 1146075
Change-Id: Ife49eb677fa0e973be845f2b715ce0db3f580cfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589040Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836894}

Bug: None
Change-Id: Ib7791d9a5a46f07d733c8926973cc45a797c2f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587567
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836893}

compile skew test binaries

Currently there is a freeze in increasing GOMA usage. So I had to
remove goma compilation from the skew test refresher recipe,
CL crrev.com/i/3462616.

Bug: 1147459, 1099017, 1041619, 1156861
Change-Id: Ibdbc2dfb7364dd7ed0083a76bf041a48de7be392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590372Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#836892}

This reverts commit 340ff5b3.

Reason for revert: causes crash crbug.com/1158611

Original change's description:
> Remove external dependencies from |AudioInputImpl|
>
> This will allow us to easier move this class to the Libassistant mojm
> service.
>
> All dependencies have been moved to the new class |AudioInputHost|.
> This class currently talks directly to |AudioInputImpl|, but later
> it will instead talk to the mojom APIs.
>
> Some notes:
>    - |AudioInputImpl| still depends on
>      |AssistantClient::Get()->RequestAudioStreamFactory()|, because the
>      Libassistant mojom service will also use an audio stream factory to
>      open/close its audio input. In a follow up CL I will introduce a
>      delegate to sever this dependency.
>    - There is one behavior change:
>      |power_manager_client_->NotifyWakeNotification()| was previously
>      only called when DSP was enabled, and it is now always called (when
>      Libassistant starts a conversation). I can think of no reason why
>      this would be an issue.
>
> Bug: b/171748795
> Test: chromeos_unittests, deployed on real hardware with and without DSP.
> Change-Id: I119521c7a72bf5361019d70240c02ba47a23d6ad
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582537
> Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#836710}

TBR=xiaohuic@chromium.org,wutao@chromium.org,meilinw@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,jeroendh@chromium.org

Change-Id: I2525fce21492c0417d0411db99fbb8463583cb02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/171748795
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591771Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836891}

Bug: 687225
Change-Id: I475aa0fb47961e8d3d50c5721522586359b3e565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587701
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836890}

This CL adds 2 interfaces for the window management component to save
the window information, and get the saved window info based on:
go/chrome-os-full-restore-interfaces

There will be separate CLs to implement these 2 interfaces.

BUG=1146900

Change-Id: Id2885863f4e9a1725382793064e10ac7597cfb1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586648
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836889}

The difference between NO_SHADOW and NO_ASSETS is that we still draw a
border stroke for the former. Since live caption uses the same
background color for different themes, it should not use a themed system
border stroke. This CL removes the border stroke which is not visible
anyway.

Bug: 940027
Change-Id: I249191cfd51e82ea835e7e1f5997ac98a9c33bab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590706Reviewed-by: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836888}

Fixes/improves the GPU unexpected pass finder script in the following
ways:

1. Adds support for preventing expectations from being auto-removed via
   block or inline comments. This is mainly intended for cases where the
   flake rate for a test is low enough that the script does not reliably
   find a flake with a reasonable sample size.
2. Works around the suite name being reported to typ/ResultDB not being
   the same as the suite name reported by Telemetry for several suites.

Bug: 998329
Change-Id: Ie9119dbf24353de7487cb1601db8234fd8efcd90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590365
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836887}

Bug: 1158272
Change-Id: I86da7a24ce0f182de56548479e6381689efa9c46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587873Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836886}

The DCHECK in ~Bluetooth() is reachable because navigator.bluetooth can
be destroyed before the execution context is destroyed.

Bug: 972058
Change-Id: I5ed4d4c3b874a6bb7b73e91efcf918945dbf4250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591240
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836885}

Bug: 1122395, 1157765
Change-Id: Ib4bb91970cc582b26c0010a07168ad109ae04d12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591888
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836884}

Bug: 687225
Change-Id: I57449229bf443ce33613a41b21e47f3fe52ca4f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586096
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836883}

Bug: chromium:1156804
Change-Id: Ief802cd221d57d8379a31f16224d654e4fa0dd47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587355Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#836882}

Bug: 1099917
Change-Id: I57bfd6b3cb8b5496663b5d5d9fcd75a9603d5e57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590627Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: Roman Arora <romanarora@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836881}

This reverts commit ffac4483.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 836656 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmZhYzQ0ODNlNTQ4Y2RmODk3NzJlYmM5ODk5MTM3MDU4OTczOGZjNww

Sample Failed Build: https://ci.chromium.org/b/8860905823939722448

Sample Failed Step: browser_tests

Sample Flaky Test: TranslateModelServiceWithoutOptimizationGuideBrowserTest.TranslateModelServiceEnabled

Original change's description:
> [LanguageDetection] SimpleKeyedService and optimization guide.
> 
> 
> This change converts the translate model service to a
> SimpleKeyedService and moves it to components which will enable
> easier support beyond just browser use cases.
> 
> This change also registers the translate model service to
> the optimization guide for provided necessary model files.
> 
> A future change will add loading and service the model files
> to consumers of the translate model service.
> 
> Bug: 1151407
> Change-Id: I4e903115c82a30757d46d75ed8d733874726d830
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580339
> Commit-Queue: Michael Crouse <mcrouse@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Trevor  Perrier <perrier@chromium.org>
> Reviewed-by: Scott Little <sclittle@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#836656}


Change-Id: I9f63ed714aafbe14ce8c48c23474becadd752186
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1151407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591947
Cr-Commit-Position: refs/heads/master@{#836880}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b99456364d8..e9409d7cfa91

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC ftirelo@google.com,atotic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1157567
Tbr: ftirelo@google.com,atotic@google.com
Change-Id: Ieded572b3576033cf474ec013fe3aabd1f7a12f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590418Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836879}

This patch removes the logic to process input panel policy changes
in TSF in favor of VirtualKeyboard APIs that we have been suggesting
to web authors to use instead and not rely on TSF to manage VK for
them as it leads to lot of buggy behaviors and its non-deterministic.

Bug: 1031786
Change-Id: I5fe03a8a7dba40eef1101f3172751dd9f597e216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587587Reviewed-by: Yohei Yukawa <yukawa@chromium.org>
Commit-Queue: Anupam Snigdha <snianu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#836878}

This reverts commit 36efcfc8.

Reason for revert: Need to revert this in order to revert the last
usrsctp update: https://chromium-review.googlesource.com/c/chromium/src/+/2586379

Original change's description:
> Add fuzzer targets for usrsctp.
>
> Bug: chromium:1025302
> Change-Id: Iadbcb87f0f3f3a1845e925aed8f52685d78e740e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108066
> Reviewed-by: Harald Alvestrand <hta@chromium.org>
> Reviewed-by: Florent Castelli <orphis@chromium.org>
> Commit-Queue: Taylor <deadbeef@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816872}

TBR=hta@chromium.org,deadbeef@chromium.org,orphis@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1025302
Change-Id: Ib984dc975c5802ad52d07b96d91e8fb1367bc4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586282Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Taylor <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836877}

https://chromium.googlesource.com/catapult.git/+log/a4d2246a2f93..f22b977bc4c0

2020-12-14 bsheedy@chromium.org Reland "Switch to vpython version of mock"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1156832
Tbr: oysteine@google.com
Change-Id: Ibcf954b81a25d673a5d159491084688b3435b8ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591288Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836876}

https://chromium.googlesource.com/chromium/deps/icu.git/+log/5c3a0b9..899e1838

TBR=jshin@chromium.org

Bug: v8:11039
Change-Id: I111a7aaec74c909f4e3a68a9fcd44500ebb42392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591229Reviewed-by: Frank Tang <ftang@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836875}

This CL disable the prevent fake login screen feature

Following concerns from leadership, we are going to disable
the fake login screen feature for M88. We will revisit in M90.

Bug: 1158574
Change-Id: I12abd81a2871da1864ad166bb2929d6f38dd9dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590751Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaodan Zhu <zxdan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836874}

Bug: 1010491
Change-Id: I122de2811a029c17afd184077d7693350917179f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586296Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836873}

macOS 11 introduced a new notification UI that has a dedicated close
button in the top left corner. Unfortunately we're no longer able to
override the caption of the overflow menu button via the
NSUserNotification API so this will also remove the "More" button. The
overflow button will now have the default label which is "Options"
instead. Once we switch to the new API we can have our own labels on
macOS 11 again.

Before: https://imgur.com/6pOt5NH
After: https://imgur.com/ImCqjQ5

Bug: 1157781
Change-Id: I3924fed16b54147f6de7fadb65ab32ac18f250a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587014Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836872}

Starting at 10%.  Plan is to scale it up to 50% in the next couple days.

Bug: 1042757
Change-Id: I795f0a3aba74644e98818aaf44a5ebd6e22369dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591233
Auto-Submit: Gary Tong <gatong@chromium.org>
Commit-Queue: Gary Tong <gatong@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836871}

This CL adds a check to only register the SODA language pack component if the LiveCaption and UseSodaForLiveCaption features are enabled as well as the Live caption toggle switch.

Bug: 1156412
Change-Id: Icede8bd752c6617ca16a0f55da926cd8ab0b1675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590625Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/master@{#836870}

Upstream implementation for adding a custom UIScrollViewDelegate to
the feed. Uses NewTabPageCoordinator as UIScrollViewDelegate for the
feed collection view. This allows for us to monitor scroll actions in
the NTP when the feed is the primary scroll view.

Downstream: crrev.com/c/3466483
google3: cl/347390497

Bug: 1114792
Change-Id: I0b9fc60f6de1856270bdda7cf71ce4dcc40e3bb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588639Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com>
Cr-Commit-Position: refs/heads/master@{#836869}

Bug: b/163064897
Change-Id: I5aa951a9f57ceb63c1f3d1e0d624656e7d3c6ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586270
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836868}

If the autofill suggestion has an offer_title set, then replace the
network icon with the offer tag icon.

Mock: https://screenshot.googleplex.com/5bbDeGuhcL3vzSJ
Implementation: https://screenshot.googleplex.com/3eKqiXgSzvXsqGU

Bug: 1156916
Change-Id: I97d13a3fdd5af631747ac1bc00772768d41afdaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580113Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836867}

Roll Chrome Win64 PGO profile from chrome-win64-master-1607925234-725e190e4680cc41f5e8777dffee5ef8a0b3f956.profdata to chrome-win64-master-1607968714-699bf16f3c6ce2b1b6a355f7ee1c8b08436d6eb2.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I36d24203aeba1534103d76b9f6e6ac7f2d2909c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590415Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#836866}

Bug: b:163432680
Change-Id: Ief9324452d082dfe4f94e8e9bc7d2bbb998b07ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584630Reviewed-by: Jason Lin <lxj@google.com>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836865}

This also only instantiates the previews opt guide if previews are
allowed.

The root of the flake is that Previews was registering the opt target
which caused the fetch for regular profiles. By disabling the previews
feature in our tests, we are able to better isolate the logic we want
to test. (Previews was default enabled on Linux)

Bug: 1158257
Change-Id: I3bfe66979bb156698e438b26e2bccf6c172dd140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590708
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836864}

lld/MachO currently doesn't produce working TLS for position-independent code.
Disable PIE, and for protoc disable TLS (since protoc loads dylibs for plugins
at runtime).

The produced Chromium Framework still uses TLS and PIC and is still broken,
but with this (and
https://chromium-review.googlesource.com/c/chromium/src/+/2591007) all host
binaries that run during the build at least work. So with this, a build with
use_lld=true on a macOS machine at least gets mostly through the build
(...and far enough to find new interesting problems in lld).

Bug: 1149587
Change-Id: I862308158f4aaa4419f0fb5e98c206294a2835cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590392
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836863}

Bug: 1154531
Change-Id: I68dbd92b6d4066d4add555be602ece24c714c283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590145
Commit-Queue: Kent Tamura <tkent@chromium.org>
Auto-Submit: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836862}

When test is batching, FirstRunStatus#getFirstRunFlowComplete could
stored wrong value to restore due to commandline switch. Replace the
original value from the shared preference directly.

Bug: 1158467
Change-Id: I5dccfe3b28167c78c04f5ea04b348faff20677a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591232Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836861}