- 03 Dec, 2020 40 commits
-
-
Anton Bikineev authored
GCed optionals on stack are fine. Change-Id: If5a6fd603f06c376167a93b790df4970289a2663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566937Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#833302}
-
Daniel Libby authored
The alleged bug no longer hits, so these tests can be re-enabled and the bug closed (last reference to this in the source tree). Bug: 545547 Change-Id: I74469684932ba2bb61a8ac91a522024ac24dc328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570540 Auto-Submit: Daniel Libby <dlibby@microsoft.com> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#833301}
-
ckitagawa authored
This might save on binary size, but regardless it is good to change. This was made a static_library at project start and should have been a source_set. Change-Id: I925848a98d299c106e007f1770d54b984f414e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570239 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833300}
-
Nohemi Fernandez authored
This patch adds a metric to track when the user attempts to add an account to the web when they are already signed in to Chrome. This situation is possible when all GAIA cookies are removed from the web during a user session. Bug: 1154244 Change-Id: I3818d6ad6fcae014d381ccaf67ab9e0a46025ff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566755 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#833299}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d937e6cbed6..877fbcb69179 2020-12-03 primiano@google.com Merge "Docs: improve reference" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia0971f586e027c45609fb77f007bf589b9442871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833298}
-
Clark DuVall authored
Now that bundletool has been updated and isolated splits support JNI in DFMs, we can bring back the vr module. This requires telling the native code which split to load the vr module from. See crbug.com/1145287 for more context. Bug: 1145287 Change-Id: I594d98b1cff002e5966700487fd906f25de109cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569783 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#833297}
-
Etienne Pierre-doray authored
Previously, job_task lifetime in gin was bound to handle. This was fine until we exposed CancelAndDetach, where worker_task are allowed to run beyond handle lifetime. job_task lifetime must thus be extended to match worker_task. This CL also adds a gin test. Drive by: Fix IsRunning->IsValid calls in tests. Change-Id: I1f67d9c759e5b1a6fbc98de909a194df2001f087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566724Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#833296}
-
Francois Doray authored
Experiment results: https://docs.google.com/document/d/1Fpq31rNHiMHorCygu_1krpIun_0J1ePfef6lf1l4PLA/edit?usp=sharing Bug: 1075553 Change-Id: I63b893fb7e4fef9269d498c03f95b4cd201133b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568213Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#833295}
-
Antonio Gomes authored
... instead of pixels. It happens today that WaylandCursorPosition stores the last mouse position in pixels, instead of DIP. In lacros, this position is queried by the call to `display::Screen::GetScreen()->GetCursorScreenPoint()` in `ImmersiveFullscreenController::UpdateLocatedEventRevealedLock()`, for instance by hovering the mouse cursor over the upper display boundary in immersive fullscreen mode, so that the tabstrip slides down. When a high DPI display is used, the mismatch occurs. This CL changes WaylandCursorPosition to store the last mouse cursor position in DIP, instead of pixels. BUG=1153998, 1113900 R=msisov@igalia.com Change-Id: Id37ee61de4d22b8ffd190b403df91fd87e198007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569775Reviewed-by:
Maksim Sisov (GMT+2) <msisov@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#833294}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45552c0f29d..9d937e6cbed6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I0db11aede2dfac049c7bdadc2ba23f7e871236ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571059Reviewed-by:
-
Eric Willigers authored
Web apps on Chrome OS may use the Web Share API to send title, text and/or url, in addition to files. If title, text and/or url ShareData fields have been supplied, they are used to set the text and title for the Intent. If the web app is sharing both a text string and a URL, we combine them into a single string, with a space separator. The same approach is already taken on Android: https://source.chromium.org/chromium/chromium/src/+/master:components/browser_ui/share/android/java/src/org/chromium/components/browser_ui/share/ShareHelper.java;drc=28d989a1fc83edb779c034cad48572775696bc66;l=357 Not yet implemented or tested: sharing title/text/url without files. Design doc: https://docs.google.com/document/d/1EjpgseTbBhT9ogQv6HV6sLlBl4hpb2viOcmPtFJorMQ/edit# Bug: 1127670 Change-Id: Ie56a372816602b71ff386dc1094be61610d70a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569329 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833292}
-
Michael Lippautz authored
Bug: 1154667 Change-Id: I421ba6c9d6513dae3a66bddfd50a2de67e4046eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571283 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#833291}
-
Antonio Sartori authored
This reverts commit a1e3b5ad. Reason for revert: Breaks browser_tests All/SharesheetBubbleViewBrowserTest.InvokeUi_Default on Linux Chromium OS ASan LSan Tests (see https://crbug.com/1155058) Original change's description: > [Sharesheet] Refactor SharesheetServiceDelegate. > > This CL refactors sharesheet_service_delegate to be identified > by its native_window. This is so that we can ensure only one > sharesheet for any one native_window at any time. > > Bug: 1142706 > Change-Id: I7892bb5b95f6ab4fa17c772e173084b11e3ab69f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563010 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Commit-Queue: Melissa Zhang <melzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833098} TBR=dominickn@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,melzhang@chromium.org Change-Id: I9ed8d55ae616d952f3c53d1f459ae8c65be43507 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569747Reviewed-by:
Antonio Sartori <antoniosartori@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#833290}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606975184-aefe3d214a47b5e57d9dcedd54737f7057f97fb8.profdata to chrome-linux-master-1606996231-dddb4c2fad470c1e447a44fedd130c4825b70fb9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I20c30a20e2220737c1266f33afc639feabafa6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571186Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8670d6183a84..19a302fca592 2020-12-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bfb211914759 to bae138de13ac (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I7f6abf09b82797037dc8de2eb494116a8304fa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571176Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/35dd9a4faaff..0cf173dfbc29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC antoniosartori@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: antoniosartori@google.com Change-Id: Ie6a0bdc3ad0a2826610cd79f28de8d119a589814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571183Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833287}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f3f2c24ae44..4b10d58fc905 2020-12-03 robertphillips@google.com Fix bug in GrClearOp combining and remove some asserts (take 2) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I10442932afb15767e6905040c740273234521830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568298Reviewed-by:
-
Michael Lippautz authored
Avoids Member<HeapVector<...>> and saves the allocation when creating ScrollTimeline. Bug: 1154667 Change-Id: Id8a61f4ca6607a21e23d8ad1d9ac54340bf0d452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570369 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#833285}
-
Norman Rosas authored
and removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: Icdb5dc11aeee764ed5f3d621dcb26517d9f5d617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570246 Auto-Submit: Norman Rosas <normando@google.com> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833284}
-
Noam Rosenthal authored
Blink.DecodedImage.DensitySizeCorrectionDetected was necessary to test backwards compatibility of a new feature, this test is finished. Removed all calls for the count, test, and obsoleted histogram. Bug: 1152025 Change-Id: I16870a075271ead8ba46a44c6c0f4a485acc4551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567927Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#833283}
-
Bo Liu authored
Hopefully no longer needed on all platforms after r832898 Bug: 1153376 Change-Id: I7bc173cd4f404d6ababbe3e549f495b04bb028d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571151Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#833282}
-
Ben Joyce authored
CastSessionControllerTests were fixed. Bug: 1147740 Change-Id: I33fac64b04eb8e29d06286f657d74a6e1194a464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570410 Auto-Submit: benjamin joyce <bjoyce@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833281}
-
Benoit Lize authored
Group members that are accessed on the fast path at the beginning of the object. While the buckets are large enough that the relevant one is likely several cache lines away from the beginning of the object, reducing the distance may still help, and we've seen evidence that PartitionAlloc is sensitive to layout. Bug: 998048 Change-Id: I8642aa83b48a5e0890b2eb39e14a25fb7d6a3b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568288 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#833280}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bdf70c39ad5a..6ee0f9db82db 2020-12-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-12-03 pfaffe@chromium.org [e2e] Make arguments to the getValuesForScope helper non-optional 2020-12-03 mathias@chromium.org [Dark Mode]: migrate browser_debugger/domBreakpointsSidebarPane.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9629cd140ea6024eb966896fda6eace6d706c955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568296Reviewed-by:
-
Irem Uguz authored
This cl adds certificate profile name field to FailedWorkerInfo and CertificateProvisioningProcess. Then retrieves the certificate profile name from CertificateProvisioningProcess and displays it in certificate details UI. Updates mock_cert_provisioning_worker and tests with the new name field. Bug: 1137523 Change-Id: If189e84f83ca55ff384622a92b0a4b64f81ca2b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562250Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Irem Uğuz <iremuguz@google.com> Cr-Commit-Position: refs/heads/master@{#833278}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606975184-196f68b969b73bc3452eae4d054586312080107c.profdata to chrome-mac-master-1606996231-ba5c68d71497939eb8f18cb3a40e45fa42cfdc85.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I09cf2e13c0da8671cca2a6eacc3d42d5a35fe1bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571181Reviewed-by:
-
Ewann authored
This CL enables the Done button if tabs are not closed from the confirmation action sheet. It also correctly enables the button when switching from incognito to normal tabs slowly. Bug: 1151299, 1147770 Change-Id: Icfc5d601333a326ae9eb5c5c74f87d085c2361a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566816 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833276}
-
Adam Rice authored
We no longer have two implementations of ReadableStream. Fix comments accordingly. Change-Id: Ibbcd35b19782bb402e2623ae9ac3f05548b38819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497966Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#833275}
-
Rakina Zata Amni authored
The RFH accessed in a DCHECK might be null if the navigation never reached the ReadyToCommitNavigation state. Bug: 1133115 Change-Id: I57472efb15d4acb375c5a6980ca5b661bb08f53a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569637 Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#833274}
-
Roman Sorokin authored
Bug: 1100942 Change-Id: Idf4c0d44b85614c592bd333b0ec9410360b1cb31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560507 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#833273}
-
Robert Sesek authored
Bug: 1153883 Change-Id: I905596a4373b1381a1c882d65b83520d657b8246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565654Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833272}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/615ae5f5..9421b815 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6f0a21e32c18eb5dc43e95a17f108bdce78bf85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571057Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833271}
-
Ehimare Okoyomon authored
After speaking with UX for both teams, it was decided that it would be best to only use one location icon for both page info / site settings and keyboard accessory. Change-Id: I74af67df53da05f358b8daa735d9bb5363c43982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566951Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#833270}
-
Oriol Brufau authored
This provides the expected behavior for caret browsing when there is shadow DOM. Bug: 1116663 Test: SelectionModifierTest.MoveCaretWithShadow Change-Id: I11fc7dac6aa8cbfc0d2ebba958b4e57807845414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485262 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833269}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c40073b687da..091617dda85b 2020-12-03 nisse@webrtc.org Change TestStunServer::Create to take a SocketServer rather than a thread as argument. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7f26708f3a0b1fbf2e932a9b5d3409d6fe0e68c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571056Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a45552c0f29d..9d937e6cbed6 2020-12-03 fmayer@google.com Merge "Ensure client sends /proc/<PID>/{mem,maps}." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I925b9665c71076692880f7e30cb7d761be466ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571177Reviewed-by:
-
sandromaggi authored
When navigating to a Google property, shutdown immediately (which destroys UI), without showing an error first. Bug: b/173986107 Change-Id: I0cd31a2d45d96410066bcc44c7873dae7ce54fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566964Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#833266}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6544c663aa7e..bdf70c39ad5a 2020-12-03 tvanderlippe@chromium.org Cleanup empty JSDoc comment 2020-12-03 tvanderlippe@chromium.org Cleanup devtools_module_entrypoints.gni 2020-12-03 jacktfranklin@chromium.org [Dark mode] disable patching for sourcesPanel.css 2020-12-03 jacktfranklin@chromium.org Load themeColors.css in karma unit tests 2020-12-03 jacktfranklin@chromium.org Enforce readonly string[] over ReadonlyArray<string> 2020-12-03 jacktfranklin@chromium.org Enable interaction tests 2020-12-03 wolfi@chromium.org [DarkMode] indexedDBViews.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1152736,chromium:1153281 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I386c4d810a9d9bf220a02ecfb0f7662fd3211502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571175Reviewed-by:
-
Marc Treib authored
Trivial cleanups: - Rename StartNextAssociation to RecordConfigurationStats (that's all it does now after previous cleanups; "association" doesn't exist anymore with USS). - Rename the existing RecordConfigurationStats to RecordConfigurationStatsImpl. - Update a bunch of comments to not refer to "association". - Remove download_started_ which was only used in a DCHECK. Bug: 1102837 Change-Id: I81c2b6fd485afe968b78d6e4007e925e30bc9dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567926 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#833264}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/062280eeaa96..35dd9a4faaff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC antoniosartori@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: antoniosartori@google.com Change-Id: Ifeba502044510aaa9b84d0bff8ed3be17f8bdf37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571171Reviewed-by:
-
