- 13 Oct, 2020 15 commits
-
-
Matthew Mourgos authored
This CL adds text to the nudge view and an inline icon to represent the key to press to activate the keyboard shortcut. The icon shows as either a search icon or a launcher icon, depending on what the device supports. If the launcher icon is to be shown, then the icon is changed depending on if assistant is available. Bug: 1105541 Change-Id: Ieaad19c899af545f38410350ece2d30a48409a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463869Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#816375}
-
Timothy Loh authored
This CL simplifies the code for downloading Plugin VM images: - Remove PluginVmInstaller::OnDownloadCancelled(). It is not necessary for us to wait for the download to cancel. If the download service takes a while to (or fails to) cancel, we will still be able to retry the installation. - Instead of tracking pre-existing downloads, compare download guid to the current download guid. - Remove excess VLOGs Bug: b/169973809 Change-Id: Icea90298768ad66e102d6af127e739a768687975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465349Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816374}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a7b0fdc90fea..51af1b428f5f 2020-10-12 natlee@microsoft.com Have Queue timeline tasks resolve in order If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I1460c559b300eedd0161e48e42d0c302f2346d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466722Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816373}
-
Ian Barkley-Yeung authored
Fix 'os' metadata so that it is not hardcoded to "ChromeOS" Bug: chromium:1121816 Change-Id: Iebdff3629d5e37b07c2ede2f298302d8f3908883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463098 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#816372}
-
Esmael El-Moslimany authored
Bug: 1116953 Change-Id: I7a454072c190da5f1363f7c98027c81c5b19aa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459168 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#816371}
-
Bill Budge authored
This also removes plugin data and settings persistence, which isn't needed if the Flash plugin doesn't exist (it used to persist its own data on command from the browser.) Adds a TODO to figure out how we will remove plugin data now that Flash is deprecated. Bug: chromium:1064652,chromium:1135773,chromium:1135779 Change-Id: I2eb1e30856071190cba29cea98cdd86a37722f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450057 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Cr-Commit-Position: refs/heads/master@{#816370}
-
Alexander Cooper authored
This change has a few cleanups that were discovered or postponed in the process of moving the ArCoreInstallHelper to //components. Primarily: 1) Use a delegate rather than wrapper pattern for supplying the installer with an InfoBarManager. 2) Move android_vr_utils to //components/webxr/android, where the logic can be shared, thus reducing code duplication. 3) Add class-level comments to install types. Change-Id: I4a4273b51a2b99bec5f2c899b082690d5c4a44f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463768 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#816369}
-
Josiah K authored
Should be pure refactor with no functional changes (except for some minor cleanup as noted, and using just root node where desktop wasn't needed). (Previously, runWithLoadedTree default invoked callback with desktop node) AX-Relnotes: n/a. Change-Id: Ib738ae4c39bf1e115878430036267baa01408201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460234 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#816368}
-
Abigail Klein authored
media controls dialog. Live Caption is a Chrome-wide feature that is currently enabled through settings. To provide a more accessible entrypoint to the Live Caption feature, we are adding a button to the global media controls dialog. This button is located below the media notification container in a footer. Screenshots: Live Caption enabled: https://screenshot.googleplex.com/5PpHAbLDzA7jPbe Live Caption disabled: https://screenshot.googleplex.com/4abNrFcTiiFmTdc UX Mock: https://docs.google.com/presentation/d/13BT8O7Gggi41sAUlIVRiwJnE73cKYmSUDniZgV_gQxE/edit#slide=id.g88757e649e_0_10 Bug: 1055150 Change-Id: If195f291da92a8b81cc070b72ac072327a2ebd65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463705Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#816367}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c99c8ab390f7..38f6d78eae8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mahmadi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mahmadi@google.com Change-Id: I6f7d8958c35b0195f4e7bcb8ca3773100af008e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466212Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816366}
-
Scott Lee authored
In crbug.com/1136998, it has been reported that the resultdb integration failed due to a connection aborted exception. The cause is not known yet, but this CL disables resultdb in all iOS tests to unblock resultdb roll-out. R=chanli@chromium.org,dpranke@chromium.org,zhaoyangli@chromium.org Bug: 1136998 Change-Id: I7684f6ad79c1f35f6af15e8d9f5a9a5246759e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465924Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#816365}
-
Joey Arhar authored
Bug: 693907 Change-Id: I33fd612193420e463c34693f875d8c7e0f25431e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466297Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#816364}
-
Zhongyi Shi authored
https://quiche.googlesource.com/quiche.git/+log/60e12c40278b..5a4f76123806 $ git log 60e12c402..5a4f76123 --date=short --no-merges --format='%ad %ae %s' 2020-10-09 zhongyi use size_t* instead of QuicByteCount* to fix quiche roll. 2020-10-09 mattm QUIC Key Update support 2020-10-09 vasilvv Replace quiche::QuicheStringPiece with absl::string_view. 2020-10-09 renjietang Temporarily disable EndToEndTest.MultipleZeroRtt in Chrome. 2020-10-09 mattm Rename CryptoUtils::SetKeyAndIV to InitializeCrypterSecrets and add separate SetKeyAndIV and GenerateHeaderProtectionKey methods. 2020-10-09 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-09 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-09 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-09 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-09 wub For BBRv2, - Change the default STARTUP and DRAIN cwnd gain to 2.0. - Change the meaning of BBQ2 to use 2.885 cwnd gain for STARTUP and DRAIN. 2020-10-08 mattm Move StrictTaggingDecrypter to quic_test_utils.h 2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-08 bnc Use faster Huffman encoding for QPACK. 2020-10-08 bnc Eliminate copying of Huffman encoded string in QpackInstructionEncoder. 2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-08 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-08 bnc Append to output instead of overwriting it in http2::HuffmanEncode(). 2020-10-07 vasilvv Replace QuicheStringPiece with absl::string_view 2020-10-07 dschinazi Fix NetSLO QUIC prober tests 2020-10-07 renjietang Add explicit numbers to QuicStreamRstErrorCode. 2020-10-07 renjietang Add regression test for 0-RTT rejection bug. 2020-10-07 bnc Use faster Huffman encoding for HPACK. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I6679f94041b1202821ad5c622b7a1092412f8349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464182 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816363}
-
Steven Bennetts authored
This argument was used with networking.config which has been deprecated. |force| is always false in the remaining calls. Bug: 1124419 Change-Id: Ic920385fc2364a04dabccfec13171f8759b8b522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442897 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#816362}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/336202d7d601..4c6b47949139 2020-10-12 cclao@google.com Vulkan: TexSubImage3D using PBO should use correct layerCount If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@chromium.org Change-Id: I7a29075e98901d108bfd7cf534696f2128c6d516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465726Reviewed-by:
-
- 12 Oct, 2020 25 commits
-
-
Timothy Loh authored
If PluginVmInstaller::Start() is called when an install is already in progress, InstallFailed() currently gets called which resets the state to kIdle. This CL changes Start() to not call InstallFailed(), but rather return a FailureReason if we failed to start. We probably shouldn't be trying to call Start() when there is already an install in progress, but currently closing the installer by clicking the X doesn't actually cancel it. This CL prevents us from getting into a weird state where multiple steps of the install are concurrently running. Bug: b/169973809 Change-Id: I703fd846a9d034659b7597606c400bdf127a2cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463093 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
-
Mark Schillaci authored
This CL updates the behavior of ListBox on Android. With this change, the state of a Listbox ("x items") will now be read during swipe navigation when a node is initially selected. For ListBoxItem, the state of the item will read as "in list, item x of y". We append the state of the ListBox or items in the stateDescription element of the node's corresponding AccessibilityNodeInfo object. This CL also updates associated unit test expectations. AX-Relnoates: ListBoxes and ListBoxItems now explicitly announce their count and item index. Bug: 1101656 Change-Id: Ibdae3a0401f03cde373d4055dbc93f9465bb2f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462276Reviewed-by:Mark Schillaci <mschillaci@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#816359}
-
Timothy Loh authored
Currently closing the Plugin VM installer dialog cancels installation only if the cancel button is clicked. Clicking the X or hitting escape doesn't cancel the install, leading to weird states if the user then opens the dialog again. This CL moves the logic for cancelling the installation to the dialog's destructor, ensuring we always properly cancel the installation. Bug: b/169973809 Change-Id: I3390e88effac6553e76e78c1509315250cb6ff18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462897 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
Defer batches of accessibility updates unless they include user actions. changes within a short period of time. AX-Relnotes: performance improvements for web pages that make many Bug: 1107988 Change-Id: I42fb6ac7a48f833cb4a42a53e80870bdf5dd7d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446089Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Vadim Shtayura authored
It means Swarming will use ACLs defined in realms.cfg when authorizing Buildbucket calls (this will eventually be default). Enable realms-aware mode on 100% on cr-buildbucket-dev builds. R=gbeaty@chromium.org BUG=1136313 Change-Id: I3c4a6fd4d85c64310f30223abeeb199ef97af1fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466488Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#816356}
-
Ben Pastene authored
It was disabled for linux-chromeos-rel since it supposedly caused a regression in cycle time. However, linux-chromeos-rel is suspected to behave similar to linux-rel in that regard, and linux-rel did not show similar regressions. So this tentatively re-enables cancellation on linux-chromeos-rel to confirm if it does more harm than good. Change-Id: I30b1f7d7514bb0b6d8ca7b2ede5cd4a494c770f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463854Reviewed-by:
-
Tal Pressman authored
This allows the use of, e.g.: CHECK_EQ(), making error messages clearer. Change-Id: I0d087117e3da0cafc792ea7baa78c89febcec4ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463281Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#816354}
-
rajendrant authored
This is a reland of 0716d3fb The failing test ran fine 100+ times in linux. Could not repro the Mac failures, but I believe this change should fix it. Original change's description: > LiteVideo: Stop throttling on playback seek events > > This plumbs the playback seek event from renderer to browser and uses it > to stop litevideo throttling. The seek updates to browser are throttled > for performance reasons. > > Subsequent CL will change this to stop throttling only after k seek > events (finchable), and record this in UKM. > > Bug: 1134672 > Change-Id: Idd88819e8ae50ffbc215197a437bf87d6fa9a36a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453801 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#815787} TBR=mcrouse@chromium.org,dalecurtis@chromium.org,kinuko@chromium.org Bug: 1134672 Change-Id: I7a24835e5a6a459ad9442ad813f92828e96f3e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466487Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#816353}
-
Phu Le authored
The OpenXR runtime on Windows supports both "opaque" (WMR VR devices) and "additive" (Hololens). This change simply turns on support for Immersive-AR session according to the WebXR AR-module spec. The majority of the change is to let the runtime to decide about the blend_mode and interaction_mode instead of the current guessing logic at at the renderer layer. Bug: 1069350, 944936 Change-Id: Ie5f1b56857f9ca5357dbd1dde6585687773d0b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432759 Commit-Queue: Phu Le <phle@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#816352}
-
Jesse Schettler authored
Add a new Polymer element, resolution-select, to display the available resolutions in a dropdown. Bug: 1059779 Change-Id: Ic4f6d3cdf27906cea77d807f0134587b38e1bb0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459007Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#816351}
-
Yusuf Sengul authored
Bug: 1137515 Change-Id: I726a1cc7d4f8aa39c68c9c12b92ba40ba4140b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466009 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#816350}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3637a44a3643..4efaf5e9fead 2020-10-12 bsalomon@google.com Reland "Revert "Use ManagedBackendTexture in place of TestUtils backend texture helpers."" 2020-10-12 brianosman@google.com Add geometry shader test demonstrating max_vertices/invocations bug 2020-10-12 ethannicholas@google.com moved SkSL Swizzle data into IRNode 2020-10-12 michaelludwig@google.com Enable new clip stack for Fuchsia 2020-10-12 michaelludwig@google.com Enable new clip stack for google3 2020-10-12 michaelludwig@google.com Expand image filter factories to accept more types for crop rects 2020-10-12 egdaniel@google.com Add scratch msaa attachment creation to GrResourceProvider. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: robertphillips@google.com Change-Id: I900d816cb58a6dc1179c1cc467350c6ce4febbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466720Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b49605bd62cd..182a24a6540b 2020-10-12 brgoddar@microsoft.com Force Tabbed Pane to update all Tabbed widths on DPI changes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136226 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibd6f1135070089b8c91c876c0341a3438460393f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466719Reviewed-by:
-
Nathan Zabriskie authored
This CL adds a virtual test suite runs all the web tests in fast/canvas with the OOPR canvas feature enabled. Bug: 1081534 Change-Id: Ie76ec3ea3d2c365eba4fbc99cf19b8803a07636a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453501 Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#816347}
-
Yulun Wu authored
This addresses changes in: https://chromium-review.googlesource.com/c/chromium/src/+/2442354 Note that the restoration is not exact as we are maintaining a fix to unify launcher inkdrop highlights due to this related bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1051167 Bug: 1134800 Change-Id: Ie7f70b30bf4ec5fc646cb77e8b18578b96392024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464364Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816346}
-
Andrei Pascovici authored
In preparation for turning it off on certain platforms Bug: 1136105 Test: on affected device Change-Id: I73ab150e54baba1e09e20559cd9c31500ceb3515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466196Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Auto-Submit: Andrei Pascovici <apascovici@chromium.org> Cr-Commit-Position: refs/heads/master@{#816345}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1e73818c7ac8..3e0a5fc2097e 2020-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c67306a2..b4b8f552 (816064:816181) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9d05be5acf9ee8f96e99984292c0c5e0ff33d038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466641 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Eric Willigers authored
Various chrome/browser/extensions files were needlessly including chrome_features.h and scoped_feature_list.h Bug: 1137231 Change-Id: Ib91d13989f3b2a19d139d1e6b73bcfddfb2dbfb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463034Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#816343}
-
Toni Barzic authored
BUG=1092726 Change-Id: I96c70415a9c3afaaced5ab4976396864fe9cb91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460785Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
-
Adam Ettenberger authored
Blink fires the TextChanged event for all sorts of reasons, and it leads to flakiness and difficulty fixing other bugs. Instead, fire this event when a static text node has changed its text using AXEventGenerator, which is more stable and predictable. When static text changes under UIA, fire a text-changed event rather than raising a property-changed for UIA_NamePropertyId. Add AXEventGenerator::Event::EDITABLE_TEXT_CHANGED which is fired on an editable root when static text within an editable text region changes. Bug: 904977, 1062063, 1085481, 1105262 Change-Id: Ic655deba0d1a5ab1fb575ffa8a56cef1c538c923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393067 Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#816341}
-
David Black authored
Search + Space propagates to the view as mouse events. Unfortunately we can't tell from the mouse event if the event was created by ChromeVox but its good enough to just check if ChromeVox is enabled. Bug: 1137039 Change-Id: I0ed18774632b0e46bf6100d86a27abbf5df29f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466165Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#816340}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba88e59b..7bb48090 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I95a61574ebdaa9fcab1866231cd4a46092517bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462181Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816339}
-
Dirk Pranke authored
The new typ-based version of this test doesn't support the --avd-config flag, so we disable the test temporarily on Android emulator bots until it does. Tbr: pkotwicz@chromium.org Bug: 1137405 Change-Id: Ieae25138a160d351813dbdc7205070129a082eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466057Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#816338}
-
Siyu An authored
Offer data will be server-only data, so I figure we don't need two clients integration tests. Bug: 1093057 Change-Id: I8afb57ed49b7ab6d57071c331ea679fdf1928260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453351 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#816337}
-
Ben Joyce authored
reduces speed from 16438ms to 4656 ms Bug: 989569 Change-Id: Ide7b215a03df82d724f5e3639038734c2c574857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438779 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#816336}
-
