- 16 Aug, 2018 40 commits
-
-
Kyle Milka authored
As the feature is enabled by default the flag is no longer necessary. The api override url is now never used and is also removed. Bug: 874095 Change-Id: I82a102ba9935b8ab25fa8a986aab9741c8ac8670 Reviewed-on: https://chromium-review.googlesource.com/1174911 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#583706}
-
Charlie Andrews authored
This reverts commit cfdb3952. Reason for revert: Story is still failing Original change's description: > Re-enable load:media:soundcloud for webview on system_health.common_mobile. > > It's passing in perf tryjobs. > > Bug: 787001 > Change-Id: Ie9a74b141d6dd610a1bfab3d9d9ea79b40dafc48 > TBR: tdresser@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/1174632 > Reviewed-by: Annie Sullivan <sullivan@chromium.org> > Commit-Queue: Annie Sullivan <sullivan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582944} NOTRY=true TBR=sullivan@chromium.org Bug: 787001 Change-Id: If734162c4815ec7c1a988343859b80556cce6044 Reviewed-on: https://chromium-review.googlesource.com/1178001 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#583705}
-
Helen Li authored
This CL adds NetLog events to SessionCleanupCookieStore. This is based on rdsmith@'s CL at https://chromium-review.googlesource.com/c/chromium/src/+/925181 Bug: 801910 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I87a89ff265d703792a492f93ce59cb57f9f02d14 Reviewed-on: https://chromium-review.googlesource.com/1175437 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#583704}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/937745b81606..fccde774f480 git log 937745b81606..fccde774f480 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 manojgupta@chromium.org Revert "cros_chrome_sdk: Invoke compiler in relative form" Created with: gclient setdep -r src/third_party/chromite@fccde774f480 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I81c80f4ae4ebe264da66ebbccac5e138aabc22e6 Reviewed-on: https://chromium-review.googlesource.com/1177984Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583703}
-
Martin Šrámek authored
...to match the Incognito NTP background color. Bug: 865786 Change-Id: I87c1ea80b8405c5003f4085f71019af925617f09 Reviewed-on: https://chromium-review.googlesource.com/1177395Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#583702}
-
Xianzhu Wang authored
- Disable under-invalidation checking for the test. Animated svg sometimes fail under-invalidation checking because the forced paint by under-invalidation-checking may paint differently based on the current timer, while without under-invalidation-checking we still get image changed notification which will cause needed paint invalidation. We have already disabled under-invalidation checking in similar cases. Not sure why the test succeeded without blink-gen-property-trees, but the test does run normally in content_shell with --enable-blink-gen-property-trees. - Modify the test to test raster invalidations instead of object invalidations (which was removed in crrev.com/582462), and ensure that the reference image is invalidated after animation is advanced. Bug: 854196 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7d00d61d15cb6172e216793c14a0b29b9d56be1b Reviewed-on: https://chromium-review.googlesource.com/1176435Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#583701}
-
Evan Stade authored
Only needed one small tweak to BrowserNonClientFrameViewAsh. Bug: 854704 Change-Id: Ib6536580a84bf4035279512f2e6c22c31d4cdabd Reviewed-on: https://chromium-review.googlesource.com/1176427Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#583700}
-
Denis Kuznetsov authored
Bug: 864455 Change-Id: I93548d73dcf82590bb31ad884d6af436c91e3159 Reviewed-on: https://chromium-review.googlesource.com/1167845Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#583699}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874954 Change-Id: I197eddaa975cca5edb0db359fc44c127e6d64fec Reviewed-on: https://chromium-review.googlesource.com/1178113Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583698}
-
Florent Castelli authored
Bug: 787254 Change-Id: I44dd447f8799a4b1ff45da609112e46294e89747 Reviewed-on: https://chromium-review.googlesource.com/1175919 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#583697}
-
Xiaoqian Dai authored
When dragging a window from caption area in tablet mode, overview will open behind the dragged windows. When the dragged window is dragged into the preview split area, we should update the overview grid's bounds and also update the new selector item's visibility. See recorded video: https://drive.google.com/open?id=10gPVG1Wlgt4YDnZI_tPS2p6JJGYJ-ztl Bug: 873292 Change-Id: Ibc7028820bed11d61bdbb376fdc6723c26a0c262 Reviewed-on: https://chromium-review.googlesource.com/1176220 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#583696}
-
Anders Hartvoll Ruud authored
In StyleValueToCSSValue, when checking whether a certain CSSStyleValue matches the property in question, we now ask the registration (via CSSOMTypes) if the CSSStyleValue matches. If it doesn't match, we throw a TypeError like for normal properties. If it does match, the CSSStyleValue is stringified, tokenized, and set on the style rule as tokens. I have postponed support for <color> and <transform-function>, because CSSUnsupportedStyleValue currently does not handle registered custom properties at all. This is appropriate to fix in a separate CL. Note that, because the string version of StylePropertyMap.set also uses StyleValueToCSSValue, it will no longer be possible to set registered custom properties with a string--even if the syntax is matched. A subsequent CL will fix this. R=futhark@chromium.org Bug: 641877 Change-Id: Ie0cc2f87e39f8f59015824bfd1b81efaf402c326 Reviewed-on: https://chromium-review.googlesource.com/1175822 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#583695}
-
Katie D authored
This makes it possible to read content in menus with the Select-to-Speak tray button, for example on tablet mode. Bug: 870922 Change-Id: I3501625721c8d49a2ec422377a83b9f8f036b228 Reviewed-on: https://chromium-review.googlesource.com/1176181 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#583694}
-
Kyle Horimoto authored
This change was suggested by our UX string writer, jonann@. Bug: 872982 Change-Id: I179d7e8b7abb25db822f1828d5364731a38104e0 Reviewed-on: https://chromium-review.googlesource.com/1176822Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#583693}
-
Anders Hartvoll Ruud authored
In order to implement interpolation types for custom property lists (issue 868959), it is needed to pass along additional state to these callbacks. Hence, regular function pointers are not enough. In preparation of that, this CL changes the function pointers to base:: RepeatingCallbacks. R=flackr@chromium.org Bug: 868959 Change-Id: Ic6214d4119af69c9bc1b87a9fdc63c05ea33e05f Reviewed-on: https://chromium-review.googlesource.com/1165545Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#583692}
-
John Delaney authored
Send data use updates per resource from renderer to browser. This will allow the browser process to aggregate per-resource information and will keep feature specific logic out of core PageLoadMetrics code. Bug: 873746,851543 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I34a617c8f1212d9d9ec157de16d65379340b1697 Reviewed-on: https://chromium-review.googlesource.com/1164222 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#583691}
-
Elad Alon authored
Bug: 775415 Change-Id: I24a08a3d000a5d06d2ada6a68a8d9245523ab538 Reviewed-on: https://chromium-review.googlesource.com/1177758Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#583690}
-
Sammie Quon authored
It is now black when there is a maximized window. Test: added test Bug: 850630 Change-Id: I8ea09cdc0196f2f52fe26eae63f823ca46450100 Reviewed-on: https://chromium-review.googlesource.com/1176832Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#583689}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874946 Change-Id: I21c44dc3e423f28012eb0459b1b1302bfcf47b3f Reviewed-on: https://chromium-review.googlesource.com/1178106Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: If72184b571a5d550e321bf8568523a16c9fb35f0 Reviewed-on: https://chromium-review.googlesource.com/1177603 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#583687}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5314945fa47a..922ba81b497b git log 5314945fa47a..922ba81b497b --date=short --no-merges --format='%ad %ae %s' 2018-08-16 simonhatch@chromium.org Enable LUCI presubmit 2018-08-16 simonhatch@chromium.org Dashboard - Flaky alerts test setting global 2018-08-16 nastasoiuf@google.com Functional prototype for dotPlot and linePlot Created with: gclient setdep -r src/third_party/catapult@922ba81b497b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:825436,chromium:874800,chromium:866423 TBR=sullivan@chromium.org Change-Id: Id94d5cfa2c8e1955d0b39cec9afcb63365f89650 Reviewed-on: https://chromium-review.googlesource.com/1177585Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583686}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874929 Change-Id: Ia0cabec9bdd4bacaf4d8acdb8a69cbd50dc0a446 Reviewed-on: https://chromium-review.googlesource.com/1178103Reviewed-by:
-
Bill Budge authored
- RawResource is used for several non-text resources, as well as document resources. The cached metadata handling has been set up for a document's inline scripts. This makes it difficult to cache metadata properly for other RawResources, such as WebAssembly modules. This change only creates SourceKeyedMetadataHandler for RawResources whose type is kMainResource. - Renames RawResource::CacheHandler to InlineScriptCacheHandler so it doesn't hide the Resource::CacheHandler method, and so we can later add other kinds of metadata handlers. Bug: chromium:719172 Change-Id: I53f361a0df48dc9d73780971e3408dfff08de518 Reviewed-on: https://chromium-review.googlesource.com/1173496Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#583684}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/767fddfcce61..cbd83bbd77d1 git log 767fddfcce61..cbd83bbd77d1 --date=short --no-merges --format='%ad %ae %s' 2018-08-16 mtklein@google.com don't adapt gray colors to 565 Created with: gclient setdep -r src/third_party/skia@cbd83bbd77d1 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I60eb62a1fd42049248d3da549efa211368927357 Reviewed-on: https://chromium-review.googlesource.com/1177584Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#583683}
-
Tibor Goldschwendt authored
This is a reland of bc740b07 with a fix to include the loadable modules into the final APK. Original change's description: > [build:android] Add a module for AR in Monochrome > > Add an AR Dynamic Feature Module (DFM) and bundle it into the public > Monochrome bundle. > > + Add loadable modules to the build config so that their paths can be > passed to the module create target. > > + Add option to bundle targets to specify the Android SDK target for > synchronized proguarding. This was necessary because the Monochrome > base module uses a different Android SDK than the AR module, which > made proguard sad. Also pass the Android SDK Jar as a dedicated > classpath Jar to proguard and don't mix it with the other classpath > Jars. > > Bug: 863063 > Change-Id: I024d05dd99136c069e510995657ac7236f6b6e5e > Reviewed-on: https://chromium-review.googlesource.com/1165533 > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582765} TBR=tedchoc@chromium.org Bug: 863063, 873986 Change-Id: I4a72667027ab283b43685197c980b46e90553df8 Reviewed-on: https://chromium-review.googlesource.com/1174772 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#583682}
-
Cole Winstanley authored
Added a class to parse out HTTP and WebSocket DevTools entries from ChromeDriver log files. Bug: chromedriver:2501 Change-Id: I0a3173b295b802c119c90c416fe1e77d7e39cdab Reviewed-on: https://chromium-review.googlesource.com/1166036Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#583681}
-
Elly Fong-Jones authored
These use focus rings even on platforms that normally use the ink drop effect to indicate focus. Bug: 874750 Change-Id: I1a531126b348b8d910998778caa5abd40e87a898 Reviewed-on: https://chromium-review.googlesource.com/1177681 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#583680}
-
Daniel Vogelheim authored
The previous implementation used both a --feature-enabled and a --runtime-feature-enabled switch, initializing the latter based on the former, presumably because it had components in both browser and Blink. That's redundant. The current implementation uses the browser switch. All Blink-resident parts of the code act on whether they receive a policy or not (which would be always false if the browser switch isn't set). Bug: 751996 Change-Id: I81f10cc888fd7c29c6c93e727526863216ca6f02 Reviewed-on: https://chromium-review.googlesource.com/1165351Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#583679}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor ans has no intended behavior change. Bug: 842194 Change-Id: I700df0bc23f0b52d123e92ff16013153a359b16f Reviewed-on: https://chromium-review.googlesource.com/1176897Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#583678}
-
about://flagsBecca Hughes authored
Add flag for new unified sound settings UI to about://flags. BUG=865548 Change-Id: Ie3a3139d9af32bacfe6992708841272c47f4179c Reviewed-on: https://chromium-review.googlesource.com/1176648Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#583677}
-
Ramin Halavati authored
Settings Reset Prompt preferences are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I84164f5734290d20c2a50ed93139645b91561296 Reviewed-on: https://chromium-review.googlesource.com/1176808 Commit-Queue: Robert Shield <robertshield@chromium.org> Reviewed-by:
Robert Shield <robertshield@chromium.org> Cr-Commit-Position: refs/heads/master@{#583676}
-
Adam Langley authored
Chrome isn't doing Token Binding any longer. Change-Id: I5c9cdfec22ae1075f3943d4c041544311be9c4ad Reviewed-on: https://chromium-review.googlesource.com/1176786Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#583675}
-
Peter E Conn authored
This will display Trusted Web Activities correctly when they are launched when verification hasn't been completed. It also ensures that Trusted Web Activities show the top bar when they are launched to a non-verified origin. Bug: 871266 Change-Id: Ibd245812647a2f1d6b6a9405f14d12f46f6ae6f9 Reviewed-on: https://chromium-review.googlesource.com/1177611Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#583674}
-
Sadrul Habib Chowdhury authored
The PersistentMemoryAllocator in the gpu (and other) process is created asynchronously. If any uma-histogram is reported before that time, then those Histograms are not stored in the shared memory. This has some implications: . If the process crashes (which is common for the gpu process on android), then these metrics are lost. . If the process stays alive, then the metrics are reported periodically, but because it is buffered, it doesn't match up correctly with the other metrics that are reported in the shared memory. The allocator is created in response to a message from the browser, which includes the handle for the shared memory to use for the allocator. The browser waits until the process has been launched and connected. So this happens much later, compared to other messages which are sent from browser over mojo without waiting for the connection to have been established first. Therefore, change this so that the browser immediately shares the shared-memory segment with the gpu process. mojo takes care of waiting for the process-launch etc. BUG=865179, 778749 Change-Id: Iccd3d4422de3e22ead4bc6510afc5ea207bf6b6e Reviewed-on: https://chromium-review.googlesource.com/1174709Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#583673}
-
Annie Sullivan authored
Bug: 874935 Change-Id: Ic5959bd2f22097f6534248d9c1f15323f8ebe57b TBR: nednguyen@google.com NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1177890Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#583672}
-
rbpotter authored
In Polymerized Print Preview, the event target is always print-preview-app, which does not have an ancestor with a scrollbar even if one exists on the page (e.g. in the settings sections). Examine the event path instead of the target and its ancestors to determine if there is a scrollbar that should receive the arrow key events instead of the plugin. Bug: 872251 Change-Id: I034542d04644e1b47fd1961a9b984a48843b2b40 Reviewed-on: https://chromium-review.googlesource.com/1174995 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#583671}
-
W. James MacLean authored
There have been no flakes reported on EmulatedTouchPinchGoesToMainFrame since https://chromium-review.googlesource.com/c/chromium/src/+/1172723 went in, so let's try re-enabling some more tests. Bug: 833380 Change-Id: If406a6f5d7b0a88e84cad84e07d1bba547eb1baa Reviewed-on: https://chromium-review.googlesource.com/1177843Reviewed-by:
-
Arthur Sonzogni authored
Some builds timed out recently: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester Bug: 874840 Change-Id: I31aa161ef63488debb8c3fe38f71c096fe132207 Reviewed-on: https://chromium-review.googlesource.com/1177703 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#583669}
-
Xida Chen authored
TBR=wjmaclean@chromium.org NOTRY=true Bug: 874931 Change-Id: I49375c4593122e9a3a1f8c06ffa3969b6fa1ea1c Reviewed-on: https://chromium-review.googlesource.com/1177904Reviewed-by:
-
Siddhartha authored
Change-Id: I1f9f3f47933ef13a0a69f999e7ddd2b021affa16 Reviewed-on: https://chromium-review.googlesource.com/1177197Reviewed-by:
-
