- 09 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e28390cc438f..af0ede1e73a7 git log e28390cc438f..af0ede1e73a7 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-09 mheikal@chromium.org Fix crash were CL has no reviewers Created with: gclient setdep -r src/third_party/depot_tools@af0ede1e73a7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:895722 TBR=agable@chromium.org Change-Id: I1f65e12c3257a9fa87331f2e409dc702434e5c96 Reviewed-on: https://chromium-review.googlesource.com/c/1330007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607014}
-
Erik Luo authored
Hovering over a TextNode in DevTools will now highlight it on the page. Its tooltip shows "#text" with VisualOverflowRect dimensions. Screenshot: https://imgur.com/a/yPFT73e Bug: 893426 Change-Id: If988e72960aa68b2d9c666c5de3feb5ce1192509 Reviewed-on: https://chromium-review.googlesource.com/c/1269859Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#607013}
-
bsheedy authored
Moves the 'file count' metric generated by resource_sizes.py out of the _Specifics group into its own _FileCount group. This is a workaround for https://crbug.com/903970, where mixing units within a group causes malformed data to be generated when using the HistogramSet format. Bug: 892344, 892301 Change-Id: Icfd47567127d51f7ee703262c448c2619148cb10 Reviewed-on: https://chromium-review.googlesource.com/c/1330707Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#607012}
-
Scott Violet authored
This reverts commit ce37f17d. Reason for revert: Causes crash, see 903671 Original change's description: > Fix text input on ARC++ Kiosk apps. > > We changed IsInArcAppWindow() to use the window property, > aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window. > It makes text input on ARC++ Kiosk apps stop working. > This CL adds a temporary workaround for this situation. Ideally, > IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app > correctly. > > Bug: 891825 > Test: Can type text on Wikipedia kiosk app. > Change-Id: I594aa5c0730704b9ad922441187297bd707de20a > Reviewed-on: https://chromium-review.googlesource.com/c/1291289 > Commit-Queue: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601631} TBR=yusukes@chromium.org,yhanada@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 891825 Change-Id: Ic50a4bac3af3dfb7f8fd335bb669d3e620a4446a Reviewed-on: https://chromium-review.googlesource.com/c/1330339Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607011}
-
Carlos IL authored
Bug: 885376 Change-Id: Ic1b4075a169512103994edabc53b5d1b6daffb10 Reviewed-on: https://chromium-review.googlesource.com/c/1325190 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#607010}
-
Mohamed Amir Yosef authored
After initial sync is done, sync loads the persisted metadata and checks their integrity against the bookmark model. This CL adds a UMA metric to track different reasons why metadata might be corrupted Bug: 516866 Change-Id: I94ed2d80ec487a52069de6a6124419f97b4d5456 Reviewed-on: https://chromium-review.googlesource.com/c/1329248Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#607009}
-
Bailey Berro authored
- Creates a free form SMB share dialog - Dialog will be opened by SmbProvider::RequestMount Bug: chromium:887135 Change-Id: I379417ac15d633bce704bd50c8d31e8488fc2975 Reviewed-on: https://chromium-review.googlesource.com/c/1289409 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607008}
-
wutao authored
This cl add a STOP button to timer notification. Bug: b/118655426 Test: manual Change-Id: I88752010e4b0c5be54debddb8394827a798d65fe Reviewed-on: https://chromium-review.googlesource.com/c/1330296Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#607007}
-
Scott Chen authored
Bug: 881937 Change-Id: Iac86251f6f6d7bba501b2add3260579d2f2ba53b Reviewed-on: https://chromium-review.googlesource.com/c/1327569 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#607006}
-
Martin Kreichgauer authored
There are versions of webauthn.dll that ship without BLE support. On platforms where that is the case, direct access to FIDO token is not blocked by the OS and so we don't want to integrate with webauthn.dll there. This changes WinWebAuthnApi to call WebAuthNGetApiVersion on initialization and mark the API as unavailable if the version number is not at least the current version (1). The check may be overridden by a flag while we wait for WebAuthNGetApiVersion function to ship. Bug: 898718 Change-Id: Ic20e55a416d858214b9f444031f4700567933eb4 Reviewed-on: https://chromium-review.googlesource.com/c/1327885 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#607005}
-
Jao-ke Chin-Lee authored
BUG=790286,790294,790309 Change-Id: I5314b6a2743a83ed3b864b6842b32d023caed977 Reviewed-on: https://chromium-review.googlesource.com/c/1330340Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#607004}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b07ed8fb0766..2bb343c5e822 git log b07ed8fb0766..2bb343c5e822 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 herb@google.com Remove runIndex as a concept for GrTextBlob 2018-11-09 reed@google.com rm legacy flags for hinting enum 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-09 herb@google.com Reland "Move remove ptr args to MakeRecAndEffects" 2018-11-09 herb@google.com Revert "Move remove ptr args to MakeRecAndEffects" 2018-11-09 herb@google.com Move remove ptr args to MakeRecAndEffects Created with: gclient setdep -r src/third_party/skia@2bb343c5e822 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I4074acffea1b16b5c684b8b2d47166cca80b0257 Reviewed-on: https://chromium-review.googlesource.com/c/1329992Reviewed-by:
-
Siddhartha authored
Remove java mapped regions so that the unwinder does not try unwinding these frames at all. BUG=888434 Change-Id: Ic5999652ec85a4a3ed04aa7e8030d0a3faf11fbd Reviewed-on: https://chromium-review.googlesource.com/c/1327424 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607002}
-
Kim Paulhamus authored
Bug: 902554 Change-Id: Ic14cfeaa7b041c316bcb77066d69a7b701bd5a62 Reviewed-on: https://chromium-review.googlesource.com/c/1321260 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#607001}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7b37bbfad45f..1ba4ba601cc4 git log 7b37bbfad45f..1ba4ba601cc4 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 treehugger-gerrit@google.com Merge "profiling/memory: tiny fixups of a couple of copy/move aspects." Created with: gclient setdep -r src/third_party/perfetto@1ba4ba601cc4 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I69cc1381e2a50fa4332ac2d776ade5e00bfebc8f Reviewed-on: https://chromium-review.googlesource.com/c/1330023Reviewed-by:
-
David Jacobo authored
views::TouchSelectionMenuRunnerViews::Menu should be better by separating it on their own class, this CL introduces TouchSelectionMenuViews. Bug: None Test: Build. Change-Id: Ic9e8e258c41d2686746ff9b7d73fef1826424851 Reviewed-on: https://chromium-review.googlesource.com/c/1328281Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
-
Sammie Quon authored
Now that tablet mode manager tracks all user windows and not just current accounts, the window should be non account windows should be maximized on entering tablet mode, not on user switch. Test: unit_tests MultiUserWindowManagerChromeOS.TabletModeInteraction Bug: 903427 Change-Id: Ib21a7e1d7f1a37f8a571ad16226f11e03f0db960 Reviewed-on: https://chromium-review.googlesource.com/c/1329502Reviewed-by:
-
Kevin Marshall authored
Currently, a Frame doesn't process WebContentsObserver methods until a FIDL NavigationEventObserver is registered. WebContentsObserver is useful for more than just navigation events, though! In cases where a Frame is created but never passed a N.E.O., observer events like ReadyToCommitNavigation() were not being received, which interfered with on-load script injection. This CL fixes the issue by attaching the observer at Frame creation time. Bug: 903880 Change-Id: Ie3ab194fbaa60a5e18a4150be3ce4c6f7345845f Reviewed-on: https://chromium-review.googlesource.com/c/1328147 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606997}
-
Kyle Milka authored
Allocate more ids for local ntp resources in preparation for adding more resources. Bug: 864763 Change-Id: I9b68fdda795959306d248eec973b86e0506323c7 Reviewed-on: https://chromium-review.googlesource.com/c/1327558Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#606996}
-
Roger McFarlane authored
Change-Id: Ia78991eda5e1e25ca410ab94b3a1176ae75f7d7a Reviewed-on: https://chromium-review.googlesource.com/c/1330333Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#606995}
-
Becca Hughes authored
Support playback state in MediaSessionImpl. This is analogous to the previous IsActuallyPaused boolean. Also exposes MockMediaSession as we have duplicate test helpers in content and services that can be shared. BUG=893296 Change-Id: I8d7120a64b2eb9792eb7ba11e1ef13849eb81b93 Reviewed-on: https://chromium-review.googlesource.com/c/1281905 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#606994}
-
Parastoo Geranmayeh authored
validity related members in AutofillProfile should be mutable, and changing them should not change an instance of the profile. (The instances could remain const.) Change-Id: I2b088013ab4be3f4d7116c6949285690c965d68f Reviewed-on: https://chromium-review.googlesource.com/c/1324233 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#606993}
-
Fabio Tirelo authored
This CL is the first step in the refactoring and: - Adds a new class (TabData) to represent the data in both C++ and Java, which replaces the AccessoryItem/KeyboardAccessoryData.Item classes. - Replaces AccessoryItem with TabData in the back end and sends it to the Java frontend. - Converts from TabData to KeyboardAccessoryData.Item in the Java frontend, so we don't need to propagate these changes everywhere. A follow-up CL will completely replace KeyboardAccessoryData.Item with TabData and remove the conversion listed in the last step above. Please check the linked bug for the desired final state as well as the steps of this refactoring to be sent in follow-up CLs. Bug: 902425 Change-Id: I6c28a31c682176c2409d3e3df2f6604768aed16d Reviewed-on: https://chromium-review.googlesource.com/c/1320732 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#606992}
-
Mikel Astiz authored
Each flag maps to one feature toggle representing one (usually) or two (rarely) sync datatypes. If enabled, the sync datatype(s) are wrapped within the USS architecture, based on the so-called pseudo-USS approach (SyncableServiceBasedBridge). The functionality has been sanity-checked for crashes on dev&canary already, although some resulting UMA is suspicious. The flags should allow easier debugging and testing. Bug: 870624 Change-Id: Id5762c01f7232de8dda4e524083fae59f66217a2 Reviewed-on: https://chromium-review.googlesource.com/c/1329142 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#606991}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5d2dfa46c05c..50bf0429394d git log 5d2dfa46c05c..50bf0429394d --date=short --no-merges --format='%ad %ae %s' 2018-11-09 syoussefi@chromium.org Vulkan: add depth-only or stencil-only tests Created with: gclient setdep -r src/third_party/angle@50bf0429394d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Id57aa1fff67ad92703d95353f149e8be85379621 Reviewed-on: https://chromium-review.googlesource.com/c/1329991Reviewed-by:
-
kylechar authored
The overridden functions for GpuMemoryBufferFactory can be called on multiple threads with OOP-D. Add a lock to protect |buffer_map_| which is used in both CreateGpuMemoryBuffer() and DestroyGpuMemoryBuffer(). Bug: 902163 Change-Id: Ib80169103677f5bdaccc2d4803efa029f4910b03 Reviewed-on: https://chromium-review.googlesource.com/c/1329547 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606989}
-
Francois Doray authored
Previously, we read a variation param from the "BrowserScheduler" study to determine whether all tasks should have USER_BLOCKING priority. With this CL, we instead use a base::Feature. Benefits: - Study that controls the feature doesn't have to be "BrowserScheduler". - Enabling/disabling a feature is less verbose than setting a variation params with the new GCL config format. Bug: 902441 Change-Id: Ib38dcfdf097c1ca92784a22c3501b644b077f744 Reviewed-on: https://chromium-review.googlesource.com/c/1321032 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#606988}
-
Maks Orlovich authored
This time with a DumpWithoutCrashing Bug: 901405 Change-Id: Ie2a075afe384e3dc13fde076a558d5d90591ab92 Reviewed-on: https://chromium-review.googlesource.com/c/1330076Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#606987}
-
Scott Violet authored
I'm converting some tests, and would like to avoid having to update a bunch of places to use lower case strings. BUG=756085 TEST=none Change-Id: I4beba5088736a6f1c9dbf040741073ce19016097 Reviewed-on: https://chromium-review.googlesource.com/c/1329930Reviewed-by:
-
Roger Tawa authored
This is needed to make sure that credential provider pdbs make it to the chromium symbol server. Bug: 901825 Change-Id: I23e116d0c7405c827fc3ed5385013a9e776644d2 Reviewed-on: https://chromium-review.googlesource.com/c/1315533Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606985}
-
David Tseng authored
Bug: 898386 Change-Id: Id924396f5fa4cd88c5a8efa2b7ac593553237a64 Reviewed-on: https://chromium-review.googlesource.com/c/1327807 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#606984}
-
Justin Cohen authored
CIPD packages: infra_internal/ios/xcode/mac 10b61 infra_internal/ios/xcode/ios 10b61 Bug: 903674 Change-Id: Ifd61e84840a4ff9d36a215ad0c8d11efc51cbfd0 Reviewed-on: https://chromium-review.googlesource.com/c/1329022Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606983}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a5a398e8. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I664c9c1148f41ec79d7464441dce7b4029b3a220 Reviewed-on: https://chromium-review.googlesource.com/c/1329899 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606982}
-
danakj authored
This is a reland of 68d8dbc0 The flaky test this caused to fail is flaky before this CL. Investigation in https://bugs.chromium.org/p/chromium/issues/detail?id=903695. I will disable it if I can't resolve it. TBR= Original change's description: > Don't make a LayerTreeFrameSink for a non-visible RenderWidget. > > Importantly, non-visible RenderWidgets include swapped out RenderWidgets > which are zombies, without a frame, and which should not be used. > > This can happen if the RenderWidget swap out races with the posted task > from the compositor to make a LayerTreeFrameSink. When swapping out, the > compositor would be marked as not-visible, which would stop it from > making such requests, but one could already be in flight. > > In the other case, honoring the request for a non-visible compositor is > more benign, but we can delay it until the compositor is actually > visible again. This means if a context is lost, backgrounded tabs would > not all attempt to reconnect to the Gpu process at once. > > This is a better followup for the hacky > https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which > was meant only for merge to a release branch. It reverts that change as > part of this one. > > R=piman@chromium.org > > Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7 > Bug: 896836, 419087 > Reviewed-on: https://chromium-review.googlesource.com/c/1292714 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606655} Bug: 896836, 419087, 894899 Change-Id: Ic82c9c61d0e3154e20352470636e09b13248d775 Reviewed-on: https://chromium-review.googlesource.com/c/1329546Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#606981}
-
Stephane Zermatten authored
With this change, when TouchEventFilter restricts usage of the page to some specified element, it also highlights these elements by graying out the sections of the page that cannot be used. The color used for graying out is the same as the one used for the overlay. https://screenshot.googleplex.com/TX0MNV26coP.png If the user taps 3 times within a 15s window, the message "Continue Manually" appears in the snackbar, allowing 5s to decide to continue or let Autofill Assistant shuts itself down. https://screenshot.googleplex.com/zxYdR8i9JuO.png This patch also lengthen the duration of the snackbar shown when closing Autofill Assistant to 5s. And shortens the message shown after hitting the back button, for example, to "I cannot help anymore, please continue manually." Bug: 806868 Change-Id: I6a31b31e6f8810b30b64e6a4060ca2fab117f5d1 Reviewed-on: https://chromium-review.googlesource.com/c/1328988 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606980}
-
Raphael Kubo da Costa authored
This code was added in commit 061d113d ("[sensors](CrOS/Linux) Implement Sensor device manager for sensors") but was never used anywhere. Change-Id: I3a0a213c09461d416aa0fffe7bbed6346692e95f Reviewed-on: https://chromium-review.googlesource.com/c/1329922Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#606979}
-
Raphael Kubo da Costa authored
There is no reason to require SensorReader instances to be created in a thread/task that allows blocking: SensorReader already uses a ThreadChecker and all methods verify they are being called from the right thread (i.e. one that can block). The call to base::AssertBlockingAllowedDeprecated() has been there since the code was added in commit 061d113d ("[sensors](CrOS/Linux) Implement Sensor device manager for sensors"), but the existing unit tests behaved differently from the production code paths and not many people seem to have used a Linux or ChromeOS build with DCHECKs enabled on a machine with sensors. PlatformSensorAndProviderLinuxTest has been adjusted and now almost all code runs within a base::ScopedDisallowBlocking scope to better mimic production conditions. Care has been taken to avoid changing too much code: porting classes and tests to base::PostTask() and reducing the amount of task runners passed around will be done separately. Bug: 896382 Change-Id: I374acba4ec982cf5ae49eb44e410607e57ac85c0 Reviewed-on: https://chromium-review.googlesource.com/c/1329921Reviewed-by:
-
Tommy Martino authored
Change-Id: I5c4e2a34c2c39e06029d27bc1a0f27dab26c4382 Reviewed-on: https://chromium-review.googlesource.com/c/1329896Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#606977}
-
Balazs Engedy authored
Add a TRACE_EVENT to track how long it takes to initialize content_settings::PrefProvider, and record the number of exceptions parsed. Bug: 890129 Change-Id: Ic70783bc9c69f4ce0fdb84e5406701b59bbcbd10 Reviewed-on: https://chromium-review.googlesource.com/c/1326150Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606976}
-
danakj authored
During the navigation in the test, a renderer is loading a page and if it completes in time, sends a AddLinkRelPrerender IPC to the browser to start a link prerenderer. If this occurs before the navigation started by the test completes, then the test will fail with the wrong number of prerenderers. This seems to imply the test is exiting too quickly, and not observing the actual number of prerenderers that we create. TBR=droger@chromium.org NOTRY=true Change-Id: If74bf60f45b60f52041167532eca9915c6d604b3 Bug: 903695 Reviewed-on: https://chromium-review.googlesource.com/c/1330287Reviewed-by:
-
