- 27 Aug, 2018 40 commits
-
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d94a2077d68c..06b42949b620 git log d94a2077d68c..06b42949b620 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 31666470+s-perron@users.noreply.github.com Validate uses of OpTypeFunction. (#1867) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@06b42949b620 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idd0289bbb82e98dfc9200f9ebc89b4e43ec90c90 Reviewed-on: https://chromium-review.googlesource.com/1191142Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586367}
-
Rune Lillesveen authored
We no longer (re-)attach the layout tree from style recalc. Change-Id: Ia944649b6e12345c23ecbd7e6ea91d8d6aaba94c Reviewed-on: https://chromium-review.googlesource.com/1190205Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#586366}
-
Alex Moshchuk authored
Change-Id: I3f664cb970a58b34e91075cf29928390878e182d Reviewed-on: https://chromium-review.googlesource.com/1191146Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#586365}
-
Bo Liu authored
Bug: 855390 Change-Id: Icf7785b87dd04b9b2a9dd641fb7eaea6e401f611 Reviewed-on: https://chromium-review.googlesource.com/1189029Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#586364}
-
Nicolas Ouellet-payeur authored
'safe_browsing_g4_update': s/g4/v4/ Bug: 876856 Change-Id: Iefda4121e331a5005d9372e5bfcc493646e5e47d Reviewed-on: https://chromium-review.googlesource.com/1187322 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#586363}
-
Eric Orth authored
Convert the //net/dns:public source_set into :host_resolver and move all public headers to source. Access to these previously-public headers will now only be allowed for BUILD.gn rules listed in the friend list. Added friend entries with explanation comments for all remaining usage. Some with TODOs to remove, eg because they'll be migrated to network service. Confirmed that there are no other remaining usage in code where private headers are or are not enforced (checking unenforced by searching for "net/dns" in the error output). Removed a couple includes that were no longer needed. TBR=jochen@chromium.org Bug: 846454 Change-Id: I7bb633088689dc896f9fc27e1dec87ae699410db Reviewed-on: https://chromium-review.googlesource.com/1183981 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#586362}
-
Antonio Gomes authored
This is a follow up of CL https://crrev.com/c/1136518 where, CrDownloader/UrlFetcherDownloader migrated from URLFetcher to SimpleURLLoader. As part of the migration, it was verified that CrxDownloader::Result had struct members only used in unit tests: |downloaded_bytes| and |total_bytes|. Additionally, the CrxDownloader::ProgressCallback did not use its |result| parameter. This CL removes the struct members from CrxDownloader::Result as well as their use (mocked up anyways) in unittests, and removes the unused |result| parameter from CrxDownloader::ProgressCallback. BUG=844972, 871211 Change-Id: I5b36c63784ff2632f71c1e5a0cd44b6e0c7c7f37 Reviewed-on: https://chromium-review.googlesource.com/1190324 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#586361}
-
Victor Costan authored
AppCacheResponseIO is an abstract (with pure virtual methods) base class for classes that also use WeakPtrFactories. Some method in the base class currently use the WeakPtrFactory embedded in the base class to vend WeakPtrs, which will point to instances of the derived classes. These pointers will be invalidated when the base class' WeakPtrFactory is destroyed. So, there is a time window when the weak pointers are valid, but the members in derived classes are being destroyed. To avoid reasoning about such complexities, this CL removes the WeakPtrFactory in the base class. Instead, base class methods use a virtual method to get weak pointers from the derived classes' factories. Change-Id: I343a0e1159d839b0f71fb09518704ce560b2c5ad Reviewed-on: https://chromium-review.googlesource.com/1188825Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#586360}
-
Allen Bauer authored
The previous patch attempting to fix this, https://crrev.com/c/1188434, didn't blend in the right direction. It got the background color calculation correct, but the title color calculation wasn't right. This change just uses GetColorWithMinimumContrast directly so that the text (and the close button icon) has sufficient contrast on a selected inactive tab. Bug: 876794 Change-Id: I8ee0a8f2a38aac60c14d104fbf75c3ef85304720 Reviewed-on: https://chromium-review.googlesource.com/1191189Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#586359}
-
Etienne Bergeron authored
No code change. R=ssid@chromium.org Change-Id: I7eaef6cab924fb60dd7b242d333276dce83522aa Reviewed-on: https://chromium-review.googlesource.com/1191327Reviewed-by:
Siddhartha S <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#586358}
-
Weilun Shi authored
Change Font Family to Segoe UI for custom link when using Windows and make it bolder for fallback icon letter. Before: https://screenshot.googleplex.com/pRPVmEC3yc8.png After: https://screenshot.googleplex.com/m16uEv78QBp.png Bug: 867778 Change-Id: I1f16dbf044cad7504617868f131b7517985cd2c2 Reviewed-on: https://chromium-review.googlesource.com/1178469 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#586357}
-
Manu Cornet authored
This changes the color, alpha and size of indicators according to the spec (see linked bug for the spec). Bug: 877351 Change-Id: I6237ab1f0d4727907b344147a0cf816319192b26 Reviewed-on: https://chromium-review.googlesource.com/1189196 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#586356}
-
Eunseok Oh authored
This patch replaces the erase(std::remove()) used in the media folder with base::Erase(). Bug: 875665 Change-Id: Id832871a1fbfcb657e4160f57ff206f93950e7ab Reviewed-on: https://chromium-review.googlesource.com/1180953Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586355}
-
Scott Violet authored
Here's the list of changes: git mv services/ui/common services/ws (update build files, rename services/ui/common:mus_common to common) git mv services/ui/public/cpp services/ws/public git mv services/ui/gpu_host services/ws git mv services/ui/ime services/ws git mv services/ui/test_ws services/ws git mv services/ui/input_devices services/ws/ git mv services/ui/ws2/* services/ws BUG=876924 TEST=covered by tests TBR=jamescook@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_dbg_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia93dc557a45dc75bcf8a2b3bf80f2e393d4362ed Reviewed-on: https://chromium-review.googlesource.com/1188961 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
jonross authored
The last bots running surface_sync_content_browsertests were Android. However Surface Sync is now on by default on Android, so these tests are redundant. This removes the config from test_suites, and all Android bots. TEST=surface_sync_content_browsertests Bug: 849746 Change-Id: Ie9de3fabaaee8a694acb5ce48c8ff2a9c58e0e42 Reviewed-on: https://chromium-review.googlesource.com/1190125Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#586353}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b6bda5336f20..9b4fbc6e4341 git log b6bda5336f20..9b4fbc6e4341 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 jbudorick@chromium.org devil: add arm64 version of empty_system_webview. Created with: gclient setdep -r src/third_party/catapult@9b4fbc6e4341 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7349e57f96257fd64301982b964478b5914b1eac Reviewed-on: https://chromium-review.googlesource.com/1190903Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586352}
-
Xida Chen authored
Right now in TouchActionFilter, we set |gesture_sequence_in_progress_| false when processing GestureTap and GestureTapCancel. This is wrong with considering the following gesture sequence: 1. A simple tap: GestureTapDown-->GestureTapUnconfirmed-->GestureTap 2. Double tap: GestureTapDown-->GestureTapUnconfirmed-->GestureTapCancel -->GestureTapDown-->GestureTapCancel-->GestureDoubleTap 3. A gesture scroll: GestureTapDown-->GestureTapCancel -->GestureScrollBegin-->GestureScrollUpdate-->GestureScrollEnd 4. A fling: GestureTapDown-->GestureTapCancel-->GestureScrollBegin -->GestureScrollUpdate-->GestureScrollEnd All these sequence indicates that the gesture_sequence_in_progress_ should be true when filtering a GestureTapCancel and false when GestureTap. This CL does that. In additional to that, this CL also mark gesture_sequence_in_progress_ false when it is GestureLongTap or GestureTwoFingerTap. Unit tests are added for both cases. TBR=dtapuska@chromium.org Bug: 851644 Change-Id: I40e70cb95a93c20b13952c571d1e1108405c6051 Reviewed-on: https://chromium-review.googlesource.com/1190423 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#586351}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/441ef218c20b..d3220624aa66 git log 441ef218c20b..d3220624aa66 --date=short --no-merges --format='%ad %ae %s' 2018-08-27 thestig@chromium.org Add a "lastchange" hook. Created with: gclient setdep -r src/third_party/pdfium@d3220624aa66 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I31689f09585535157510c076eb194190ba6490ce Reviewed-on: https://chromium-review.googlesource.com/1191143Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586350}
-
Weidong Guo authored
Bug: 878000 Change-Id: I22ee53ca780fa1fa5c848f11352ab251306e0bab Reviewed-on: https://chromium-review.googlesource.com/1191090Reviewed-by:
-
Dave Tapuska authored
The spec pull request has been updated provided feedback from others: https://github.com/whatwg/fullscreen/pull/129#issuecomment-415873900 This change brings our implementation to match the current pull request. BUG=829937 Change-Id: I9374ddcb694e4322090da1cc8b4ce0c51628158a Reviewed-on: https://chromium-review.googlesource.com/1188885Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#586348}
-
Ben Pastene authored
crrev.com/c/1179227 didn't actually disable it. Looks like we messed up the conditional a little. Bug: 875104 Change-Id: Ide2caab7969f2aa33f6c16e7b73e2f389273f9fe Reviewed-on: https://chromium-review.googlesource.com/1189033Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#586347}
-
Daniel Rubery authored
LOG doesn't even evaluate the streamed arguments if the conditions for logging aren't met (verbosity, debug, etc.) Now CRSBLOG does the same, so that CRSBLOG << Function() is a noop if there are no listening chrome://safe-browsing tabs. Bug: 874693 Change-Id: I6e1316b280b87264e65cb789151cff8596eb380a Reviewed-on: https://chromium-review.googlesource.com/1187008 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Filip Gorski authored
* Updates referrer for content suggestions to https://feed.google.com * Makes the referrer configurable through Field Trials bound to the NTPArticleSuggestions experiment. Bug: 870750 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I87b0af69e05e9b1c38bf12caade61ebb80f6cee0 Reviewed-on: https://chromium-review.googlesource.com/1185857 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#586345}
-
Kai Ninomiya authored
This was introduced in my earlier patch https://chromium-review.googlesource.com/c/chromium/src/+/1147251 because I didn't realize it would affect regular GLES2 contexts. I backported this fix from my in-progress patch: https://chromium-review.googlesource.com/c/chromium/src/+/1186129 NOTRY=true Bug: 877952 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8930bcb7b4c739a49c533141f28aebd6a5181712 Reviewed-on: https://chromium-review.googlesource.com/1191124 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#586344}
-
Elly Fong-Jones authored
This change: 1) Renames MenuDelegate::GetLabelFontList to MenuDelegate::GetLabelStyle; 2) Removes MenuDelegate::GetShouldUseNormalForegroundColor() in favor of the MenuDelegate supplying its own foreground color; 3) Removes the "emphasized" notion from MenuItemView, since it was only used in one place (AppMenu) to achieve the behavior of having a disabled item paint as an enabled item; This leads into a cleanup of MenuItemView::GetTextColor() to use TypographyProvider to retrieve all colors. Bug: 865318 Change-Id: Ie6238cfd5c9baac7be595809560485c23b804a08 Reviewed-on: https://chromium-review.googlesource.com/1186702 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Soojung choi authored
This patch simplifies conditions around the code in ui/ozone Bug: 561800 Change-Id: I910244a9a50ff89b2979e9942e619752bbc319b1 Reviewed-on: https://chromium-review.googlesource.com/1183262Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#586342}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/01e8e625ad83cc9a07288bd4dc285bd8b0ccd550..7f4f41fa81c03e0f8ef1ab5b3d1d566b5968f107 BUG=none Change-Id: I1cd205bc69f4fcbb0f1dd86f17c62b3b34f3d279 Reviewed-on: https://chromium-review.googlesource.com/1190405 Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#586341}
-
Mohsen Izadi authored
These fields of CompositorFrameMetadata are not used on other platforms: - |top_controls_height|, - |top_controls_shown_ratio|, - |bottom_controls_height|, - |bottom_controls_shown_ratio|. BUG=859969 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibe602785bf2214bd371b3ed64964f112e3c7f149 Reviewed-on: https://chromium-review.googlesource.com/1184237Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#586340}
-
Andres Medina authored
Followed steps on README.chromium to update protobuf. Added BUILD.gn.template and gen_extra_chromium_files to automated generation of extra files and BUILD.gn file. removed unnecesary patches, updated patches and added new patch for a missing override Bug: 874265 Change-Id: Icfc221ef47dab7191403c73791509b79383ac6b7 Reviewed-on: https://chromium-review.googlesource.com/1081411 Commit-Queue: Andres Medina <medinaandres@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#586339}
-
Xida Chen authored
Right now there's crash at TouchActionFilter when filtering a gesture scroll update generated by fling controller. This CL adds debugging instrumentation to record the gesture sequence. TBR=dtapuska@chromium.org Bug: 851644 Change-Id: Ifb9b246eab063e1df9563501b7c31d69ae45c16d Reviewed-on: https://chromium-review.googlesource.com/1191024Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#586338}
-
Tibor Goldschwendt authored
This will be required to set a version code for the internal module targets. Bug: 877998 Change-Id: Ieb91e78d062a14af25ad8b8d2aac649bd5a05b67 Reviewed-on: https://chromium-review.googlesource.com/1191089Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#586337}
-
George Burgess IV authored
This fixes a bug in I8a928eaab93ec181ba057cdda4cb635389f30926, which breaks ThinLTO builds for CrOS with an unused variable. Bug: 807147 TBR=agreive@chromium.org, rnk@chromium.org Change-Id: I19b7cf81f035009d5390e9fc3f12f6e29413aa24 Reviewed-on: https://chromium-review.googlesource.com/1190904Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#586336}
-
Marijn Kruisselbrink authored
Implements method to create a FileWriter for a FileSystemFileHandle, as well as fixes a bug in the FileSystemWriter implementation. Bug: 872460, 872465 Change-Id: Idfd7d2b486a7f2e1b0ec3f996ba940e10236b764 Reviewed-on: https://chromium-review.googlesource.com/1185624Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#586335}
-
Jüri Valdmann authored
The file names read from /proc/self/maps can contain a special " (deleted)" suffix to indicate that the file has been deleted (unlinked). This is expected and should not trigger a LOG(WARNING). Change-Id: Ia96b3bf1894c8fbd6bfa0c217bc8a01bbb59d750 Reviewed-on: https://chromium-review.googlesource.com/1186622Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586334}
-
Victor Costan authored
The file name of the AppCache SQLite database is an implementation detail that is only relevant to the browser process. The renderer should not be able to access the database directly. The CL also clarifies the code declaring a few related AppCache constants. Most importantly, the AppCache code used to implement a content::kMB global variable, which is now in an anonymous namespace in the only file that needs it. Change-Id: I7c66543ded40c241622b0587e2abce1de15b18f5 Reviewed-on: https://chromium-review.googlesource.com/1189345 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Chris Harrelson authored
This was a mistake in commit 1fde0aa3. Bug: 873883 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia48ad8ddc5d63225ccca1a2b8d6f26920de605a5 Reviewed-on: https://chromium-review.googlesource.com/1190923Reviewed-by:
-
John Abd-El-Malek authored
This reverts commit 268fcfac. Broke http/tests/devtools/service-workers/service-workers-redundant.js http/tests/devtools/service-workers/service-workers-view.js with network service See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux/17958 You can reproduce this locally via --additional-driver-flag=--enable-features=NetworkService Original change's description: > DevTools: Show scriptResponseTime for ServiceWorker only if present > > As per the browser protocol, the field scriptResponseTime is > optional. Hence adding a check to see if it present before > displaying it. > > Bug: 767790 > Change-Id: I2638328aeec901419e48977ba40a15971da43f8b > Reviewed-on: https://chromium-review.googlesource.com/1180623 > Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586048} TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org,gautham.bangalore@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 767790 Change-Id: Idd1be72fe1bd5325263b8d46137edc07d70a4d22 Reviewed-on: https://chromium-review.googlesource.com/1191062Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#586331}
-
Jorge Lucangeli Obes authored
It's hard to be sure that the different permissions are correct without documentation of what the parameters mean. BUG=None TEST=Compiles. Change-Id: If11e34593c38ae66b65e8b9ede8fb3198a03967e Reviewed-on: https://chromium-review.googlesource.com/1186982Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#586330}
-
Theresa authored
This is no longer used and hasn't been for a while. If it's needed in the future, we can add it back. BUG=765306 Change-Id: I34992be49776f1f97de432bece0070c53ae9df9c Reviewed-on: https://chromium-review.googlesource.com/1184273Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#586329}
-
Victor Costan authored
Change-Id: Id9766b693c33aabadf9265722cf32605378c06a1 Reviewed-on: https://chromium-review.googlesource.com/1191023 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
