- 29 Jul, 2019 40 commits
-
-
Boris Yusupov authored
https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-getthreadpriority Change-Id: If2d50f6c0ee4e8da8bbf81cca8cfa37d2272d3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720641Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Boris Yusupov <boriay@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#681818}
-
Andrei Chulkov authored
This CL implements prompting the client to show the onboarding when a new credential is saved and the right kPasswordManagerOnboardingState is set. Bug: 983445 Change-Id: Idbbd00690ff12a6dd250fc782a0de13bd9b5abbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706507 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#681817}
-
Justin Cohen authored
Showcase's protocol_alerter.mm is conflicting with OCMock. Prefixing with crsc_ instead. Bug: 988423 Change-Id: I542b7df1374a285b3a8ecf293b682fa922d10fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724654 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#681816}
-
Dave Tapuska authored
https://chromium.googlesource.com/chromium/src/+/f898f31efa9b13b56985d60b30eddeb068598891 asserted that sandbox flags weren't changing. Doing a document.open across same origin iframes caused this CHECK to fire. BUG=987452 Change-Id: I81a255fd9b6de4af375abab523148349e3108ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720995Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#681815}
-
Xiyuan Xia authored
ash::KeyboardController is converted from mojo interface. As a mojo interface, it does not need RemoveObserver since closing underlying connection automatically stops observing. As C++ interface, we should have an explicit RemoveObserver to avoid having a dangling pointer in the observer list. Bug: 958203 Change-Id: Ia61a43ff2d6d95b7c3d5264c27632aae277b6a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721230Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#681814}
-
Justin Miron authored
This allows observers to access page load info from the metrics observer delegate directly, instead of being passed the PageLoadExtraInfo struct by the delegate. Previously the entire PageLoadExtraInfo struct was created and passed independent of the data needed by the observers. This also removes the duplication of delegate and PageLoadExtraInfo fields (navigation_start, did commit). Each API function returns the same data as used to populate the PageLoadExtraInfo struct. This API will be followed up with the following sets of CLs: 1. Replace common observer utility functions to use the delegate returned values instead of the PageLoadExtraInfo struct. 2. Group page_load_metrics_observer On* functions that use PageLoadExtraInfo structs and replace them with delegate returned values. This also adds first_background_time and first_foreground_time as members of the page_load_tracker, so as to not compute these with each call to their respective getter function. BUG=939403 Change-Id: I84af9f19fc2d14a727318ea2eb0668229f795cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713153 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#681813}
-
Haohao Wang authored
This CL adds the new UI to incorporate Google Translate branding into the new Button_GM2 and Tab translate bubble UI. Bug 987962 is filed to track this new feature request. Bug: 963148, 987962 Change-Id: Ia648f322cea5dae55bd9e21a537775bf74c772a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708843Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#681812}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/da370c8e520b..ecd71dad4bd5 git log da370c8e520b..ecd71dad4bd5 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 treehugger-gerrit@google.com Merge "protozero: Fix moving a protozero decoder" 2019-07-29 rsavitski@google.com Merge "tmux script: tee to log files; add -s (skip converters) -l (tmux layout) options" Created with: gclient setdep -r src/third_party/perfetto@ecd71dad4bd5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I5816df2f06854c1e1afa78ac4a22e86035592eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724112Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681811}
-
Kinuko Yasuda authored
Also remove some dead code in BrowserContext. Bug: 934009 Change-Id: I015a1b65086f28304a6f0b0ff36f4341b709b9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723930 Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#681810}
-
Javier Ernesto Flores Robles authored
This keeps the navigation controller and the presented view controller in sync with the same style. Bug: 985461 Change-Id: I49af9e8a7eacdcccbb4b67ca3e5925454081b58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722838 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#681809}
-
Matt Menke authored
Previously, HttpServerPropertiesManager would watch for any changes to prefs, and then it would update the prefs stored in HttpServerPropertiesImpl. Since it also sets preferences in response to changes in HttpServerPropertiesImpl's state, it also kept around a bool to avoid reentrancy. This seems like a fair bit more effort than necessary - nothing writes to the HttpServerPropertiesManager's prefs field except for HttpServerPropertiesManager itself. When running in the network service, there's even a dedicated pref file just for the network service, which almost nothing else uses. This CL simplifies HttpServerPropertiesManager to only read the preference once, when it starts, and only write prefs once the initial prefs have been loaded, on shutdown, after Clear(), and when the prefs have been modified. This CL is intended to simplify the state machine, to make it easier to invert the relationship between HttpServerPropertiesManager and HttpServerPropertiesImpl (see bug). Bug: 984996 Change-Id: I71c303bdac23424dc268d21b8be72f87043dad7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707401Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#681808}
-
Haohao Wang authored
doesn't trigger translate This CL address issue 983510. Currently under TAB UI, if the "Always translate {source language} option is de-selected and selected again, it doesn't trigger translation as it should. This CL fixes this issue. Bug:983510 Change-Id: I8ed90119a25f959ab52410cc2c7fbc930097f082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702766Reviewed-by: -
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ia4011889cd8075236bf80a4bda1e1f19c8c6b608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700853Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#681806}
-
arthursonzogni authored
Adding filter files to exclude the known broken tests from running by default. This will get the bot back to green, which is key for us understanding when outside changes result in breakage in BackForwardCache code. It also gives us a clear burndown list to work through and fix, which can be easily understood and measured. Bug: 511340 Change-Id: I8da2149acf09fbcb13384285150817ec4e1dae70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718029Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#681805}
-
David Jean authored
Change-Id: I93f84a3eac89cc584bdb6414522b0adc71f3d66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722846Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#681804}
-
Mugdha Lakhani authored
Fix TaskId translation logic for Background Sync one-off tasks. Bug: 988406 Change-Id: I91aa4d1fde9e6b372d99fba6644e6c3f1dd748ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722960Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#681803}
-
Juan Antonio Navarro Pérez authored
This reverts commit 21505f63. Reason for revert: Broke all webview perf bots Original change's description: > Reland "heap: Enable concurrent sweeping" > > This relands 51bb0bd3 as flaky failures in webgl tests were caused by > aecfa837. > > Bug: 967258 > Change-Id: Icf2e5d050e763e112471f5ac1897a3e24f6c9006 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713525 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679918} TBR=haraken@chromium.org,mlippautz@chromium.org,bikineev@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 967258 Change-Id: Iff6d2058bbe0370f4cd8cae676919572f946e47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724509Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#681802}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6d7e1dd2..bac9d6cd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie2db9b5b381db8e630355ae5cf62b844b8250ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723853Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681801}
-
Michelle Roxas authored
Bug:973603 R=caraitto@chromium.org, pauljensen@chromium.org Change-Id: Ia1d3309579ee45b222375b12cd655ee1d985a07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652540 Auto-Submit: Michelle Roxas <michelleroxas@google.com> Commit-Queue: Michelle Roxas <michelleroxas@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#681800}
-
Adam Raine authored
To use color values, the compositor must have a CrossThreadStyleValue specific to color values so it can use the proper functionality for color values. The new class CrossThreadColorValue was created for this purpose. CrossThreadColorValue is intiended to be used alongside CSSUnsupportedColorValue. Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1713747 Bug: 883721 Change-Id: If296bf492ceb20380f82bcc80225094cd3d72a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716962Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Adam Raine <asraine@google.com> Cr-Commit-Position: refs/heads/master@{#681799}
-
Mohamed Amir Yosef authored
This is a reland of 6811de35 It was reverted due to crbug.com/988010 The underlying issue was unrelated to that patch and has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1722841 No changes are introduced and hence TBR'ing original reviewers. Original change's description: > [PasswordManager] Stop Using Native Backends on Linux systems > > Recent migrations moved all users who have been using the keying to the > LoginDatabase. This CL forces all users to using LoginDatabase > instead of native backends on Linux. > > TBR=pcc@chromium.org > > Change-Id: Ibac11e68d8f354ecf7f3c9828d95777ea5b3df60 > Bug: 950269, 950267 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713560 > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Peter Collingbourne <pcc@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681042} TBR=cfroussios@chromium.org,vasilii@chromium.org,pcc@chromium.org Bug: 950269, 950267 Change-Id: I1f091e18f6e23da8a2c8588c9a00bdb08fbda2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722964Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#681798}
-
Kamila authored
Bug: 986737 Change-Id: I7a96cbc5668adfb8c9922e2adca03bc7cfa5ab7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719127 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681797}
-
Takuto Ikuta authored
Bug: 977804 Change-Id: Ib6d2a783bd053ef1554cb5a133b03d6fb894ace5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722272 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681796}
-
Leonard Grey authored
Modal sheets use "NSTitleWindowStyleMask" for Reasons (looks like mostly input handling). This means that when we ask for their content rect, they account for the title bar, though we don't actually display one! In practice this means: 1. We've been undersizing modals for a while. 2. If it so happens that if we roundtrip back through NativeWidgetNSWindowBridge::SetBounds (motivating example: when the window is moved to a screen with different DPI), we lose *another* title bar's worth of height. This change modifies the style mask so that the title bar isn't accounted for when calculating the content rect. Bug: 982477 Change-Id: I79da0297a1d79eaae3f7eaef85a5986c12b74436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721269 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#681795}
-
Edvard Thörnros authored
The (somewhat flakey) correct-events-for-short-animations-with-syncbases.html has been reworked and made more stable. This might affect it's coverage but it was too flakey to work reliably. rapid-syncbases.html has been created to hopefully catch what correct-events-for-short-animations-with-syncbases.html used to catch. Together these tests should have some redundancy which will improve the test stability and hopefully make them less flakey. Bug: 981522 Change-Id: I217903f66dc5a1a1739a258b32da39338a44bb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722966 Commit-Queue: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#681794}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d188f3a9613d..33f77d35ca2c git log d188f3a9613d..33f77d35ca2c --date=short --no-merges --format='%ad %ae %s' 2019-07-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@33f77d35ca2c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I06a360cd7cfc82bbd0f676ec4699bfec04d749ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722203Reviewed-by:
-
Lutz Justen authored
Disables the flaky test virtual/cors-rfc1918/http/tests/security/cors-rfc1918/ addressspace-serviceworker-basic.html on Linux. TBR=nhiroki@chromium.org BUG=chromium:988074 TEST=Made sure failure is OK. Failure shows up as "The test ran as expected (0 passed, 1 didn't)." Change-Id: I5a49ca60b7ab3bc1b15f96ffad456be65c9e35a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722543 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#681792}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ed0febf57383..630443aba2b4 git log ed0febf57383..630443aba2b4 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 sprang@webrtc.org Remove usage of RTPSender::SetSsrc() in unit tests Created with: gclient setdep -r src/third_party/webrtc@630443aba2b4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ia1a75afedb1cb3f12826284a50fe748fa264373f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723643Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a0ddf25cee99..da370c8e520b git log a0ddf25cee99..da370c8e520b --date=short --no-merges --format='%ad %ae %s' 2019-07-29 taylori@google.com Merge "perfetto-ui: Track data request changes" 2019-07-29 treehugger-gerrit@google.com Merge "Fix a few typos" Created with: gclient setdep -r src/third_party/perfetto@da370c8e520b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ia1fde5f31130c3e69d1a803fcf698dd91fd731a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722202Reviewed-by:
-
Matthew Cary authored
Change use of the legacy base::SharedMemory to base::UnsafeSharedMemoryRegion. No functional change. Bug: 849207 Change-Id: I488e1ca93ea6dd28c70633a3271a8bb46a2ec447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722540 Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org> Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#681789}
-
Ben Kirchman authored
Context: https://chromium-review.googlesource.com/c/chromium/src/+/1715173/10 Bug: 669707 Change-Id: I5445852775cc7e15fe01e70f16c58110e6e4a9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721466Reviewed-by:
-
Omer Katz authored
Replace ObjectResurrectionForbiddenScope with NoAllocationScope Bug: 981414 Change-Id: Iced48387c20c431ee0918f4c239f6ef0b8de82a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702368 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Sam Maier authored
Change-Id: I984ce23ea9494151e309aa69d7e0a9c27111a4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721021Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#681786}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/df746d0e6fd4..c5656169e42b git log df746d0e6fd4..c5656169e42b --date=short --no-merges --format='%ad %ae %s' 2019-07-29 tmrts@chromium.org Add optional target selection for resolving fixed revisions Created with: gclient setdep -r src/third_party/depot_tools@c5656169e42b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:950731,chromium:982711 Change-Id: I0a14c8b3fa17d63b292174e8ecc5feba1f0179cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723015Reviewed-by:
-
Nico Weber authored
We're on a very different toolchain nowadays; maybe this works now. Bug: 485542 Change-Id: I5adfd8758853f18c1825d80e2b183ac1da1136f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721079 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#681784}
-
Armando Miraglia authored
crrev.com/c/1708136 fixed a bug so that when a device is unplugged and it was either a 'default' or a 'communications' device, or both, an onended event is triggered. This is a follow-up CL to add tests for it. BUG=970153 Change-Id: Id7bbe6428ae4ac735fe9ac0762a12d41c1b87240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722834 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#681783}
-
Tanmoy Mollik authored
Remove AccountAdder.addAccount usage and replace it with calls to SignUtils.openSettingsForAllAccounts. Bug: 842860 Change-Id: I9187b916f7a8805dcdd7c39d9fca2580bd7eac62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712676Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#681782}
-
Mohamed Amir Yosef authored
In PasswordStoreX migration_step_pref_ gets destroyed on the UI thread in PasswordStoreX::ShutdownOnUIThread() but there could be already a task posted in PasswordStoreX::UpdateMigrationToLoginDBStep() that would actually consume the destroyed pref. We should invalidate the weak pointer when destroying the migration_step_pref_ to make sure any posted tasks are preempted! Change-Id: I7af97af346c61d352e8a294ce4998e641c8f08f6 Bug: 988417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722841 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1587f23b8531..3fea07b44639 Created with: gclient setdep -r src-internal@3fea07b44639 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4d437e0c8819dbb86f806aab652a1c70ad409eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723839Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681780}
-
Mohamed Abdelhalim authored
This includes removing |pending_nav_entry_id_| from NavigationHandleImpl since it is always equal to the |nav_entry_id_| in NavigationRequest, and neither of them is modified after the creation of the handle. Removing the logic for initializing |reload_type_| and |restore_type_| in NavigationHandleImpl. This does not change the current behavior, since if the |pending_nav_entry_id_| was not 0, this means the |nav_entry_id_| is not 0, and we can simply initialize both |reload_type_| and |restore_type_| in NavigationRequest. Bug: 916537 Change-Id: Ia51aa8d64021e37d81ea20f6328b21315af6be9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715081 Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#681779}
-
