You need to sign in or sign up before continuing.
- 30 Sep, 2020 40 commits
-
-
Guillaume Jenkins authored
Add a simple unit test case for BrowserReportGeneratorIOS class. The test generates a basic report and checks that the values in the proto make sense. Bug: 1114853 Change-Id: I18dc1114c5785a4063483614b308b1f327ce1bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439785 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812363}
-
Jordan Oroshiba authored
Instead of opening the full site settings, change the individual setting in a dialog directly and provide the option for removal of the override. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1130668#c1 Bug: 1130668 Change-Id: Ib1a0da6f637288b6a62a6b898de34fe4f647d7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422499 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#812362}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsInternetDetailPage* Change-Id: I4a713bea34443f9a834b79a769b09f67adf0495f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436783 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812361}
-
Christian Dullweber authored
Copy message about https image compression from old UI to the new UI. We need to improve the design later on. Screenshot: https://crbug.com/1077766#c64 Bug: 1077766, 1101489 Change-Id: I8f68ab51388b1604372dea3815d4d999393d75fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440619 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#812360}
-
Stephen Roe authored
as the bugs motivating disabling the tests are fixed. The net_unittests suite is running successfully on other fuchsia FYI and CI builders. Bug: 780652, 877248, 844416 Change-Id: Id7b46e9a450aa937b09309dff972871f359dfb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436700 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#812359}
-
Yao Xiao authored
Also removes the base::Feature kInterestCohortAPI, as there's no plan for finch. Bug: 1062736 Change-Id: I19d847b92ed57ae88a4fc99bc56039c7f4feaa9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434091 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#812358}
-
Titouan Rigoudy authored
These will be used to determine the path forward to an eventual removal of the feature in the NonSecure case, and a rollout of CORS-RFC1918 in the Secure case. These features are not yet recorded, but we know that the event rate will not exceed 1% of page loads. Indeed these features are finer-grained replacements for the now-obsolete LoopbackEmbeddedIn{Non,}SecureContext feature, which average less than 0.003% combined on Windows Stable. Bug: chromium:1124358 Change-Id: Ie53327654907d4b3ee8d88b91cceb957a8640602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436823Reviewed-by:John Delaney <johnidel@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812357}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601451302-0fcd721072a85aa7cd1d6b997a82e6798fe72a84.profdata to chrome-linux-master-1601488745-3c2b7a3f9b9c6b0806062ba2172ccc5544f62b8d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ide1ec116afe1df0f69a5d5fe1488118f45afac48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441176Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812356}
-
Taylor Bergquist authored
BrowserView::IsVisible returns false if the tabstrip is *currently* not visible, but HasVisibleBackgroundTabShapes is really just doing a sanity check that there even is a tabstrip, and doesn't actually care whether the strip is currently visible or not. I audited the other callers to IsTabStripSupported (all to do with immersive mode) and believe they are fine with this change. Also got a little bonus improvement to loading animations! They were previously shown for normal browsers to get around IsTabStripVisible returning false during fullscreen; they now use CanSupportTabStrip. Change-Id: I7823add41f9aa942056acd8b71e98c8f9d7680e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436522 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#812355}
-
Dave Tapuska authored
window.open on webviews had their widgets left in half creation state which is unexpected. The Init call is supposed to be called after the Window/Widget is shown. This was not called due to the ShouldResumeRequestsForCreatedWindow callback. The ShouldResumeRequestsForCreatedWindow() is added because we want to wait until the load is complete on the embedder page so it has a chance to execute before the guest contents. Since the RenderWidgetHostImpl::Init was never called it caused an issue when input handler binding was moved to be performed during the Init call. BUG=1132643 Change-Id: If8967d21bdbeb5dd9114eb918af793f88c4fe330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438477 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#812354}
-
Muyao Xu authored
Users can start a cast session from the GMC dialog by clicking on the cast sinks in the device selector list. After a new session is started, the local media notification will be hidden, and the cast media notification will show up in the dialog. Bug: b/161610050, 1107162 Change-Id: Ia3ad0634f0a45159ed92581ca2c6f097566c1a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422737Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/master@{#812353}
-
Gauthier Ambard authored
Bug: none Change-Id: Ic88c004d28ac7f6eabf2a134b483a33fd3f7a392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438051 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812352}
-
Xing Liu authored
Move ReadingListManagerImpl to its own header, there is no logic change. TBR=wylieb@chromium.org,dtrainor@chromium.org Bug: 1128074 Change-Id: I2e4f3c951e58dc1df0550b9725e8b8b830ee8b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441200Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812351}
-
Jun Mukai authored
Bug: 1109851, 1037570 Change-Id: I4ed6ef065c4b731993dc9885935029510d9918ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436703Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Illia Klimov authored
This patch verifies if an origin is on CrowdDenyPreloadData or CrowdDenySafeBrowsing blocking list. If yes, the notifications permission will be revoked. Bug: 1106283 Change-Id: I73e9434d74f67281a99246fee8515a7ca604efa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301969Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Auto-Submit: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#812349}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e816b5197f5e..3773c401fe1a 2020-09-30 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I16cebc4cafd7270d29f662afe30a1c0cc876ef99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441172Reviewed-by:
-
Sergey Ulanov authored
Previously cast_runner_integration_tests were creating CastRunner instance in-process instead of launching it in a separate component. As result the tests were not executing all parts of CastRunner. Particularly code in main.cc was not tested. Updated the tests to start cast_runner component in a separate process. Also updated cast_runner to allow enabling headless mode with the --headless argument. Bug: 1062351 Change-Id: Id5ea70616e069aa8416855eab613ab791283668b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113513 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812347}
-
Lei Zhang authored
- Sidenav toggle button - Sidenav thumbnails/outline buttons - Display annotations toggle Bug: 1130089 Change-Id: Ic41062ae48936efc94a3614540143ce969e14c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439643 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#812346}
-
Klaus Weidner authored
The Blink WebXR code has two parallel classes. XRViewData corresponds to the internal "view" from the spec, and XRView is what is exposed to JS. XRViewData has session lifetime, while XRView is ephemeral and created per frame. This change adds a reference from the XRView to the underlying XRViewData object, as expected by the spec's algorithms. This requires making XRViewData and their containing list garbage-collected objects. Bug: 1133381 Change-Id: I696a1a899ab8fdf27a2107bbadeb61773c4ade84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438690Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#812345}
-
Mohamed Adel authored
This CL introduces unittests that test both methods CreateMacNotificationTitle and CreateMacNotificationContext. Bug: None Change-Id: I18da2fee72cf5ae2aa100617fea7e2afcb97b668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438426Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#812344}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009300800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/T6gPp8Ky1tPZf16RQSiLa1YTO1Q2iv-5oa8YHP4nq8YC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/166047521 Tbr: help-app@grotations.appspotmail.com Change-Id: If5dced1f26b6bb024c506951c73fdf892198478a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440470Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812343}
-
Melissa Zhang authored
This CL adds a callback when the sharesheet closes. Bug:1126788 Change-Id: Ibc5e0a0d3d0f431139af5d0d783ad398646713f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434078 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#812342}
-
Jun Mukai authored
Bug: 1089768, 1089767, 1089854, 1089855 Change-Id: I8d927ca35e82a004c8900930b09c1a9ce250b137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439418Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
mark a. foltz authored
This was to record YouTube-specific use of remote playback, which is no longer supported. Bug: 1088674,1090963 Change-Id: Ib51ce33d59abb26ad29da01d887d923495c9faa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436554Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812340}
-
Elly Fong-Jones authored
There's no particular reason for it to be on DialogDelegate since it applies to all WidgetDelegates. Bug: 1075649 Change-Id: I48da9f88b2c7b9bcc4171091eaa519ff0997bd4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440285Reviewed-by:
-
Andre Le authored
This is a reland CL for crrev/c/2419552, which ran into a compilation failure and merge conflict when reland. In this CL: - Create a base class for quick actions controller. - Create silence phone controller that connect to the DND controller in PhoneHubManager. Display the icons according to the states. - Hook up the quick actions UI in the bubble to silence phone controller. Enable hotspot and locate phone implementation will be added in the next CL. BUG=1106937,1126208 Change-Id: Ie8540bdc29de8b73297dcf5c3f0a0d963f76d63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438590 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
-
Tomasz Wiszkowski authored
This change introduces an abstract CarouselSuggestion item that features title and configurable RecyclerView component. The content of the RecyclerView component (items) can be easily configured to display any type of elements. Change-Id: Ibdf9505c919c1f47a9cd1af14d538ff2bcbeacb3 Doc: http://doc/1IFsDKYhy_ARMOdT8jd1pMtk497xe03lb3hVnsaY-dOM Slides: http://slides/1c1SzJLzEsTjLmqIVLTomC8l9EgslBgYaBN6I7t8mbDI#slide=id.g8b3736bab3_0_0 Figma: https://www.figma.com/file/h8qjD0s9tezRzHdCMxIhYJ/On-Focus-Suggestions?node-id=290%3A309 Bug: 1106109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427724 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#812337}
-
Xiaohui Chen authored
When running ash_unittests on CloudTop instance, many tests would fail with "Maximum number of clients reached" X11 error. This does not repro on physical gLinux workstation though. Adding explicitly -maxclients parameter to make it consistent across platforms. Bug: None Test: Run testing/xvfb.py out/Release/ash_unittests Change-Id: Iac41378470d87df4b5d8140b3ee03a9a93a8c5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438577Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812336}
-
Lei Zhang authored
With the SaveEditedPDFForm feature, users have several new choices for how to save PDFS. Extend the existing PDF.Actions histogram with new ChromePDFViewerActions to cover these scenarios. This will help developers understand how often these new features are being used. Bug: 1130079 Change-Id: Ifb090f74b4f369d5e7c229bdaaf69138f430dc17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439553Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
-
Brandon Wylie authored
This reverts commit fd165f29. Reason for revert: Failing build on ToT: new ChromeActivityTestRule<>(ChromeActivity.class); ^ reason: cannot infer type-variable(s) T Original change's description: > Migrate remaining usages of ChromeActivityTestRule > > Bug: 989569 > Change-Id: If9f2bf207142253262bca092ca7dad6975893322 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437026 > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811949} TBR=mthiesse@chromium.org,agrieve@chromium.org Change-Id: I5970dcbad4685e2ae423b0bf5bdcd8beb7b00396 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441672Reviewed-by:
-
Ahmed Fakhry authored
This reverts commit 99860347. Reason for revert: Causes SubresourceExternalFileURLLoaderFactoryTest.SubresourceNotAllowed to fail on linux-chromeos-rel BUG=1133842 Original change's description: > Make ExternalFileURLLoaderFactory always owned by its |receivers_|. > > This CL introduces ExternalFileURLLoaderFactory::Create static method > that allows creating a ExternalFileURLLoaderFactory that is owned by its > |receivers_| and will self-delete when the last receiver disconnects. > > This CL removes the ability to directly construct and own a > std::unique_ptr<ExternalFileURLLoaderFactory>, because this ability > means that the factory can be destructed while receivers bound via the > Clone method are still alive (see the associated bug). In particular, > this CL stops exposing ExternalFileURLLoaderFactory constructor as a > public member, which forces construction to go via the new Create static > method. > > This CL mostly just follows the pattern established earlier by > https://crrev.com/c/2337411. > > Bug: 1106995 > Change-Id: I4bd235cf9132668d80657aece34de6fe7b60f78b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357620 > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812139} TBR=sammc@chromium.org,lukasza@chromium.org Change-Id: I46984baa4f64848eb15a0a5db2a7883bd6077520 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441048Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#812333}
-
Xinghui Lu authored
For the motivation, see the document linked in https://crbug.com/1103015#c15. before: http://screen/By7yYtW4AUgLf5v after enterprise: http://screen/6JGbKuWZvsbmTNK after extension: http://screen/8KwaPD3geRVmDmN Bug: 1103015 Change-Id: I144468a0499493a7a7ca1d7fa622a49afc41cc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439560 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#812332}
-
Akihiro Ota authored
This change adds tests for: 1. The 'Main menu' button; ensure that clicking this button takes the user to the main menu. 2. The 'All lessons' button; ensure that clicking this button takes the user to a screen displaying all lessons for the chosen curriculum. 3. The 'Next lesson' and 'Previous lesson' buttons; ensure that clicking these buttons moves the user between lessons. Fixed: 1127049 AX-Relnotes: N/A Change-Id: I0223769bf3ac79071918bcd764b0d2069556f446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439480Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#812331}
-
Ken Rockot authored
This reverts commit 18096716. Reason for revert: collides with https://chromium-review.googlesource.com/c/chromium/src/+/2401506 for compile failure Original change's description: > Delete service_manager/embedder/switches.h > > Each switch is either deleted because it's no longer used, or migrated > to a more appropriate layer (generally Content). > > Bug: 977637 > Change-Id: I9c4a74d4d99f4f7e7df8319d95b4ac4f55f11165 > Tbr: caseq@chromium.org > Tbr: dschuff@chromium.org > Tbr: finnur@chromium.org > Tbr: halliwell@chromium.org > Tbr: wez@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440908 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812318} TBR=avi@chromium.org,rockot@google.com,rsesek@chromium.org Change-Id: I6edf5e5305491092e3d9ad52d252a7eafc518a0b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440973Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#812330}
-
Antonio Gomes authored
This is a reland of e511a14a Change from the original CL: - `BLINK_MODULES_EXPORT` added to the FuchsiaAudioDeviceFactory class declaration (fixes the linking problem locally for component builds). TBR=haraken@chromium.org Original change's description: > Onion soup FuchsiaAudioDeviceFactory > > This CL executes phases 5 on the design document [1]. > > [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/ > > It also adds triggers the generation of blink bindings by > //media//fuchsia/mojom. > > BUG=787252 > R=guidou@chromium.org, haraken@chromium.org > > Change-Id: Ic2a1ffaea1f9647d9c2c18d298fc23c58d5cc5bb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436749 > Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812057} Bug: 787252 Change-Id: If5d205e84c2a27842303566e03c568fb8e6c87c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441148Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#812329}
-
Zentaro Kavanagh authored
- Tests method calls after resetting the FakeSystemDataProvider Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I83e6b90a47dec6ac2e1c885dfb17a2642e91b7bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441012Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#812328}
-
Yuwei Huang authored
Per discussion with Chrome network folks, network stack we are using appears to have an issue with proxy resolution such that it always fails no matter whether the host is using a proxy, and it blocks each HTTP request for 10-30 seconds, which is unreliable and sometimes triggers timeout error on the caller. This CL disables proxy resolution on Windows 7 hosts as a workaround, given we have never officially supported or tested proxied connections, and it will likely fail in later P2P connection stage. Bug: 1132978 Change-Id: I9096557105c566075bd2991007fe7d984476bf27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436670 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#812327}
-
Christian Biesinger authored
These have the same issue that I fixed in https://crrev.com/c/2429543, but I didn't realize that when I made that CL. The -014 test is still failing. I will fix that separately. R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1045668 Change-Id: Ic13c0e44edf7b962b2e28a8d3e6910e8bd841a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441009 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#812326}
-
Aaron Leventhal authored
Layout is always clean here. Bug: None Change-Id: I5e45083d0be1ac99bd25bbc183dbeb6126c83db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438689 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812325}
-
Ian Struiksma authored
Match proper mb configs for win10 1909 fyi and trybot Bug: 1132195 Change-Id: Ie40149eb07bd1298cebd83bbbc31dcc4e916714a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433999Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
-
