GitLab

Review URL: https://codereview.chromium.org/271623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270060 0039d316-1c4b-4281-b951-d872f2087c98

Previously the test system cannot obtain the name of test cases because they are
anonymous inline functions. And it causes a log like "[SUCCESS] undefined".

BUG=372683
TEST=run the tests

Review URL: https://codereview.chromium.org/288513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270058 0039d316-1c4b-4281-b951-d872f2087c98

Blink GC plugin: require that trace call base::trace and traceAfterDispatch call base::traceAfterDispatch.

BUG=334149
R=wibling@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/278523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369496

Review URL: https://codereview.chromium.org/261883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270056 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363836
NOTRY=true
TBR=ygorshenin@chromium.org, antrim@chromium.org

Review URL: https://codereview.chromium.org/273643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370692

Review URL: https://codereview.chromium.org/287613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347425

Review URL: https://codereview.chromium.org/268413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270052 0039d316-1c4b-4281-b951-d872f2087c98

Before, the Function objects (roughly corresponding to the commands
being generated) would construct itself based on the function info
object, parsed properties and many argument lists. The argument lists
themselves were also constructed out of function info object and the
parsed properties.

Try to clarify this by following changes.

Define that function info object is first parsed from the
cmd_buffer_functions.txt file.

Then the function info is possibly augmented by the optional object
for the function info object table (_FUNCTION_INFO).

Function objects are created solely on the function info
object. Function constructor parses the function info object and
constructs the needed properties, such as function type handlers,
argument arrays and return value types.

Function provides simple initialization function that the immediate and
bucket subclasses can use to construct specialized versions of the
command buffer command argument lists.

Review URL: https://codereview.chromium.org/276873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270051 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369895

Review URL: https://codereview.chromium.org/274243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270050 0039d316-1c4b-4281-b951-d872f2087c98

Will create a PrerenderCookieStore for each prerender, retaining all cookie
operations of a prerender until the prerender is shown to the user.
Forces prerenders to be in a new render process by themselves for this to work.
This is a resubmission of https://codereview.chromium.org/233353003, which had
to be reverted due to build breaks. See LGTM's there.
BUG=371003
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/280403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270049 0039d316-1c4b-4281-b951-d872f2087c98

This change so that WebRtcVideoCapturerAdapter receives video frames on libjingle worker thread instead of the IO-thread.

BUG= 371711, 350111

Review URL: https://codereview.chromium.org/282523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270048 0039d316-1c4b-4281-b951-d872f2087c98

The DevToolsManagerDelegate will be used to open DevToolsWindow from ServiceWorkerInternalsUI(chrome://serviceworker-internals/). 

BUG=358657

Review URL: https://codereview.chromium.org/251653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270047 0039d316-1c4b-4281-b951-d872f2087c98

Fix a flaky EndToEndTest where packet loss is possible with a large
buffer that may overrun.

Merge internal change: 66821654
https://codereview.chromium.org/280383003/


QUIC change to invoke SetNotPending for retransmissions in
MarkForRetransmission and a minor cleanup in UnackedPacketMap.

Merge internal change: 66729074
https://codereview.chromium.org/278823005/


Remove unused IsHandshake argument to QuicConnection::OnCanWrite.

Merge internal change: 66652078
https://codereview.chromium.org/286563003/


Revert of Fix a bug where if a crypto packet is spuriously retransmitted
and thenneutered, it remains in missing_packets until the end of the
connection.

Reverted chromium cl: https://codereview.chromium.org/270213002/

Rollback of Merge internal change: 66262890.

*** Reason for rollback ***

 This appears to have caused a major QUIC loadtest regression on
 internal server.

Additionally, it's wrong in some other subtle ways, so rolling it back
and trying a new approach.

*** Original change description ***

 Fix a bug where if a crypto packet is spuriously retransmitted and then
 neutered, it remains in missing_packets until the end of the
 connection.

***

Merge internal change: 66615668
https://codereview.chromium.org/287583002/


Revert of Minor QUIC cleanup to combine QuicUnackedPacketMap's
RemovePacket and NeuterPacket into RemoveOrNeuterPacket.

Rollback of merge internal change: 66306887
Rollback of Chromium's CL https://codereview.chromium.org/271443008/

*** Reason for rollback ***

 After further issues with the QUIC handshake packets, rolling back this
 change in favor of a different approach.

*** Original change description ***

 Minor QUIC cleanup to combine QuicUnackedPacketMap's RemovePacket and
 NeuterPacket into RemoveOrNeuterPacket.

 This prevents potential bugs where a packet can be set not pending, then
 neuter'd, which cuases the packet to never be removed from the unacked
 packet map.

***

Merge internal change: 66573334
https://codereview.chromium.org/280753002/


Merging end_to_end_test.cc with the internal source tree.

+ Fixed comments (MB for megabytes and 256KB per sec instead of 1Mbit).
+ Made LargePostWithPacketLossAndBlockedSocket and
  LargePostNoPacketLossWithDelayAndReordering to be in the same
  order as the internal source tree.

Merge internal change: 66556306
https://codereview.chromium.org/283683002/


Allows QUIC connections to remain established even though the peer's
port has changed. Should make things a bit better for clients
experiencing NAT rebindign while talking QUIC to Bandaid.

QUIC connection port migration. Protected behind
FLAGS_quic_allow_port_migration

Merge internal change: 66523001
https://codereview.chromium.org/279453004/


Remove unnecessary methods from QuicUnackedPacketMap and a minor
QuicSentPacketManagerTest fix as a result.

Merge internal change: 66427453
https://codereview.chromium.org/287443003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/283693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270046 0039d316-1c4b-4281-b951-d872f2087c98

If the alwaysOnTop property is enabled, but the app.window.alwaysOnTop
permission is not specified in the manifest, app window creation will
now fail with an error.

BUG=371213
TEST=browser_tests 
(PlatformAppBrowserTest.WindowsApiAlwaysOnTopNoPermissions)

Review URL: https://codereview.chromium.org/274123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270045 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270044 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173886:173932&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/270583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270043 0039d316-1c4b-4281-b951-d872f2087c98

There was a small regression in http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64929
in the range r270006-r270012 which seems to be normal growth. This updates expectations as per
http://www.chromium.org/developers/tree-sheriffs/perf-sheriffs?pli=1#TOC-Updating-Performance-Expectations

This is a followup to http://src.chromium.org/viewvc/chrome?revision=270015&view=revision which fixed linux-64

BUG=none
TBR=bokan@chromium.org,qyearsley@chromium.org

Review URL: https://codereview.chromium.org/282803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270042 0039d316-1c4b-4281-b951-d872f2087c98

Previously it has shown vendor-name + volume-name + device-id where
the last part does not mean anything for the end users.

BUG=370692

Review URL: https://codereview.chromium.org/289443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270041 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds support to opening a file. It is currently no-op, and it is
not yet bound to fileapi.

In order to bound it to fileapi::AsyncFileUtil, we need to implement closing
operation, and reading operations first. Otherwise, creating a snapshot
(required by fileapi::AsyncFileUtil) is not possible.

TEST=unit_tests: *FileSystemProvider*OpenFile*
BUG=248427

Review URL: https://codereview.chromium.org/284443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270040 0039d316-1c4b-4281-b951-d872f2087c98

The perfect hash table containing all registry controlled domains is
replaced by a compact graph (a dafsa) to reduce binary size and PSS
of the running process. Size of the new structure is about 33kB
compared to 380kB for the perfect hash table.

Patch by Olle Liljenzin <ollel@opera.com>, originally at
https://codereview.chromium.org/197183002/

BUG=370672
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/270363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270039 0039d316-1c4b-4281-b951-d872f2087c98

This may have caused indexed_db layout tests to start failing.

> Add most of the metadata-handling code for blobs.  It's not quite all there, but
> this is the biggest chunk I can pull out vaguely cleanly.  It does contain a
> couple of fake calls to keep the compiler happy.
> This CL also makes SetUpMetadata a member in order to ease testing in a later CL.
> 
> This depends on https://codereview.chromium.org/261843004/.
> 
> BUG=108012
> 
> Review URL: https://codereview.chromium.org/266333002

TBR=ericu@chromium.org

Review URL: https://codereview.chromium.org/281623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270038 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Rename AudioRenderer::Play/Pause() to Start/StopRendering(). (https://codereview.chromium.org/277123002/)

Reason for revert:
This seems to have broken NewFrameProcessor/PipelineIntegrationTest.ChunkDemuxerAbortRead_AudioOnly/0 Linux Tests (dbg)(2) and Win7 Tests (dbg)(1).
Will provide links and stdio on the new CL. This is speculative, if the issue won't go away, the revert will be reverted.

Original issue's description:
> Rename AudioRenderer::Play/Pause() to Start/StopRendering().
> 
> This makes a clearer separation between methods for controlling the
> actual rendering of audio versus methods for controlling the state of the
> renderer (i.e,. flushing and seeking).
> 
> Consequently, clean up AudioRendererImpl to reflect the separation
> between rendering methods and state change methods.
> 
> BUG=370634
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270017

TBR=dalecurtis@chromium.org,xhwang@google.com,scherkus@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370634

Review URL: https://codereview.chromium.org/274443006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372634
TESTS=unittests and manual

Review URL: https://codereview.chromium.org/276093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270036 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371184

Review URL: https://codereview.chromium.org/273283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270035 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes the webrtc video quality test page generic so that the
same page can be used for more than one tests. The paramters are now extracted from the video stream itself.

BUG=286290
TEST=out/Release/browser_tests --gtest_filter=WebRtcVideoQualityBrowserTest* --run-manual --ui-test-action-max-timeout=150000

Review URL: https://codereview.chromium.org/254803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270034 0039d316-1c4b-4281-b951-d872f2087c98

When using the quit/sign out shortcut (ctrl-shift-q) on chrome-os display the string "... to sign out" instead of "... to quit"

BUG=365166

Review URL: https://codereview.chromium.org/275243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270032 0039d316-1c4b-4281-b951-d872f2087c98

Mageia uses urpmi, but the autodetection code currently selects yum. Fix that.

Review URL: https://codereview.chromium.org/264913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370658

Review URL: https://codereview.chromium.org/266363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270030 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds an Extensions.LoadCreationFlags UMA histogram which logs an
aggregate of a user's extension's flags.

BUG=None

Review URL: https://codereview.chromium.org/240613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270029 0039d316-1c4b-4281-b951-d872f2087c98

It's regressed in  https://codereview.chromium.org/226293005.

BUG=368365
TEST=CursorLoaderX11Test.Scale, also tested manually
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/280133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270028 0039d316-1c4b-4281-b951-d872f2087c98

Android does not use location_bar_view but its own LocationBarView, and this
still requires access to ToolbarModel::GetText() to show formatted URL
to its users. We need to reuse GetText() to get formatted URL.
    
BUG=365567,293227

Review URL: https://codereview.chromium.org/251983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270027 0039d316-1c4b-4281-b951-d872f2087c98

Which glibc defines h_addr as a macro to h_addr_list[0],
newlib has a separate h_addr member in struct hostent.

To correctly handle this, h_addr should be set to match h_addr_list[0].

BUG=None
R=binji@chromium.org
TEST=bots

Review URL: https://codereview.chromium.org/275533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270026 0039d316-1c4b-4281-b951-d872f2087c98

Moves NonBlockingTypeProcessor from sync/internal_api to sync/engine.

It's become increasingly clear to me that the NonBlockingTypeProcessor
will be too big to expose outside of sync.  When it comes time to export
its functionality, we'll need to define a wrapper class with a simpler
interface.  This means that there's no benefit to keeping it in
internal_api.

There is a benefit to moving this to sync/engine.  In this location, it
should be able to collaborate more closely with its sibling, the
NonBlockingTypeProcessorCore.

We intend to start adding lots of code to this class soon.  It's a good
idea to get this move out of the way first, so we can have a better git
history in the end.

BUG=351005

Review URL: https://codereview.chromium.org/280693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270025 0039d316-1c4b-4281-b951-d872f2087c98

This clean up alarm, declarative, idle, push_messaing API.

R=kalman@chromium.org
BUG=354046, 354458
TEST=unit_tests

Review URL: https://codereview.chromium.org/275383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270024 0039d316-1c4b-4281-b951-d872f2087c98

This matches the behaviour of the DelegatedFrameHost used by mac and
aura, and ensures the RenderWidgetHostViewAndroid does not try to
return resources twice since the client callback would be called from
LoseAllResources otherwise.

R=aelias
BUG=372486

Review URL: https://codereview.chromium.org/275813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270023 0039d316-1c4b-4281-b951-d872f2087c98

This is to address TODO and keep the naming consistent.

BUG=none
TEST=none due to no functionality changes

Review URL: https://codereview.chromium.org/285623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371108, 359845

Review URL: https://codereview.chromium.org/280043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270018 0039d316-1c4b-4281-b951-d872f2087c98

This makes a clearer separation between methods for controlling the
actual rendering of audio versus methods for controlling the state of the
renderer (i.e,. flushing and seeking).

Consequently, clean up AudioRendererImpl to reflect the separation
between rendering methods and state change methods.

BUG=370634

Review URL: https://codereview.chromium.org/277123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270017 0039d316-1c4b-4281-b951-d872f2087c98

this is the biggest chunk I can pull out vaguely cleanly.  It does contain a
couple of fake calls to keep the compiler happy.
This CL also makes SetUpMetadata a member in order to ease testing in a later CL.

This depends on https://codereview.chromium.org/261843004/.

BUG=108012

Review URL: https://codereview.chromium.org/266333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270016 0039d316-1c4b-4281-b951-d872f2087c98

There was a small regression which http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64929
in the range r270006-r270012 which seems to be normal growth. This updates expectations as per
http://www.chromium.org/developers/tree-sheriffs/perf-sheriffs?pli=1#TOC-Updating-Performance-Expectations

See also the perf dashboard at https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes&rev=270012&checked=core

BUG=none
TBR=bokan@chromium.org,qyearsley@chromium.org

Review URL: https://codereview.chromium.org/279413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270015 0039d316-1c4b-4281-b951-d872f2087c98