- 20 Jul, 2020 40 commits
-
-
Andrey Zaytsev authored
UI mocks: https://docs.google.com/presentation/d/13qExIGI7BDaSUGBAXR0B02VzKcIqVt5Y_vo0lC7nC04/edit#slide=id.g8b3f4ba7b6_2_7 Order: 1. Updates 2. Passwords 3. Safe Browsing Bug: 1070620 Change-Id: Ic2f97a2c6fdb088b5fa5ed107507eb7b2803e2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307289 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#789885}
-
Miyoung Shin authored
This CL converts FrameMsg_VisualStateRequest to FrameWidget Mojo message and FrameHostMsg_VisualStateResponse to the return callback of FrameWidget mojo message. The legacy IPC message sent a single IPC with the multiple sub IPC messages in reply, but this CL invokes each mojo message's callback queued in the queue when the frame swap has occurred. This CL also includes to - add WidgetCompositorHost interface bound on the compositor thread. - move the implementation of |visual_state_callbacks_| from RenderFrameHost to RenderWidgetHost. - introduce WidgetSwapQueue queuing |id| having the same source frame number to invoke the callbacks. Bug: 1071588 Change-Id: If8c4db40be397921d19ca6a9a9287760879f3ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178480 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#789884}
-
Mark Cogan authored
The eg2 test target build of Chrome wasn't adding in the plist entries for multiwindow when the multiwindow gn flags were enabled, causing the tests to immediately crash if run with those flags. This CL copies the logic in i/c/app/BUILD.gn for including those plist fragments into the eg2 test .gni. Test: Compiled and ran an eg2 sub-suite with the multiwindow flags; it ran as expected (with some test failures, but no immediate crashes). Bug: 1105529 Change-Id: Ieb2541104fb70e7036497242f1df07cd93f2595e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299344 Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789883}
-
Takashi Sakamoto authored
Bug: 1092288 Change-Id: I0b0f32d16a01128087fecf2c6b1b3b32ca07d4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299941 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#789882}
-
Alice Wang authored
This CL removes the redundant argument accountName in the method AccountManagerTestRule#addAccount as this method is only responsible of adding an account and its corresponding profile data to the fake AccountManagerFacade and fake ProfileDataSource, so the accountName always equals the one in ProfileData. We can make this easier to have only one argument for this method. Bug: 1094298 Change-Id: I7a6136bf1f0d2e41376828dd95ddd91921bbe013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303398 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789881}
-
Mikel Astiz authored
crrev.com/c/2296420 recently introduced some heuristics that use the notion of when bookmarks were sync-ed for the last time. In such patch, the persistence of this time was overlooked, fixed here. Change-Id: I9eb5046e1dcae1affb99fe2fc732678c7d922dce Bug: 1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306033 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#789880}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1TVPFiVBhgMFsdfOHSL9AvrJqF_cHKFBC/view?usp=sharing Bug: 1063856 Change-Id: Ibaa987e941d11269eacfe1dc091dab234f8b206e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302034Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#789879}
-
Hiroki Nakagawa authored
For code simplification, this CL... - merges WebSharedWorker::Create() and StartWorkerContext() into CreateAndStart(), and - removes |worker_thread_| check from WebSharedWorkerImpl because it is always alive. Bug: 911415 Change-Id: If1921be5587c823562d4481e0bbf827b55bcb94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307009 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#789878}
-
Philip Pfaffe authored
Test disabled to land https://crrev.com/c/2245146. Bug: chromium:1083146, chromium:1107339 Change-Id: I49fccfeed94c655b2a5f2893fe3b16cd25c90ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306036Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#789877}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8815d8ec324d..559e6e50d226 2020-07-20 aerotwist@chromium.org Moves generated scripts to devtools_module If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I66c43a51e9662d3dc4fad81a2e7b5025d0fd1e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307133Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789876}
-
Maggie Cai authored
This CL adds a version number in the preferred apps file to indication which format the preferred apps are stored. This will avoid going through the whole list over and over again to see if we need to upgrade the list. BUG=1092784 Test: Unit test PreferredAppsConverterTest Change-Id: I3c9aa33beded325fd8d9bb6713c8ea797cc0f8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303741 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#789875}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/680c77fa6c81..717e7877cac1 2020-07-17 alanbaker@google.com Store location values sparsely (#3488) 2020-07-17 dneto@google.com Permit Simple and GLSL450 memory model in WEBGPU_0 (#3463) 2020-07-17 antonikarp@google.com spirv-fuzz: support floating-point in TransformationInvertComparisonOperator (#3551) 2020-07-17 stefanomil@google.com Change MaybeApplyTransformation to return a boolean (#3555) 2020-07-17 stefanomil@google.com spirv-fuzz: Implement MaybeApplyTransformation helper function (#3540) 2020-07-17 stefanomil@google.com spirv-fuzz: Assert false in IsApplicable method of TransformationAccessChain (#3528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Ibe52f2f1d4c911df089c58c4ebdc59721a412b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307130Reviewed-by:
-
Alex Rudenko authored
Adds a new option to GridHighlightConfig to display grid track sizes. Screenshot: https://i.imgur.com/JjSr5v2.png Frontend CL: https://crrev.com/c/2300099 Change-Id: Ic2a105128bce8c67ee41c3a153808ac171e5ea98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299343 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#789873}
-
Eric Willigers authored
share() requests fail with a rejected promise if the 'web-share' feature is not enabled. We define 'self' as the default feature policy for web-share. The spec has been updated https://github.com/w3c/web-share/pull/166 Intent to Ship https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ Bug: 1079104 Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Rob Buis authored
Setting URL.hash to '#' should set empty fragment identifier [1], unlike setting it to the empty string which drops the fragment identifier. Behavior matches Firefox. [1] https://html.spec.whatwg.org/#dom-hyperlink-hash Change-Id: Ibb577d0e362798bd81ce727f633e36f0be6c68fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302696Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#789871}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=fernandex@chromium.org Change-Id: I230ddff389ed6baeede4e0e95455f8aafe68f592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298880 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#789870}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I95d79a293e50b13c7fa29449f14cdd96861eb86a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307131Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d969ac13d806..8ee58ef3895b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mmoskvitin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mmoskvitin@google.com Change-Id: I129d7f2eb30918068723aeba69ccc8080a4cae3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307129Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789868}
-
Marc Treib authored
This helps recover from cases where the account store should have been cleared, but wasn't (e.g. badly-timed crash). Bug: 1079297 Change-Id: I57e6a53c4de7807aba7346531c7b2056b5ac100f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292518Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#789867}
-
Bartek Nowierski authored
We suspect that CheckedPtr2 and MTECheckedPtr suffer from cache misses. This solution will help us verify this hypothesis by satisfying all requests from a single tag, which is very likely in a hot cacheline. Bug: 1073933,1092288 Change-Id: I5ca13baed9e183d509d7546dffc5fa921cac252d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306131 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
-
Leo Lai authored
The new attestation flow doesn't rely on cryptohome client anymore. as for testing, EnrollmentCertificateUploaderTest.* are passed. Change-Id: Id289cdc1b2e2d4a27179f048c0d6e3d4d968cd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303743 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789865}
-
Hiroshige Hayashizaki authored
Previously, HTMLParserScriptRunner::ExecuteScriptsWaitingForLoad() required the given PendingScript is still the valid ParserBlockingScript(). However, this isn't the case when HTMLParserScriptRunner::ExecuteParsingBlockingScripts() is called after PendingScriptFinished() before NotifyScriptLoaded(), because the PendingScript is already evaluated and is no longer parser blocking. This CL allows ExecuteScriptsWaitingForLoad() to be called even when the finished PendingScript doesn't match with ParserBlockingScript() or even when there are no longer ParserBlockingScript(), by removing DCHECK()s and |pending_script| argument. This is safe because: - All necessary conditions for evaluation is checked in ExecuteParsingBlockingScripts(), and extra stale calls to ExecuteParsingBlockingScripts() (i.e. called when parser blocking scripts are not ready) are ignored. - |pending_script| hasn't been used other than for DCHECK()s. Bug: 1093051 Change-Id: I921f8d8f1fc261547fa214822f75341de03c8cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239770 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#789864}
-
Aya ElAttar authored
Changed PolicyTest::SetPolicy and all its references to pass the policy value as base::Value instead of unique_ptr. Bug: 2270317 Change-Id: I6839ce75d32dfe4b17ba4ffde21ae6585ecdc7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301143Reviewed-by:
-
sandromaggi authored
Bug: b/159309621 Change-Id: I45016405c85a5bef1b674ea8477c34b5bbc30711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306251Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#789862}
-
Alice Boxhall authored
This reverts commit 7da56cfe. Reason for revert: Test is still failing: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20(dbg)(1)/83673 Original change's description: > Update vr_pixeltests exceptions > > https://crrev.com/c/2304097 updated the tests that originally required > this exception to be added so that they now automatically skip/pass on > Windows 7, so we don't need to keep these exceptions anymore. > > Bug: 1106809 > Change-Id: Ia84e677ed9d6f74e040a24a73a0fa4a14720b778 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304936 > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789684} TBR=thakis@chromium.org,alcooper@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106809 Change-Id: Id8a98cce9da8ec8933e75686718f92e7b7ec2d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307011Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789861}
-
Alice Boxhall authored
This reverts commit 38a4c6af. Reason for revert: Newly added test is failing: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19641 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874475110456145024/+/steps/browser_tests/0/logs/Deterministic_failure:_OSSettingsResetPageV3Test.All__status_FAILURE_/0 Original change's description: > [OsSettingsDeepLinking] Add DeepLinkingBehavior & Deep link OSResetPage > > Added the Polymer Behavior to fetch the settingId parameter from the > URL and then focus on elements containing that settingId. Imported in > the OS Reset Page. > > Bug: 1084154 > > Change-Id: I52bb73227447d6293a7b31402f7cc5a29e045309 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296008 > Commit-Queue: Daniel Classon <dclasson@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789709} TBR=khorimoto@chromium.org,tjohnsonkanu@google.com,dclasson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1084154 Change-Id: I1dcf9ed2ea428e69918db46df581c4614a19a40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306122Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/426f13e93f99..8815d8ec324d 2020-07-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9036f6aecab073520e369be520ed1ba9ce4a3d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307054Reviewed-by:
-
Leo Lai authored
This CL deploys the usage of platform side of attestation flow because attestation service at platform side knows better about the stat machines of the enrollment. BUG=b:158955123 Change-Id: I902f8bfc43da9cb2cae0e65a0d244c31ce986dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297061 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Kenichi Ishibashi authored
Bug: 1055677 Change-Id: Ieb2758fdda0ae2a6054936d57e7454ffaad1bddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303411 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789857}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/60bf6924b42f..1860aed6436d 2020-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cc5513855cc5 to 08c4d09493bf (11 revisions) 2020-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0e82586297a8 to ea6f21a052c9 (4 revisions) 2020-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from cb2938a1afd7 to d0dd661f1805 (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Id0fa18d73fc4530c675d9ce96142093ba6df720d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305852Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/870e2d8168cc..d969ac13d806 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aboxhall@google.com Change-Id: I5d9dd818b7955f2aa4097b5d3639b97311437adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307053Reviewed-by:
-
sandromaggi authored
The first animation used to be delayed, this is not necessary as there are no previous animations to wait for. Bug: b/158750294 Change-Id: If4260181f45be9fb9aaaea574c507600891b58c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302617Reviewed-by:
-
Koji Ishii authored
This patch adds |PostLayout| gurad to FragmentItem codepath in |AddOutlineRectsForNormalChildren|. While I have not succeeded to reproduce the issue locally, this is the most likely the reason from the stack traces. This patch is speculative. Bug: 1105283 Change-Id: I94813dc011e6a43a08a111ad7dfc51804d7877de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303417Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789853}
-
Yoichi Osato authored
This CL implements https://fetch.spec.whatwg.org/#body-mixin: """ Request includes Body; The body attribute’s getter must return null if body is null and body’s stream otherwise. """ Since this feature is required for fetch upload streaming, this CL makes it under the flag FetchUploadStreaming. Fixed: 1105704 Change-Id: I334d9e1a3494ff4ba31efc9dc8b319294d2e19d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297035Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#789852}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/642be1d27d97..39d317835bd0 2020-07-20 yyanagisawa@chromium.org Roll out new goma client binary VERSION=203 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ifd510705b382410de1c35e281f196cfbaea5d6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307050Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595191024-184b839913bdf74d85d86bbb55656bedc1cb42fe.profdata to chrome-mac-master-1595224759-e1768d31ec00790ba2a6883a1e8e7f5013b1d5d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I3984689a6158751d15965f56c632883757126842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307055Reviewed-by:
-
David Munro authored
Bug: chromium:1105298 Test: manual Change-Id: I890e2ae4f7b5b2a49f999aa957c4923d613c19a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301690 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789849}
-
Koji Ishii authored
|NGFragmentItem| has a union. This change shows only the used member of the union depending on its type. |NGFragmentItems| has a flexible array. VS debugger could show only the first item before this change. With this change, synthetic |ArrayItems| shows all items. Checked no warnings/errors with Natvis diagnostic messages turned on in Tools/Options/Debugging/Output Window. Bug: 982194 Change-Id: Ic5a75668c2e0482f7c6a00915459f6401886b9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294837Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Dmitry Torokhov authored
Members of a struct are publicly accessible and therefore should not end with an underscore. Bug: 1071872 Change-Id: Icd6a4db3952df9e6c7efe172f0d638e9944bb81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306550Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#789847}
-
Kenichi Ishibashi authored
This removes direct use of ServiceWorkerResponseReader from tests. Tests use the mojo version instead. Bug: 1055677 Change-Id: Id1d955a88d76b515c5e2be9ed0b8bd12dbade814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302978 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
