- 03 Jun, 2020 40 commits
-
-
Stepan Khapugin authored
Fix a UIWindowScene leak in multiwindow. Improve memory management of overlays. Bug: 1090263 Change-Id: Ia5e06566635b182fa33c4976c933cebcf0b5f11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228654 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#774646}
-
Stephen McGruer authored
This also changes to use full email addresses instead of usernames, which is (coincidentally) a concern raised by Pinpoint team in issue 1045089. This change is being deliberately TBR'd (after review!) to confirm that TBR-ing an @google.com account works. TBR=kyleju@google.com Bug: None Change-Id: I472c8fcdfba0aae9d2ff75d34a59e287905b50f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226769Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#774645}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d4d88908b1bb..fb2bd34e2d92 2020-06-03 fmayer@google.com Do not use id as row number. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4a18c1e94b379cbc0a0fc4be31dca398777f030c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229141Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774644}
-
Andrew Grieve authored
Noticed this was the only resource in the sw720dp config. Turns out that it's not even necessary anymore since sw600dp/window_background.xml == sw720dp-v19/window_background.xml And we don't support pre-v19. Saves 3.7kb Change-Id: I591bf7f1a91c1984ad5896db85a6c09f168b314e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225944Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#774643}
-
Gavin Williams authored
- Show the 3 default print preview destinations Save to PDF, Save to Google Drive, and See More... - Add the existing icons to inside the dropdown using |destinationIcon| Bug: 1059607 Change-Id: Icef448773ac3f350c0fd3bf5eb8b63c8d567cb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194789 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Auto-Submit: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#774642}
-
Sylvain Defresne authored
The incognito BrowserState should only be destroyed when there are no tab open in any window. When multi-window is enabled, this mean that all the WebStateList of all Browsers are empty. Additionally, before destroying the incognito BrowserState, the objects whose lifetime is tied to the incognito BrowserState must first be destroyed (like Browser, ...), so iterate over all the SceneController to inform them to destroy those items before the BrowserState is destroyed. Bug: 1069749 Change-Id: Ibcba14081e3bccc9737f57104a77a11e68eeea46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225772 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5a46f5c6. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I5a6b0e46ab7b851b7137034c46382fee8b8c246b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228574Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774640}
-
Yi Gu authored
The TODOs are now assigned to the linked bugs. Bug: None Change-Id: I92ee6368f1d9b730c9cc31d204d716c0c2c30f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225291 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#774639}
-
Peter Kasting authored
* Remove DownloadShelfNeedsLayout(). The BrowserView implementation of this turned out to be equivalent to checking if the download shelf GetVisible() returns true. BrowserViewLayout can do this directly. The test implementation of this was easy to replace with setting the visibility directly. * Remove the SetViewVisibility() call in LayoutDownloadShelf(). The download shelf updates its own visibility (correctly), so this was a no-op. * Remove the Layout() call in LayoutDownloadShelf(). If the View size has changed, SetBoundsRect() will Layout() automatically. If not, layout is unnecessary. * Better use of unique_ptr to convey ownership in unittest code. Bug: none Change-Id: Ia79970b1fd386a080623ff80c57eb29bc50c2d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227435 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774638}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b4a80ad22de..463d729cd6db 2020-06-03 paraboul@gmail.com Fix an "use-after-move" in SkFontMgr_custom_embedded. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I97aae6fb02303207bf4d8d0cec97933749198a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229139Reviewed-by:
-
Tim van der Lippe authored
The flag is being removed. Before we can remove the usages in devtools-frontend itself, we first have to remove the references to them in Chromium. R=yangguo@chromium.org Bug: 1087379 Change-Id: I09650358aba4bc2ec30fe91fe49e7e287d4b205b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224216 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774636}
-
Peter Wen authored
Rename the one offending non-java target with a java target name pattern by removing _java and _junit. Bug: 1090812 Change-Id: I8a00951fd9564e9b2842af78e4f5485f9df5aa7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229001 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774635}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/78a3c915a1d7..232ba0d848d1 2020-06-03 47594367+rg3igalia@users.noreply.github.com Add SPIR-V capabilities needed for spec constants (#2199) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: Iabda92ca97d27d9bd714896735d46e76b7718f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228916Reviewed-by:
-
sandromaggi authored
This re-introduced the ShortWaitForElement for the Use*Action, if the |form_field_element| is specified. This is not a hard restriction, if |skip_autofill| is true, the element does not need to be specified. If it's not, the |RequiredFieldsFallbackHandler| will be called immediately without waiting. Bug: none Change-Id: I269ac0735a060357a6679e66fdf41f7a315f402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228720Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#774633}
-
Travis Skare authored
Matches c/b/ui/views/qrcode_generator Change-Id: I4e2a0600908b849893decdd0b0d72162d55ce5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227853 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774632}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fb005807e661..c042e00faa0e 2020-06-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-06-03 tvanderlippe@chromium.org Typecheck sdk/SourceMap.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1ca9cc397fe3c26ae4cc7e823b26f884fcf93fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228915Reviewed-by:
-
François Doray authored
This reverts commit bc99f5b2. Reason for revert: https://crbug.com/1090820 Original change's description: > [COOP access reporting] Preliminary WPT tests. > > Add some basic WPT tests about the COOP access reporting feature. > No web browsers actually implement this. As a result, chrome do not > pass them yet. > The tests aren't complete yet, they will evolve along the specification > and the implementations. > > Bug: 922191 > Change-Id: I9aa03e727252086eb64c0110afc9b5885b66802d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225757 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774599} TBR=clamy@chromium.org,arthursonzogni@chromium.org,pmeuleman@chromium.org Change-Id: Iffd419fd7bc0e2f4b9c77260c2f9a40ba44b0cdc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922191, 1090820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229003Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774630}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/adbf9153d909..d586b079f20d 2020-06-03 cwallez@chromium.org Fix compilation failure with libstdc++ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I22d51ed0ad374080d4be449bebc580c41e97c478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228912Reviewed-by:
-
Nick Diego Yamane authored
No functional change, just fixing coding style and a couple cleanups. R=sadrul@chromium.org Bug: None Change-Id: I437a973ad6a50957c642923e8e088c2c3744e782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216710 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#774628}
-
Steven Bennetts authored
This introduces a 'disabling' state to the cros_network_config.mojo API and uses it in the system menu and settigns UI. It also removes the 'Enabling' state from network_health.mojom (instead of adding 'Disabling') since we don't care about either from a network health perspective; the intermediate states are pseudo states for the UI only. Bug: 1032030 Change-Id: I1301cd87068ee8d98bf63b004dc3e9857c3bcdca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225370Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#774627}
-
Francois Doray authored
Affected tests: HeadlessOriginTrialsBrowserTest.TrialsDisabledByDefault HeadlessOriginTrialsBrowserTest.WebComponentsV0CustomElements HeadlessOriginTrialsBrowserTest.TrialsCanBeEnabled HeadlessWebContentsScreenshotWindowPositionTests/HeadlessWebContentsScreenshotWindowPositionTest.RunAsyncTest/0 HeadlessWebContentsScreenshotWindowPositionTests/HeadlessWebContentsScreenshotWindowPositionTest.RunAsyncTest/1 HeadlessWebContentsTaggedPDFTest.RunAsyncTest TBR=fdoray@chromium.org Bug: 1090801 Change-Id: I28769af93ffc772a36a3104f3e16c1c758a956a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229062Reviewed-by:
-
Alex Ilin authored
This reverts commit 6d801322. Reason for revert: fixed the tests by increasing the dialog interaction timeouts Original change's description: > Revert "[signin] Add browser tests for the reauth dialog" > > This reverts commit 98d00374. > > Reason for revert: > Both of these are failing on MSAN: > SigninReauthViewControllerBrowserTest.CancelReauthDialog > SigninReauthViewControllerBrowserTest.ConfirmReauthDialog > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/24165 > > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878588233120522160/+/steps/browser_tests/0/logs/Deterministic_failure:_SigninReauthViewControllerBrowserTest.CancelReauthDialog__status_CRASH_/0 > > Original change's description: > > [signin] Add browser tests for the reauth dialog > > > > This CL adds tests for the first step of the reauth flow, the reauth > > confirmation dialog. The tests check that clicking on all buttons > > produces expected results. > > > > The tests for the second step of the reauth flow will be added in > > follow-up CLs. > > > > Bug: 1045515 > > Change-Id: I4266f29ea03080d3d6612099a0b9a49cff5cdf09 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219897 > > Reviewed-by: David Roger <droger@chromium.org> > > Commit-Queue: Alex Ilin <alexilin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#774122} > > TBR=droger@chromium.org,alexilin@chromium.org > > Change-Id: I08bfa073e1b51c4dbb3125232cc4b60880deb293 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1045515 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227932 > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774447} TBR=droger@chromium.org,ortuno@chromium.org,alexilin@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1045515 Change-Id: Idb1848dca0d77856943253cd69c63930791d2b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228155Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774625}
-
Luke Zielinski authored
This will contain functionality that is shared between desktop and android wptrunner. For now it's just copying the output to full_results.json but the plan is to start adding support for more files that are needed by the results viewer. Change-Id: Iedd7e9a624274d90dd79f91c60ae3452d483a1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218528Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#774624}
-
Illia Klimov authored
That patch shows "Automatically blocked" subtitle for embargoed origins in Site Details page. Bug: 1033593 Change-Id: Ib9820f31cce317b23a62d4f53eff301f8e638d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219505 Commit-Queue: Illia Klimov <elklm@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774623}
-
Katie D authored
AX-Relnotes: Changes STS focus ring color to a more purple hue. Bug: 1085231 Change-Id: I7c9305be152aa857c01626839a691adc0a98f126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225523 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#774622}
-
Daniel Rubery authored
When adding the fieldtrial_testing_config for this experiment, I missed the enabled feature field, blocking the rollout to beta. Change-Id: Ibfe8e0f266c94f76b46881bbb0dcd12a66ad4df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227395 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#774621}
-
Mikel Astiz authored
Two of the histograms were deleted long ago and the remaining one may be useful in the near future. Change-Id: Ib7aee4697fa4c95a0bed8e5be75f3e325766c7f0 Bug: 1089546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225404Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Akihiro Ota authored
Bug: N/A Change-Id: I360d0e27e22241f8617d1d74f1fd42d33ae44a6e AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226921Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#774619}
-
Felipe Andrade authored
Extend the expiration date of some (about to expire) authpolicy histograms. Justification: AuthPolicy doesn't send enough data to the server to provide data for usage of the feature. Bug: 1088595 Change-Id: I72a227683b8be3391513d4912ca238df1069fd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226755 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
-
Mila Green authored
Bug: 1053667 Change-Id: I697f9eb48375b4f1d474e2c2823519848aea84d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225464Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774617}
-
Francois Doray authored
[sheriff] Expect failure for external/wpt/fullscreen/api/element-request-fullscreen-and-move-to-iframe-manual.html on Mac TBR=fdoray@chromium.org No-Try: true Bug: 1007228 Change-Id: I45cb0b1f0ede2d4659690f98fc6e6d0a0c6d066c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229060 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/890735b8c86d..d4d88908b1bb 2020-06-03 treehugger-gerrit@google.com Merge "Frame lifecycle MVP updates" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id03d84de2b9dc35550947e4c72f41b5413cd6c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228909Reviewed-by:
-
Stephen McGruer authored
These are symptomatic of crbug.com/1047818, but to stop the pain for sheriffs lets mark them timeout=long for now. TBR=lpz@chromium.org Bug: 10904552, 1090484 Change-Id: I67b37d6ad915b28d57a95be88243eed619585b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229058Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#774614}
-
David Lechner authored
This enables the new Web Bluetooth BluetoothRemoteGattCharacteristic writeValueWithResponse() and writeValueWithoutResponse() APIs on Win10, Mac, Android and ChromeOS. This has LGTM3 from blink-dev. https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/1JE8tjylY3s Bug: 672648 Change-Id: Iebcdb0c6c7daeb3aa230f0ec511a805655a0cdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220694Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: David Lechner <david@pybricks.com> Cr-Commit-Position: refs/heads/master@{#774613}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d77fdbe0..e02ac975 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I75ed78e9287db5567787b9098d267318d4d8be21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228939Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774612}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/93f1a38fb5b9..5b4a80ad22de 2020-06-03 tdenniston@google.com Revert "Roll dawn from 295a4177aebc to adbf9153d909 (18 revisions)" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: If3ee31752ea6e6d15cd28038a61d0c4ff2be0365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228907Reviewed-by:
-
Miguel Casas authored
This CL removes two unnecessary preprocessor definitions, that were not there when the code landed, but now they are after the appropriate //third_party/libdrm uprev. No new code, just a cleanup to close a bug. Bug: 958181 Change-Id: I3e9cab3ba5677585d188c4e54676aa525224a515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225251 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#774610}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591170216-219e7bf40eeb405c9bdb366afea32eceddcbc16f.profdata to chrome-mac-master-1591184865-5fd7e217cbf2739ffd4335727dd5978110d7b63d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib119fb03afcdad0912b5e3307925e9a2b1f9c1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228908Reviewed-by:
-
Aaron Leventhal authored
Avoid unnecessary processor usage for blinking caret, as accessibility children changed events are not needed. The caret is an ignored object, meaning that it is not even exposed as a child. These extra events are especially prevalent when the JAWS screen reader is running, because it increases the caret blink rate in order to track it better in legacy apps. Bug: None Change-Id: I83b20883dca9f73c5f529f23e5b99195bb0982a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225621 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Alex Rudenko authored
Inspector resources have been moved to DevTools[1]. This CL integrates all inspector resources with the inspector overlay agent. [1] https://crrev.com/c/2226560 Bug: 1078267 Change-Id: Ia0f8df3181bfc428df1e3222de070aa814523ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228551Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
