- 10 Aug, 2018 40 commits
-
-
Joanmarie Diggs authored
These three roles are part of reaching role parity with HTML5. As such, they should be exposed via platform accessibility APIs in the same way as their native host language counterparts. Thus just add them to the map of ARIA roles to internal roles. Bug: 849650 Change-Id: I9a513e187a5beccd57fc5c7306929b0fd194b6dd Reviewed-on: https://chromium-review.googlesource.com/1169476 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#582340}
-
Christian Biesinger authored
This avoids recomputing them later. Also, changes RunOldLayout to use legacy layout to compute border/padding to store on the fragment, which seems more correct. R=eae@chromium.org Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id659d7c92eae81431d8e75a26ac3973421afc3d0 Reviewed-on: https://chromium-review.googlesource.com/1169634 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#582339}
-
Stephen Martinis authored
This reverts commit 306be5bf. Reason for revert: GS bucket names have been fixed Original change's description: > [ChromeDriver] Fix path for old Chromium snapshots > > Chromium snapshots before revision 579575 are still archived using > the old directory name. > > TBR=crouleau@chromium.org > > Change-Id: I4cc1e9ca51af9f8f21e22214af2110a6d8be8fe7 > Reviewed-on: https://chromium-review.googlesource.com/1158709 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579802} TBR=crouleau@chromium.org,johnchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I093548f1d0ef02a37ffd8d3d2fe66f7222234e1b Reviewed-on: https://chromium-review.googlesource.com/1171426Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#582338}
-
Chris Harrelson authored
Instead, dirty them on particular PaintLayers only when their layout changed. Bug: 410867 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idf7664b869b1e7205e68adc075bcf828f279cffb Reviewed-on: https://chromium-review.googlesource.com/1168142Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582337}
-
James Cook authored
display::Screen (and ScreenMus) now has the display for new windows, so we can use that when making new browser windows under both mash and classic ash. Likewise, we can use display::Screen (as ScreenAsh) for new windows inside of ash. This lets me remove ShellStateClient, a different mechanism that accomplishes the same goal in a less general way. Leave ash::ShellState for now. I will clean that up in a separate CL. TBR=tsepez@chromium.org Bug: 764009 Test: existing browser_tests for browser frame/size Change-Id: I5c255dc2bf8fdd48f519f148d29aca3d37e7ae73 Reviewed-on: https://chromium-review.googlesource.com/1168197Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#582336}
-
Yue Li authored
Bug: b/112447220 Test: Manual Test Change-Id: Idcab08aca234f9f5528529aedb71fbbbdfa29d1d Reviewed-on: https://chromium-review.googlesource.com/1171551Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#582335}
-
Daniel Murphy authored
As part of onion souping domstorage this adds a couple of new classes to blink more or less duplicating the content equivalents: CachedStorageArea matches content::LocalStorageCachedArea (with some minor API changes, in particular around how it acquires a mojom StorageArea). Also has improved test coverage compared to the content version. MockStorageArea is very similar to content::MockLevelDBWrapper (with the difference that it doesn't implement StoragePartitionService since it doesn't need to with the changed API of CachedStorageArea). Bug: 781870 Change-Id: Ic64b3bf307fe275d9287669743f186c8470847bb Reviewed-on: https://chromium-review.googlesource.com/1166218Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#582334}
-
Evan Stade authored
One of them lives on in browser because the Ash version trips a dcheck when run in classic Ash mode. Bug: 854704 Change-Id: I7822cc088c255b8c16c91cb1b5304c5e2b974115 Reviewed-on: https://chromium-review.googlesource.com/1170127 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Jason Chase authored
Remove chasej from background_sync and tweak inclusions for origin_trials. Change-Id: Ie3f19642c491d791f5681ca92e15b34002b51d2e Reviewed-on: https://chromium-review.googlesource.com/1171563Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#582332}
-
Jon Mann authored
Add a function to ServiceWorkerContextWrapper which starts a service worker and keeps it alive indefinitely. This is only for use in ChromeOS for the Android Web Messages native integration. Change-Id: Id2357f54078c12db0ad25cd9fe0622d57e34a064 Bug: 850823 Reviewed-on: https://chromium-review.googlesource.com/1119580Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#582331}
-
Ryan Sleevi authored
Support for file-based persistence was removed in r571588, so its no longer necessary for Cronet to explicitly create a CertVerifier to guarantee it is a CachingCertVerifier. Bug: 590875 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I23e9e6db12225a7474ce589d9333595729108f1c Reviewed-on: https://chromium-review.googlesource.com/1169822Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582330}
-
Mark Pearson authored
These histograms are used, both within Chrome and within Google, in the effort to identify and fight unwanted software and malware. As such, I'm giving them a longer expiration date: two years. Bug: 871482 Change-Id: I320976f7a18dfa3c5c0d6bb6c3bf05ddfec8e5b4 Reviewed-on: https://chromium-review.googlesource.com/1166197Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#582329}
-
John Abd-El-Malek authored
Bug: 797292, 859594 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id4e90f0ebdf5ac172b12c92d80b54348125bc883 Reviewed-on: https://chromium-review.googlesource.com/1171556Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#582328}
-
Manas Verma authored
Before: https://screenshot.googleplex.com/5YhNTQYuHV1 After: https://screenshot.googleplex.com/thg0VSMKzNX Bug: 855186 Change-Id: I64b1ca9452330a847512c45220bda9173e1a1ac1 Reviewed-on: https://chromium-review.googlesource.com/1170141 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#582327}
-
Kai Ninomiya authored
Historically, we haven't been running these WebGL perf tests on our Android perf bots (which are all Qualcomm devices). This change should hopefully allow us to start tracking WebGL perf on mobile. Bug: 867368 Change-Id: I8e409d649f6238094928dfdac4cc6f7d2c444ca5 Reviewed-on: https://chromium-review.googlesource.com/1170032Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#582326}
-
yoshiki iguchi authored
Inline reply on lock screen is not launched at the same time as the lock screen notifications. So this CL creates a separate feature flag for inline reply. Bug: b/111391270 Change-Id: I585beba17b3a491ce495f1d6c35ce46b2a6b6686 Reviewed-on: https://chromium-review.googlesource.com/1166617 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
-
Erik Chen authored
This CL adds a new MessagePumpForUI::Observer class, which can be used to get notifications pre and post MSG dispatch. Change-Id: I16b0df6d30b41f04f124d4b64d850c278f2c10d9 Reviewed-on: https://chromium-review.googlesource.com/1166164 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#582324}
-
Francois Doray authored
Previously, using the clipboard on a non-whitelisted thread triggered a DumpWithoutCrashing + NOTREACHED. If a developer introduced code that used the clipboard on an incorrect thread, they were not warned immediately unless they had DCHECKs enabled. The issue could only be noticed once an official version of Chrome started generating crash reports via DumpWithoutCrashing (e.g. https://crbug.com/872737). This CL replaces the DumpWithoutCrashing + NOTREACHED with a CHECK to ensure that developers can't miss the issue. Bug: 872737 Change-Id: I5de2c1498245604fc94ca29c35518cc0c9531b0f Reviewed-on: https://chromium-review.googlesource.com/1170595Reviewed-by:
-
Scott Violet authored
This will be important for SingleProcessMash as the context/parent is needed to properly create the NativeWidgetDelegate. In particular NativeWidgetAura's constructor takes an Env that comes from either the context or parent. We need to ensure code in Ash sets that properly so that the right Env is used. BUG=847992 TEST=covered by tests Change-Id: I2876ac862e00c4f03a7c328230db372f5d74a005 Reviewed-on: https://chromium-review.googlesource.com/1171204 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Varun Khaneja authored
since that path has been removed and folded into safe_browsing Change-Id: I9a81174f82bb39bcd43183b180e6250eff833167 Reviewed-on: https://chromium-review.googlesource.com/1171163Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#582321}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 21c70dad. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." b883f432 "[LayoutNG] Propagate abspos inline container" 0cca86c6 "[Background Fetch] Reject BackgroundFetchUpdateEvent::UpdateUI if called again" 0f9021aa "[LayoutNG] Flip for writing mode when calculating inline bounding box." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22585 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ide77f40071e045eb5e1b3574920b5e62e88256c7 Reviewed-on: https://chromium-review.googlesource.com/1171214 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582320}
-
Etienne Bergeron authored
This CL is activating the "system_stats" category for the navigation slow-reports. The idea is to collect more system wide information to determine the cause of janks. We believe many janks are related to system wide properties not visible without system wide metrics. R=fdoray,oysteine Bug: 872900 Change-Id: I2151616b07b79997b20243181eb31c5270c4ee68 Reviewed-on: https://chromium-review.googlesource.com/1171109Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582319}
-
Helen Li authored
This reverts commit 838e1b19. Reason for revert: Reland after fix Mojo doesn't allow dropping response callbacks (see https://groups.google.com/a/chromium.org/forum/#!topic/services-dev/zSNh16-tkaA for discussion). The fix is to modify ProxyResolvingSocketFactory::CreateProxyResolvingSocket to always invoke the response callback even when the underlying socket is destroyed. This CL also adds a regression test in proxy_resolving_socket_mojo_unittest.cc. TBR=dcheng@chromium.org TBR=jam@chromium.org TBR=sdefresne@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie9fdb93f965bbcf534253aaabe436c4de5f0666d Bug: 862608, 868220 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie9fdb93f965bbcf534253aaabe436c4de5f0666d Reviewed-on: https://chromium-review.googlesource.com/1169345Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582318}
-
Clifford Cheng authored
1. The test uses a video with only 2 different frames. The first frame of the video is a blue/pink color frame and the rest are a yellow frame to avoid any possible error because of image compression. 2. The test loads a page, starts playing the video and trigger PiP. The PiP window is set to a specific size and then a screenshort is grabbed. Change-Id: I63e0ede4013dbeee688770cca06ac673ed6003b3 Reviewed-on: https://chromium-review.googlesource.com/1137533 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#582317}
-
Wez authored
This addresses flaky DCHECKs in ServiceManagerTests and LifecycleTests, triggered by mixing of RunLoop::QuitClosure() with the calls to the old RunLoop::QuitCurrent*Deprecated() APIs. Change-Id: Ieb510aa1501f9d46ac606d66a3556744fd0f95da Reviewed-on: https://chromium-review.googlesource.com/1170355Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Michael Thiessen authored
EAGAIN should only happen when no timer has expired, but the function should only be called when a timer expires. And yet, very rarely during tests, we error with EAGAIN. I have no theories as to why this is happening. Possibly a platform bug. Ignoring EAGAIN should be safe, we only read the timer to clear it so that we don't keep getting called back. If it's already cleared then we're fine too. Bug: 872044 Change-Id: I6eb29ab99402d90140bd5b89a26df2aa5e53b1c6 Reviewed-on: https://chromium-review.googlesource.com/1168154 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
Mark Pearson authored
Having these histograms is an important reminder that, on many platforms, these things take on the order of hundreds of milliseconds shortly after startup, likely making slow slower as a user is trying to interact with it. Bug: 871495 Change-Id: Iab792bb11446a8258865562937b8f8b9b81fe4a1 Reviewed-on: https://chromium-review.googlesource.com/1170132 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#582314}
-
Keishi Hattori authored
This CLs added 3 unit tests in HeapCompaction for IncrementalMarking. One of tests checks that slots is collected if the slot content is nullptr of inline buffer. Another case checks whether compaction is correctly working if collected slot is dropped references. Moreover, we check whether compaction is correctly working if collected slot is destructed by mutator. Bug: 864425 Change-Id: I3038c9a6e2607f3ed81a5f438a1ab415fa96df9a Reviewed-on: https://chromium-review.googlesource.com/1152750 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582313}
-
Quan Nguyen authored
Bug: 855546 Change-Id: I065c2bbd1e3db69dca3f8b18d40ce5beb09f9abd Reviewed-on: https://chromium-review.googlesource.com/1162715Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582312}
-
Ella Ge authored
On Android, we want the underline thickness to follow with device scale as other app. (And also 1px is two thick since mobile has larger pixel density) Thus, we need to apply the zoom level to the text underline thickness. Bug: 870203 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I98080028c59837b69742101a2239df7f9b8dc43c Reviewed-on: https://chromium-review.googlesource.com/1162518Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#582311}
-
David Black authored
Which view we should focus on depends on which UI mode we are in. Bug: b:112443502 Change-Id: I2ba63f401f0f8a900971b9c2cef7ce22cff67e4f Reviewed-on: https://chromium-review.googlesource.com/1171142Reviewed-by:
-
Alexander Alekseev authored
This CL adds I18nBehavior.i18nRecursive and uses it for parametrized strings in Chrome OS Sync Consent screen. Bug: 822889 Change-Id: I0ca8c3b7a45ee1cea8a80a0e8ace388e958709c4 Reviewed-on: https://chromium-review.googlesource.com/1166464 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582309}
-
Ryan Daum authored
* Port of Ash's MagnificationController to cast. First patchset is the original source, with changes/removals for cast in patchset 2. * Enabled via triple-tap when that is enabled. * Two-finger pan & pinch-to-zoom. Bug: internal b/110532452 Test: manual Change-Id: Ia346fcc6d4ff70aaa0236f1d976c3b0de13a0f86 Reviewed-on: https://chromium-review.googlesource.com/1170987Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#582308}
-
Kenneth Russell authored
There are many crashes seen on Chrome Canary inside nvml.dll, so until a pattern can be found and a workaround proposed, stop calling into it. Bug: 693090, 873095 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0204273fb88ba8b61799916d98c843f0068ccadc Tbr: zmo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1171376 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#582307}
-
Marina Ciocea authored
Update names to match latest finch beta config names. Bug: 832666 Change-Id: Ic108cf7f545fd174209d0b2eee517999c7875b43 Reviewed-on: https://chromium-review.googlesource.com/1171223Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#582306}
-
Sunny Sachanandani authored
We plan on shipping this via a finch experiment to Canary/Dev soon, and then enable it by default if we don't encounter major issues. This should only affect the DirectComposition pixel tests since we force-enable overlays for those tests. Other tests don't exercise DirectComposition code because those code paths are disabled unless the hardware supports it. Bug: 869677 Change-Id: I31c1fd96f2c2567c82c19776a57b2fe18a1b1e1a Reviewed-on: https://chromium-review.googlesource.com/1170385Reviewed-by:
-
Manas Verma authored
Metrics for the Manage Cards view, which appears when the user clicks on the credit card icon after saving a card locally. bug: 855186 Change-Id: I036b16bc4a5a4f48115212263909e49371e9778f Reviewed-on: https://chromium-review.googlesource.com/1162900Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#582304}
-
Scott Violet authored
As part of the mash work we're going to have multiple aura::Envs at the same time. Code that may run in Ash now gets the Env from aura::Window, rather than using Env's static GetInstance(). This patch converts exo to remember the Env so that it can get the right one. BUG=847992 TEST=covered by tests Change-Id: I5fd1c6120868b3847ccd68a063039eec5b54a3b6 Reviewed-on: https://chromium-review.googlesource.com/1169590 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#582303}
-
Francois Doray authored
Previously, these histograms were recorded prior to startup temperature evaluation, which caused almost (*) no data to be recorded in temperature-suffixed histograms. With this CL, the values are stored in global variable and recorded to appropriate histograms after the startup temperature is evaluated. (*) Most of the time, the browser window is displayed before startup temperature evaluation. However, if Chrome is launched with --silent-launch, the first window can be displayed later. That may explain why we see a few samples in temperature-suffixed BrowserWindowDisplay histograms. With this CL, any browser window display that happens after normal startup won't be recorded to an histogram. Bug: 580207, 589118 Change-Id: I8419df6f42df64f60be0858462159a276d17557e Reviewed-on: https://chromium-review.googlesource.com/1167470Reviewed-by: -
Shimi Zhang authored
After we migrated native side callback to |OnceCallback|, it exposed that we sometimes call |askUserForSettingsReply()| more than once. The |DCHECK(callback_)| in |PrintingContextAndroid::AskUserForSettingsReply| was violated. Since |Printingcontext.askUserForSettings()| will call |askUserForSettingsReply()| for sure, we don't need to call it in other places. This CL removes a call site of |askUserForSettingsReply| in |PrintingControllerImpl|. Bug: 863297 Change-Id: If1c34a4a89acaca461074231ab1bef8edef9baae Reviewed-on: https://chromium-review.googlesource.com/1161604 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582301}
-
