- 01 Nov, 2017 40 commits
-
-
Matt Menke authored
In particular, switch them to using the EmbeddedTestServer from URLRequestFilter, which required them to be in the same process as the network stack. Bug: 776589 Change-Id: I5d4d363d47149a11ccb38b5c18d8c57c377b58b4 Reviewed-on: https://chromium-review.googlesource.com/730888Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#513128}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/994f20cfb76f..3fff90a670d8 $ git log 994f20cfb..3fff90a67 --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Move some XFA JS code into fxjs/ Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I78339ea0a09a6572d758f15097f549e95ac056f0 Reviewed-on: https://chromium-review.googlesource.com/749167 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513127}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/994f20cfb76f..3fff90a670d8 $ git log 994f20cfb..3fff90a67 --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Move some XFA JS code into fxjs/ Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id225a632bfa3674bd95f9690f117ddb5b1fd1203 Reviewed-on: https://chromium-review.googlesource.com/749164 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513126}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/994f20cfb76f..3fff90a670d8 $ git log 994f20cfb..3fff90a67 --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Move some XFA JS code into fxjs/ Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I902c974f04679d754eb4a4e73b7daf92dcfbac3e Reviewed-on: https://chromium-review.googlesource.com/749244 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513125}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/51e24003..ea01f412 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I908e9706e114c8df804eb439ea8892b247636c8c Reviewed-on: https://chromium-review.googlesource.com/748764Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513124}
-
John Abd-El-Malek authored
This is needed to avoid race conditions with setting a cookie and making a request right away. Currently it works when cookies and request handling are dispatched on the same thread and associated mojo interfaces are used. However this will stop working if non-associated interfaces are used, which will be the case when the cookie and loading interfaces live in different processes. More background here: https://docs.google.com/a/chromium.org/document/d/1eg1ohplfFGrlz5gFNgbJflRdIljPqCj58p4Zfb81QGM We don't anticipate this having a perceptible perf impact, but added UMA stats to confirm. Cookie getters are already sync, and this new sync call replies right when the IPC is dispatched (as opposed to when the cookie database is updated). BUG=721395 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Icb7afe358a9fa969cd6fed1c2c5730fa9a18a2ec Reviewed-on: https://chromium-review.googlesource.com/742345 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#513123}
-
Biao She authored
This CL fixes two issues: 1. transitioned based on edge_color_ for foreground animation. Previously, we transition based on center_color_. 2. use alpha channel in the SkColor correctly. Previously, the alpha channel in SkColor didn't apply to its RGB channel before blending. Bug: NONE Change-Id: I3533c062d632412cd181d0ed89c770910e6d56e3 Reviewed-on: https://chromium-review.googlesource.com/747444 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513122}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/994f20cfb76f..3fff90a670d8 $ git log 994f20cfb..3fff90a67 --date=short --no-merges --format='%ad %ae %s' 2017-11-01 dsinclair Move some XFA JS code into fxjs/ Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If938a4d592049bb665922b0a18960ac8ddc1d3db Reviewed-on: https://chromium-review.googlesource.com/749166 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513121}
-
Ian Vollick authored
These elements were previously special-cased in UiRenderer. With this change, the elements are now included in the scene graph permitting some simplifications and making it easier to, for example, fade out the controller if desired. There should only be one functional change in this CL: we break reticle sorting. This is tracked by crbug.com/779692. Bug: 774501,768512,776521 Change-Id: I5173b0a419a93abe324d496664bdafef933162a5 Reviewed-on: https://chromium-review.googlesource.com/744543Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513120}
-
Daniel Bratell authored
The two kMaxListSize constants collided in jumbo builds where files are merged before compilation, for higher build performance. This patch makes the constants be shared. Bug: 777470 Change-Id: Idf90fcf389ba3895b4f0e28b4649f11ff5f8257e Reviewed-on: https://chromium-review.googlesource.com/749142 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#513119}
-
Brian White authored
The active_file can exist if the prevous run was an older version and exited uncleanly. The file is deleted by the line below. Bug: 780444 Change-Id: Ice81a06ab42310a5977d165cf67968b81965c4e2 Reviewed-on: https://chromium-review.googlesource.com/749301Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#513118}
-
Hajime Hoshi authored
This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663 Bug: 780378 Change-Id: I7b191160836f22a620d5a33d88c4d9a8a955705d Reviewed-on: https://chromium-review.googlesource.com/749122Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513117}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/611d48c1ed39..0b78a6912eba $ git log 611d48c1e..0b78a6912 --date=short --no-merges --format='%ad %ae %s' 2017-10-31 mtklein another batch of lowp stages Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Id9b9088503b4b4db283c4e6168ae1266765a758d Reviewed-on: https://chromium-review.googlesource.com/749242Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513116}
-
Han Leon authored
BUG=769236 Change-Id: Ifeee539a033b93ccee3e2223e7eb36b266385911 Reviewed-on: https://chromium-review.googlesource.com/748905Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#513115}
-
Mounir Lamouri authored
Bug: 744659 Change-Id: I3de1c7b784759ef930239ce40b8391409cf93143 Reviewed-on: https://chromium-review.googlesource.com/746662Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#513114}
-
Peter Beverloo authored
Using Mojo for blob handles has recently been enabled, but the Background Fetch code hadn't been updated yet. In effect, responses originating from Background Fetches started hitting a DCHECK. BUG= Change-Id: I0e4d765eb8ae42f02144261ba517b134be432ece Reviewed-on: https://chromium-review.googlesource.com/746921 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#513113}
-
Elly Fong-Jones authored
Specs for the Harmony collected cookies dialog call for regular domain entries to have their icons hidden in this dialog, which needs support from TreeView to implement. Bug: 610420 Change-Id: Ie611b95b896f6d6f3d9c0b0c59084a2ebaaeacdb Reviewed-on: https://chromium-review.googlesource.com/746534Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#513112}
-
Allen Bauer authored
Added find_bar_icon to display the find icon in the OmniBox. This icon is only displayed while the find bar is displayed. Moved the find bar to be snuggled right up under the OmniBox close to the find bar icon image. TBR=phajdan.jr@chromium.org Bug: 651643 Change-Id: I99d9bd458eb14dea3bcee2e6ab86c1598c3e6ef8 Reviewed-on: https://chromium-review.googlesource.com/685637 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#513111}
-
Hajime Hoshi authored
This was introduced at https://codereview.chromium.org/1646583002, but it looks like this is no longer used. Bug: n/a Change-Id: I2260ffbbd3095af18ddc53a0343548ad85bd5019 Reviewed-on: https://chromium-review.googlesource.com/749081Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513110}
-
Raphael Kubo da Costa authored
We are currently hitting an "argument list too long" error in git-cl upload that is blocking imports. At least temporarily, stop mentioning the owners for the directories being changed, and trim the "note to sheriffs" so that the CL message gets shorter. Bug: 780055 Change-Id: Icf65268c5f8429c1b18d327d320a5731b1bd0784 Reviewed-on: https://chromium-review.googlesource.com/749062 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#513109}
-
Miguel Casas-Sanchez authored
This CL updates code in a few locations in vaapi_decode_accelerator.cc: - inlines the ctor and emtpy destructor of Vaapi{H264,VP8,VP9}Picture because, since they're in a .cc file anyway, separating declaration and definition is unnecessary. - makes some members const in VaapiDecodeSurface. - makes ctors explicit and uses scoped_refptr (and not const&), see [1] and the discussion in [2]: "If the function (at least sometimes) takes a ref on a refcounted object, declare the param as scoped_refptr<T>. The caller can decide whether it wishes to transfer ownership (by calling std::move(t) when passing t) or retain its ref (by simply passing t directly)." "A great deal of Chromium code predates the above rules. In particular, some functions take ownership of params passed as T*, or take const scoped_refptr<T>& instead of T*, [...]. Try to clean up such code when you find it" [1] https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#object-ownership-and-calling-conventions [2] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/TlL1D-Djta0 TEST= **No new code intended**. Compiled simplechrome and loaded on Soraka, then played videos making sure (via chrome://media-internals) that GpuVideoDecoder was used. Bug: 717265 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6006fb23325d23841c8613fa41d65f8707a5446c Reviewed-on: https://chromium-review.googlesource.com/746369Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#513108}
-
Mounir Lamouri authored
There was a hard coded limitation to 3 actions because the pre-N notifications do not look great with more than 3 actions but it is breaking consistency for websites using the Media Session API. This is also renaming `isRunningN()` to `isRunningAtLeastN()`. Bug: 775471 Change-Id: I2e9289ff0daa987acf0b656a239069676b03d722 Reviewed-on: https://chromium-review.googlesource.com/747221Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#513107}
-
Hajime Hoshi authored
This CL also replaces caller side of Suspend(IfNeeded)/Resume to use Pause(IfNeeded)/Unpause. This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663 Bug: 780378 Change-Id: Ie228c1e2e498ff5c65a877e4cf24dc92c9714039 Reviewed-on: https://chromium-review.googlesource.com/748722Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513106}
-
Ryan Hamilton authored
BUG=777728 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6a80db88aafdf20c7abd3847404b818565681310 Reviewed-on: https://chromium-review.googlesource.com/748425Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#513105}
-
Donna Wu authored
The report_id in U2fHidDevice is always 0. This CL removed it from U2fPacket payload and updated related unit tests. BUG=728223 Change-Id: I460e0a867c111c71e5cf0939ca504b0ffb802bd6 Reviewed-on: https://chromium-review.googlesource.com/741167 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#513104}
-
Edward Jung authored
+ Remove the gradient from behind the fix button nav as this is poorly rendered on low bit depth screens. + Reduce the margin needed for the details button. + Reduced the margin for the dino game. This allows all the text to fit without scrolling. Bug: 755714 Change-Id: Ia90afd5ab621fd0c0c9781cb13f7a9e003c053a0 Reviewed-on: https://chromium-review.googlesource.com/741741 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#513103}
-
Robert Hogan authored
Bug: 690087 Change-Id: I9628c03accaf66fffae40d96bb1de2174e5fd3e2 Reviewed-on: https://chromium-review.googlesource.com/732110 Commit-Queue: Robert Hogan <robhogan@gmail.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#513102}
-
Anatoly Pilikov authored
Bug: 771907 Change-Id: Ib15de7a0792d370f75d17275670abb8685b68585 Reviewed-on: https://chromium-review.googlesource.com/738138Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#513101}
-
Yoichi Osato authored
This patch excludes text granularity adjustment part from ComputeVisibleSelection() to a function which returns SelectionTemplate<Strategy> for code health. We will have ComputeVisibleSelection(passed_selection) { const SelectionTemplate<Strategy>& xxx_adjusted_selection = AdjustSelectionXXX(passed_selection); const SelectionTemplate<Strategy>& yyy_adjusted_selection = AdjustSelectionYYY(xxx_selection); const SelectionTemplate<Strategy>& zzz_adjusted_selection = AdjustSelectionZZZ(yyy_selection); return zzz_adjusted_selection. } Bug: 775701 Change-Id: I34fefb47fe7b82916a41f0f876030561fc21f1d4 Reviewed-on: https://chromium-review.googlesource.com/748842 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513100}
-
Hajime Hoshi authored
This is the first step to replace all SuspendableObject with PausableObject. This CL is part of the giant CL https://chromium-review.googlesource.com/c/chromium/src/+/748663 Bug: 780378 Change-Id: I76781b850f8a1c71f4a01178d3fd7432534adc06 Reviewed-on: https://chromium-review.googlesource.com/749022Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#513099}
-
Makoto Shimazu authored
TBR=lazyboy@chromium.org Bug: 780398 Change-Id: Iab2f2612095ebf947bb0f86d0e3067119c53d1c9 Reviewed-on: https://chromium-review.googlesource.com/748743Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513098}
-
wutao authored
Create a flag to implement keyboard shortcut viewer. This flag will be removed once the feature is launched. Bug: 778874, 768932 Test: test new flag with command line, and chrome://flags. Change-Id: I7ea41f990059a52c4a3f008fff9f8b9ba30da938 Reviewed-on: https://chromium-review.googlesource.com/740943 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#513097}
-
Yoichi Osato authored
We clear old selected but not selected LayoutObject's SelectionState to kNone using LayoutObject::SetSelectionStateIfNeeded(). However the function calls virtual LayoutObject::SetSelectionState(), which change containing blocks' SelectionState. This causes inconsistency that marked not kNone LayoutObject can accidentally marked kNone. This patch changes it to call non virtual LayoutObject::SetSelectionState() and assign kNone SelectionState to only target old selected LayoutObjects. Bug: 739062 Change-Id: I9ca736de43a2a982b1e29a1607325a1b77e3c35f Reviewed-on: https://chromium-review.googlesource.com/748841 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513096}
-
Greg Thompson authored
Tests in the interative_ui_tests fixture are known to timeout if there's an always-on-top window on the desktop. This change introduces a few improvements to the existing data collection strategy to help diagnose the provenance of these always-on-top windows. - Checks for always-on-top windows are moved out of the test child processes and up to the parent test proc. This is a more reliable place to log any info, as such log messages are more likely to make it into the main swarming log output. This is a result of the way GetTestOutputSnippet pulls what it thinks is the only relevant test output -- it drops messages emitted outside of the test body. - Scans for always-on-top windows now take place before running any test in the shard and after any test that times out. - A screen snapshot is saved if any always-on-top window is found, even in the case of dialogs that will be closed. - An attempt is made to find and emit the command lines for all processes in the process hierarchy of the proc owning an always-on-top window. - All details are emitted in a single log message. For example: There is an always on top window on the desktop after this test timed out. This may have been caused by this test or a previous test and may cause flakes; window class name: ConsoleWindowClass; subprocess command line: "".\interactive_ui_tests.exe" --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=AutofillInteractiveTest.AutofillViaClick --single_process --snapshot-output-dir="e:\b\s\w\iomhwbd8" --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6396_16240\results6396_26680\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iomhwbd8\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir6396_16240\d6396_27306""; owning process lineage: (process_id: 2000, command_line: "C:\Windows\system32\cmd.exe /c ""C:\Users\chrome-bot\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup\run_swarm_bot.bat" ""), (process_id: 1496, command_line: "C:\Windows\Explorer.EXE"); screen snapshot saved to file: "e:\b\s\w\iomhwbd8\ss_20171030114011_636.png"; BUG=764415 R=sky@chromium.org Change-Id: I1aed3a41542680b197c7856e1f5d9ec9af6e3774 Reviewed-on: https://chromium-review.googlesource.com/737641Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#513095}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/c1f14fbea92b..e88ec8eed5a4 $ git log c1f14fbea..e88ec8eed --date=short --no-merges --format='%ad %ae %s' 2017-10-31 jmadill Vulkan: Refactor GarbageObject. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.angle:android_angle_rel_ng,android_angle_deqp_rel_ng,linux_angle_rel_ng,linux_angle_dbg_ng,linux_angle_deqp_rel_ng,linux_angle_ozone_rel_ng,mac_angle_rel_ng,mac_angle_dbg_ng,win_angle_rel_ng,win_angle_dbg_ng,win_angle_x64_rel_ng,win_angle_x64_dbg_ng,win_angle_deqp_rel_ng,win_angle_x64_deqp_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I9640a7405b0f235657dbf178862712f5c5c2dd60 Reviewed-on: https://chromium-review.googlesource.com/748903Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513094}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3987906..51e24003 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I75b68b1278937a3d796bb263225cee9c0c13261d Reviewed-on: https://chromium-review.googlesource.com/748803Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#513093}
-
Makoto Shimazu authored
TBR=kochi@chromium.org Bug: 780386 Change-Id: If4286a902cde9c33ef04aebc648b9f5ad822601d Reviewed-on: https://chromium-review.googlesource.com/748462Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#513092}
-
Greg Thompson authored
This allows consumers of TestLauncher and content::LaunchTests to take action on child process timeout before the process is terminated. BUG=764415 R=phajdan.jr@chromium.org,sky@chromium.org Change-Id: Iccb359273c464f1e660a079af92edfc7feed817f Reviewed-on: https://chromium-review.googlesource.com/746701 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#513091}
-
Hayato Ito authored
Format js files by "clang-format -i <file>". TBR=kochi@chromium.org Change-Id: I28f5a0885688928dcb8b40e8f0abcedfdc6a30c5 Reviewed-on: https://chromium-review.googlesource.com/748921Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#513090}
-
Greg Thompson authored
Originally, LaunchChildGTestProcess took a single callback that was run on the caller's thread when all processing was done for the child process. Eventually, a second callback was added to give consumers a chance to act immediately on process launch. This here change switches from two callbacks to an observer interface in preparation for a third observation point. BUG=764415 R=sky@chromium.org,phajdan.jr@chromium.org Change-Id: I38a8a99a78007d4598e650b85d9936beb1ef6a1e Reviewed-on: https://chromium-review.googlesource.com/746682 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#513089}
-