- 03 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d5dec09c44de..45929d74770b 2020-08-03 janscheffler@chromium.org Migrate `front_end/main` to `devtools_entrypoint` 2020-08-03 t-olfly@microsoft.com Source Order Viewer Experiment Location 2020-08-03 janscheffler@chromium.org Migrate `front_end/protocol_monitor` to `devtools_entrypoint` 2020-08-03 janscheffler@chromium.org Migrate `front_end/input` to `devtools_entrypoint` 2020-08-03 janscheffler@chromium.org Migrate `front_end/web_audio` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4bf6bf34202a56b7c090a5c08598dee954c83de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794256}
-
Nick Diego Yamane authored
WaylandConnection initialization is considered done once at least one of the wl_outputs advertised gets its "done" event (ie: all its metadata was already received, ie: size, origin, mode, etc), which has been working well so far, at least with the Wayland compositors tested until now. It turns out that such initialization is broken for multi-screen scenarios, where the compositor sends events in the following order: ... wl_registry::global for wl_output object 1 wl_registry::global for wl_output object 2 wl_output::geometry for wl_output 1 wl_output::mode for wl_output 1 <-- output 1 ready wl_output::geometry for wl_output 2 wl_output::mode for wl_output 2 <-- output 2 ready ... This is how Exo compositor sends the events, which leads Ozone/Wayland to crash at startup. To fix it, this patch modifies code that deals with wl_output and WaylandScreen so that it only creates display::Display objects for wl_outputs once they are "ready" (ie: all required metadata already received from the server). In addition, some cleanup and minor fixes are made. R=tonikitoo@igalia.com Bug: 1111905 Test: Covered by unit tests. Change-Id: I25d23c5a76d0b2ab900bab4460344cf908db07e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332844 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#794255}
-
Xiaocheng Hu authored
Bug: 443467 Change-Id: I8e6ddb0381bfe9aee8cbfe63bdf0dc644569b0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330056 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#794254}
-
Tom Anderson authored
R=sky Bug: 955316 Change-Id: I24701fa5e7c51d2469f980acafbe61a1e078818e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335477 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#794253}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4b9b34558fe5..7b9da25e1b8b 2020-08-03 ethannicholas@google.com Can now swizzle SkSL scalars 2020-08-03 jvanverth@google.com Revise GrMtlGpu::onUpdateBackendTexture. 2020-08-03 herb@google.com add chrome bug triage to the Sheriff's Documentation 2020-08-03 herb@google.com move source padding to the AtlasLocator 2020-08-03 brianosman@google.com Always send premul paint color to shader FPs 2020-08-03 johnstiles@google.com Enable ClangTidy check modernize-make-unique. 2020-08-03 jvanverth@google.com Fix texture errors on iOS Metal 2020-08-03 reed@google.com Add arc methods to path builder 2020-08-03 jvanverth@google.com Remove unused dynamic allocation code from GrMtlResourceProvider. 2020-08-03 cwallez@chromium.org GN: Add support for GN's framework variable in the toolchain 2020-08-03 johnstiles@google.com Increase ClangTidy code coverage by enabling features. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I7e86849b892cceaa00bf1930970d8603c34a41fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335562Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596459406-112652fc3cbb93a8d59d2edad7ed0033698f8002.profdata to chrome-win32-master-1596470392-1db0b1fcfff2e5dea91624929cca8d9002b8d6ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iad21a6bcb5d093bac10eb2b767fbf7185f9e351c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335594Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: I422630785b5b3a441de4a6bd627e7525c6e64bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296061 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/981002aea991..9dedfc814fbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rajendrant@google.com,gayane@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033067,chromium:1108305,chromium:1111514,chromium:1112125 Tbr: rajendrant@google.com,gayane@google.com Change-Id: Ifd83a974f420cadfc1137810517672b58f109e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335534Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794249}
-
Clark DuVall authored
This is how WebLayer will be run in the field, and there are some edge cases where it's hard for the client app to call initializeWebViewCompatibilityMode() before WebLayer is used. This also removes some of the version checking logic which was needed when we supported versions < 82. Now 82 is our minimum version, so this should no longer be needed. Bug: 1111511 Change-Id: Iedce8bc31b82d1a38d5910dc1c3d3b6c5edd6258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333056Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#794248}
-
David Tseng authored
AX-Relnotes: Volume key adjustments no longer stop read to end/Search+R in ChromeVox. Test: currently manual; automated tests tbd. Fixed: 913264 Change-Id: I61503592b2e2262b5e2036c895341a1301d60739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333051Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#794247}
-
Andrei-Laurențiu Olteanu authored
Implement GetAvailableRoutines that exposes the same interface from cros_healthd to chrome-trusted. Add converters for types used by GetAvailableRoutines. Bug: b:162051831 Change-Id: I925dc22824a8adb52cc33b3296d80c21ed7d32ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312417Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#794246}
-
Ulan Degenbaev authored
Bug: 1085129 Change-Id: I5ad0528aac918934395eca23b0bb66157638e9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329592Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794245}
-
Andrew Xu authored
Usually the clipboard history menu is anchored at the caret's location. This CL anchors the history menu at the cursor's location when there is no textfield. In addition, some apps may provide unreliable caret's bounds, such as Google Doc. The menu is also anchored at the cursor's location in that case. Subsequent CLs will solve the unreliable caret bounds thoroughly. A browser test is created to protect this feature. Bug: 1110027 Change-Id: I30f31b0ab89542b5c7f63ebd25257dc765f57929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328191 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794244}
-
Mihai Sardarescu authored
This CL removes the hack to write the CHROME_CONNECTED cookie using a WKWebView and instead uses the cookie manager API. This works well as the Chrome iOS cookie manager is now backed by the WKHTTPCookieStore. Bug: 1102794 Change-Id: Ida2d74372616ce8331eadbde507fb131e4afa0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323901 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#794243}
-
David Grogan authored
Flex gaps had no problems in the M84 rollout. Bug: 762679 Change-Id: Ib776156c3344998cb460feb24e224d0281321966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334471 Commit-Queue: David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#794242}
-
Sujie Zhu authored
We plan to launch to 100% stable so set AutofillEnableSurfacingServerCardNickname enabled by default. Bug: 1059087 Change-Id: Ide8962f9995c4bea2f95a137b4f53578bb2b2561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334102Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#794241}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4b656a010be5..c6f029c304ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic3c5876255acff987fd65c696221f5013300b6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335335Reviewed-by:
-
Matt Jones authored
TabsTests are almost completely deflaked with the exception of text occasionally be incorrectly selected in testTabSwitcherCollapseSelection. This speculative fix will hopefully deflake by scrolling the correct direction in the test and above what should be empty space on the web page and adding arbitrarily long content area to scroll on. Flakes can be found here: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testTabSwitcherCollapseSelection Bug: 799728 Change-Id: I47eb6e9e5439fe545d71889a75886fdee2edf618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334821Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#794239}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b5aa09d7531b..9a482652ab18 2020-08-03 treehugger-gerrit@google.com Merge "trace-processor: Add extensions once" 2020-08-03 treehugger-gerrit@google.com Merge "Update language to comply with Android's inclusive language guidance" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8878097ee47c6a2a8d4b8b9d5a165510b2ed0fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335551Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d6c02e4a..e2a0b5a6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If61a8d4c2cc3d4216861992608dd84a22a1d6a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334577Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#794237}
-
Rohit Rao authored
Multiple test files were defined classes named TestWebState in the global namespace, which is an ODR violations and was causing crashes in ios_chrome_unittests. Since these are all test-specific helpers, this CL moves them into anonymous namespaces. BUG=None Change-Id: If9ca07916e8d0a5063bb45abe3f971f58c224150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335336Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#794236}
-
Carlos IL authored
Adds a rectangle that gradients from omnibox background color to transparent on the left side of the omnibox, and an inverted one to the right. The rectangles are used as gradient masks when an elide animation is running, to smooth out the color transition at the end. The mask is fixed size, except if they would obscure the not-elided part of the URL, in which case they shrink. Screencast of change (public link): https://docs.google.com/presentation/d/1AGXJNkt8_oQyPLSDOfAGduscL0LRCCUcZq5XtJo2eC0/edit?usp=sharing Bug: 1106467 Change-Id: Ic5029bbc850285ebe4e5e76a5a3d810c965f7e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321883 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#794235}
-
Michael Giuffrida authored
With legacy supervised profiles no longer available, these classes can be removed. Bug: None Change-Id: I90a014ca6c862b8ac3040032e0355bf3e635b756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318560 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794234}
-
Guillaume Jenkins authored
Adds support for the CloudPolicyOverridesPlatformPolicy policy, which controls whether policies fetched from CBCM should take precedence over policies found on the device. This policy is a requirement for launching CBCM. For now, it is declared as a Future policy for iOS until iOS CBCM is launched. Bug: 1066495 Change-Id: I5b2ce20e2f2b435992f84747a47a3c2ea0f14273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332322Reviewed-by:
-
Yue Zhang authored
* Adjust height of the title from 58px to 64px. * Add a 16px top margin to the title. Bug: 1077458 Change-Id: I1c82831e873432f206379bebef11cf604ce3eaac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335497Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#794232}
-
Liquan (Max) Gu authored
Change: * Separate ProvidePaymentInformation into two parts - the business logic goes into recordShowEventAndTransactionAmount and remains in PRImpl, the UI logic remains in providePaymentInformation (renamed into providePaymentInformationToPaymentRequestUI for clarity) and gets moved into PaymentUIsManager. * For the sake of decoupling UI and the business logic in enableUserInterfaceAfterPaymentRequestUpdateEvent(), the inline business logic is moved out of the method. Bug: 1102522 Change-Id: Ifb639c31bf0f3abcd56e415c8cce1d933a4fdd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324571 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#794231}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/01a0945e034b..6c7b829e5473 2020-08-03 tikuta@chromium.org remove reference to jumbo build If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:994387 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I5a4d9609f39735708c21314447cba7237b87f1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335550Reviewed-by:
-
Michael Moss authored
This is primarily needed to bring in symupload v2 protocol support on Mac. a6218eb Fix v1 symupload protocol in Mac client. a740aa2 Fix Mac symupload non-XCode builds 28d7cbd Check for tombstone as very first entry in the line table 7d65240 Properly handle new tombstone values that now appear 1143368 Port new symbol API to symupload on Mac 428a01e There are source files with APSL-2.0 as well 2e6f8de Add 3-clause BSD license text as well 678c4c5 Include libunwind license in LICENSE file 721108f fix NDEBUG breakage with new dwarf5 code 09b0569 fix pointer style to match the style guide a741027 Add support for dwarf5 line tables b6f36dd Move GetSectionByName out of CompilationUnit 8efe0f1 Read dwarf5 compilation unit headers 72c118f Add and handle various dwarf5 addrx forms feb2dca Add and handle new dwarf5 string-related forms BUG=1021742 R=nbilling@google.com, rohitrao@chromium.org Change-Id: I84dc9efdbbecbeb9d40aae2cbe1df79e491c2bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335357Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#794229}
-
Jongmok Kim authored
Uses explicit deletion instead, removes use of base/macros.h. Bug: 1010217 Change-Id: I67e2e009d242537186e5feb0f2992fe44b35cecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325526 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#794228}
-
Olivier Robin authored
Due to a bug in iOS 13 multiwindow system, touch events randomly do not set the keyWindow. The result is that you can interact with a page and continue to tap in another page. This is specially bad for autofill, where it becomes possible to fill private information in the wrong page. This CL keep track of the last window that has been tapped and disables autofill if this is not the keywindow. Bug: 1109124 Change-Id: I6ef0797ca74f425999fe30e607541bc6757ffcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317345 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Omer Katz authored
Bug: 986235 Change-Id: Ifba84fb0880c668e3c1f6bc276d1f7beacea4261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332629Reviewed-by:
-
Ben Pastene authored
When '--' is present on the cmd line, anything to the right of it is considered args to the test binary and will be pass untouched to it. This also adds the '--' arg to all isolated-script tests, which is practically only telemetry tests. Bug: 1108412 Change-Id: Iec53e68d39c0bbe947ebdc166426d6b4c848e892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318309 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#794225}
-
Darin Fisher authored
Compile all OS_CHROMEOS code from //base/system/* as part of the Lacros build. Bug: 1096590 Change-Id: I5b1d3b75fc823f57c807928e4e0a7f1cdb98b54f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332568Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794224}
-
Yi Gu authored
Transfer the ownership to the TL since I have left the team. Bug: None Change-Id: I2d8aac8f336555513eb4cd0101848117b7ce5322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332987Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794223}
-
nancylingwang authored
For the standard icon/adaptive icon, the icon effect kCrOsStandardIcon is applied, so modify the test case, to use the kCrOsStandardIcon effect for it. BUG=1083331 Change-Id: I6bdf18aa70eb07f7df94bd3a83cd490df722c0b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332002 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Jit Yao Yap <jityao@google.com> Reviewed-by:
-
Raymond Toy authored
These analyser tests use a ScriptProcessorNode with 0 outputs. That's not actually well-defined in the spec. so create the node with one output. And also connect the node to the destination so that Chrome will process it. (Yes, that's a bug in chrome for a deprecated ScriptProcessorNode.) Update TestExpectations too. Bug: 626703 Change-Id: I5f21e6b96c55ff66f76e43b3c7dbc7b2c2635656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316791Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#794221}
-
Sinan Sahin authored
BrowserControlsManager#setTab() restores controls positions for the tab the user switches to. This caused a bug with the status indicator where the native page would have its old controls offsets restored even after the status indicator is shown. This CL prevents the situation above by showing the controls when the controls are restored for a native page. Bug: 1111202 Change-Id: I75bb1f9d9851800f123bc6bab87307a191696202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332567 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#794220}
-
Laís Minchillo authored
Fixed: 1100373 Change-Id: I7b7be3a67eaa96529e2b23e7f1a4138f1ba2287c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335436 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#794219}
-
Xianzhu Wang authored
This reverts commit 491b5a9c. The original CL was reverted because it caused failure on MSAN bots due to use of uninitialized value. The reason was that PaintInvalidatorContext::tree_builder_context_ pointed into an PrePaintTreeWalkContext entry in a vector, and the vector could be reallocated when we added new entries, causing the pointer in the parent PaintInvalidatorContext to point to an invalid address. Now remove PaintInvalidatorContext::tree_builder_context_ and add PaintInvalidatorContext::transform_ (which was the only used information from the parent PaintInvalidatorContext) to avoid the problem. Original change's description: > Revert "Use border box or layout overflow rect for layout shift tracking" > > This reverts commit 0933392f. > > Reason for revert: ASAN/MSAN failures due to "use of uninitialized value"; see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8873209606965810848/+/steps/browser_tests/0/logs/Deterministic_failure:_AllForms__x2f_FormStructureBrowserTest.DataDrivenHeuristics__x2f_148__status_FAILURE_/0 > > Original change's description: > > Use border box or layout overflow rect for layout shift tracking > > > > This CL addresses the following issues of layout shift tracking: > > - Changed visual overflows triggered layout shift report > > (originally filed as crbug.com/1090763). > > - Descendant layout overflows were not included in ancestor's layout > > shift report. > > - Unnecessary descendant layout shift report. > > - Slow visual rect calculation for LayoutInline and LayoutText. > > > > It includes the following changes > > - Track LayoutBoxes and LayoutTexts only. > > - Track both old and new starting points and visual representations > > instead of using location of visual rects as starting points. > > - For a LayoutBox, the local visual representation is the layout > > overflow rect if the LayoutBox has layout overflow and doesn't clip > > overflow. Otherwise use the border box rect. > > - For a LayoutText, suppose its shift causes shift of all contents > > in containing block logically below the LayoutText, and use that > > part of visual representation of the containing block as the visual > > representation of the shift. > > - Map both local starting points and local visual representations to > > the initial containing block and viewport. > > > > This has the following benefits: > > - More accurate starting points and visual representations, conforming > > to the specs; > > - Better performance by > > * avoiding unnecessary layout shift reports of descendants > > * avoiding slow LayoutInline and LayoutText visual rect calculation. > > - sizeof(LayoutObject) is reduced by 16 bytes because now we use the > > previous geometry data in LayoutBoxes for paint invalidation. > > > > Bug: 1108622 > > Change-Id: I7ebb4e250e7ca2a03b4dadea50034e300e55ad84 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319538 > > Reviewed-by: Steve Kobes <skobes@chromium.org> > > Reviewed-by: Koji Ishii <kojii@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#793806} > > TBR=wangxianzhu@chromium.org,skobes@chromium.org,kojii@chromium.org > > Change-Id: I590f2abc4a48ba65bdfe7a948ffce00b299f9e06 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1108622 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333578 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793874} # Not skipping CQ checks because this is a reland. Bug: 1108622 Change-Id: I253a24799b6d2a3af346d4f65e3889217064b035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333648Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#794218}
-
Jan Wilken Dörrie authored
This change is part of a series of changes that replacs usages of base::string16 with std::wstring in chrome/chrome_cleaner and fixes appropriate includes. This CL fixes the following subdirectories: * chrome/chrome_cleaner/executables * chrome/chrome_cleaner/http * chrome/chrome_cleaner/ipc * chrome/chrome_cleaner/logging * chrome/chrome_cleaner/mojom This change is a simple search and replace and does not effect any functionality. Bug: 911896 Change-Id: I2d4ed44769b00090e2bcc38d92f259352fcf43b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332717Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#794217}
-
