Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 07 Feb, 2015 11 commits
    • aiolos's avatar
      Only download from cloud_storage when a bucket parameter is used in the... · 681ceae0
      aiolos authored 
      Only download from cloud_storage when a bucket parameter is used in the user_story. Use system_stub instead of going over the network in user_story_runner_unittest.

BUG=447462

Review URL: https://codereview.chromium.org/903083004

Cr-Commit-Position: refs/heads/master@{#315152}
      681ceae0
    • ananta's avatar
      Support low latency mode decoding in the H/W video decoder on Windows. · 6e74dc46
      ananta authored 
      This is enabled via an attribute CODECAPI_AVLowLatencyMode set on the decoder transform.
From testing I could see a reduction in the number of input packets before the first output frame was delivered
by the decoder. On vimeo, with this attribute, the first output frame came after 9-10 input packets. Without it
after 25-30 input packets. On the HTML5 quirksmode site, with this attribute the first output frame came after 9-11 input
packets. Without it it came after 16-17 input packets.

We can enable this on Canary to see how this fares in the wild.

BUG=456359

Review URL: https://codereview.chromium.org/890603004

Cr-Commit-Position: refs/heads/master@{#315151}
      6e74dc46
    • garykac's avatar
      [Chromoting] Remove wildcard ('*') from remoting_all target. · 9fb75ed8
      garykac authored 
      Support for the wildcard is going away in GN, so this helps prepare for the transition away from GYP.

This cl adds dummy targets so that that logic for when the proper targets should be build can be kept in the platform-specific files.

Some of the conditions in the host gyp files needed to be restructured so that the dummy targets would be defined only when necessary.  The updated conditions caused a lot of lines to be re-indented, but the target definitions are the same (except for the new dummy targets).

BUG=

Review URL: https://codereview.chromium.org/896743004

Cr-Commit-Position: refs/heads/master@{#315150}
      9fb75ed8
    • kalman's avatar
      Replace the ExtensionHost load UMAs (Extensions.BackgroundPageLoadTime and · 30114511
      kalman authored 
      friends) to measure the time from the URL starting to load to it loading.
Extensions.BackgroundPageLoadTime2 replaces Extensions.BackgroundPageLoadTime
etc.

Previously it measured from ExtensionHost construction to it loading, which is
wrong because URL loading can be deferred in a queue, or callers just might not
try to load it until later.

Also do a bit of UMA cleanup: delete some of the Extension page load UMA that
isn't used anymore, and add back the Extensions.PopupLoadTime2 load UMA which
was forgotten about at some point.

R=yoz@chromium.org, isherman@chromium.org
BUG=453073

Review URL: https://codereview.chromium.org/902963002

Cr-Commit-Position: refs/heads/master@{#315149}
      30114511
    • jbudorick's avatar
      [Android] Convert ContentShellTest.apk to isolate. · 4cf59ffa
      jbudorick authored 
      We were previously using --test-data to push files from
//content/test/data/android/device_files to
$EXTERNAL_STORAGE/chrome/test/data/content. Switching to isolate lets
us handle all of our instrumentation and gtest data dependencies in the
same way. It will also facilitate using isolate to optimize transfers
between builders and testers.

BUG=400499
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/878163004

Cr-Commit-Position: refs/heads/master@{#315148}
      4cf59ffa
    • rdevlin.cronin's avatar
      [Extensions] Propagate activeTab hosts to extension background pages · c491dbfa
      rdevlin.cronin authored 
      Let extensions with active tab use XHR in background pages to any hosts that
they have active tab on.
Also move tab_finder to //extensions.

BUG=452688

Review URL: https://codereview.chromium.org/890083002

Cr-Commit-Position: refs/heads/master@{#315147}
      c491dbfa
    • michaelpg's avatar
      Add md_settings to WATCHLISTS · 32ca0790
      michaelpg authored 
      Review URL: https://codereview.chromium.org/905883002

Cr-Commit-Position: refs/heads/master@{#315146}
      32ca0790
    • rch's avatar
      Revert of NaCl: Update revision in DEPS, 2363d1a -> a3e1e94 (patchset #1 id:1... · b6ac2651
      rch authored 
      Revert of NaCl: Update revision in DEPS, 2363d1a -> a3e1e94 (patchset #1 id:1 of https://codereview.chromium.org/905793003/)

Reason for revert:
Looks like it broke the build:

http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/42375/steps/compile/logs/stdio

FAILED: cd ../../remoting; python ../native_client/build/build_nexe.py --root .. --product-dir ../out/Release/xyz --config-name Release -t ../out/Release/gen/sdk/ --arch pnacl --build newlib_pexe --name ../out/Release/remoting_key_tester_newlib.pexe --objdir ../out/Release/obj/remoting/remoting_key_tester_pexe.gen/pnacl_newlib/remoting_key_tester_pexe "--include-dirs=../out/Release/gen/tc_pnacl_newlib/include .. .. \"../out/Release/gen\"" "--compile_flags=-O2 -g -Wall -fdiagnostics-show-option -Werror  -gline-tables-only -Wno-unused-function -Wno-char-subscripts -Wno-c++11-extensions -Wno-unnamed-type-template-args -Wno-extra-semi -Wno-unused-private-field -Wno-char-subscripts -Wno-unused-function " --gomadir /mnt/data/b/build/goma "--defines=\"__STDC_LIMIT_MACROS=1\" \"__STDC_FORMAT_MACROS=1\" \"_GNU_SOURCE=1\" \"_DEFAULT_SOURCE=1\" \"_BSD_SOURCE=1\" \"_POSIX_C_SOURCE=199506\" \"_XOPEN_SOURCE=600\" \"DYNAMIC_ANNOTATIONS_ENABLED=1\" \"DYNAMIC_ANNOTATIONS_PREFIX=NACL_\" \"NACL_BUILD_ARCH=x86\" \"BINARY_CORE=1\" \"BINARY_DESKTOP=2\" \"BINARY_HOST_ME2ME=3\" \"BINARY_NATIVE_MESSAGING_HOST=4\" \"BINARY_REMOTE_ASSISTANCE_HOST=5\" V8_DEPRECATION_WARNINGS \"_FILE_OFFSET_BITS=64\" CHROMIUM_BUILD \"CR_CLANG_REVISION=223108\" \"TOOLKIT_VIEWS=1\" UI_COMPOSITOR_IMAGE_TRANSPORT \"USE_AURA=1\" \"USE_ASH=1\" \"USE_PANGO=1\" \"USE_CAIRO=1\" \"USE_DEFAULT_RENDER_THEME=1\" \"USE_LIBJPEG_TURBO=1\" \"USE_X11=1\" \"USE_CLIPBOARD_AURAX11=1\" ENABLE_ONE_CLICK_SIGNIN ENABLE_PRE_SYNC_BACKUP \"ENABLE_REMOTING=1\" \"ENABLE_WEBRTC=1\" ENABLE_PEPPER_CDMS ENABLE_CONFIGURATION_POLICY ENABLE_NOTIFICATIONS USE_UDEV DONT_EMBED_BUILD_METADATA \"ENABLE_TASK_MANAGER=1\" \"ENABLE_EXTENSIONS=1\" \"ENABLE_PLUGINS=1\" \"ENABLE_SESSION_SERVICE=1\" \"ENABLE_THEMES=1\" \"ENABLE_AUTOFILL_DIALOG=1\" \"ENABLE_BACKGROUND=1\" \"ENABLE_GOOGLE_NOW=1\" \"CLD_VERSION=2\" \"ENABLE_PRINTING=1\" \"ENABLE_BASIC_PRINTING=1\" \"ENABLE_PRINT_PREVIEW=1\" \"ENABLE_SPELLCHECK=1\" \"ENABLE_CAPTIVE_PORTAL_DETECTION=1\" \"ENABLE_APP_LIST=1\" \"ENABLE_SETTINGS_APP=1\" \"ENABLE_SUPERVISED_USERS=1\" \"ENABLE_MDNS=1\" \"ENABLE_SERVICE_DISCOVERY=1\" V8_USE_EXTERNAL_STARTUP_DATA \"USE_LIBPCI=1\" \"USE_GLIB=1\" \"USE_NSS=1\" __STDC_CONSTANT_MACROS __STDC_FORMAT_MACROS" "--link_flags=-B../out/Release/gen/tc_pnacl_newlib/lib -O3 -lppapi_stub -lppapi_cpp" "--source-list=../out/gypfiles/remoting/pnacl_newlib.remoting_key_tester_pexe.source_list.gypcmd"
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/bin/le32-nacl-ld.gold:error: cannot open ../out/Release/gen/tc_pnacl_newlib/lib/libnacl.a: No such file or directory
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to '_realloc_r'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'read'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'close'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'lseek'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to '_calloc_r'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'isatty'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to 'fstat'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to '_free_r'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc.a:error: undefined reference to '_malloc_r'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to '__pthread_initialize_minimal'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to '__nacl_tls_initialize_memory'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to 'calloc'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to '__nacl_tls_combined_size'
../out/Release/gen/tc_pnacl_newlib/lib/libpthread.a:error: undefined reference to '__libnacl_mandatory_irt_query'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc++.a:error: undefined reference to 'malloc'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/le32-nacl/lib/libc++.a:error: undefined reference to 'free'
../out/Release/gen/tc_pnacl_newlib/lib/libppapi_stub.a:error: undefined reference to '_exit'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/lib/clang/3.5.0/lib/le32-nacl/unwind_stubs.bc:error: undefined reference to 'write'
/mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/gen/sdk/linux_x86/pnacl_newlib/lib/clang/3.5.0/lib/le32-nacl/unwind_stubs.bc:error: undefined reference to 'abort'
FAILED with 1: ../out/Release/gen/sdk/linux_x86/pnacl_newlib/bin/pnacl-clang++ -o ../out/Release/remoting_key_tester_newlib.pexe.debug -Wl,--as-needed ../out/Release/obj/remoting/remoting_key_tester_pexe.gen/pnacl_newlib/remoting_key_tester_pexe/remoting_key_tester_61dcf3bc.o -B../out/Release/gen/tc_pnacl_newlib/lib -O3 -lppapi_stub -lppapi_cpp

Original issue's description:
> NaCl: Update revision in DEPS, 2363d1a -> a3e1e94
>
> This pulls in the following Native Client changes:
>
> 6c11549: (mseaborn@chromium.org) Add IRT interface for PNaCl's sandboxed linker to use to talk to Chromium
> 9fff96b: (teravest@chromium.org) NaCl: Remove use of NACL_BUILD_* in common.gypi.
> 76d6d4b: (mseaborn@chromium.org) PNaCl: Update Binutils revision in pnacl/COMPONENT_REVISIONS: use new IRT interface
> a3e1e94: (jfb@chromium.org) Delete Windows time code
>
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build
>
> Committed: https://crrev.com/accbfa1e86e32df669fad209185cba4acd6847be
> Cr-Commit-Position: refs/heads/master@{#315133}

TBR=jfb@chromium.org,mseaborn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/905043002

Cr-Commit-Position: refs/heads/master@{#315145}
      b6ac2651
    • Ryan Hamilton's avatar
      Disable flaky test InlineLoginUISafeIframeBrowserTest.NavigationToOtherChromeURLDisallowed · a26b9dd2
      Ryan Hamilton authored 
      TBR=bauerb@chromium.org
BUG=456375

Review URL: https://codereview.chromium.org/893843009

Cr-Commit-Position: refs/heads/master@{#315144}
      a26b9dd2
    • Arman Uguray's avatar
      DEPS: Roll third_party/cros_system_api · b8854d2b
      Arman Uguray authored 
      Roll third_party/cros_system_api to 286cec023e90f54f391fe32bae512f9ec7b4e807

BUG=407773
TBR=benchan@chromium.org

Review URL: https://codereview.chromium.org/909543003

Cr-Commit-Position: refs/heads/master@{#315143}
      b8854d2b
    • lazyboy's avatar
      Fix OSX IME, Call RVH::SetInputMethodActive() after Attach. · 8b0b5d0c
      lazyboy authored 
      This broke quite a bit ago when the implicit ordering changed by refactoring.
It is unfortunate that we don't have test coverage for mac, and
trying to type accent characters (IME) from browsertest didn't work.

BUG=450641
Test=On mac, load a chrome app with <webview> that has an input box.
Try to type accent chars, e.g. Option+e followed by e. Proper chars
should be seen in the input box.

Review URL: https://codereview.chromium.org/904013002

Cr-Commit-Position: refs/heads/master@{#315142}
      8b0b5d0c
  3. 06 Feb, 2015 29 commits