GitLab

When a download is detected as malicious by the safe browsing service, the download shelf now displays a warning message along with a 'Discard' button and a drop down menu with additional actions.

BUG=102540
TEST=Initiating a download that is flagged as malicious by the safe browsing service causes the new malicious download warning to be displayed on the download shelf.


Review URL: http://codereview.chromium.org/8757007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112954 0039d316-1c4b-4281-b951-d872f2087c98

If the user is already logged in pre M17 and user sets
up notifications, the user will be asked to sign in.
AppNOtifyChannelUI::OnStateChanged is called more than
once before the oauth2 token is generated.

Fix it by:
Remembering if the wizard ever became visible instead of
whether the callback happened once.
Review URL: http://codereview.chromium.org/8787013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112953 0039d316-1c4b-4281-b951-d872f2087c98

Add chromeos tab to chrome://net-internals.
Move ONC file import input field to chromeos tab, from network options.
Support for encrypted onc files.
Fix net_internals browser test.

BUG=chromium-os:23472,chromium-os:19397
TEST=Go to chrome://net-internals, click on chromeos tab. Should be able to import an onc file from there. If the file is encrypted, should be prompted for a passcode.

Review URL: http://codereview.chromium.org/8741009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112952 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112951 0039d316-1c4b-4281-b951-d872f2087c98

This DEPS roll pulls in a new script for downloading NaCl toolchains.

TRB= bradnelson@chromium.org
Review URL: http://codereview.chromium.org/8742033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112950 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112949 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vsevik

Review URL: http://codereview.chromium.org/8797001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112948 0039d316-1c4b-4281-b951-d872f2087c98

Capitalize column headers and buttons as appropriate for the platform.

BUG=none
TEST=Private Memory, Shared Memory, JavaScript cache, End process, etc. should have consistent capitalization


Review URL: http://codereview.chromium.org/8711001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112947 0039d316-1c4b-4281-b951-d872f2087c98

These objects were created differently than any other resoures. This cleans
them up to behave like the other resources.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8790009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112946 0039d316-1c4b-4281-b951-d872f2087c98

|printable_size| is a misnomer. |content_size| is correct.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8784012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112945 0039d316-1c4b-4281-b951-d872f2087c98

This is really re-landing 112937 and attempting to avoid a warning from the
Linux builder.

R=jar@chromium.org
BUG=106326
TEST=needs to run on the CQ


Review URL: http://codereview.chromium.org/8796006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112944 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jstritar@chromium.org
BUG=106331
TEST=valgrind bots go greener

Review URL: http://codereview.chromium.org/8797002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112943 0039d316-1c4b-4281-b951-d872f2087c98

It was enabled in r112775.

TBR=brettw@chromium.org
BUG=87625,104535
TEST=mac valgrind bots go greener

Review URL: http://codereview.chromium.org/8796008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112942 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jstritar@chromium.org
BUG=106331
TEST=memcheck and heapcheck bots report less leaks

Review URL: http://codereview.chromium.org/8796007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112941 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=112933&graph=chrome-si
http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=150&rev=112933&graph=chrome-si

BUG=94125
TEST=none
TBR=cmp
Review URL: http://codereview.chromium.org/8793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112940 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jar@chromium.org
BUG=106326
TEST=memcheck bots go greener

Review URL: http://codereview.chromium.org/8794004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112939 0039d316-1c4b-4281-b951-d872f2087c98

I'm going to TBR this, since it causes a bunch of redness
on the tree, and is really a supression.

tbr=rtenneti,mk
bug=106326
Review URL: http://codereview.chromium.org/8792005

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8796005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112938 0039d316-1c4b-4281-b951-d872f2087c98

I'm going to TBR this, since it causes a bunch of redness
on the tree, and is really a supression.

tbr=rtenneti,mk
bug=106326
Review URL: http://codereview.chromium.org/8792005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112937 0039d316-1c4b-4281-b951-d872f2087c98

this change is the first part of the FreeBSD support

BUG=
TEST=


Review URL: http://codereview.chromium.org/8773051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112936 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112933 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104645

Review URL: http://codereview.chromium.org/8787009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112931 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rtenneti
Review URL: http://codereview.chromium.org/8793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112930 0039d316-1c4b-4281-b951-d872f2087c98

Manual changes to spdy_protocol.h and spdy_framer.cc, rest of the CL generated by
running:
  perl -pi -e "s/SpdyFrame::size\(\)/SpdyFrame::kHeaderSize/" $(git grep -l SpdyFrame::size)

This is the same as the google-internal CL 25917366 and 25938381

BUG=94125
TEST=none
TBR=willchan

Review URL: http://codereview.chromium.org/8790015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112929 0039d316-1c4b-4281-b951-d872f2087c98

I also did some cleaning and refactoring in
tracked_objects.  We had a lot of functionality that
has migrated to JS, that we didn't need (a lot of
acccessors that are supplanted by the ToValue()
methods.

I'm anticipating that we'll move to an asynhcronous
collecting of data from the profiler, so that we can
bounce around to various threads and more cleanly
collect samples (without risking races during
data snapshots).  Several of the refactors are
heading in that direction.

r=rtenneti
tbr=jam (for microscopic content change)
BUG=106291,106293
Review URL: http://codereview.chromium.org/8775061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=31037
TEST=none in this patch, will be landed in WebKit as layout tests.

Review URL: http://codereview.chromium.org/8775025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112927 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112926 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vsevik

Review URL: http://codereview.chromium.org/8786007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112925 0039d316-1c4b-4281-b951-d872f2087c98

This CL has two fixes that were suggested in the above review.

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/8770057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112924 0039d316-1c4b-4281-b951-d872f2087c98

Strip invalid characters (line breaks, tabs), javascript:schemes from the copied text while pasting text, droping text and creating right click popup for omnibox.

BUG=82181, 103703

TEST=Copy a string with line breaks "\n" or tabs "\t".
Then right click on omnibox.
Chromium should not trigger DCHECKS.

Review URL: http://codereview.chromium.org/8702002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112923 0039d316-1c4b-4281-b951-d872f2087c98

This is needed because there can be two site instances for the
same extension/process pair. Boo.

The linear scan for Contains() is a bummer. I thought about
more exotic data structures, but it didn't seem worth it.

BUG=105328

Review URL: http://codereview.chromium.org/8769022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112921 0039d316-1c4b-4281-b951-d872f2087c98

The "chrome_url_overrides" manifest key is now accessible by packaged apps.

BUG=101992, 104103
TEST=existing, ManifestTest

Review URL: http://codereview.chromium.org/8654001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112914 0039d316-1c4b-4281-b951-d872f2087c98

They caused http://crbug.com/106304

BUG=99629
TEST=none
TBR=dmazzoni

Review URL: http://codereview.chromium.org/8793001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112913 0039d316-1c4b-4281-b951-d872f2087c98

Do not assume that the history_info_map_ will always contain entries for keys.

BUG=106192
TEST=With a big History database, type a single 'w' and verify that a crash does not occur. 'w' is chosen since it occurs in the bulk of URLs ('www'). Other common characters to test singly are 'c', 'h', 'm', 'o', 'p' and 't'.
Review URL: http://codereview.chromium.org/8785021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112910 0039d316-1c4b-4281-b951-d872f2087c98

. In aura, before a window is focused, ask the delegate if it can be focused.
. Make a popup RWHVA non-focusable.

This is to prevent the focus from moving from the main web-page to the combobox (which causes the combobox to get destroyed). This fixes an issue where comboboxes in the login screen could not be used properly.

BUG=105786
TEST=manually

Review URL: http://codereview.chromium.org/8770011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112909 0039d316-1c4b-4281-b951-d872f2087c98

Revert 112839 (it probably caused http://crbug.com/106299 ) - GTK: Port omnibox drawing from GdkGC interface to cairo.

GdkGC is deprecated and will be removed in gtk3 and cairo should be faster anyway. This uses the new CairoCachedSurface in gfx::Image.

BUG=79722
TEST=none


Review URL: http://codereview.chromium.org/8781001

TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/8789016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112905 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/mac-release/sizes/report.html?history=150&rev=-1&graph=chrome-si
http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=112878&graph=chrome-si
http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=150&rev=112878&graph=chrome-si

BUG=94925
TEST=none
TBR=cmp
Review URL: http://codereview.chromium.org/8784014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=csilv

Review URL: http://codereview.chromium.org/8784003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105028
TEST=none (browser side still missing, does nothing yet)


Review URL: http://codereview.chromium.org/8774050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112898 0039d316-1c4b-4281-b951-d872f2087c98

show a node, so we need it. *SIGH*

For the most part this is a revert of
http://codereview.chromium.org/8759017/, so don't feel you need to
review it that deeply.

BUG=102714 
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/8772064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104757
TEST=manual

Review URL: http://codereview.chromium.org/8745020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112892 0039d316-1c4b-4281-b951-d872f2087c98