GitLab

On Windows 8, always enabled accessibility for editable text controls.
So the base accessibility is AccessibilityModeEditableTextOnly.

R=aboxhall@chromium.org

BUG=

Review URL: https://codereview.chromium.org/545863002

Cr-Commit-Position: refs/heads/master@{#296562}

See bug for more context; this makes the "Accessibility" section show up
on all platforms, not just Chrome OS, and adds a link to the special
web store page with curated accessibility extensions.

BUG=416983

Review URL: https://codereview.chromium.org/599683002

Cr-Commit-Position: refs/heads/master@{#296561}

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/597413002

Cr-Commit-Position: refs/heads/master@{#296560}

This way the size should always remain the same regardless of the
origin. Also, it's important that we ceil here otherwise a round trip
for DIP to screen to DIP could result in a smaller value resulting in
all sorts of wierdness.

BUG=417392
TEST=see bug
R=ananta@chromium.org

Review URL: https://codereview.chromium.org/600103002

Cr-Commit-Position: refs/heads/master@{#296559}

This adds a rasterizer implementation explicitly used for
rasterizing to bitmap resources. Each rasterizer is already
aware of specific resource details and it is much easier
and less confusing to implement a different rasterizer that
handle bitmap resources then trying to emulate support for
GL-ish APIs that are used by other rasterizer implementations.

This allows us to clean up LTHI a bit and reduces the
complexity of the ResourceProvider class significantly.

It also makes future changes that will allow GpuMemoryBuffers
to be created and mapped in worker threads easier implement.

BUG=

Review URL: https://codereview.chromium.org/602493003

Cr-Commit-Position: refs/heads/master@{#296558}

This CL adds automatic "last used keyboard layout" for active user POD
on User Adding screen.

BUG=292774
TEST=manual

Review URL: https://codereview.chromium.org/602593003

Cr-Commit-Position: refs/heads/master@{#296557}

Revert of Revert of Fix doodle verification URL. (patchset #1 id:1 of https://codereview.chromium.org/599243002/)

Reason for revert:
The original revert was a mistake. Relanding this with no changed.

Original issue's description:
> Revert of Fix doodle verification URL. (patchset #3 id:40001 of https://codereview.chromium.org/587943003/)
>
> Reason for revert:
> Caused test failure:
> http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944
>
> Original issue's description:
> > Fix doodle verification URL.
> >
> > When verifying that the cached doodle is still valid, we load the doodle
> > URL and append the query param "async=es_dfp:<fingerprint>". Previously,
> > the ":" was being escape to "%3A", causing the server to respond with a
> > 400 error. This mollifies the server by keeping the colon unescaped.
> >
> > BUG=413845
> >
> > Committed: https://crrev.com/673cc76103079eaada968c537c6605dbaf8d909c
> > Cr-Commit-Position: refs/heads/master@{#296512}
>
> TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,newt@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=413845
>
> Committed: https://crrev.com/6101b6321585a402ffc7c45dbb4fc61bc36f0051
> Cr-Commit-Position: refs/heads/master@{#296546}

TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,groby@chromium.org,jiayl@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413845

Review URL: https://codereview.chromium.org/606443004

Cr-Commit-Position: refs/heads/master@{#296556}

Revert of [AiS] Merge answers into highest-scoring result (patchset #6 id:100001 of https://codereview.chromium.org/584653004/)

Reason for revert:
The new tests are flaky:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944

Original issue's description:
> [AiS] Merge answers into highest-scoring result
>
> Answer contents and type must always be copied to the highest-scoring
> suggestion, to ensure answers are not lost due to suggestion
> deduplication.
>
> BUG=415836
> R=mpearson
>
> Committed: https://crrev.com/978a4bf4a3be714950ed265660bd9566f7abd922
> Cr-Commit-Position: refs/heads/master@{#296520}

TBR=mpearson@google.com,mpearson@chromium.org,newt@chromium.org,groby@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415836

Review URL: https://codereview.chromium.org/598253002

Cr-Commit-Position: refs/heads/master@{#296555}

This race should be benign, because the count is just used for a heuristic and can't truly be synchronized anyway, but best to use a lock with the access.

BUG=417194

Review URL: https://codereview.chromium.org/604583002

Cr-Commit-Position: refs/heads/master@{#296554}

Revert of [Suggestions] Move ImageManager to the component (patchset #6 id:220001 of https://codereview.chromium.org/543753002/)

Reason for revert:
One of the new unit tests failed with uninit memory access: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/43137/

Original issue's description:
> [Suggestions] Move ImageManager to the component
>
> Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions.
>
> BUG=387751
> TBR=blundell
> TEST=ImageManagerTest,ImageFetcherBrowserTest
>
> Committed: https://crrev.com/5a25f30080dd57d200679546c970d70f2247def9
> Cr-Commit-Position: refs/heads/master@{#296503}

TBR=huangs@chromium.org,blundell@chromium.org,mathp@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=387751

Review URL: https://codereview.chromium.org/600203002

Cr-Commit-Position: refs/heads/master@{#296553}

BUG=397741

Review URL: https://codereview.chromium.org/601573002

Cr-Commit-Position: refs/heads/master@{#296552}

This is to intended to match the HTTP/2 static table:
http://http2.github.io/http2-spec/compression.html#static.table.definition (entry 16).

BUG=389914

Review URL: https://codereview.chromium.org/437353004

Cr-Commit-Position: refs/heads/master@{#296551}

BUG=412955

Review URL: https://codereview.chromium.org/595353003

Cr-Commit-Position: refs/heads/master@{#296550}

BUG=none
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/598833002

Cr-Commit-Position: refs/heads/master@{#296549}

BUG=414936
TEST=WindowManagertest.BezelGestureToSwitchBetweenWindows

Review URL: https://codereview.chromium.org/574113004

Cr-Commit-Position: refs/heads/master@{#296548}

EnhancedBookmarkBridge is only used in android platform and should be
moved to chrome/browser folder, bacause most bookmark services going
through this bridge requires profile.

BUG=415774

Review URL: https://codereview.chromium.org/597253003

Cr-Commit-Position: refs/heads/master@{#296547}

Revert of Fix doodle verification URL. (patchset #3 id:40001 of https://codereview.chromium.org/587943003/)

Reason for revert:
Caused test failure:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944

Original issue's description:
> Fix doodle verification URL.
>
> When verifying that the cached doodle is still valid, we load the doodle
> URL and append the query param "async=es_dfp:<fingerprint>". Previously,
> the ":" was being escape to "%3A", causing the server to respond with a
> 400 error. This mollifies the server by keeping the colon unescaped.
>
> BUG=413845
>
> Committed: https://crrev.com/673cc76103079eaada968c537c6605dbaf8d909c
> Cr-Commit-Position: refs/heads/master@{#296512}

TBR=justincohen@chromium.org,rsleevi@chromium.org,mmenke@chromium.org,newt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=413845

Review URL: https://codereview.chromium.org/599243002

Cr-Commit-Position: refs/heads/master@{#296546}

This was caused by some very slow running trybots. If the test was running significantly slower
than a second, a MemoryPressureNotifier event was able to be sent, which caused the ResourceManager
to perform some asynchronous action which is not wanted for these unit tests.

BUG=412537, 417189
TEST=AppActivityTes.TestUnloadProxyLocation, AppActivityTest.TestMultipleActivityUnloadLock

Review URL: https://codereview.chromium.org/598033004

Cr-Commit-Position: refs/heads/master@{#296545}

BUG=none
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/592353003

Cr-Commit-Position: refs/heads/master@{#296544}

Have TestRunner::OverridePreference() recognize "WebKitWebSecurityEnabled"
as a boolean preference which controls the web_security_enabled web
preference.

R=mkwst,jochen
BUG=254993

Review URL: https://codereview.chromium.org/601513002

Cr-Commit-Position: refs/heads/master@{#296543}

BUG=none
TBR=aa@chromium.org

Review URL: https://codereview.chromium.org/600153002

Cr-Commit-Position: refs/heads/master@{#296542}

Discussion thread:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/VTNZzizN0zo

NOTRY=true

Review URL: https://codereview.chromium.org/596723003

Cr-Commit-Position: refs/heads/master@{#296541}

Note: Currently this solution is implemented in the chrome module but once
ZoomController moves to extensions, zooming from embedder to guest should
move to GuestViewBase and a more general solution should be made available
for GuestView types that wish to receive this zoom plumbing.

BUG=416581

Review URL: https://codereview.chromium.org/598163003

Cr-Commit-Position: refs/heads/master@{#296540}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a8890fa..5777092

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/601913002

Cr-Commit-Position: refs/heads/master@{#296539}

Previous CL for adding base_search_provider_unittest.cc did not update
BUILD.gn - this CL does.

BUG=none
TBR=mpearson@chromium.org

Review URL: https://codereview.chromium.org/600963002

Cr-Commit-Position: refs/heads/master@{#296538}

These five lines just cause the current browser window to be shown after
the tab with the IME options has already been focused and activated in
another window.

BUG=409270
R=stevenjb@chromium.org,shuchen@chromium.org

Review URL: https://codereview.chromium.org/599663003

Cr-Commit-Position: refs/heads/master@{#296537}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cd523eb..0f7197b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/600933002

Cr-Commit-Position: refs/heads/master@{#296536}

Review URL: https://codereview.chromium.org/596123002

Cr-Commit-Position: refs/heads/master@{#296535}

BUG=416722
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/594973002

Cr-Commit-Position: refs/heads/master@{#296534}

The test is flaky. Disabling it while investigating the cause.

BUG=417439
R=jam@chromium.org

Review URL: https://codereview.chromium.org/597003006

Cr-Commit-Position: refs/heads/master@{#296533}

This pixel test is now passing on the bots, after a hardware change
to use the same GPU on all systems.

BUG=416719

Review URL: https://codereview.chromium.org/595323002

Cr-Commit-Position: refs/heads/master@{#296532}

UIAccountTweaks disables the "manage protected content exceptions"
button in guest mode, but the ContentSettingsHandler re-enables it.

BUG=417103
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/601633002

Cr-Commit-Position: refs/heads/master@{#296531}

This CL breaks chrome://inducebrowsercrashforrealz

I don't know exactly why the behavior is broken, but it appears that setting a
signal handler for SIGTRAP interferes with breakpad exception handling. See bug
for more details.

Original CL: https://codereview.chromium.org/329423003
Original Commit: d81d222c

TBR=cpu@chromium.org
BUG=402337

Review URL: https://codereview.chromium.org/602793002

Cr-Commit-Position: refs/heads/master@{#296530}

BUG=20997,22923,30703,68069,81796,88640,89942,90057,90496,90671,92741
TBR=ericwilligers@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/598203002

Cr-Commit-Position: refs/heads/master@{#296529}

Simple crash fix.

BUG=417381

Review URL: https://codereview.chromium.org/601893002

Cr-Commit-Position: refs/heads/master@{#296528}

Excluding USE_OPENSSL is no longer appropriate now that Mac is on OpenSSL/BoringSSL.
(It should have been USE_OPENSSL_CERTS.) Switch them to condition on OS instead to
match the condition in browser_options.js.

BUG=417241
TEST=Manage certificates button in Settings opens Keychain on Mac

Review URL: https://codereview.chromium.org/597913004

Cr-Commit-Position: refs/heads/master@{#296527}

window.onpopstate used to be called with a null state when a page was
loaded for the first time. This was a bug, and inconsistent with other
browsers, but we relied on it in the PNaCl demo page.

Without it, direct links to a demo page were not working properly. Even
after fixing this, I ran into issues with history when creating/destroying
a new iframe element whenever the page switched. Using
iframe.contentDocument.location.replace seems to have fixed these issues.

No trybots because this only affects the AppEngine demo page.

BUG=none
R=sbc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/600653002

Cr-Commit-Position: refs/heads/master@{#296526}

In case this header is included without sdk_util headers
being available (as can happen in naclports).

Review URL: https://codereview.chromium.org/596133002

Cr-Commit-Position: refs/heads/master@{#296525}

 * Instead, show it explicitly on caller side. This is necessary as the extensions system controls the app window's visibility.

Remove ActivityViewManager
 Instead of keeping activity -> widget map, use views::Widget::GetWidgetForNativeWindow

BUG=417017
TEST=ActivityManagerTest.Basic

Review URL: https://codereview.chromium.org/596623005

Cr-Commit-Position: refs/heads/master@{#296524}

std::{min,max} requires the algorithm.h header.

BUG=none
R=bradnelson@google.com, bradnelson@chromium.org

Review URL: https://codereview.chromium.org/597283002

Cr-Commit-Position: refs/heads/master@{#296523}