GitLab

There are two tests that test this, but they are currently failing
in Legacy too.
virtual/android/url-bar/bottom-and-top-fixed-sticks-to-top.html
virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html

I've confirment manually that position:fixed, bottom:0 Elements
stick to bottom on scrolling.

There is one remaining problem.
While scrolling is active, position:fixed, bottom:0 element does
not stick to the bottom of the viewport. It gets positioned correctly
after scrolling stops. Bug #906516

Bug: 870008
Change-Id: Ibe597141869794978865809caa3991cd4c2bd8a6
Reviewed-on: https://chromium-review.googlesource.com/c/1341127
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611045}

Move away from OAuth2TokenService and SigninManagerBase by implementing
IdentityManager::Observer and using Identity Service's APIs only (i.e.
IdentityManager, PrimaryAccessTokenFetcher).

Bug: 905689
Change-Id: I68e971ddf8a23987abfdadb8e2daf7b17a4a6ddb
Reviewed-on: https://chromium-review.googlesource.com/c/1340315Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611044}

Experiment discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hE2B1iItPDk

Bug: 908272
Change-Id: I97a5d26996469d33b75afa4babf40e54eb830e6a
Reviewed-on: https://chromium-review.googlesource.com/c/1350174
Commit-Queue: Ruslan Burakov <kuddai@google.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611043}

Introduce blink::WritableStream which is a ScriptWrappable.

There are some compatibility issues:
 - Function lengths (e.g., WritableStream.prototype.abort.length)
   change.
   (external/wpt/streams/writable-streams/properties*)
 - attribute @@toStringTag is added to ReadableStream and
   TransformStream. (*global-interface-listing*)

Bug: 894357, 888165, 902633
Change-Id: I93762fec72a4654759a7fbe4e80b4704befac2c3
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1337220
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611042}

GWP-ASan is a debug allocator intended to find memory errors in the
wild. In order to detect as many as bugs as possible, it should start as
early as possible, e.g. soon after it's dependency, FeatureList, has
been initialized. Since content/ doesn't call into ChromeMainDelegate
for child processes after FeatureList has been initialized, create a new
delegate method for post-FeatureList initialization and enable GWP-ASan
at that point.

Bug: 896019
Change-Id: I9c081602cd32a71d5d9eb774bd9818757d9b7e95
Reviewed-on: https://chromium-review.googlesource.com/c/1343347Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611041}

Don't run dirRenameWithoutChangingCurrent with MyFilesVolume flag, since
it was flaky crbug.com/908352.

Add RootPaths.DOWNLOADS_PATH which sets the full path to Downloads
folder: "" when MyFilesVolume is disabled, which means Downloads is the
root; "/Downloads" when MyFilesVolume is enabled, which means that
Downloads it's a folder at root.

Change tests that uses entry.fullPath to prefix with
RootPaths.DOWNLOADS_PATH so the tests passes with/without the flag
MyFilesVolume.

Enable some tests to run with flag MyFilesVolumeEnabled which were
failing before this CL.

NOTE: RootPaths.DOWNLOADS_PATH will be removed and the full path with
/Downloads will be in-lined when MyFiles as Volume is fully rolled out.

--gtest_filter="DirectoryTreeContextMenu/FilesAppBrowserTest*"
--gtest_filter="CreateNewFolder/FilesAppBrowserTest*"

Test: browser_tests
Bug: 873539, 908352
Change-Id: Iaac6c8bd51c2bc8dc31e1c395f2f74d8533f4f9c
No-try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1351341
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611040}

Checking for values in UKM metrics is a lot of boilerplate in the
password manager unittest, so this CL adds two helper methods for
brevity.

Bug: 907794
Change-Id: Iecf86eb564f9f0f239e7b337725a9666f59d56d4
Reviewed-on: https://chromium-review.googlesource.com/c/1350959
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611039}

Add helper to count the number of items on the MockProgressCenter. Use
it in drive_sync_handler_unittest as an example, to remove a shed-load
of closure compiler complaints about the following code:

   Object.keys(progressCenter.items)

Move that code into the MockProgressCenter helper: getItemCount(), and
the Closure compiler will be a happy koala.

No change in test behavior, no new tests.

Bug: 907964
No-try: true
Change-Id: I3da5fda8226a64a0cad27dcb57b84fac6c7a43be
Reviewed-on: https://chromium-review.googlesource.com/c/1351201
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611038}

Transient downloads shouldn't show up on download home and hence should
be filtered out.

Bug: 908670
Change-Id: Ic7ff12a36a7c46a6d7f7e63fe0faede8173488e1
Reviewed-on: https://chromium-review.googlesource.com/c/1351717Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611037}

With https://github.com/web-platform-tests/wpt/pull/14172 wpt streams
tests now use the standard *.any.js format for multi-platform tests. As
a result all the test filenames have changed and there are a large
number of obsolete *-expected.txt files left behind. Delete them.

Change-Id: Ia5ce3b89e3866745d19bd1d521c7fb731342e024
Reviewed-on: https://chromium-review.googlesource.com/c/1350552Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611036}

This fixes the GCC build after fdf95b6b ("CacheStorage: Refactor handle
ref-counting"):

    ../../content/browser/background_fetch/storage/match_requests_task.cc: In constructor ‘content::background_fetch::MatchRequestsTask::MatchRequestsTask(content::background_fetch::DatabaseTaskHost*, content::BackgroundFetchRegistrationId, std::unique_ptr<content::BackgroundFetchRequestMatchParams>, content::background_fetch::MatchRequestsTask::SettledFetchesCallback)’:
    ../../content/browser/background_fetch/storage/match_requests_task.cc:29:25: error: use of deleted function ‘content::CacheStorageRef<TargetType>::CacheStorageRef() [with TargetType = content::CacheStorageCache]’
           weak_factory_(this) {}
                             ^

With GCC, having that noexcept marker would require all members to be
marked with noexcept themselves (in this case, base::WeakPtr and its
hierarchy). While that could also be possible, the style guide only
explicitly mentions move constructors/assignment operators, and it is not
clear if having a noexcept default constructor brings any benefits.

clang is fine because we pass -fno-exceptions and it disables the same error
there, while GCC continues to raise it (bug 843143 and its corresponding CL
have a longer discussion on this issue).

Bug: 819294
Change-Id: I726cbc8d9e0d624c530a835373c0dbad32279b78
Reviewed-on: https://chromium-review.googlesource.com/c/1350954Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#611035}

Before this CL we didn't bundle WebRequestProxyingURLLoaderFactory
to the default URLLoaderFactory for service worker. This means that
fetches from service worker didn't go through webRequest extension
API when NetworkService is enabled. Bundle the factory so that
fetches from service worker go through extensions.

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iabcc00674c8b62c9eae97e83f067d7a838a3d0fd
Bug: 897060
Reviewed-on: https://chromium-review.googlesource.com/c/1333173Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611034}

After a GWP-ASan exception occurs, a crash handler hook (e.g. a crashpad
UserStreamDataSource) is responsible for looking at the crash and
1) determining if the exception was related to GWP-ASan, and 2) adding
additional debug information to the minidump if so.

The crash handler hook determines if the exception was related to
GWP-ASan by finding the AllocatorState address (using a crash key),
reading the allocator state and seeing if the exception occurred in the
bounds of the allocator region. If it did, we extract debug information
about that allocation and report it in the minidump.

CQ-DEPEND=CL:1339246

Bug: 896019
Change-Id: I63d12b5137098b20ec946e3bddbdcabaf20e430a
Reviewed-on: https://chromium-review.googlesource.com/c/1330283Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611033}

Bug: v8:8503,821764
Change-Id: I0b541e06f0326f8270e14e0b7a685cab3c288882
Reviewed-on: https://chromium-review.googlesource.com/c/1350177Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611032}

This is useful in debugging to attribute what a window is.

BUG=none
TEST=none

Change-Id: If996333847d83c5102ddd81e4ecff25691c09eca
Reviewed-on: https://chromium-review.googlesource.com/c/1351099
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611031}

The crasher happens when the session is connected/disconnected. The code
registers/unregisters RemoteMediaClient callback upon
connecting/disconnecting. However it should check the availability of
RemoteMediaClient of the current session.

Bug: 711860
Change-Id: Ie4b29f507a0044ac8649b52b37f1541e4dc9b4ee
Reviewed-on: https://chromium-review.googlesource.com/c/1350211
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611030}

This CL removes command line switches for experimental features in AEC3
that now are deprecated.

This CL also replaces the outdated CL
(https://chromium-review.googlesource.com/c/chromium/src/+/1274905)

Bug: webrtc:8671
Change-Id: I83582049ab8c144ff8654107e928e8e75fd1f4e0
Reviewed-on: https://chromium-review.googlesource.com/c/1350752Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Per Åhgren <peah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611029}

This is the first step in a refactor, and moves only
the TTS controller header but none of the logic, in order
to keep changes relatively small.

Refactoring the TTS controller to content is the first
step in displaying the audio icon in tabs when TTS is
speaking.

BUG: 517317
Change-Id: Ic8c4c06e13001feec5c880691055ff0604127260
Reviewed-on: https://chromium-review.googlesource.com/c/1341154Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611028}

Switches-over GLRendererCopier to use the new GLScaler and
GLI420Converter when scaling and/or format-converting images for
CopyOutputRequests. This change also addresses:

1. Simpler handling of cached GL resources (used across copy requests
having the same requester). Rather than separate methods for each of the
possible cached resources (with some duplicated logic), there is now one
"ReusableThings" struct to hold them all (and is passed around on the
stack).

2. Simplified the I420 code around handling of "packed textures" and
"aligned rects".

3. Simplified the detection/execution of whether to byte-swizzle on the
CPU (after readback) or GPU (before readback). Simplified the RGBA
bitmap copy-from-pixel-buffer code (w.r.t. upside-down row-by-row copy
and byte-swizzling).

Testing: Confirmed existing unit and pixel tests are thoroughly-testing
all possible code paths in GLRendererCopier. Manually confirmed tab and
desktop capture (incl. CrOS), and screenshots work.

Performance improvement: A local run of performance_browser_tests, on a
machine with a high-end nVidia GPU, has shown a ~20% improvement in
capture latency (i.e., the interval of time from when copy request was
issued until an SkBitmap result is ready in system memory).
http://chromeperf.appspot.com/ will reveal how other platform
configurations are affected.

Bug: 870036,810131,781986,758057
Binary-Size: Increase is temporary (linking in new impl, future CLs will switch-over other clients to stop using old impl).
Change-Id: Ibcb16c1382ea0cffb00bc7605e0594b1fe28356a
Reviewed-on: https://chromium-review.googlesource.com/c/1343247
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611027}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=benmason@chromium.org

Change-Id: Ib41b9d039ce07a1387583c3444c93477b2266acb
Reviewed-on: https://chromium-review.googlesource.com/c/1351722Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611026}

This CL changes the behavior. Another CL (https://crrev.com/c/1341158)
removes the resources, but for now we don't want to land the second
one because the resources will be used by Discover.

Bug: 903577
Change-Id: I004abeb0541f64c5ab8ba655cf8c7cf6736a7cb6
Reviewed-on: https://chromium-review.googlesource.com/c/1341149Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611025}

This CL renames the following md files:
 - layout_tests_linux -> web_tests_linux.md
 - how_to_extend_layout_test_framework.md ->
   how_to_extend_web_test_framework.md
 - testing/layout_test_baseline_fallback.md ->
   testing/web_test_baseline_fallback.md
 - testing/layout_test_expectations.md -> testing/web_test_expectations.md
 - testing/layout_tests.md -> testing/web_tests.md
 - testing/layout_tests_in_content_shell.md ->
   testing/web_tests_in_content_shell.md
 - testing/layout_tests_tips.md -> testing/web_tests_tips.md
 - testing/layout_tests_with_manual_fallback.md ->
   testing/web_tests_with_manual_fallback.md
 - testing/writing_layout_tests -> testing/writing_web_tests.md

No-Try: true
Change-Id: Ied34815c92e449888b20818540a5ed0a76107bd1
Bug: 843412
Reviewed-on: https://chromium-review.googlesource.com/c/1350559
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611024}

Change-Id: I0ff4dbdf64ae3d2176a2e5bd1afe0ed353ebe223
Reviewed-on: https://chromium-review.googlesource.com/c/1343559Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611023}

third_party/blink was forked from WebKit, so we should credit for WebKit.
Move third_party/WebKit/LICENSE_FOR_ABOUT_CREDITS to third_party/blink.

Remove third_party/WebKit/OWNERS because third_party/WebKit doesn't have
files any longer.

No-Try: true
Bug: 622551
Change-Id: Icdf9b5a08e78848925cd4a7db48d076c1baa328a
Reviewed-on: https://chromium-review.googlesource.com/c/1350011
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611022}

Assigns owners for the following Crostini flags:
crostini-usb-support
disable-crostini-files
enable-experimental-crostini-ui

Bug: 897809
Change-Id: I077743a15cb65e552d38e23f189401193723006f
Reviewed-on: https://chromium-review.googlesource.com/c/1345673Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Josh Pratt <jopra@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611021}

This moves GetTab{Foreground,Background}Color() and
ShouldDrawStrokes() to TabStrip. This also plumbs other necessary
functions through TabStripController.

Change-Id: Iff487d3d228ae4ea3101b713df16c79183fe53cf
Reviewed-on: https://chromium-review.googlesource.com/c/1343255Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611020}

There's not really much point in the distinction between page and
browser actions anymore, and we'd like to merge them. Make the
declarativeContent.showPageAction API work with browser actions.
A follow-up will introduce declarativeContent.showAction.

Bug: 893375
Change-Id: Ib4651c225099c62070239f0c37cb4b075d124b1c
Reviewed-on: https://chromium-review.googlesource.com/c/1270006Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611019}

Bug: 847729
Change-Id: I31ab35f815a578d236eff6a75fdfa45a3a6df89f
Reviewed-on: https://chromium-review.googlesource.com/c/1351507Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611018}

The client is notified of changes to the window owner.

BUG=756085,875111
TEST=covered by test

Change-Id: I8cec4fe2b547bb1f9f31899e2bc2a9437c186d27
Reviewed-on: https://chromium-review.googlesource.com/c/1343507
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611017}

PRESUBMIT.py existed just for linting LayoutTest/TestExpectations.
It's unnecessary now.

No-Try: true
Bug: 622551
Change-Id: I4e3d801ecfa829f3a99e187eb2058fa326aa7c67
Reviewed-on: https://chromium-review.googlesource.com/c/1350430
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611016}

Bug: 891131
Change-Id: I00c96a302291e4df79810e67e3a50cdf96a7c104
Reviewed-on: https://chromium-review.googlesource.com/c/1350384Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611015}

BUG=

Change-Id: I11d351d4681554741a961cd2d54c9de102192bd8
Reviewed-on: https://chromium-review.googlesource.com/c/1345273Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611014}

This changes removes the deprecated GetNetworks API.

BUG=907245
TEST=Boot and test ARC++ WiFi apps.

Change-Id: Iec0f9e18ba6a709af6e40d205503e5c1bf2545cb
Reviewed-on: https://chromium-review.googlesource.com/c/1344991Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611013}

This patch removes //third_party/WebKit/Tools/.gitattributes to make the
directory empty as follow-up of the patch[1].

[1] http://crrev.com/c/1338583 Remove //third_party/WebKit/Tools and //blink

No-Try: true
Bug: 829697
Change-Id: Icae6924a6365e9b32c274dbb063914c03f052279
Reviewed-on: https://chromium-review.googlesource.com/c/1350560
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611012}

Change-Id: Ifee152ae16c133e0d2dcf7f334e1ff7700a47167
Reviewed-on: https://chromium-review.googlesource.com/c/1341068Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611011}

This change adds a base::Clock pointer to the base TaskQueue tasks and
updates all time related calls in tasks and tests in:

components/offline_pages/core/prefetch/tasks/

Bug: 906903
Change-Id: Ia701af7d49dcd5376c903598e61f490721149df2
Reviewed-on: https://chromium-review.googlesource.com/c/1344829Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Dan H <harringtond@google.com>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611010}

Add a list of skipped commits when looking for exportable commits.
Currently, there is only one commit in the list: the great
LayoutTests->web_tests move.

Bug: 908445
Change-Id: Ia5cf4f66b93966e2a510a0d04932643a9e6fadaf
Reviewed-on: https://chromium-review.googlesource.com/c/1351451Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611009}

Remove code that is dead now that touchable app menus are enabled by
default.

Bug: 906684
Change-Id: I28bb46da596ba93e0bbc01c0685ed1cc1b7ec0ac
Reviewed-on: https://chromium-review.googlesource.com/c/1341064
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611008}

This reverts commit 48d32d67.

Reason for revert: FDIO doesn't handle overrides as expected.

Original change's description:
> [Fuchsia] Allow namespace overrides in base::LaunchProcess
> 
> Previously base::LaunchProcess didn't allow paths_to_transfer to be used
> with the FDIO_SPAWN_CLONE_NAMESPACE flag. This meant that to override
> directories the test launcher had to avoid FDIO_SPAWN_CLONE_NAMESPACE
> flag. This is not ideal because of the added complexity in the test
> launcher and also because the launcher was changing test environment
> by not cloning all entries in the namespace (i.e. some tests would behave
> differently when started with --single-process-tests flag). This change
> updates LaunchProcess() to allow individual dirs transfer while cloning
> the rest of the namespace. Also updated test launcher to use this new
> feature.
> 
> This CL should unbreak the tests currently broken in
> https://crrev.com/c/1341243
> 
> Change-Id: I3c30497222ffd33d6240f478523d3e767fad90f5
> Reviewed-on: https://chromium-review.googlesource.com/c/1345236
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610042}

TBR=thakis@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org,scottmg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Iecb39de51037b41cc4b75914c688e1b412dcce71
Reviewed-on: https://chromium-review.googlesource.com/c/1351788Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611007}

Change-Id: I1ad110c817b75e62116dfcb0fabe17eb9f40088f
Reviewed-on: https://chromium-review.googlesource.com/c/1351598Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611006}