- 11 Nov, 2019 40 commits
-
-
Jun Mukai authored
The autotestPrivate API provides the information of a window, but I guess some properties might not be very clear to every developers. I added comments to some of them, I hope some things are a bit clearer without looking into the code. Bug: none Test: none Change-Id: Iee076c45a89b0fdd8382f200cc584b86f3512671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907269Reviewed-by:
Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714292}
-
Mila Green authored
Specifically, delete the line of code which deletes the test file (and even asserts on that). This is not needed to test the functionality of the networking code and the file will get deleted when the ScopedTempDir gets out of scope. Bug: 1020650 Change-Id: Ib045cbd790c55753362c0e0367c61fd12bc35101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906473 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714291}
-
Manu Cornet authored
Separate suspension of shelf visibility updates and work area updates (the former is needed for desk transitions, the latter is needed for overview transitions). Bug: 1021691, 1017435, 1019531 Change-Id: Ie0bb64d931a06b2157a58afc2b1c8604ccf2d71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898718 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714290}
-
Theresa Wellington authored
BUG=1023429 TBR=yuezhanggg@chromium.org Change-Id: I3b7834debf66efd20034ae53699e26e34509d97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910419Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#714289}
-
Piotr Bialecki authored
Currently, we extensively use VRPose to surface data to blink even for the entities where additional VRPose fields make no sense. In addition, VRPose allows for null position / orientation even though those entities will always have position and orientation known. I have decided against using gfx.mojom.Transform to surface that information since it allows for transforms that perform more than just translation and rotation and we would have to perform additional checks to enforce that no additional components are present. Bug: 1013229 Change-Id: I517a5b33aa905ca3c29e8b742c6767f2b6eb03bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887752 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#714288}
-
Sean Harrison authored
This CL does 3 things: 1) The order of rows in the privacy page is affected, regardless of the value of the "privacySettingsRedesignEnabled" flag. 2) The privacy-page is moved to the "basic", only when the "privacySettingsRedesignEnabled" flag is on. 3) A "more" expansion button is introduced in the privacy-page only when the "privacySettingsRedesignEnabled" flag. Bug: 1014143 Change-Id: I678e81aa3b67acd2ae41eeda355cd3b32a5b4088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872094 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714287}
-
Yutaka Hirano authored
This is needed to start the experiment on beta. Bug: 1018081 Change-Id: I46aa390c69c9b152d0a217618cfc0b6bb46f4c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906856 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714286}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/f2fb48c3b3d7..076c46198fe1 $ git log f2fb48c3b..076c46198 --date=short --no-merges --format='%ad %ae %s' 2019-09-19 absl-team Googletest export 2019-09-27 gennadiycivil Bump llvm version to 4 so brew can work again Created with: roll-dep src/third_party/googletest/src CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Change-Id: I5deffd4ea07a78bd62f1d18af23407ecb4e37462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909717 Commit-Queue: Staphany Park <staphany@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#714285}
-
Robert Liao authored
CComPtr has been deprecated in Chromium's codebase in favor of Microsoft::WRL::ComPtr. BUG=5027 Change-Id: I3918227f797ba1b5306cdd65a77f56a0a15bfdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906249 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Stefano Sanfilippo authored
Reintroduce the modifying hook with the new signature. Scripts are executed if both TT and CSP allow them, otherwise throw an EvalError and send reports as side-effects. Non-string, non-trusted values are passed through, and skip any TT default policy. eval(TT) still returns the object if TT enforcement is disabled, for now. This is because unconditional codegen from strings overrides our callback. Bug: 940927 Change-Id: I718694cc050cf071a2ccf9669543628cf568cbdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768427 Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#714283}
-
Eric Roman authored
This reverts commit 11ec6a9b. Reason for revert: The failed screenshot tests were not caused by this change Original change's description: > Revert "Make use of new hex decoding function for extensions color string parser." > > This reverts commit 2de0ccb8. > > Reason for revert: Suspecting cause for screenshot test failure. Seems unlikely but this is the only color related CL in regression range. crbug.com/1023255 > > Original change's description: > > Make use of new hex decoding function for extensions color string parser. > > > > Bug: 1021236 > > Change-Id: I1d1b5180048eb36fa78406a02fc3277cba0dcf63 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904809 > > Commit-Queue: Eric Roman <eroman@chromium.org> > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Auto-Submit: Eric Roman <eroman@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#713942} > > TBR=eroman@chromium.org,reillyg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1021236 > Change-Id: I474f4e07583f571722e4bacf28ae482c071276a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909669 > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714159} TBR=eroman@chromium.org,reillyg@chromium.org,keishi@chromium.org Change-Id: Ifff4b8df577ad13e2cbffcfe90044caac9b0a888 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1021236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909654Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#714282}
-
Christian Dullweber authored
Bug: 1022562 Change-Id: I4a3bcc4c80a0e72f8df9244e481ff4e98227b1d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910228Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#714281}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/524459562448..3c4707d608f2 git log 524459562448..3c4707d608f2 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 swiftshader.regress@gmail.com Regres: Update test lists @ 414f99e0 2019-11-11 chrisforbes@google.com Relax descriptor set index assert at descriptor point of definition Created with: gclient setdep -r src/third_party/swiftshader@3c4707d608f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140648941 Change-Id: Iea02ca180b93e7964aa2fbc26effefe601fabc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714280}
-
Sky Malice authored
Bug: 1019707 Change-Id: Ia138c008fd201263d86f22fbafecb0ccf3406ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891586Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#714279}
-
W. James MacLean authored
Disabling contrib.cluster_telemetry.screenshot_unittest.ScreenshotUnitTest. testScreenshot and external/wpt/webdriver/tests/take_element_screenshot/iframe.py>>test_source_origin to de-jank the linux-trusty-rel bot. TBR=keishi@chromium.org Bug: 1023255 Change-Id: Ie8fbb182ba5d2d3c4df5282db62b72b622a26b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908715 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714278}
-
Dominique Fauteux-Chapleau authored
Removing overload as discussed in crrev.com/c/1903957 so callers don't have to use the Create* functions. They are however still public as test code will need them to test the behaviour of different DM token statuses. Change-Id: I8ee20e4b54a1b946317d1d4265bade05d4dab15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906628Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#714277}
-
Christoph Schwering authored
This is a cleanup CL that avoids any semantic changes, with one exception noted below. * Used std::tie() and tuples to improve maintainability in FormFieldData. * Removed FormData::operator==() and FormFieldData::operator==() They were only used in tests, and they are relatively difficult to maintain. (Case in point: FormFieldData::operator==() did not compare several members, and behaved awkwardly for |FormFieldData::label|.) Replaced the usage in the tests with !(a < b) && !(b < a). * Moved FormData::operator<(), FormFieldData::operator<() to comparators. These only exist to make STL containers happy, namely an std::set member of FormCache. The style guide advises not to implement operator<() in such cases. * FormData::operator<() and FormFieldData::operator<() (now the comparators) did and do not compare all members. This seems unintended with the use case in FormCache. However, this change is deferred to a follow-up CL. This CL only makes minor modifications to the lexicographic orderings in that the order in which the members are compared is slightly changed. This should have no repercussions since FormCache makes no assumptions about the ordering. Bug: 1007974 Change-Id: I5109aa37edccfd858993e1f0c6992b9988c8cf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884790Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#714276}
-
Markus Handell authored
While trying out MediaRecorder with a H.264 profile_idc 77 level_idc 52 remote stream on Mac, the code DCHECKs in video_track_recorder.cc:239. This change adds support in the same way as the fix for crbug/585242. Bug: 1022294 Change-Id: I0e8804b6b0b2a22f64b4af07d0078a0415499bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908537Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#714275}
-
Theresa Wellington authored
Add an Android app menu test to exercise some basic drag helper functionality. BUG=966644 Change-Id: If1c159250d015a0cac0a50f3d848cc50bd243ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899199 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714274}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de7c754b..5a2bf4dc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0790b9df430613b9a018468bb1391b85533e5844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907058Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714273}
-
James MacLean authored
This reverts commit 5e7d8eb8. Reason for revert: This CL disabled the wrong test. Original change's description: > Disable ExternalProviderImplTest.BlockedExternalUserProviders on Linux. > > Disabling this test to reduce jank on the bots. > > TBR=domfc@chromium.org > > Bug: 1023391 > Change-Id: I26243bb6acba2af947357222ac1fa5664601b1e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908063 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714232} TBR=wjmaclean@chromium.org,domfc@chromium.org Change-Id: Ice16cb05e8e047380bba533e9b0cfda37204f316 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909642Reviewed-by:
-
Victor Hsieh authored
Spec: https://spec.googleplex.com/crosux-spec/feature-specs/start-screen-auth-methods.html#start-screen-auth-methods-bottom-status-indicators Test: turn on/off, see correct result Bug: chromium:893332 Change-Id: I40c34b50e297f46fca8102403ed4b81d6821e576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900135 Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
James Cook authored
The build flag was introduced when we supported the app list on Windows, Mac and Linux. However, the app list currently only works on Chrome OS and it's been that way for years. Finish cleanup of //chrome/test/BUILD.gn and chrome_paks.gni and remove the flag altogether. Bug: 1022886 Change-Id: If7a312207376abed4e6e56efa2c75e2c53852bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907547Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#714270}
-
sczs authored
- These new strings will be used to configure the new Infobar modal on iOS. Bug: 1014652 Change-Id: I2f79de8bef51c38d37947c25fb5b55dce825901f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904948Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714269}
-
Xing Liu authored
Android starts to resize big icon size on notification. We now check version O for exact icon size match instead of O MR1, that we suspect the Android CL to resize icons is included in some pre MR1 O versions. TBR=peter@chromium.org, dtrainor@chromium.org Bug: 1009855 Change-Id: I5eac5e0c2218797419fb82de59c2ed6763e23fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900395Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#714268}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1abb0dd1324b..f18ff947360d git log 1abb0dd1324b..f18ff947360d --date=short --no-merges --format='%ad %ae %s' 2019-11-11 jmadill@chromium.org Minor tweaks to SampleApplication. Created with: gclient setdep -r src/third_party/angle@f18ff947360d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I38a188b7da704555043a23599a24ea5189dd086f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910300Reviewed-by:
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/7cde68f10cdf..64a45be5198f $ git log 7cde68f10..64a45be51 --date=short --no-merges --format='%ad %ae %s' 2019-11-09 ebrahim [ubsan] Don't decrease pointer if match_glyph_data is null (#2048) 2019-11-05 don.j.olmstead [cmake] Add harfbuzz-icu library 2019-11-06 ebrahim [fuzz] Remove just added case 2019-11-05 ebrahim [fuzz] Upload testcase of https://crbug.com/oss-fuzz/18529 Created with: roll-dep src/third_party/harfbuzz-ng/src TBR=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 1023070 Change-Id: I9bc02abe3f177adfd8afe6eb439fb47d68158ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910222Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#714266}
-
Martin Robinson authored
This support is required for ATs on AuraLinux, so fall back instead of triggering an assertion failure and a null position. We can remove this workaround once sentence boundary analysis support is added to AXPosition. Bug: 1000049 Change-Id: I00c4eee451c75e7efe8e132d15995899eccca049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832811Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#714265}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a4c1aaad8d5f..26f7dde56c90 git log a4c1aaad8d5f..26f7dde56c90 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 mbonadei@webrtc.org Revert "Whitespace change" 2019-11-11 alessiob@webrtc.org APM runtime setting: fix kPlayoutVolumeChange not dispatched 2019-11-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5145d23f..e2cf3bc0 (714086:714186) 2019-11-11 philipel@webrtc.org Add allowCodecSwitching flag to RTCConfiguration.mm 2019-11-11 mbonadei@webrtc.org Whitespace change 2019-11-11 asapersson@webrtc.org Add field trial for rampup in quality based on available bandwidth. Created with: gclient setdep -r src/third_party/webrtc@26f7dde56c90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:none Change-Id: Ia447ff234f35bbb597531725a443fb25ab304a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910167Reviewed-by:
-
Fan Yang authored
Change-Id: I5e9a81c98270b5acb68899c13fc75c22c74bebc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909888 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#714263}
-
Dan Elphick authored
Uses new V8::GetSharedMemoryStatistics API to report stats on shared memory in V8 (i.e. not per isolate) such as read_only_space's size. Bug: v8:7464 Change-Id: I139e084c51703dd5cf1239a59128de874aea62c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905547 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#714262}
-
Sergio Villar Senin authored
As part of the rewriting of Blink Animation Engine we're replacing the way the elapsed time is represented inside a TransitionEvent. The spec mentions it must be a double but we can use AnimationTimeDelta as the internal representation. This change reduces a little bit the number of required conversions between AnimationTimeDelta and double. Bug: 737867 Change-Id: Ide96f3906c3937c6d4af893a9677211c7f8de8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907247Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#714261}
-
Francois Beaufort authored
This CL adds a menu item named "NFC" to Android site settings and page info. It allows websites to query the NFC permission which can be set only by user from site settings for now. A future CL will allow websites to prompt in-page user to grant access to NFC. Screenshots: https://photos.app.goo.gl/k7wz55v9ELVTS19i8 Bug: 520391 Change-Id: I64aefeb26e0a849422a21fe6eb2217817d101060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891415 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#714260}
-
Sergio Villar Senin authored
As part of the rewriting of Blink Animation Engine we're replacing the way the elapsed time is represented inside an AnimationEvent. The spec mentions it must be a double but we can use AnimationTimeDelta as the internal representation. Bug: 737867 Change-Id: I38041957586d2d151eea6dddc908bb176eadf97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907248Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7980e5ea3e34..51516f076308 git log 7980e5ea3e34..51516f076308 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 fmayer@google.com Merge "Do not count roots as unique_retained." 2019-11-11 rsavitski@google.com Merge "compact_sched: remove "unstable" notices" 2019-11-11 rsavitski@google.com Merge "compact sched_waking: event decoding in trace_processor" 2019-11-11 rsavitski@google.com Merge "compact sched_waking: writer (traced_probes)" Created with: gclient setdep -r src/third_party/perfetto@51516f076308 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I85e20b4475481af1fd2c2c1eaca3b224e6cbba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910168Reviewed-by:
-
Yusuke Sato authored
This is to support unibuilds, and the content of the class is the exact copy of platform2's. We don't expect that the original functions will be updated often, and once we stop supporting ARC container, we'll move their unit tests to Chromium and delete the platform2 code. BUG=b:123309049 TEST=try Change-Id: I5b4d2fe39f9177a177ac1d98e33581dec7b15c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904874Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#714257}
-
Vadym Doroshenko authored
FieldInfoManager is a KeyedService which keeps password related field information. Namely it contains map: (FormSignature, FieldSignature)->field type (FormSignature, FieldSignature) is unique identifiers of fields, type is PASSWORD, USERNAME, NEW_PASSWORD etc. Bug: 959776 Change-Id: I21d2044d619a6ad3b1788c8c98ed75cd58316bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872224 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714256}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/78441455a3f7..eab1e281fa5e git log 78441455a3f7..eab1e281fa5e --date=short --no-merges --format='%ad %ae %s' 2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 652dbfc63e70..012d15196023 (9 commits) 2019-11-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2019-11-11 mtklein@google.com add assert_true() 2019-11-11 bsalomon@google.com C++17 Created with: gclient setdep -r src/third_party/skia@eab1e281fa5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None Change-Id: Ibbdb86d1e79fc3bbd52d6ea0c270cb854fc20738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910166Reviewed-by:
-
Rouslan Solomakhin authored
The line between instruments and payment apps is blurred in the current implementation of Web Payment in Chrome. With the exception of Autofill, each payment app contains exactly one instrument. This typically results in both payment app and payment instrument being implemented in the same class, because that is easiest. To alleviate the confusion, this patch has only payment apps and no payment instruments on desktop implementation of Web Payment. The payment sheet displays exactly one entry per payment app. In the case of autofill credit cards, each one is technically a payment app, although its UX look and feel has not changed. Previous Name New Name ----------------------------------------------------------- PaymentInstrument PaymentApp ServiceWorkerPaymentInstrument ServiceWorkerPaymentApp AutofillPaymentInstrument AutofillPaymentApp This patch corresponds to steps 1-3 in Phase I of go/cross-platform-pay-app-factory The Android code is affected because of the shared browser tests. The iOS code is affected because it re-uses PaymentInstrument and AutofillPaymentInstrument, but the iOS changes in this patch are meant to be minimal. Bug: 1022512 Change-Id: I2ea83fcb81a7cf862a559d011686c6b2c170b6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904532Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714254}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f0bfbce62d42..f4cf10c66fbf git log f0bfbce62d42..f4cf10c66fbf --date=short --no-merges --format='%ad %ae %s' 2019-11-11 rharrison@google.com Correct Unicode issue with add_copyright.py (#876) Created with: gclient setdep -r src/third_party/shaderc/src@f4cf10c66fbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I88a68115bd0c2f6cb0aa1091f68903c3c9d598c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910165Reviewed-by:
-
