GitLab

Change-Id: I0d2e3211720c255647db43ec9bed24f17cf6c5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096793
Commit-Queue: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Auto-Submit: Joe Downing <joedow@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749221}

The test sets up Sync-the-transport, has the user opt-in to the account
password storage, and makes sure that saves go to the correct store.

This requires a few changes to password_manager_test_base.h/cc:
- Most notably: The password manager tests used to set up a
  MockPasswordFeatureManager (in order to make IsGenerationEnabled()
  return true), but the new combined tests require a real
  PasswordFeatureManager. So this CL removes the mock (which also lets
  us remove CustomPasswordManagerClient), and instead sets up a
  TestSyncService which claims "everything is active" and so also makes
  IsGenerationEnabled() true.
- Some simple refactorings to avoid duplicating test setup code:
  - Split the "GetNewTab" part out of SetUpOnMainThreadAndGetNewTab(),
    into a new static helper.
  - Exposed PasswordStoreResultsObserver (it used to be fully defined
    in the .cc).
  - Exposed a version of CheckThatCredentialsStored() that takes a
    PasswordStore parameter.

Bug: 1058339
Change-Id: If9b040cbd56ee10ba6b6badd1b4b4d772603f13a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089825
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749220}

Using wpt-import in Chromium b255692f.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
acf33020 "Add testing for the scrolling attribute"
2594f643 "Fix timeout in update-and-send-events-replacment.html"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Ifdeb54f516c165074ea1d83c75aff41eea56c2f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095266Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749219}

Bug: 1060374
Change-Id: I75f2df23ef35ff16e912fd0c037333a329bdd459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097333
Commit-Queue: Ali Juma <ajuma@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749218}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8cf4a76817cb..c7796cf40d5e

git log 8cf4a76817cb..c7796cf40d5e --date=short --first-parent --format='%ad %ae %s'
2020-03-11 vapier@chromium.org gerrit: rewrite helpers to use classes
2020-03-11 saklein@chromium.org build_target_util: Rename to build_target_lib.
2020-03-11 vapier@chromium.org git_metrics: have git commands return strings
2020-03-10 tbegin@google.com packages: add termina VMs to versioned package uprev
2020-03-10 saklein@chromium.org commandline: Add build_target argument type support.
2020-03-10 vapier@chromium.org export_to_gcloud: fix some python3 unittest logic
2020-03-10 kcwu@chromium.org cros_chrome_sdk: fix goma install using python3

Created with:
  gclient setdep -r src/third_party/chromite@c7796cf40d5e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I51e30138a7d72c632be9937e8aab2c80a5e3e975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098237Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749217}

Bug: 1059046
Change-Id: I3663b4e7d9c84e7f7d7a90652995d7addb0a4088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097935Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#749216}

This is a reland of 63c4f9f5

The problem with the reverted CL is that a binding file needs updating.
third_party/blink/renderer/bindings/generated_in_core.gni should be
manually updated to point to the newly generated binding classes.
The reason CQ and my local didn't catch this is because the old
generated files v8_shadow_root_slotting(.h|.cc) still exists. But a
clean build will fail.

This CL is the reverted CL plus updates to generated_in_core.gni. See
patch 1 for the failed case. Patch 2 has the update and failed try job
passes.

Original change's description:
> Adds slotAssignmentMode to the shadow root bindings.
>
> Prior to this CL, the previous implementation of imperative slot API uses
> 'slotting' as an optional parameter for Element.attachShadow(). However,
> based on the feedback by JanMiksovsky@ in
> https://github.com/w3c/webcomponents/pull/866, the parameter should be
> changed to 'slotAssignment' to make it align with other members,
> assignNodes(), assignElements(). I agree with this feedback.
>
> This CL updates the following:
> 1. update bindings where the previous 'slotting' was used to
>  'slotAssignment'.
> 2. Updated the enum type of slotAssignment. It should be,
>  SlotAssignmentMode [auto | manual].
> 3. Added attribute 'slotAssignment' to Shadow_Root.idl and updated
>  global-interface-listing-expected.txt.
> 4. Modify existing tests from using slotting to slotAssignment.
> 5. Removed test that'll be covered by
>  external/wpt/shadow-dom/slots-imperative-slot-api.tentative.html.
> https://chromium-review.googlesource.com/c/chromium/src/+/2083742
> I'll update this CL with the correct
>  slots-imperative-slot-api.tentative-expected.txt once that CL lands.
>
> Bug: 869308
> Change-Id: I0fb1a9e11c88d52fc0b0570f3f3e1f5bf834f858
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084376
> Commit-Queue: Yu Han <yuzhehan@chromium.org>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Reviewed-by: Hayato Ito <hayato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#748116}

Bug: 869308
Change-Id: I26121ca421d707393afc720c1c5918ff36373f29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096784Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749215}

Register SharedPreferences keys in ChromePreferenceKeys and use
SharedPreferencesManager consistently instead of SharedPreferences
directly.

Bug: 1022108
Change-Id: I03887624498879df9ee8a01f68abf877e340f57c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076519
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749214}

https://source.chromium.org/search?q=use.src.side.runtest.py

Change-Id: I23d9a8fa42135e76a302e768a97c7af6068d060b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094930
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749213}

Change-Id: I7d83599340c971cb585b32f41d862104ef639cb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092157
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749212}

Currently, testSetsViewAdapterOnTabCreation fails because it reaches a
feature check which needs the native library to be loaded. This should
not happen in unit tests, so we explicitly set the feature for test for
all test cases.

Bug: 1060580
Change-Id: I688b49b0df49e7262e186bda321f221b7d62be5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093444Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749211}

https://webrtc.googlesource.com/src.git/+log/78964c1e0afa..4d3f93f34813

git log 78964c1e0afa..4d3f93f34813 --date=short --first-parent --format='%ad %ae %s'
2020-03-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9a91e044..03913e7d (749020:749124)
2020-03-11 titovartem@webrtc.org Add jitterBufferTargetDelay as RTCNonStandardStatsMember to new GetStats API
2020-03-11 danilchap@webrtc.org Add Av1 Decoder wrapper behind a build flag
2020-03-11 handellm@webrtc.org RtpTransceiver: add kStopped enumeration value.

Created with:
  gclient setdep -r src/third_party/webrtc@4d3f93f34813

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:980879
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I2ff9e0cb5469955468eaa4f6a8f8ed459314db46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098235Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749210}

iOS flag owners were asked to claim ownership and state an expiry in
this announcement email:
https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ

This is one of several CLs that adds iOS flag ownership information into
flag-metadata.json.

The owner of these flags was identified via git blame. A placeholder
expiry milestone of M86 was added. Please either LGTM, or suggest a new
owner and/or expiry.

Bug: 1058614
Change-Id: I4f527871f7b54804bf43a15e9c39419f0b272047
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094243Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749209}

https://swiftshader.googlesource.com/SwiftShader.git/+log/ca10816d6c22..ce25c2d434cf

git log ca10816d6c22..ce25c2d434cf --date=short --first-parent --format='%ad %ae %s'
2020-03-11 capn@google.com Suppress warnings in Subzero dependencies
2020-03-11 bclayton@google.com Regres: Simplify running of local tests

Created with:
  gclient setdep -r src/third_party/swiftshader@ce25c2d434cf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I9c9db96a5a8fd5a5e5b063468c63b77795824edb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098071Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749208}

For dates, a format string must be specified for ToString to work. User
actions are not supported in ToString. SetText only works for TextViews
or subclasses of it.

Bug: b/145043394
Change-Id: Ic44c9dad4ae714afb0d95ccfae00f4f461c546c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096439
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#749207}

This reverts commit 00134099.

Reason for revert: New test failing on several bots for use-of-uninitialized-value. see: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886112714306274752/+/steps/blink_platform_unittests/0/stdout

TBR=waffles@chromium.org
Original change's description:
> Passing audio capture timestamp to WebRTC.
> 
> Bug: 1054403
> Change-Id: I6349687ce55535a0cdc405db67687d967a04fea1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066777
> Commit-Queue: Minyue Li <minyue@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Henrik Andreasson <henrika@chromium.org>
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749126}

TBR=miu@chromium.org,wangxianzhu@chromium.org,minyue@chromium.org,guidou@chromium.org,olka@chromium.org,henrika@chromium.org,chxg@google.com

Change-Id: Iba7e0f72e06eba2f4b58a01c67f2e7c33f28cb80
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1054403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098402Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749206}

Add explicit instructions on how to add a userid to
the `kvm` group.

Bug: None
Change-Id: Iea1432c2213a9b8f1b5875c91727963e83cc747a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097158
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749205}

Those tests are flaky on the noncq bot. They are passing on all the
other bots. They are only failing for one very specific configuration
so disabling them for that configuration.

Fixed: 1059496
Change-Id: I77c8764cd02077abd1eb9871a7a968c8ca988830
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093437
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749204}

Remove WebContents#notifyRendererPreferenceUpdate() calls in
CustomTabActivityTabController.java and WebApkActivity.java which are
redundant to WebContents#notifyRendererPreferenceUpdate() call in
TabImpl#initWebContents()

BUG=1059580

Change-Id: I6f55adb5ce7e29f1b00b45ef2dad31ca960bafe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093995
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749203}

https://android.googlesource.com/platform/external/perfetto.git/+log/029aa0d6eb2c..c095a02a0ee0

git log 029aa0d6eb2c..c095a02a0ee0 --date=short --first-parent --format='%ad %ae %s'
2020-03-11 taylori@google.com Merge "perfetto-ui: Sort on aggregation columns"
2020-03-11 treehugger-gerrit@google.com Merge "traced_perf: avoid aligning concurrent ReadTick tasks"

Created with:
  gclient setdep -r src/third_party/perfetto@c095a02a0ee0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ifb887c44357b55da2236587e2fe54e82cd0fc7ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098069Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749202}

TBR=avi@chromium.org

Bug: 1060063
Change-Id: I57c025f40b85517f362daefcbed0ffbf8f5e8485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095971Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749201}

Adjust the number of successful gestures needed to stop showing the
nudge from 7 to 3.

Hide the nudge if the user taps it.

Move the nudge (and hotseat) 2 dips up (further from the screen edge).

BUG=1060368, 1060373, 1060372

Change-Id: I0b0e292648948a4c3d7ee40825ea38c36908779a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097496
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749200}

time_t's backing type isn't always 64 bits. In order to format it as an
int64, a cast is necessary.

Bug: 1058218
Change-Id: Iab600b212e3e83736cbeb0a0a01bf4698aa66317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096106Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749199}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/576a8e97..83b2817d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I37bd97e0821ea9a1773c3cc15dd05b220bdea7d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096939Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749198}

This small CL introduces an addition to the SharedImageUsage enum:
SHARED_IMAGE_USAGE_NATIVE_BUFFER. It will be used
in the shared image factory to determine the correct type of factory
(interop_backing_factory) to be used for platform specific tasks such
as VA-API decoding on Chrome OS.

The goal of this new usage is that on Chrome OS, a SharedImage created
using SHARED_IMAGE_USAGE_NATIVE_BUFFER should have an underlying
buffer and representations suitable for working with a video
acceleration API. In the case of VA-API, this means the underlying
buffer should be a NativePixmap.

Separate CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2083662

BUG=1058103
TEST=None

Change-Id: I7159163b5cc276f9ea4f6d5a6c0835b66bd72c89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089951
Commit-Queue: Paulo Warren <pwarren@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749197}

blink::EventHandler::OptionalCursor is a custom class equivalent to
base::Optional<blink::Cursor>. This CL replaces it with the base class.

Bug: 1040499
Change-Id: I85bb3384b999533c63780177807cbd47d3a8995c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093216
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749196}

Adds browsertest that ensures that on Win a focus event always fires when navigating to another page

If a user of Jaws or NVDA screen reader navigates to another page,
they expect their screen reader focus to move to the web contents, otherwise
they might develop the mistaken belief that the virtual buffer hasn't loaded.
I wasn't able to add a DumpEventTest under content/test/data/accessibility/events
because we filter out all focus events and adding them back would cause too many other tests to fail randomly.
This Windows specific browser is my best shot at testing this expectation.

R=dmazzoni@chromium.org, kbabbitt@microsoft.com

Bug: 1058959
Change-Id: I161ea42c38220d5245b68d271af74f8b748b95ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097389Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749195}

The tests are similar enough that differences can reasonably be
handled by build flags.

Change-Id: I257fb4aebf47cc7e5c67a2965e64dbb90d8a7007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097557
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749194}

TBR=hkamila@chromium.org

Bug: 856601
Change-Id: I516f5039cb227c098977a8645dbe0bebe2d57cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098112Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749193}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55e502897c6e..6a14c8da7c4d

git log 55e502897c6e..6a14c8da7c4d --date=short --first-parent --format='%ad %ae %s'
2020-03-11 jacktfranklin@chromium.org Allow third_party DEPs to be exempt from import rules
2020-03-11 tvanderlippe@chromium.org Add e2etest to verify removal of pseudo states works

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@6a14c8da7c4d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1050549
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I0d060848de576d4344c0ffb6262163d133091183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098072Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#749192}

ExternalNavigationHandler currently directly calls into
IntentWithGesturesHandler when launching an external intent with a user
gesture to record that fact in case the intent ends up coming back into
Chrome. This is //chrome-level behavior, as it is relevant only in the
case where the app handles incoming intents. In addition,
IntentWithGesturesHandler would not be straightforword to componentize.

This CL abstracts this dependence through ExternalNavigationDelegate,
similar to how we have done for other such dependences.

Bug: 1031465
Change-Id: I2138400f7a62d1911073b1fd7b31ef484e7fbc17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095130
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749191}

`_framework_headers_config` is needed by `_framework_public_config` for
the `framework_dirs` variable, even if no `public_headers` defined.

Introduced by https://crrev.com/c/2061194.

Change-Id: I82964f1266aa7c1764f33912b02b48ddf7677ba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098155
Commit-Queue: Bang Lee <banl@microsoft.com>
Auto-Submit: Bang Lee <banl@microsoft.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749190}

This CL records a user action when the user navigates to
chrome://settings/syncSetup/Advanced. This metric is needed for sync
setup friendly settings.

Bug: 1050070
Change-Id: I6206807fd8038385f8cd9d8b9fe1d7e0077c9a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096441Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749189}

TBR=hkamila@chromium.org

Bug: 1060175
Change-Id: I14d9e16673932cf153998d388109d37d898a1720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098106Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749188}

https://crrev.com/c/2087623 wasn't rebased properly which caused
browser_test failures. This CL uses the new testing helpers which
fixes these issues.

Bug: 1047726
Change-Id: If1cccf27566019753b200e63966e2d756f40d745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093442Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749187}

BUG=None

Change-Id: I91ef942b5349e1682660b3040a89d3fc7ecfe425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094000Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749186}

This reverts commit 21285304.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Make the coverage config reusable for generic profiling."
>
> This reverts commit c7695f63.
>
> Reason for revert: Possible reason for win10_chromium_x64_rel_ng failing builds with error:
>
> lld-link: error: undefined symbol: __llvm_profile_dump
> >>> referenced by .\..\..\base\test\clang_profiling.cc:23
> >>>               obj/base\base/clang_profiling.obj:(void __cdecl base::WriteClangProfilingProfile(void))
>
> Original change's description:
> > Make the coverage config reusable for generic profiling.
> >
> > Most of the coverage configuration can be re-used for general
> > Clang-based profiling (e.g. the profiling step of a PGO build).
> > This changes most of the |use_clang_coverage| checks to
> > |use_clang_profiling|.
> >
> > The toolchain opt-out option is still limited to the coverage
> > builds (grep for "toolchain_use_clang_coverage" in CodeSearch).
> > I.e. targets built simply with |use_clang_profiling=true| won't
> > be opted out by the clang_code_coverage_wrapper.py script.
> >
> > This CL is a pure refactoring with no functional change.
> > Getting profiling information from the sandboxed renderers work
> > this way:
> > - After creating a new child process the browser will open a
> >   profiling file for this process and pass the handle to the
> >   child via the SetProfilingProfile Mojo call (see change in
> >   content/browser/renderer_host/render_process_host_impl.cc).
> > - This process will used by the LLVM instrumentation to record
> >   profiling information.
> > - When terminating, child processes will call
> >   WriteClangProfilingProfile to write the data to the profiling
> >   data file.
> > - Once all the raw profile data files have been collected,
> >   they'll be merged (via the "llvm-profdata" tool) and used.
> >
> > Note that this isn't meant to be enabled into any build that
> > will be shipped to users (a profiling build is usually 10x
> > bigger than a normal build anyway, not really shippable).
> >
> > The goal of this refactoring is to make it possible to reuse
> > this mechanism for the instrumentation step of PGO builds.
> >
> > Bug: 1058979
> > Change-Id: If8321234f6b6f86befd81f6e9e068a342728d605
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090493
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
> > Reviewed-by: Sajjad Mirza <sajjadm@chromium.org>
> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#749015}
>
> TBR=sky@chromium.org,thakis@chromium.org,wfh@chromium.org,sebmarchand@chromium.org,liaoyuke@chromium.org,sajjadm@chromium.org
>
> Change-Id: I6aaf638f6385afe35c488575aac84e3e952b76a3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1058979
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096332
> Reviewed-by: Jeevan Shikaram <jshikaram@chromium.org>
> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#749040}

TBR=sky@chromium.org,thakis@chromium.org,wfh@chromium.org,sebmarchand@chromium.org,liaoyuke@chromium.org,sajjadm@chromium.org,jshikaram@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1058979
Change-Id: I5492c81b707e5741bd7c494893e3bc7953221263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097305Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749185}

Adds tests to ensure that about:policy loads properly and that policies
are parsed properly out of NSUserDefaults.

Adds EG2 helpers to retrieve policy settings from the current platform
policy provider.

BUG=1024115,1027249

Change-Id: I9835d106c873efa020293bfff4d59f0feb47abe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088532
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749184}

Start using FileSourceRequest for download deep scanning, since it
achieves most of the same functionality. This CL moves the encryption
checks into the FileSourceRequest, since those are needed by both upload
and download deep scanning.

Bug: 102710
Change-Id: I5b4e1983bd108c6454908586e52f8f2ad2dadcb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095775Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749183}

Change-Id: Id71c80eb058ddd35ecda8156a2faf742d25faf24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095536Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749182}