- 20 Jul, 2020 40 commits
-
-
sandromaggi authored
Bug: b/159309621 Change-Id: I45016405c85a5bef1b674ea8477c34b5bbc30711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306251Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#789862}
-
Alice Boxhall authored
This reverts commit 7da56cfe. Reason for revert: Test is still failing: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20(dbg)(1)/83673 Original change's description: > Update vr_pixeltests exceptions > > https://crrev.com/c/2304097 updated the tests that originally required > this exception to be added so that they now automatically skip/pass on > Windows 7, so we don't need to keep these exceptions anymore. > > Bug: 1106809 > Change-Id: Ia84e677ed9d6f74e040a24a73a0fa4a14720b778 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304936 > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Auto-Submit: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789684} TBR=thakis@chromium.org,alcooper@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106809 Change-Id: Id8a98cce9da8ec8933e75686718f92e7b7ec2d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307011Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789861}
-
Alice Boxhall authored
This reverts commit 38a4c6af. Reason for revert: Newly added test is failing: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19641 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874475110456145024/+/steps/browser_tests/0/logs/Deterministic_failure:_OSSettingsResetPageV3Test.All__status_FAILURE_/0 Original change's description: > [OsSettingsDeepLinking] Add DeepLinkingBehavior & Deep link OSResetPage > > Added the Polymer Behavior to fetch the settingId parameter from the > URL and then focus on elements containing that settingId. Imported in > the OS Reset Page. > > Bug: 1084154 > > Change-Id: I52bb73227447d6293a7b31402f7cc5a29e045309 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296008 > Commit-Queue: Daniel Classon <dclasson@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789709} TBR=khorimoto@chromium.org,tjohnsonkanu@google.com,dclasson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1084154 Change-Id: I1dcf9ed2ea428e69918db46df581c4614a19a40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306122Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/426f13e93f99..8815d8ec324d 2020-07-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9036f6aecab073520e369be520ed1ba9ce4a3d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789859}
-
Leo Lai authored
This CL deploys the usage of platform side of attestation flow because attestation service at platform side knows better about the stat machines of the enrollment. BUG=b:158955123 Change-Id: I902f8bfc43da9cb2cae0e65a0d244c31ce986dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297061 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#789858}
-
Kenichi Ishibashi authored
Bug: 1055677 Change-Id: Ieb2758fdda0ae2a6054936d57e7454ffaad1bddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303411 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789857}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/60bf6924b42f..1860aed6436d 2020-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cc5513855cc5 to 08c4d09493bf (11 revisions) 2020-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 0e82586297a8 to ea6f21a052c9 (4 revisions) 2020-07-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from cb2938a1afd7 to d0dd661f1805 (14 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Id0fa18d73fc4530c675d9ce96142093ba6df720d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305852Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/870e2d8168cc..d969ac13d806 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aboxhall@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: aboxhall@google.com Change-Id: I5d9dd818b7955f2aa4097b5d3639b97311437adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307053Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789855}
-
sandromaggi authored
The first animation used to be delayed, this is not necessary as there are no previous animations to wait for. Bug: b/158750294 Change-Id: If4260181f45be9fb9aaaea574c507600891b58c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302617Reviewed-by:
-
Koji Ishii authored
This patch adds |PostLayout| gurad to FragmentItem codepath in |AddOutlineRectsForNormalChildren|. While I have not succeeded to reproduce the issue locally, this is the most likely the reason from the stack traces. This patch is speculative. Bug: 1105283 Change-Id: I94813dc011e6a43a08a111ad7dfc51804d7877de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303417Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789853}
-
Yoichi Osato authored
This CL implements https://fetch.spec.whatwg.org/#body-mixin: """ Request includes Body; The body attribute’s getter must return null if body is null and body’s stream otherwise. """ Since this feature is required for fetch upload streaming, this CL makes it under the flag FetchUploadStreaming. Fixed: 1105704 Change-Id: I334d9e1a3494ff4ba31efc9dc8b319294d2e19d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297035Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#789852}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/642be1d27d97..39d317835bd0 2020-07-20 yyanagisawa@chromium.org Roll out new goma client binary VERSION=203 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ifd510705b382410de1c35e281f196cfbaea5d6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307050Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595191024-184b839913bdf74d85d86bbb55656bedc1cb42fe.profdata to chrome-mac-master-1595224759-e1768d31ec00790ba2a6883a1e8e7f5013b1d5d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I3984689a6158751d15965f56c632883757126842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307055Reviewed-by:
-
David Munro authored
Bug: chromium:1105298 Test: manual Change-Id: I890e2ae4f7b5b2a49f999aa957c4923d613c19a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301690 Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789849}
-
Koji Ishii authored
|NGFragmentItem| has a union. This change shows only the used member of the union depending on its type. |NGFragmentItems| has a flexible array. VS debugger could show only the first item before this change. With this change, synthetic |ArrayItems| shows all items. Checked no warnings/errors with Natvis diagnostic messages turned on in Tools/Options/Debugging/Output Window. Bug: 982194 Change-Id: Ic5a75668c2e0482f7c6a00915459f6401886b9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294837Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
Dmitry Torokhov authored
Members of a struct are publicly accessible and therefore should not end with an underscore. Bug: 1071872 Change-Id: Icd6a4db3952df9e6c7efe172f0d638e9944bb81b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306550Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#789847}
-
Kenichi Ishibashi authored
This removes direct use of ServiceWorkerResponseReader from tests. Tests use the mojo version instead. Bug: 1055677 Change-Id: Id1d955a88d76b515c5e2be9ed0b8bd12dbade814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302978 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Prior to crrev.com/c/2270077, |OnPendingDownloadsLoaded| always eventually used |original_coordinator_|. The code is updated to perform the same behavior, and ensure there exist a non-OffTheRecord coordinator when the function is called. OnPendingDownloadsLoaded Bug: 1106324, 1099577 Change-Id: Ie6f8a4c727d481eb1b3a946b1de4b0a2a02c70bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302992 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789845}
-
Alan Cutter authored
Change-Id: Ie4499ae0d7c26bffbe1b5cb620ae60c1a8aba2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306501 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#789844}
-
Kent Tamura authored
They become - DocumentPolicyFeatureState defined in document_policy_features.h and - FeaturePolicyFeatureState defined in feature_policy_features.h. This CL is one of steps to drop full mojom header includes from core/frame/frame.h. This CL has no behavior changes. Bug: 242216 Change-Id: I2c8b4114f7ab201de2ccd87cae47562d8da80d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299685Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#789843}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c6e070bb. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I20c6992e924ef88f066d16b511d2d851a343e9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306576Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789842}
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-009.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: Id4bccfbf5cb2f3e1f3158083f095b380482c839e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306117 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#789841}
-
David Black authored
Ink drop layers are painted *beneath* the view background. This posed a problem since our background is opaque. To address this, we redirect our ink drop layer from our view to an InkDropContainerView. This way our background will not obstruct the ink drop effect. Demo: http://shortn/_reUPdq6Q56 Bug: b:161161492 Change-Id: I8457ed207709d343cb9eba020c3a88a2197a9132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303490 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789840}
-
Timothy Loh authored
This CL moves the logging of setup result histograms from the Plugin VM installer frontend to the installer backend. Also tidy up some unneeded plugin_vm:: namespace prefixes. Bug: 1063748 Change-Id: I39cff19fdca9387ac4ca300c59dea6e9a28cb6d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304609Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#789839}
-
Hiroki Nakagawa authored
AddRegistrationToMatchingProviderHosts() on ServiceWorkerRegisterJob is an outdated function name. ServiceWorkerProviderHost were separated into ServiceWorkerHost and ServiceWorkerContainerHost. This function should be renamed to AddRegistrationToMatchingContainerHosts(). Bug: 931087 Change-Id: I525c588a808a1b49424b345a6426abf9be03a1bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303748Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
My Nguyen authored
Adjusting color, paddings and font-size to match spec. Current view: http://screen/7kkHnq2NMqY See spec in bug Bug: 1106644 Change-Id: I7281430568f30e6fc96403443d05d622849d8d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303936Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#789837}
-
HyunJi Kim authored
It seems the job in TODO comment has been resolved. So I think we can safely remove it. Change-Id: Ic9d4b919e72373382f5da8828e5d890e9494b009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297071Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Gavin Williams authored
The blue highlighted state ensures the color of the printer status icon background-badge always matches the background of the dropdown item. http://screen/JxUqAa8Uhai Bug: 1059607 Change-Id: I93e665f6cc3a12f8976f9135c7be3b210f9d0224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301124 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#789835}
-
Kenichi Ishibashi authored
This CL replaces old response writers with new mojo-based writers in the following test helper functions: * WriteToDiskCacheWithIdSync() * WriteToDiskCacheSync() * WriteToDiskCacheAsync() Bug: 1055677 Change-Id: Ic897b36d770a57efc88b53dde6a0e4776f626785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301710 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-004.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: I114a279e440bf18df6ba7f13808c34089528fad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306496 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-001.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: Ib46e754f93ffac99054968123a6651e30f45e324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305821 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Peter Kasting authored
Based on thakis' suggestion that the names shouldn't mirror std:: when the functions didn't behave the same, and some feedback on #cxx that "saturated" is less obvious than "clamped". Bug: none Change-Id: Id0d9651b9fcc13f1acb663d56f357c7eab1c994e AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306750Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#789831}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1595066475-962e9a9c381a2273ccfe1834d9f1dc2b972cf2cf.profdata to chrome-win32-master-1595191024-521ec280875ff00917e41f4db8004114035c0cbe.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If76adaa6558dc831bc1ad388acc76f3dc44eeabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306818Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dc107a0c..f3d231ec Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3ce090640efba4d9a3762349cc5c553009e1fe7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305916Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789829}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=rayankans@chromium.org Change-Id: Ia0302dcba3b4a4fcaac69b8b1801e29c09cb6578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298860 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Anand K Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#789828}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/324e3e521fd4..60bf6924b42f 2020-07-19 rmistry@google.com Output different error for when CL cannot be created in canary task driver If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ifa0db82d35b59735f8236560b6a47595e950b9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306810Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "editing/deleting/delete-line-002.html" to utilize |selection_test()| to avoid using unnecessary reference images for ease of maintenance and enabling new features, e.g. EditingNG, high-DPI font, etc. Bug: 679977 Change-Id: Idd5e56cece8cf891373add23e924fb15107155cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306495 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
According to the finch results on M83 Stable and the discussion, all launch blockers of this feature have been cleared. This patch first enables it on trunk. A followup internal CL will enable it in other channels via finch configurations. Bug: 1040632 Change-Id: Icd9ab4a85c9d755072310c1be4fc4e524133d6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296280Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#789825}
-
Leo Lai authored
With this CL, the CA type can be configures as the way we do in AttestationCAClient. BUG=b:158955123 Change-Id: I78c4c23c334bec456e86f9591fb6363e99a50d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297060 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
-
Bartek Nowierski authored
This CL reduces the estimated pre-processed size of partition_alloc.h by 200KB. It affects 8,400+ compilation units. Co-author: bartekn@ Bug: 242216 Change-Id: I0cce59b944eb092dd44c9dd8bc2d5fdb90521cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298787Reviewed-by:
Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#789823}
-
