- 29 May, 2019 40 commits
-
-
Rohan Pavone authored
Adds newWindow and background params to Target.createTarget, exposing ability to create a new window or tab, as well as whether to create it in the background or foreground. Design doc: http://bit.ly/chromedriver-new-window Bug: chromium:966010 Change-Id: I5cb5875af668f5c37ecfb778392dd09315091ee0 Tested: Manually using ChromeDriver + WPTs (in a branch with the NewWindow endpoint implemented). Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623131 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#664469}
-
chrome://flagsMay Lippert authored
BUG=950007 Change-Id: I16148bf58dd006305e375b5ae8ec5aa4551eba80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636032Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#664468}
-
Brian Sheedy authored
Does the following refactoring/cleanup in the XR browser tests: 1. Standardizes the naming of test classes. 2. Switches any easily-ported OpenVR tests to run with both OpenVR and WMR runtimes. 3. Deduplicates some code DirectX adapter enumeration code. 4. Ensures that WMR tests always create a test hook before the test starts, to avoid issues with the real Mixed Reality Portal starting up if it's installed and a test hook is otherwise not needed for a test. 5. Documenation clarification. Bug: 926048 Change-Id: I2af46b3aa103f5b8d80c676154af451e93384a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633316 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#664467}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 84dbdd78. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 0882bebe "Change ICE connection state on transceiver changes" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dcheng@chromium.org, palmer@chromium.org: external/wpt/domxpath ericwilligers@chromium.org: external/wpt/css/motion foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ia2a4e6a55f46adccb279302081c9bfb84668795e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635205Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664466}
-
Maksim Ivanov authored
Use Polymer data binding in order to compute elements' visibility on the screen_gaia_signin screen. This removes most of the imperative manipulation of "hidden" attributes and other related logic from the JavaScript code. The only remaining old-style visibility logic is the one for SAML video recording (saml-notice-recording-indicator) - that one will be refactored in a follow-up CL. Bug: 964069 Test: manual Change-Id: If96b65dd6fb3664b66125b162e09e5d05a7e8dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627383 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664465}
-
Kayce Basques authored
Bug: 967940 Change-Id: I921dfeadb8780132cef228371395a491c9db264b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633511 Auto-Submit: Kayce Basques <kayce@google.com> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#664464}
-
Alex Cooper authored
Per the WebXR Spec, the inputSources attribute is supposed to be a live array whose input sources are updated in place. Currently the code creates a new array on every query. This changes the internal hash map of input sources to be an XRInputSourceArray object. The XRInputSourceArray object is implemented with a backing HeapHashMap so that the existing logic (i.e. looking up/setting/erasing by id) is more performant than getting by the index. This does have a side effect of meaning that an input source's position in the inputSources array can change, as it's ordering is based on the ordering of the HeapHashMap's backing .Values store. Bug: 966552 Change-Id: I21396ebbbbef6799a6bdd98791706c9159c9e061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632872 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664463}
-
Scott Little authored
Previously, support for the "loading" attribute to control lazy image loading was only used in conjunction with automatic lazy loading. This CL separates those two concepts, allowing for "loading" attribute support to be enabled for images without automatically lazily loading images that have no "loading" attribute set. A followup CL will hook this up for lazy frame loading as well. Bug: 937980 Change-Id: I55e5028ac92af61f116486f3c461b0b4fcb6ee1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590859 Commit-Queue: Scott Little <sclittle@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#664462}
-
Saman Sami authored
https://crrev.com/c/1539860 changed child throttling to allow only two unembedded surfaces. However, this seems to have regressed latency so revert back to allowing three unemedded surfaces. Bug: 951992 Change-Id: I49f67d5299642063ef265aed34767f56f1706eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598419 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#664461}
-
Tomasz Wiszkowski authored
This change also ensures the favicons are rendered in case of race between LargeIconCache and AutocompleteMediator: if LIC supplies favicon BEFORE AutocompleteMediator sets the property value (very narrow time window), favicons would not be shown. Bug: 961158, 960421 Change-Id: I8983f1aaa9e69ecc9f2b2fb7d0bb4a556d6d86bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630234Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#664460}
-
Ted Meyer authored
This refactor sees D3D11PictureBuffer no longer holding a D3D11Texture2D, instead it holds a wrapper class which is responsible for creating and owning gpu resources and mailboxes. The default wrapper behaves exactly like the old implementation. Bug: 963742 Change-Id: I49c67517203ef6464a6f0f2d3609bd7e484ac4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614937 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#664459}
-
Rayan Kanso authored
According to https://developers.google.com/protocol-buffers/docs/proto#maps iteration ordering of map values is undefined. This CL sorts the metadata entries before in the DevTools frontend so they can be presented in a consistent order. Also remove redundant test formatting, fix the OWNERS Background Service regexp to include the handler, and make the row counting start from 1. Change-Id: I36024f23fbb307b1160cd67120dcf67ca8697aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615251 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664458}
-
Alex Cooper authored
If the javascript callback ends the XRSession, then the input events should stop being processed. This check is also needed because ending the session may have changed the state of other variables that are still being processed, and access violations could occur. Bug: 967853 Change-Id: Ia54112cdb806e1ed75c32ac9b202dafb85d9b9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633749 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
kylechar authored
If Window::CreateLayerTreeFrameSink() is called more than once the DCHECK(!embeds_external_client_) would fail. This is because SetEmbedFrameSinkIdImpl() would always set |embeds_external_clients_| to true even when it wasn't called for an external client. Fix how |embeds_external_client_| is set. Also remove |frame_sink_id_internally_allocated_| since this seems like just the inverse of |embeds_external_client_|. Bug: none Change-Id: I0109106083206e0aee6743ba0c4d66e5ce15e5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634386Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#664456}
-
Scott Violet authored
Remove references to mash. BUG=none TEST=none Change-Id: I02c85b4cae87d343bd0adb0cdb7cd00be4884477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635875Reviewed-by:
-
Ahmed Mehfooz authored
This protection should fix this crash bug. Since, it is possible for an ArcNotificationItem to be deleted before an ArcNotificationContentView. Bug: 940716 Change-Id: Ie8b926748358308a91ddab4b854ed2ca21deb5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632918 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#664454}
-
Drew Stonebraker authored
android_webview/docs/prerelease.md links to the a webview bug filing template using https://goo.gl/9qkbdn. Since goo.gl is being deprecated, update this link to the full url. Test: Open prerelease.md in gitiles and check that the link is the full Test: url and links to the right place. Change-Id: I2310e0a962cafde66409e324612de6df80c48ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635989Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Cr-Commit-Position: refs/heads/master@{#664453}
-
Xing Liu authored
This CL fixed an issue that copy link option in the context menu also records an open url metric. Bug: 967941 Change-Id: I943f610b4082a9f913e1dd7ed24036747dd94f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633971Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#664452}
-
Scott Violet authored
BUG=none TEST=none Change-Id: I0296fdaff20f6826a84acedbb745d5b3bba47c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634561Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/566314b3ea6d..29364a0595bc git log 566314b3ea6d..29364a0595bc --date=short --no-merges --format='%ad %ae %s' 2019-05-29 srisser@google.com Fix buffer overflow on Mac 2019-05-29 capn@google.com Fix initializing bits after bitfields 2019-05-29 samans@chromium.org Fix build failure Created with: gclient setdep -r src/third_party/swiftshader@29364a0595bc The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:944796,chromium:967704 TBR=swiftshader-team+autoroll@google.com Change-Id: I9f30a3ee8c6c67e8ab654ee405274ad3f7933962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664450}
-
Luna Lu authored
Use counter ukm metrics measures usage of the same enum FeatureObserver (defined in enums.xml) as the use counter uma histograms. This CL adds enum attribute in the use counter ukm xml that the ukm dashboard can use the label the enum value (int) with the string label defined in enums.xml This CL also adds a presubmit checker to verify the enum declared in the ukm.xml file is defined in enums.xml Change-Id: I15388109a9a6647275efd02c9999aa77b4db65b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629187 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664449}
-
khmel@chromium.org authored
This traces input event and provide information that could be used to match events on Android side. TEST=Locally, confirmed that input events appear in ARC++ tracing tool. BUG=b:132709527 Change-Id: Ice6e823f7be43db0e832253913c27a810dcca4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625816 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#664448}
-
Jian Li authored
Bug: 967486 Change-Id: Iea0b436f94bb7dbfbbde8a97d14e7219f385f2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635879Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#664447}
-
Steven Bennetts authored
Bug: 862420 Change-Id: I9efda6eb3732ee36a82589e680b0455a4797d9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628811 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#664446}
-
Drew Stonebraker authored
Document what was learned about WebView channels while working on the project to build channels for standalone WebView. Bug: 965781 Test: Open the markdown files in this CL, and click "gitiles" at the top Test: of the page to view formatted markdown. Change-Id: I2e7cc6df5ff4b4833d1404ccb4f249f31edb8388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623498 Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
François Doray authored
A ScopedBestEffortExecutionFence prevents BEST_EFFORT tasks from starting their execution within its scope. TBR=gab@chromium.org Bug: 887407 Change-Id: I3accc5c2de212409510487174de0416697ab59a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635572Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#664444}
-
Vlad Tsyrklevich authored
Now that this experiment is rolling out to stable and has been enabled by default on ToT, delete the field trial. Bug: 912286 Change-Id: I020c490d204a92e71bd2fe1a4f09d63b9e7bedab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629487 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9d4f217992f9..2d287c02ed32 Created with: gclient setdep -r src-internal@2d287c02ed32 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:867592 TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I949731f5e6de3d14503d20a933e5886aa8a9f32e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635532Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664442}
-
manuk authored
This is the 15th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. Bookmark providers compare the user and suggest texts and find the corresponding matches during construction in 'TitledUrlIndex::AddMatchToResults'. These are then used for both scoring and classification. With this CL, bookmark classification uses the 'FindTermMatches' and 'ClassifyTermMatches' methods that other providers use. This improves consistency with other providers at the cost of inconsistency with the bookmark provider's scoring. The most prominent distinction is prefix matching; where if the user input is an exact prefix of the suggestion text, subsequent matching words in the suggestion text are not bolded. E.g., before this CL, the user text 'the' would match the bookmark suggestion '[the] cake ate [the] moon'; whereas with this CL, it will match only the first occurrence of 'the', '[the] cake ate the moon'. Re consistency with other providers: A user may see suggestions from different providers with similar texts. E.g., the user input 'the' could provide both search and bookmark suggestions with texts 'the cake ate the moon'. It would be surprising if such suggestions with the same text were bolded differently; e.g. the search suggestion were bolded '[the] cake ate the moon', whereas the bookmark suggestion was bolded '[the] cake ate [the] moon'. Re inconsistency with bookmark provider's scoring: Bookmark scoring does not consider prefixes specially and all occurrences of the user input contribute to the score. Not bolding subsequent occurrences suggests otherwise. E.g., the user input 'the' could display two bookmark suggestions '[the] cake ate the moon' and '[the] cake ate a moon', and the first would be scored higher because it contains a second occurrence of 'the'. In addition to a change in prefix bolding this CL has some other minor side affects on bolding regarding word-separators and matching input words shorter than 3 characters incompletely with suggestion words. E.g., the user input 'the' (3 characters) previously matched '[the]' and '[the]re', but 'th' (shorter than 3 characters) only matched '[th]' (complete match) but not 'the' or 'there' (incomplete matches). Bug: 366623 Change-Id: Ifc08aae00359be2669b05189e249d531ed3dabf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588554 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#664441}
-
Peter Mayo authored
A small tweak to clarify the modification of a member variable across a pointer. This way if the modification of contents is traced or overridden the this pointer is the one you would expect, rathern than a parameter. Bug: None Change-Id: Ic04a83f898b2b1b96149918871e1f7052b569883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629850Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664440}
-
Xianzhu Wang authored
Enable showLayoutTree(), showTree(), showLineTree() etc. for DCHECK_IS_ON(), for convenience of using them in debugging code in a release with DCHECK build without building a slow debug build. Change-Id: Id3c4e63d35c928907160df1baae3b10ef32bc750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632666Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#664439}
-
Ken Rockot authored
This eliminates the need to register out-of-process services at the Content layer, separate from their manifests. Display names for service processes are taken directly from the manifest now, including support for string resource IDs resolved to localized strings by the Service Manager at runtime. Bug: 915806, 895615 Change-Id: I585b03ceb5489ea1a11f95a1c77d9b36048068c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615882Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Daniel Nicoara authored
* Add rotation information to the ManagedDisplayInfo. Allows clients to be aware of the display rotation and allocate buffers in the native orientation. Buffers in the native orientation can be overlayed by the compositor. * Fix how the ManagedDisplayInfo bounds is updated. display::Display's bounds is in transformed space. ManagedDisplayInfo's bounds is in native display space. Need to un-transform the bounds to report the right information. EXO apps will use this to allocate buffers in the native display scanout orientation, allowing the compositor to skip composition and just overlay the buffer. Bug: b/132813099, b/131769446 Test: Ran wayland_fullscreen_client on device with various orientations. Change-Id: Ibef6e30bf9ce59a4004c1a179b8cefe8ab1866aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636029Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#664437}
-
Drew Stonebraker authored
The content from chromium.org/developers/androidwebview/android-webview-beta should be moved to our markdown docs at android_webview/docs/quick-start.md. That page contained some FAQ questions, which seemed a little out of place for that page anyway. This CL recreates that content in android_webview/docs. Bug: 963092 Test: Upload to gerrit > open file > click "gitiles" Change-Id: I6e1cb4e5153b9015bf17dab1889def8140689da1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611367Reviewed-by:
-
Kevin Babbitt authored
Call AddPopupChildren() when walking the layout tree in order to ensure that popup contents for controls such as <input type="date"> are added to the accessibility tree. For testing, I wanted a tree dump that would show the contents of the popup. I tried a couple of different techniques to simulate a click on the popup button from script but none of them worked. Instead I added the ability for the tree dumper to synthesize clicks on elements after the document is loaded. Bug: 964154 Change-Id: I75b6169bfd336bd98c70e93960f4f56a6413424f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616387Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#664435}
-
Madeleine Barowsky authored
Out-of-process rasterization is enabled by default on perf bots, but means the YUV decoding path will be avoided until that branch is implemented. Bug: 900264 Change-Id: Ideaa78856fc754be3436d8fecd3589b127016d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626504Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#664434}
-
Yuwei Huang authored
s/Passthroguh/Passthrough/ Change-Id: Ic6630c6c83b03767dd83dce28cf9710fa280708a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635863 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#664433}
-
Lutz Justen authored
Adds code so KerberosCredentialsManager can listen to the 4 Kerberos prefs and handles kerberos.enabled (removes all existing accounts). Moves the registration of 3 prefs from profile to local_state since those prefs were not per-profile, anyway, and it simplifies lifetime of KerberosCredentialsManager as it does not have to wait for the primary user to be available. Also changes lifetime from a static singleton to explicit management since KerberosCredentialsManager owns a pointer to local_state now and it would otherwise be hard to justify that the pointer is never dangling. TBR=battre@chromium.org BUG=chromium:952239 TEST=Turn KerberosEnabled policy on, navigate to chrome://settings/kerberosAccounts, add an account, Turn KerberosEnabled policy off, verify that the account vanishes. Change-Id: I3f4ed443014726d8b2c5f2cc536703badf37d2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617455 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:Dominic Battré <battre@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#664432}
-
Sunny Sachanandani authored
VSyncThreadWin will continue posting tasks if vsync is enabled even when the thread is being joined before destruction. Disabling vsync before joining works around this. Bug: 965936 Change-Id: Ibb4b790feca5dae099ebe594802728d2571c73a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635854Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#664431}
-
Shimi Zhang authored
Test is failing on M and L bots. Bug: 968043 Change-Id: Ied66c5015d832f42d141734b8b3a272f05947f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635930Reviewed-by:
-
