- 23 Jul, 2020 40 commits
-
-
Danil Chapovalov authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/f624790b7f..41a6263fd0 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/f624790b7f..41a6263fd0 Bug: None Change-Id: I79e04696901bf607d83ff66393340de2bd5da3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315143Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#791269}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I90724839a059c21bb98098c90a3861863f12c5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316003Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791268}
-
Elly Fong-Jones authored
Currently, some flags tests that need to simulate flag expiration work by installing a custom expiration predicate that replaces the entire body of flags::IsFlagExpired(). This is convenient but makes it difficult to test the expiration logic itself. This change replaces that test hook with one that allows injecting a custom set of flag expirations, by analogy with SetFeatureEntries(). The expiration logic then happens as normal. Tests that used to rely on a custom expiration predicate are rewritten to control expiration in the same way as production code would (i.e. via features). This change is preparatory to fixing the linked bug. Bug: 1101828 Change-Id: Ie6336c1fc1522edf2a62cd4044c121cf86ac4e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309352 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#791267}
-
Pavol Marko authored
http/tests/devtools/tracing/timeline-js/timeline-gc-event.js is flaky on Mac builders, mark it as such. Bug: 1108786 TBR=ulan@chromium.org Change-Id: I40861cea4daee5d2dcf3fa4aa91c30beceef86b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315689Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#791266}
-
Ben Mason authored
TBR=andypaicu@chromium.org Bug: 1108800 Change-Id: I4d4bbda03d49039a378764db2a92f2463e67a353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316316Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#791265}
-
Torne (Richard Coles) authored
Avoid needing to update the R8 playground script to point at the correct version of build-tools by just finding the first one available, since this is just a quick experimentation tool and not part of the actual build. Change-Id: If277326101039b1e5ec2ef0541008045957ed398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316317 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#791264}
-
Sangwoo Ko authored
Theres' no intended behavior change. ui: :ImageModel should be preferred to gfx::ImageSkia. Bug: 1048901, 1100034 Change-Id: I20d653317e3e8e0dd4782688e135f34f1507ef39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315664Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#791263}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9061d5d154bc..4d9cadd58aea 2020-07-23 tommek@google.com Enabling sampleMask usage in RenderPipelineVk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibe4bdbf3e93091276a14d199b771a3da4e5af354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316239Reviewed-by:
-
Alexander Cooper authored
These focus changed calls ultimately trigger javascript events. These events could potentially run code that would modify the list of items that the FocusChanged notifiers are notifying, and thus invalidate their in-use iterators. Fix this by having these methods iterate over a copy instead of the member list. Fixed: 1107815 Change-Id: I03fa08eeadc60736f3a3fae079253dbd3ee26476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314158Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#791261}
-
Maksim Ivanov authored
Support having multiple AuthStatusConsumer's in ExistingUserController. This is a preparation CL for implementing a browsertest that needs to subscribe itself as a "consumer" without suppressing the default consumer functionality (LoginDisplayHostMojo). Bug: 1033936 Change-Id: I97e6869c105bcddc6263f6bc201ff370a03d41dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315336Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#791260}
-
Anders Hartvoll Ruud authored
It used to be the case that animated values for custom properties were part of the base computed style. Hence this flag was used to avoid caching mechanisms when the base is "tainted" by animations. With the StyleCascade, animated custom properties don't work like this anymore, and the base computed style optimization has also been totally reworked recently, so this flag is now useless. Change-Id: Ie7ac5c39ce8d2f54e41a88df3dc28f6664f6b9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307239 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#791259}
-
Peter Wen authored
Remove allowlist for bypassing turbine direct deps since the last items in the allowlist (cronet and modules) have been removed. Bundle feature modules require the base module in their classpath. Previously they were able to get by since the base module was added to their transitive classpath, but the base module should be in their direct classpath as it is used directly in R.java via inheritance. Fix in reland: - Add missing dep on base module java Tbr: agrieve@chromium.org for reland Fixed: 1082904 Bug: 1082904 Change-Id: I4b2d6a173ad207efcc9730589b1322a02071a2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314938 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791258}
-
W. James MacLean authored
http/tests/devtools/tracing/timeline-paint/timeline-paint.js http/tests/devtools/tracing/timeline-misc/timeline-event-causes.js TBR=petermarshall@chromium.org Bug: 1046784 Change-Id: If96dfea5f642fa1602be56d00008a5b3495769ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314756Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#791257}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ic6124be6b77041cfc902f0f82d3e410bd1f0c734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315305Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#791256}
-
Marijn Kruisselbrink authored
This implements the change from https://github.com/WICG/native-file-system/pull/207 Change-Id: Ib496775f1c7e1a2c7b4be4f56232739acfc0d020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311054Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#791255}
-
Garrett Beaty authored
Bug: 1108842 Change-Id: I44ae858ebe99f33a713d814c1257359b49870a1e No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315387Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#791254}
-
Wei-Yin Chen (陳威尹) authored
In crrev.com/c/2314297, the following tests were disabled because they were flaky on emulators: - StartSurfaceTest#testScroll_Top__NoInstant_Return - StartSurfaceTest#testScroll_Top__Instant_Return - StartSurfaceTest#testScroll_Quick__NoInstant_Return - StartSurfaceTest#testScroll_Quick__Instant_Return They are re-enabled on builders like android-pie-arm64-rel. Bug: 1108459 Change-Id: I3f66a184db1e292a3f98c7a647d9cc23ab42b276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314875 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791253}
-
Vasiliy Telezhnikov authored
RunAfterPendingVideoFrames is used to make sure VideoFrameFactoryImpl pipeline is ordered and the callback is run after all pending CreateVideoFrame is done. For this purpose it RequestImage() with the same ImageSpec as last request and waits for request to complete. It is possible that RunAfterPendingVideoFrames is called before any CreateVideoFrame calls and so ImageSpec isn't initialized yet. This CL fixes this by skipping RequestImage() in this case, as there should be no pending CreateVideoFrame. Bug: 1099384 Change-Id: I669718a8c470c1f0360a79c47317252025fdedd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302410Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#791252}
-
Nicolas Capens authored
Bug: 937268 Change-Id: I395e96ea8cf72efc6c3ea69b401bc74a7f543af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311119Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
This makes sure this code works for non-native file systems. Bug: 1103076 Change-Id: I1579fd33cd40b6527504a89987ba8dbc9b3c8931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304958 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Sangwoo Ko authored
There's no intended behavior changes ui: :IamgeModel should be prefered to gfx::ImageSkia. Bug: 1048901, 1100034 Change-Id: I356a160e04f162ca6185efd798f064fb5adac305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315662 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#791249}
-
Sorin Jianu authored
Per-project coding style: ref counted types must be thread-safe and sequence affinity declared with sequence checkers in destructors if needed. The motivation for such change is that our types get aggregated in different ways, and mixing thread-safe and non thread-safe may result into puzzling asserts in ref-counting code when objects get shared between sequences. Bug: 1105922 Change-Id: Ie3b182b31765d0416ae5d6ca108782843b95528e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314677Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791248}
-
Sergey Silkin authored
https://chromium.googlesource.com/external/github.com/cisco/openh264/+log/a5473711f3e2..3dd5b80bc4f1 $ git log a5473711f..3dd5b80bc --date=short --no-merges --format='%ad %ae %s' 2020-07-07 tim meson: fix warnings when copying headers into the builddir 2020-07-01 jpetridis DecUT_ParseSyntax.cpp: avoid dangling-else warning in if statements 2020-06-28 xiaotianshimail2 Add thread decoding support for multi-slice frame. Note: In each call to DecodeFrameNoDelay, iSrcLen must be the byte-size of one coded video frame. 2020-06-06 xiaotianshimail Fix oss-fuzz reported issue 20491. 2020-05-31 tim Fix MSVC compiler warnings about non-ASCII characters in the source 2020-05-18 guxiwei-hf codec/common: [MIPS] Add msa deblock and copy_mb optimization. 2020-04-29 linjie.fu encoder_ext: modify the verbosity level for QP changing 2020-04-23 huili2 fix sha mismatch error due to travis failure and turn of TemporalLayerSettingTest UT 2020-04-13 bernd.kuhls fix mips build 2020-04-07 mcatanzaro Bump ABI to version 6 2020-04-06 mcatanzaro Update version number in meson.build 2020-03-26 matthew meson: disable tests automatically it gtest is not found 2020-03-11 33369297+borzun Fix linker errors in win32 WelsDecoder.sln 2020-03-10 matthew meson: add support for android, ios, macos 2019-10-08 fontaine.fabrice Add USE_STACK_PROTECTOR option Created with: roll-dep src/third_party/openh264/src Bug: 1108639 Change-Id: I3eb4f5ccb61fd4ebe69bab5c9390b8185a26104b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315023 Commit-Queue: Sergey Silkin <ssilkin@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#791247}
-
Sorin Jianu authored
Bug: 1105922 Change-Id: I3475c8848d9ed5af078db8eebac75e2021583dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315801Reviewed-by:
-
Scott Violet authored
My plan is to create a FaviconBackend with all the favicon related functions. FaviconBackend will be an implementation detail of HistoryBackend. HistoryService will continue to call to HistoryBackend, but all favicon related functions in HistoryBackend trivially forward to FaviconBackend. FaviconBackend will indirectly depend upon HistoryBackend for redirects. Because of this, it doesn't make sense to have HistoryService talk directly to FaviconBackend. This is a straight copy (with some very minor changes to appease the presubmit checks) so that it'll be easy to see what actually changes. BUG=1076463 TEST=covered by tests Change-Id: Ia1e5345e4a632f52e79c5392090690d305975a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314813 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791245}
-
Tanmoy Mollik authored
This class will be used by ManageSyncSettings as well during sign out when MOBILE_IDENTITY_CONSISTENCEY is on. Bug: 1092410 Change-Id: Iefbdac89c38599411d400db32046e658c1cf51b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315022Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#791244}
-
Daniel Nicoara authored
BUG=None TEST=Compiled cast_shell with debug (release optimizes out utility functions). Change-Id: If0ab660ac716366e4278abc35582fee31f61328c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314659Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#791243}
-
Stepan Khapugin authored
The omnibox' textfield is focused programmatically upon a button press. This is no longer as straightforward as it was in single window. On iOS 13, tapping a textfield will make the corresponding window key if necessary. Do this before becoming first responder. Bug: 1072414, 1092824 Change-Id: I9b9df1d41c84a89f820c813f8fa2691897dc6076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312704 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#791242}
-
Viktor Semeniuk authored
This change sets clear background colour for UITextView on popover. Bug: 1108741 Change-Id: Ifa46a2520e6b176fcd3873eeb56c33150a70178e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316196Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#791241}
-
Nate Fischer authored
No change to logic. This exposes some @VisibleForTesting methods which WebView services need to access. Bug: 1107950 Test: autoninja -C out/Default monochrome_public_apk Change-Id: I8f6d3c6d0b091db79c3b531e87fd7b642a06399e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313836Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791240}
-
Gavin Williams authored
This change will prepare the tests to allow setting PrinterStatus flag to enabled by default. Update the script in PDFPluginNotKeyboardFocusable to focus the destination_select element. Make NativeLayerStub return an empty JSON for printer status when the printer_id isn't found. Set the flag to always disabled in PrintPreviewDestinationSelectTestCrOS. The equivalent of these tests will run in PrinterStatusTestCros with the flag enabled. Bug: 1059607 Change-Id: I49e2f3d133434c4c5c1770971271074e9f45ab19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298030Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#791239}
-
Maksim Sisov authored
SurfaceHandle is of the same type as ozone now. Remove the USE_X11 section now. Change-Id: Ic69a251a5bc5214b3c00f39446d430e74253692d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315344Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#791238}
-
David Bienvenu authored
Also, change IsFullScreenWindowMode to not require the absence of WS_THICKFRAME when deciding if a window is full screen. This issue this fixes involves the glass_browser_frame_view when maximizing after going full screen - an extra 8 pixel bar gets drawn above a maximized window, and if there's another monitor above the one with chrome maximized, the bar gets drawn on the other monitor. Windows doc https://docs.microsoft.com/en-us/windows/win32/winmsg/window-styles claims that some styles can't be changed after the window is created, but also says that if you change frame styles, you need to call SetWindowPos with SWP_FRAMECHANGED, which we are doing. Not removing the WS_THICKFRAME style doesn't seem to have any visible effect on full screen windows. Bug: 1014720 Change-Id: Ibfbd480c603fd7c3aca74081201e99e59fbbbecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972258Reviewed-by:
-
Francois Doray authored
Bug: 1075553 Change-Id: I9ac77c32e96dba8a4f56fda637a8b7d0313b83aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314456Reviewed-by:
-
Tina Wang authored
Previously “Autocomplete Searches and URLs” fails to work as intended after enabling “experimental settings > “Enable Sample Policies”. Bug: 1108313 Change-Id: I83d0d12d5e9f0017f2791a7bc3ba75abc476f3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315499Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791235}
-
Thomas Lukaszewicz authored
Updated Slider to be default constructable. Cleaned up some calling code. Bug: 1108460 Change-Id: I03b91286288322c2709e9ace2d0196dbc04ff230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313496Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#791234}
-
Friedrich Horschig authored
Since the button has no functionality yet, hide it by default. Advantages of hiding over removing the code: - it provides the correctly styled button for other experiments - we can keep the finished translation for now and can reenable it on short notice Bug: 1106277 Change-Id: Ic82ac97b6de43451b15202fbce1dd06d117ec18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312801 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#791233}
-
Torne (Richard Coles) authored
The version of dexdump in build-tools 30.0.1 includes more information than previous versions in its output, which has revealed that it doesn't encode its output as valid XML in all cases; Java strings with control characters or nulls end up emitted literally in the XML output, which breaks ElementTree's parser. b/161925303 has been filed internally to track fixing this in dexdump itself. Since we only need to be able to extract a few specific things from the dexdump output in our tooling, just replace invalid characters in the output with the Unicode replacement character (as Python does when using the 'replace' error handler in encoding) before parsing it. Bug: 1106471 Change-Id: Id1c3a40e5ce91125dbee9fdf1923383d02314f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314986Reviewed-by:
-
Ben Mason authored
TBR=cduvall@chromium.org Bug: 1108684 Change-Id: Ibbaaf0b555c01c2a55c8c6469dc10c8ebe5b9536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315836Reviewed-by:
-
Shuran Huang authored
Added a UseCounter that tracks when window.name that would have been cleared because of a top-level cross-browsing-instance navigation is accessed. The metric will be used to determine whether we can safely clear the window.name in such cases. Bug: 1090128 Change-Id: I9224ae9e542a55b5d4a2efe437037ad2ea115b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276250 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
