GitLab

Bug: 1017166
Change-Id: I627c576a322c5e701fad105659b213c415e32a40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940207Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721295}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ac7755fac459..4bab6cb11c26

$ git log ac7755fac..4bab6cb11 --date=short --no-merges --format='%ad %ae %s'
2019-11-27 skau system_api: Register org.chromium.PrintersService

Created with:
  roll-dep src/third_party/cros_system_api

Bug: b:143242799
Change-Id: Ie7ced8e7e97219e3d86657a74870a2957bf9fbf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949029Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721294}

When the device is physically used as a tablet (e.g. detached or
flipped), the keyboard shortcut to rotate the display should
behave as a request to lock the user orientation to the next
rotation of the internal display.

App windows are allowed to lock the rotation to a particular
orientation in tablet UI mode on the internal display only.
In this case, the shortcut should switch between the allowed
rotations if any, or do nothing.

For example:
- If a window locks the rotation to kPortrait, the shortcut should
  switch the user rotation lock between kPortriatPrimary and
  kPortraitSecondary.
- If a window locks the rotation to kPortraitSecondary, then the
  shortcut should do nothing.

BUG=925087, 1026398
TEST=Manually, Added a new test.

Change-Id: I34bf76a336ef81de4f1f5269843a3dd8c5efcd4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892054
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721293}

This helps to create balanced shard maps. Specifically for weblayer bot, this will help
us add startup.mobile without unbalancing the shard maps.

Bug: 1026327
Change-Id: I8f5ebceba13cc6f7de8450389ecf59410425e1c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949239
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721292}

Callback should set result if it returned true.
Detected with "init_stack_vars = true".

Bug: 1030261
Change-Id: I9088a0ab498c44f9a765bf89361c91298d9458e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949643Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721291}

https://swiftshader.googlesource.com/SwiftShader.git/+log/8ffeadb66ea7..fca575e9fa48

git log 8ffeadb66ea7..fca575e9fa48 --date=short --first-parent --format='%ad %ae %s'
2019-12-03 chrisforbes@google.com Regres: Add pending deqp change to fix bad graphicsfuzz tests

Created with:
  gclient setdep -r src/third_party/swiftshader@fca575e9fa48

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ica762341c58e6ad5a25beb37b6042c71865c012d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949583Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721290}

- An End License User Agreement (EULA) link will be displayed to users
  in print preview if the printer they have selected requires a EULA.
- Adds a browser test to reflect this change.
- This CL will have a follow up to actually get the EULA URL from the
  Printer object.

Bug: 1023589
Test: Browser Tests + end to end manual
Change-Id: Iadffddf148eb13bc95687532ed66b9e2215ff3c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929089
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721289}

This CL fixes tests that will be broken by
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1889351

Bug: 963183
Change-Id: I3af9e90385d38fd9f9dce6c8107de41afda03db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811968Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Jack Lynch <jalyn@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#721288}

Disabled due to flaky failures.

TBR=aleventhal

Bug: 1030507
Change-Id: I4d998a5b0175b07bcf31bbf385fc352b2d3d5521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949558Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721287}

Bug: 1026327

Change-Id: Ia6a81e063cee197e3487bc408ac2456465c67751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948236
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721286}

Issue: 1021698
Change-Id: I4ce164922f1e5f33c127a1e61602682f4cdcca13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949666Reviewed-by: Andrew Xu <andrewxu@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721285}

This is the last major patch to remove the use of direct blob interfaces
from IndexedDB code.

It removes BlobDataHandle from IndexedDBBlobInfo.  There's no longer
any need to load blobs on the IO thread as all the IndexedDBBlobInfo
can be created directly on the idb task runner.

The downside is that tests become a little bit more complicated because
asking for the uuid is asynchronous.

Bug: 1022214
Change-Id: I4bd07cf687b10a0c65efda2044e11bb88171d632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947388
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721284}

AppServiceAppWindowCrostiniTracker is added to handle Crostini app
window special cases, e.g. CrostiniAppDisplay, Crostini shelf app id,
etc.

AppServiceAppWindowCrostiniHelper implements part of functions from
CrostiniAppWindowShelfController.

Update Crostini's LaunchApplication and CrostiniAppRestartView::Accept
to use AppServiceAppWindowCrostiniHelper.

BUG=1011235

Change-Id: If8f71b7b45e190431b1023fe9f1feab746f788f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941539
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721283}

This lets us use the JSON reader from base directly.

Change-Id: Ic0db4ace1c3f2b652a6af148e3eddc06df5282fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947983
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721282}

Using wpt-import in Chromium 9e1e5d01.
With Chromium commits locally applied on WPT:
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."
a2a91a99 "Allow another touch start happen when there are active touch points"
85b61e6b "[resource-timing] Ensure workerStart is protected by TAO"
a75430aa "Fix appcache tests."
a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders."
b0b9a76a "Revert "[LayoutNG] Set ShrinkToFit when determining MinMaxSize via layout""
83e4a43b "Refactor VRPose to fit better with WebXr concepts"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Icd00409937d0f18d89c68c1fb7735ba74961eca4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949346Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721281}

Bug: b/145612776

Change-Id: I1c3f084c11e996d752b4eeed7ceb5750bcbe708f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947482
Commit-Queue: John Bauman <jbauman@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721280}

Every volume type in FilesApp has volumeMetadata from chrome.FMP, that
contains an iconSet property: it is empty (contains no icons) for most
volume types.

Somes volumes like AndroidAppItem, PROVIDED, and DOCUMENT_PROVIDER can
(and usually do) provide icons in the iconSet property. If they don't,
FilesApp draws nothing in their .tree-row .item-icon element today.

AndroidAppItem volumes can provide icons: in the files-ng case, draw a
generic provided icon if their iconSet has no icons.

VolumeItem PROVIDED and DOCUMENT_PROVIDER can provide icons, but there
is no reliable way to detect/fix their missing icons today since other
volume types use VolumeItem too. If they don't provide icons, FilesApp
files-ng will now draw a gray box in their .item-icon, a visual change
in behavior compared to normal FilesApp.

Bug: 992819
Change-Id: I6d2ec07ef91fd3acd8edff8bc5053eab4450680c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945958Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721279}

The permission wizard had a multi-purpose "Next" button whose text and
behavior were adjusted, depending on the wizard state. Resizing the
button sometimes caused rendering glitches in the bezel outline.

This CL simplifies things by creating separate buttons (and event
handlers) for each purpose, and it shows/hides them instead of
replacing the title strings.

This CL also enables/disables the "Next" button (according to
permission grant state), so that the buttons don't jump around as much.
The "Open .. preferences" button and "Next" buttons remain visible, but
the user can still only advance when permission is granted.

Bug: 1015201
Change-Id: I255fcc8bc3f8c18acfef0dc830964c40dd081e98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949673
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721278}

This reverts commit 548b6a4e.

Reason for revert: Suspected cause of failures seen in
https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/10070

Original change's description:
> Stages storing model features first then models for get models responses
> 
> This change updates the store in stages to ensure only one store update
> in flight at a time. It prioritizes storing the model features first
> and then stores the prediction models once that update is complete.
> 
> Bug: 1001194
> Change-Id: Ic2d0ccaf64b49ca934590e6b7d0051668e155016
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938192
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> Commit-Queue: Michael Crouse <mcrouse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#721238}

TBR=tbansal@chromium.org,sophiechang@chromium.org,dougarnett@chromium.org,mcrouse@chromium.org

Change-Id: Iac2e56a8f949d30c93da1699dfb53ef15747c078
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1001194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949724Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721277}

Previously, when navigating from the left hand nav in the narrow window
size, focus did not move properly to the correct section since the
drawer closing causes focus to move to the full settings page. By
delaying the route change until the drawer closes in the narrow case.

Fixed: 1026019
Change-Id: I280c9b91660221a7363baf2e0a914002bdb31fbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929980
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721276}

https://pdfium.googlesource.com/pdfium.git/+log/8a0f76d3749e..3d7ad5ed37c1

git log 8a0f76d3749e..3d7ad5ed37c1 --date=short --first-parent --format='%ad %ae %s'
2019-12-03 thestig@chromium.org Roll third_party/freetype/src/ 3aaae716b..551bd3a90 (10 commits)
2019-12-03 tsepez@chromium.org Handle codepoints outside BMP in CFXJSE_FormCalcContext::Encode().

Created with:
  gclient setdep -r src/third_party/pdfium@3d7ad5ed37c1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029565
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I153d55e7f0fbe843537e21f2e824f6eeb37343ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949584Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721275}

Updated an error message string to more accurately describe the WebXR
state needed to satisfy it, removed a couple of WebGL helper methods
that were only being called by WebVR previously, and removed a Gamepad
enum from the IDL that was WebVR-specific.

Bug: 1030470
Change-Id: I6a4a53240f761eed94100dd374c4504f28a99b98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949298Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721274}

Looks like there was a copy paste error with
IDS_ONC_TETHER_SIGNAL_STRENGTH_OKAY having the string "Weak" which was
incorrect

Change-Id: Ic0dbadc4fb34074a3fc633c2103e54bc7441abd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939686
Auto-Submit: James Vecore <vecore@google.com>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721273}

Bug: 1029175
Change-Id: I99956e145775cc5cc4a9b6f8f6a64a97c783442a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938033
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721272}

Search and replace to spell "supported" correctly. Also fix lint errors
in modified files.

Change-Id: I4411bc2737f7ceb1b9cfa9c3316864d038a3afb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949022Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721271}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84e94841f5ea..56f46565e9ed


Created with:
  gclient setdep -r src-internal@56f46565e9ed

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I52703474b13478b05e9b5b2d00611a7ab4801da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948949Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721270}

Bug: 1021689

Change-Id: Ida4f922471b9e53684acfc683623150b82e2a7cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906873
Commit-Queue: Charlene Yan <cyan@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721269}

VA-API is a linux-specific API. This CL adds the assertion that lets gn fail
if media/gpu/vaapi is built for neither Linux nor ChromeOS platform.

Bug: 1000575
Test: compile chrome
Change-Id: I71836047fe69bff28640297e58415983a97d6760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847591Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721268}

We have a new component, Internals>Metrics>Tricium, just for Tricium bugs.

R=bpastene@chromium.org

Bug: 1030037
Change-Id: I093f2a684d2523c99bf1493084a9f85c24bf2507
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949302Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721267}

This CL is fixing the owners for subfirectories.
Since we remove alexei as owner for this folder,
we rely on a ui/owners to stamp fonts/render-text
related code.

Change-Id: I514ae10e54fe9f75229d25c428ac5e3b67534372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947552Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721266}

Enterprise customers want to prevent websites from querying payment
methods. This change adds an enterprise policy for that.

Bug: 963906
Change-Id: I1253dcd0a3db3774d1cd74a0ca366f8f4fe3bf55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940709
Commit-Queue: Kasjan Siwek <kasiwek@microsoft.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721265}

Use 'use_color_pipeline' build flag to gate the build and run of
color_unittests.

Since the flag is false by default, remove the unittest from buildbots
for now.

BUG=1003612

Change-Id: Idff6eefb720269e15c60ca69335a5eb0533bd592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947225Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721264}

This test class was only used by a BrowserPlugin specific test which
was removed.

Bug: 533069
Change-Id: I614699cdf1acbd774eac1487511f41bc64593037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944628Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721263}

TestChildOrGuestAutoresize has a parameter to determine whether to use a
BrowserPlugin code path. Since BrowserPlugin is being removed, we
remove this parameter and the supporting test code.

Bug: 533069
Change-Id: I5c7cde29b612eba62b14c2bafe9063a874fb15b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944608Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721262}

This is similar logic to what AwContents.java uses when creating a
popup.

Bug: 1030186
Change-Id: I0f207dae5ec53c0df68adb504544ec769534ce01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947639Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721261}

This replaces a special case in Document.

Bug: 1029822
Change-Id: I73a281ffaf29ae5ff9acf4b20c9fb87fd6e2e96e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949066
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721260}

These callbacks are going away.

Bug: 1029822
Change-Id: I6871110447bfd6e7e90a059108dc8ef52b10d2d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948493
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721259}

This CL brings the longtasks API up to date with the recent changes on
https://github.com/w3c/longtasks/pull/78. It also adds WPT tests for
those changes. The changes are:

* containerType is "window", "iframe", "embed", etc. depending on the
type of the culprit browsing context container.
* containerSrc is now the 'data' attribute when the container is an
<object>.

Change-Id: I06f661968778e3bec433a1bfe758b4604df01557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721258}

This CL refactors the implementation of the recovery component action
handler for Windows so that most of the code can be reused in the
future for macOS recovery component. It also adds a unit test.

This is trying to reland
https://chromium-review.googlesource.com/c/chromium/src/+/1946020
which failed on Linux with:

recovery_improved_component_installer.cc:94:11: error: no member named 'start_hidden' in 'base::LaunchOptions'
options.start_hidden = true;
~~~~~~~ ^

Bug: 1029953
Change-Id: I685963ed8b281d5709867c55b73617a121e7b78b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949224Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721257}

Showing file name and line in the output can be useful in searching the
file name directly from your IDE.

Bug: 1015236
Change-Id: If6f3ad0d4e84af9942e0e7d3b3fdb53925a391a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949106Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721256}