GitLab

Tracks usage:
+ of promoted 'Google cached copy' link doctor button.
+ on each of the two button label variants.

BUG=474848

Review URL: https://codereview.chromium.org/1214303003

Cr-Commit-Position: refs/heads/master@{#339714}

Revert of Remove race in DeclarativeContentApiTest.RulesPersistence test (patchset #1 id:1 of https://codereview.chromium.org/1222193006/)

Reason for revert:
Breaks linux clang tot bot (https://crbug.com/512506) and causes flakiness on Vista Tests bot (https://crbug.com/512431).

BUG=512506, 512431

Original issue's description:
> Remove race in DeclarativeContentApiTest.RulesPersistence test
>
> BUG=
>
> Committed: https://crrev.com/28218513bf9580515b03c73ab786c27844e9b40b
> Cr-Commit-Position: refs/heads/master@{#339432}

TBR=battre@chromium.org,matthewtff@yandex-team.ru
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1247743004

Cr-Commit-Position: refs/heads/master@{#339713}

Allow SyncPointManager instance to be set, and set the same
instance in Android WebView. Also remove ref-counting and just
guarantee SyncPointManager outlives running message loop.

Also make SyncPointManager thread safe, and callbacks are no longer
guaranteed to happen on the same thread. Make sure command buffer
implementations handle it correctly.

BUG=509702

Review URL: https://codereview.chromium.org/1231263003

Cr-Commit-Position: refs/heads/master@{#339712}

On Android, when merge tabs and apps is enabled, we need to ensure a new
activity has been started before loading URL in web contents since the
web contents delegate is not ready until then.

We already have a code path to handle this for window.open() scenario.
This completes the code path for when a link with noreferrer is clicked
by saving OpenURLParams of the pending load and resuming the load when
the activity is ready.

BUG=508366

Review URL: https://codereview.chromium.org/1233453003

Cr-Commit-Position: refs/heads/master@{#339711}

Currently the AccountManagerHelper always checks the GET_ACCOUNTS
permission. This should instead be done directly by the
AccountManagerDelegate.

BUG=509826

Review URL: https://codereview.chromium.org/1247053002

Cr-Commit-Position: refs/heads/master@{#339710}

Adds manifest data for content shell. The result matches the GYP build.

Attaches a default manifest to all tests in the GN build. The GYP build's tests have manifests that specify elevation only. In GN it also specifies Windows and common control compat that matches what we ship with Chrome.

BUG=510612
TBR=dpranke@chromium.org
Reland of https://codereview.chromium.org/1240893004/ with no cloud print or remoting changes

Review URL: https://codereview.chromium.org/1238293005

Cr-Commit-Position: refs/heads/master@{#339709}

BUG=412331

NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1228863005

Cr-Commit-Position: refs/heads/master@{#339708}

Currently Teardown is called twice on shutdown.

The ServiceProcess is on the stack. It will call Teardown from its
destructor when ServiceProcessMain returns.

It looks like this redundancy has been there since the service process was first introduced in:
https://codereview.chromium.org/2001009/

Review URL: https://codereview.chromium.org/1242873004

Cr-Commit-Position: refs/heads/master@{#339707}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/add18ed2..49d3837a

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1245103003

Cr-Commit-Position: refs/heads/master@{#339706}

  Browser Side Navigation Linux bot.

TBR=jam@chromium.org
BUG=507223
Test=None.

Review URL: https://codereview.chromium.org/1250663002

Cr-Commit-Position: refs/heads/master@{#339705}

This patch changes the interest rect calculation from using number
of tiles to screen space distance (3k as the initial setting). The
problem with using the number of tiles is that on devices like mac
book pro, we end up having very little prepainting area in software
and way too large of a prepainting area with ganesh, since the sizes
of tiles differ drastically.

BUG=483520
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1236533004

Cr-Commit-Position: refs/heads/master@{#339704}

There is an ongoing issue with failures on Mac OSX causing crashes
on the renderer side. All we know so far is that it has something to do
with failures with our usage of GL_COMMANDS_COMPLETED_CHROMIUM. We
suspect it has something to do with multiple GPUs but it is hard to
tell for sure. This will at least let us know what is going on for
the GPU side.

BUG=467678

Review URL: https://codereview.chromium.org/1242913003

Cr-Commit-Position: refs/heads/master@{#339703}

BUG=511273
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect

Review URL: https://codereview.chromium.org/1250453005

Cr-Commit-Position: refs/heads/master@{#339702}

Giving BluetoothAdapterMac ownership of the CBCentralManager (the
discovery manager retains a pointer) and separating the
CBCentralManagerDelegate class from the
BluetoothLowEnergyDiscoveryManagerMac file, as it will soon support non-
discovery callbacks from CoreBluetooth as well.

BUG=510491

Review URL: https://codereview.chromium.org/1226133006

Cr-Commit-Position: refs/heads/master@{#339701}

This reverts commit cc83d2d6.

Tested on Linux with the following command lines:

$ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1'
$ gn check out-gn/Release //components/omnibox/*

BUG=367595, 376000
TEST=see above
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1242973003

Cr-Commit-Position: refs/heads/master@{#339700}

This metric records the CERT_COMMON_NAME_INVALID errors when the hostname entered and one of the dns names of the certificate have same effective domain name (eTLD+1).This helps us see if the certificate is completely random or if it is related to the current hostname.

BUG=507715

Review URL: https://codereview.chromium.org/1227173006

Cr-Commit-Position: refs/heads/master@{#339699}

BUG=488693

Review URL: https://codereview.chromium.org/1232643003

Cr-Commit-Position: refs/heads/master@{#339698}

In the past we simply retrieved the name and short name and picked the latter
to be the title if it existed or otherwise we used the former. The user was
then able to edit the title and save the web app on their homescreen. This title
was then used on the launcher as well as in recents.

However, with the new splash screen which might be up soon, we need the long
name from the website to display on the splash screen. It also looks better
if recents utilizes the short name which is specified by the website rather than
a user specified title which is used on the launcher.

Because of all this, this CL propogates the info through various C++ and Java
classes to allow the above usage. Now the user title is used just for the home
screen icon. The name is used on the splash screen and the short name is used
in recents.

A note on backward compatibility: current webapps will simply use the
user specified title which is currently saved in the intent - this CL only
affects new webapps which the user adds after it lands.

BUG=508628

Review URL: https://codereview.chromium.org/1224273003

Cr-Commit-Position: refs/heads/master@{#339697}

Reland of https://codereview.chromium.org/1242373002/ but correctly rebased
on ToT.

BUG=511570

Review URL: https://codereview.chromium.org/1242743003

Cr-Commit-Position: refs/heads/master@{#339696}

Instead of inferring if the main thread is in a high latency
mode or not based on many other variables, track it
explicitly at the end of the BeginImplFrame deadline.

Also rename MainThreadIsHighLatency to
main_thread_missed_last_deadline so it's clearer what
that variable means exactly.

BUG=406158
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1229573004

Cr-Commit-Position: refs/heads/master@{#339695}

Review URL: https://codereview.chromium.org/1248703003

Cr-Commit-Position: refs/heads/master@{#339694}

BUG=332107

Review URL: https://codereview.chromium.org/1251463002

Cr-Commit-Position: refs/heads/master@{#339693}

This patch takes the old MD Settings work, and changes it to closer match the UI
approved mocks, which divide the settings into Basic and Advanced.

The previous subsections are now all scrollable within the Basic and Advanced
sections.

This also removes the user badge that has been removed from the mocks.

BUG=
TBR=
TBR for GRD changes only. Other changes reviewed.

Review URL: https://codereview.chromium.org/1239963004

Cr-Commit-Position: refs/heads/master@{#339692}

BUG=512188

Review URL: https://codereview.chromium.org/1238293004

Cr-Commit-Position: refs/heads/master@{#339691}

It looks like it doesn't understand static_assert?
Use the COMPILE_ASSERT from before
https://codereview.chromium.org/1248483002/ if
__cplusplus is too low.

BUG=512396
TBR=robertshield

Review URL: https://codereview.chromium.org/1251553002.

Cr-Commit-Position: refs/heads/master@{#339690}

Using Instrumentation#getTargetContext() in ChromeActivityTestCaseBase#clearAppData() is
consistent with how ApplicationTestUtils#clearAppData() is called everywhere else.
Using Instrumentation#getContext() causes crashiness

BUG=505040
TEST=None

Review URL: https://codereview.chromium.org/1245073003

Cr-Commit-Position: refs/heads/master@{#339689}

This CL componentizes the preferences registration in
AccountTrackerService, and FakeProfileOAuth2TokenService.
This is a simple code move with no change in behavior.

BUG=332107
TBR=jochen

Review URL: https://codereview.chromium.org/1245103005

Cr-Commit-Position: refs/heads/master@{#339688}

This is the first step towards refactoring our test platform. Add
BaseAdapter and FailStartDiscoveryAdapter and refactor EmptyAdapter and
DiscoverySession.

The design is specified here:
https://docs.google.com/document/d/1_QsBzcc84SwF7oaBWbO8rBzn39MISQ3w-6QM9hk0L3E/edit?usp=sharing

Blink-side patch: http://crrev.com/1236583003

BUG=499552

Review URL: https://codereview.chromium.org/1236073003

Cr-Commit-Position: refs/heads/master@{#339687}

Propagates frame name changes correctly.
Add support for origin and sandbox flags, but not fully wired up yet.
Adds more test coverage.

BUG=479172,490221
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1239313004

Cr-Commit-Position: refs/heads/master@{#339686}

Revert of Implements RLZTrackerDelegate on iOS. (patchset #2 id:40001 of https://codereview.chromium.org/1242373002/)

Reason for revert:
Landed wrong patchset.

Original issue's description:
> Implements RLZTrackerDelegate on iOS.
>
> BUG=511570
>
> Committed: https://crrev.com/8ff2e5ea76f4aed908188f0368ccb12d290236a7
> Cr-Commit-Position: refs/heads/master@{#339676}

TBR=droger@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=511570

Review URL: https://codereview.chromium.org/1250693003

Cr-Commit-Position: refs/heads/master@{#339685}

BUG=512466
TBR=thestig@chromuim.org

Review URL: https://codereview.chromium.org/1240393004

Cr-Commit-Position: refs/heads/master@{#339684}

BUG=none
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1251533002

Cr-Commit-Position: refs/heads/master@{#339683}

These files both test the accessibility tab switcher. This moves
testObservesTitleChanges() from AccessibilityTabSwitcherTest into
OverviewListLayoutTest, and deletes
AccessibilityTabSwitcherTest.testCanEnterAndLeaveSwitcher() since
equivalent tests already exist in OverviewListLayoutTest.

BUG=505040

Review URL: https://codereview.chromium.org/1246923002

Cr-Commit-Position: refs/heads/master@{#339682}

BUG=512000
TEST=navigate to the launcher without and then with ChromeVox on. No crashes.

Review URL: https://codereview.chromium.org/1245003002

Cr-Commit-Position: refs/heads/master@{#339681}

The experiment is complete and no noticeable difference was seen between
BELOW_NORMAL and IDLE, but IDLE was selected to be the one that sticks.

Experiment results, analysis, and conclusion @
https://docs.google.com/document/d/1EgwEv0bRSzX9sNnD0wmSodKIQOHXT-umUKKneb6sTFI/edit

BUG=459600

Review URL: https://codereview.chromium.org/1249683002

Cr-Commit-Position: refs/heads/master@{#339680}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7d4690..0bbe010

TBR=gavinp@chromium.org,yhirano@chromium.org

Review URL: https://codereview.chromium.org/1246933004

Cr-Commit-Position: refs/heads/master@{#339679}

- Step 1: Upstream: add a new JsAutofillManager method that doesn't require a autofill::RequirementsMask parameter.
- Step 2: Downstream: use the new method.
- Step 3: This change.

NOTE: landing this change requires waiting for https://chromereviews.googleplex.com/222467014/ to land (currently blocked on problem with try bots).

BUG=459456

Review URL: https://codereview.chromium.org/1248463002

Cr-Commit-Position: refs/heads/master@{#339678}

Previous to this change, all fields would be overwritten regardless of
their contents and whether or not they had already been autofilled. With
this change the suggestion and overwrite behavior is the same as on
desktop and Android.

1. If any form fields are already autofilled (i.e. have yellow
background) then suggestions are only given for the currently active
field, and only the currently active field is modified when a suggestion
is chosen. This is achieved by setting |isAutofilled| in
autofill_controller.js. The common Autofill code shared with desktop
takes care of it from there.

2. If a field is non-empty do not autofill it, unless it is the
currently active field.

Downstream part is here: https://chromereviews.googleplex.com/222487013

BUG=504644

Review URL: https://codereview.chromium.org/1234193005

Cr-Commit-Position: refs/heads/master@{#339677}

BUG=511570

Review URL: https://codereview.chromium.org/1242373002

Cr-Commit-Position: refs/heads/master@{#339676}

Not setting is_autofilled on select fields results in wrong metrics in FormStructure::LogQualityMetrics.

BUG=512127

Review URL: https://codereview.chromium.org/1245623003

Cr-Commit-Position: refs/heads/master@{#339675}