- 21 Jul, 2017 40 commits
-
-
Alexander Alekseev authored
Bug: 747138 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I77e1b33f74f91e5918d9a74f9a79cd8b0de79fc6 Reviewed-on: https://chromium-review.googlesource.com/580675Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488794}
-
Sadrul Habib Chowdhury authored
The destruction callback of a GpuMemoryBufferImpls can be called on any thread[1]. So make sure the destruction callbacks hops onto the correct thread before mutating local data structures or sending mojo messages. [1] See doc for GpuMemoryBufferImpl::CreateFromHandle() https://cs.chromium.org/chromium/src/gpu/ipc/client/gpu_memory_buffer_impl.h?l=28 BUG=733482 Change-Id: Ifc3fecd6a8bb42aa61f3d2d9667bd0e931d7261c Reviewed-on: https://chromium-review.googlesource.com/565858 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#488793}
-
dpapad authored
Previously it would not search any of the native language names, resulting in missing results. Bug: 746880 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6fb39d532eb87bf138c22018ca81638b1083a969 Reviewed-on: https://chromium-review.googlesource.com/580250 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#488792}
-
Bo Liu authored
Otherwise if app handles a renderer crash, then all browser crashes are incorrectly suppressed. Change-Id: Ib092df8783de535e4d281837fcbe16abe2fb53a2 Reviewed-on: https://chromium-review.googlesource.com/582079Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#488791}
-
Steven Holte authored
In addition to simplifying the code, this allows providers to do their initialization in parallel. None of the providers currently appear to depend on the order. May avoid double initializing some providers. TBR=olivierrobin,manzagop,boliu Bug: 739895 Change-Id: I8ee97e9deace636c92b0ec27fe34e451798922bd Reviewed-on: https://chromium-review.googlesource.com/576515Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Alexei Svitkine (slow) <asvitkine@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#488790}
-
Aleks Totic authored
Changed query ui into queries + filters Added flaky tests query Select all shortcut now selects only expectations. Fixed sorting bug (dirs and files were mixed) Speedup startup, and query display Bug: 726520 Change-Id: I9356455c02e70424ae1e98901fe0e5f56ed675df Reviewed-on: https://chromium-review.googlesource.com/580827 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#488789}
-
Ian Vollick authored
We'd previously set opacity to 0.0 when hiding elements in the transience manager which makes it tricky to see them when they come back. With this change, we inform the manager of the desired "opacity when visible" and it will restore elements to that opacity when shown again. Bug: None Change-Id: I1a941c3032c35adab5afed17a8afc60bd41230f5 Reviewed-on: https://chromium-review.googlesource.com/582069 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#488788}
-
John Budorick authored
This reverts commit da27a978. Reason for revert: Still over capacity. Will investigate further next week. Original change's description: > Reenable three iOS CQ builders. > > Overall cycle time and compile step time have improved signficantly > on all three matching waterfall bots since the hardlink workaround > landed yesterday: > - ios-device: http://shortn/_ow7Hr0gN6e > - ios-device-xcode-clang: http://shortn/_qdlv49pNuS > - ios-simulator-xcode-clang: http://shortn/_LlpTYE0H51 > > Bug: 740301, 739556 > Change-Id: Iebf1b1398273d87580d5aaa295231f2a9e33bcaf > Reviewed-on: https://chromium-review.googlesource.com/579567 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: smut <smut@google.com> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488736} TBR=smut@google.com,dpranke@chromium.org,jbudorick@chromium.org Change-Id: I7f66b8f8a01d3ea235ba894063e8c0f5897fa4a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 740301, 739556 Reviewed-on: https://chromium-review.googlesource.com/582449Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#488787}
-
Alexander Alekseev authored
This CL makes keyboard focus highlighting match the text size of a hyperlink on the EULA screen. Bug: 732324 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifbfed41f7c52e0089d780917a5431638a92d9476 Reviewed-on: https://chromium-review.googlesource.com/580431Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#488786}
-
Angela S authored
The data saver menu footer is supposed to be highlighted when the data saver in-product help is shown but it is not. This patch fixed it by changing the ID that is highlighted to be the inflatedID of the app menu footer view stub. BUG=747486 Change-Id: Iaf43badcf277dd424fc02fbafa4d27e51c03737c Reviewed-on: https://chromium-review.googlesource.com/581879Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Angela Shao <angelashao@google.com> Cr-Commit-Position: refs/heads/master@{#488785}
-
yucliu authored
Async Create MediaDrmBridge. When persistent license support is enabled, we need to load origin id from persistent storage before create MediaDrmStorage. BUG=493521 TEST=Test page, MediaDrmBridgeTest Review-Url: https://codereview.chromium.org/2823513002 Cr-Commit-Position: refs/heads/master@{#488784}
-
Dongseong Hwang authored
TEST=run chrome on youtube using eve BUG=743277 Change-Id: Ie096276779faafed71309372d4fa44ac07054c20 Reviewed-on: https://chromium-review.googlesource.com/581880 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#488783}
-
Ali Tofigh authored
The Chrome Cleaner dialog is shown when unwanted software is found on the user's computer. Currently, if errors occur during communication with the Chrome Cleaner process or if the user starts the cleanup from the settings page from a different browser window, the modal dialog will remain open. With this CL, the modal dialog is closed by Chrome if the global ChromeCleanerController object leaves the infected state, either due to errors or user action on the webui card in the settings page. Bug: 747077 Change-Id: I3f8ed6288901aa3f9aaa2c2f108ca141fa3d0545 Reviewed-on: https://chromium-review.googlesource.com/578472 Commit-Queue: Ali Tofigh <alito@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Shield <robertshield@chromium.org> Cr-Commit-Position: refs/heads/master@{#488782}
-
MinChen authored
If the app list is not opened and shelf is visible, swipe up on the shelf should show the app list. If the app list is opened, swipe up on the shelf should keep the app list opened. Tap anywhere else of shelf should close the app list. This is the basic one currently. Will add some simple animations followed. (e.g, change the opacity of the searchbox and apps row by row according to the dragging amount) Bug: 735999,742461 Change-Id: I5eb8b6d4d006a50720050b34168849e9d57370f2 Reviewed-on: https://chromium-review.googlesource.com/562739 Commit-Queue: min c <minch@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#488781}
-
Weidong Guo authored
Changes: 1. Change the focus behavior triggered by tab key in start page view. Focus should move cyclically like this: search box text field -> suggestion apps -> expand arrow view -> search box text field. 2. Add unit test for this behavior. BUG=741015 TEST=AppListViewFullscreenTest.StartPageTabFocusTest Change-Id: I7467d94b4028ef24422f8236e615f66b195d1f84 Reviewed-on: https://chromium-review.googlesource.com/580498 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#488780}
-
Ahmed Fakhry authored
This will revert back to software mirroring, since hardware mirroring won't work and will result in a black screen. BUG=b/35583078 Change-Id: Id8496c5966554f5fa866812cd87fc87e3ddd4a92 Reviewed-on: https://chromium-review.googlesource.com/575669Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#488779}
-
Maajid authored
inactive. Even if there is only whitespace in the searchbox, it should still be active. In addition, clearing the searchbox from the app list view creates easy opportunities for infinite loops. Bug: 740662 Change-Id: I9806242ac448dfb7a2a0d2af34388aa3fa3c47d8 Reviewed-on: https://chromium-review.googlesource.com/581567 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#488778}
-
Adenilson Cavalcanti authored
It is a feature that allows to collect data from HashTables (e.g. rehashes, reads, number of collisions, etc). This change does: - fixes the functionality for general HashTable stats - also fixes for individual HashTables And introduces a public member function (guarded behind a macro) called DumpStats() that allows to dump the stats from HashMap. Bug: 735663 Change-Id: I86f826c3d23f02f0d06dba7e0a5a157601bbd4ce Reviewed-on: https://chromium-review.googlesource.com/556919 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#488777}
-
John Abd-El-Malek authored
This is to figure out whether we need to buffer data in the network service's URLLoaderImpl. BUG=746144 Change-Id: I10a0b5923b8d9fefdceee98bbc07671e53ab4f8d Reviewed-on: https://chromium-review.googlesource.com/581742 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#488776}
-
Gabriel Charette authored
R=thakis@chromium.org Bug: 499415, 689520 Change-Id: I74dac5b0113def0b2c61bcd584e2588174941d4a Reviewed-on: https://chromium-review.googlesource.com/582147Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#488775}
-
Matthew Jones authored
Previously, blink was never properly notified of the browser controls height when they are at the bottom of the screen. This change updates Blink's concept of browser controls to include bottom controls, allowing top and bottom controls to be considered independently as the two have slightly different behavior. If top controls height is 0, the manager attempts to base the calculations off the bottom controls.The result of this is correct viewport sizing for fixed-positioned web elements when the browser controls are at the bottom of the screen. BUG=711828 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibcfd6aa6280d884200c03f24c07d3a214fc836c0 Reviewed-on: https://chromium-review.googlesource.com/560641 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Alexandre Elias <aelias@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#488774}
-
Kyle Horimoto authored
This reverts commit 752bf750. Reason for revert: Original CL was correct. Original change's description: > Revert "ozone: set the right GBM_BO_ flags" > > This reverts commit 2e75e890. > > Reason for revert: Breaks build for veyron_minnie and probably other devices. Sample of the compiler errors below: > > ../../ui/ozone/platform/drm/gpu/drm_thread.cc:120:15: error: use of undeclared identifier 'GBM_BO_USE_TEXTURING'; did you mean 'GBM_BO_USE_RENDERING'? > flags = GBM_BO_USE_TEXTURING; > ^~~~~~~~~~~~~~~~~~~~ > GBM_BO_USE_RENDERING > ../../../.cros_cache/chrome-sdk/tarballs/veyron_minnie+9588.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/gbm.h:230:4: note: 'GBM_BO_USE_RENDERING' declared here > GBM_BO_USE_RENDERING = (1 << 2), > ^ > > > Original change's description: > > ozone: set the right GBM_BO_ flags > > > > minigbm doesn't allow to pass no flags to gbm_bo_create(). GBM_BO_USE_TEXTURING > > implies texture, so use GBM_BO_USE_TEXTURING to create texture buffer. > > > > GBM_BO_USE_TEXTURING implies GPU_READ. GBM_BO_USE_RENDERING implies GPU_WRITE. > > BufferUsage::SCANOUT needs both of them because it implies GPU_READ_WRITE. > > > > TEST=run chrome on amd64-generic > > BUG=683347 > > > > Change-Id: I7431be6f5b4a8d95e6be11d86cfbf0c14b919668 > > Reviewed-on: https://chromium-review.googlesource.com/549095 > > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > > Reviewed-by: David Reveman <reveman@chromium.org> > > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> > > Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> > > Cr-Commit-Position: refs/heads/master@{#488709} > > TBR=marcheu@chromium.org,reveman@chromium.org,dnicoara@chromium.org,dongseong.hwang@intel.com,glevin@chromium.org,dcastagna@chromium.org,gurchetansingh@chromium.org > > Change-Id: I2a8327004c3ba78ca406d08b02b28515c2b2dcf0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 683347 > Reviewed-on: https://chromium-review.googlesource.com/582347 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488762} TBR=marcheu@chromium.org,reveman@chromium.org,khorimoto@chromium.org,dnicoara@chromium.org,dongseong.hwang@intel.com,glevin@chromium.org,dcastagna@chromium.org,gurchetansingh@chromium.org Change-Id: I1b8d898a5184dfe17d8f33eda533a39400c78a44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 683347 Reviewed-on: https://chromium-review.googlesource.com/582310Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488773}
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/7bffe5e1c54b..d8136924bd0b $ git log 7bffe5e1c..d8136924b --date=short --no-merges --format='%ad %ae %s' 2017-07-21 fbarchard Rename convert to yuvconvert for linux.mk 2017-07-20 fbarchard Remove deprecated macOS SDK overrides. 2017-07-20 fbarchard add exe_and_shlib_deps dependency for libc++ new[] 2017-07-19 fbarchard Roll chromium_revision 964fc7fe..c138801d (478724:487352) 2017-07-18 fbarchard include <new> header for benefit of new clang builds 2017-07-13 fbarchard Update .gn to set a min SDK for macOS via GN. 2017-06-19 fbarchard Move compare functions into a unittest class 2017-06-12 kjellander Roll chromium_revision ce95e5d8..964fc7fe (465389:478724) 2017-06-09 fbarchard Remove ARM NaCL macros from source 2017-06-08 fbarchard Lint fix for C casting for rotation code on arm 2017-06-07 fbarchard Hamming Distance using 16 bit accumulators 2017-06-06 fbarchard Port HammingDistance_NEON 32 bit code to 64 bit 2017-06-06 fbarchard HammingDistance_NEON optimized looping 2017-06-05 fbarchard HammingDistance_NEON ported to 32 bit 2017-06-05 fbarchard ScaleDown odd functions adjust math so last pixel is half width source. 2017-06-01 kjellander Remove duplicated bot linux_msan in cq.cfg. Created with: roll-dep src/third_party/libyuv R=kjellander@chromium.org Bug: libyuv:712 Test: try bot build Change-Id: Ie556bd40f7104e058399486d37e46a03b3bdeab2 Reviewed-on: https://chromium-review.googlesource.com/581632 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Frank Barchard <fbarchard@google.com> Cr-Commit-Position: refs/heads/master@{#488772}
-
Catherine Chung authored
This CL uses the NewTabFeatureEngagementTracker, which you can view in this CL: http://crrev.com/7d54c1b52c11ef28e9a19f3c6a5a7a41a25fbf5d The New Tab FeatureEngagementTracker will be notified if: * The user presses the New Tab button * The user presses Control+T * The user uses the tabstrip context menu, window frame context menu, or the app menu to open a New tab. * The user uses the omnibox to start a session in the same tab. * The user focuses on the omnibox. Bug: 734132 Change-Id: I5c9f3c394a2f2001b812a18e788fdc68220dcd20 Reviewed-on: https://chromium-review.googlesource.com/549074Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Catherine Chung <catherinechung@google.com> Cr-Commit-Position: refs/heads/master@{#488771}
-
Leslie Watkins authored
Bug: 672263, 673874, 746107 Change-Id: I5a1f7a4d86307bd84e236dc29d3da224abdcaef4 Reviewed-on: https://chromium-review.googlesource.com/580406Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488770}
-
Ken Rockot authored
There are two problems with this API: 1. The buffer size returned is incorrect and could trivially lead to callers overflowing the message buffer. 2. It does not correctly copy the entire contents of the old message buffer upon reallocation, instead only copying the extent of the buffer reported as payload so far. This fixes both problems. Note that this API has not yet been used in production, so there are no actual bugs caused by either of these issues yet. BUG=742369 R=jcivelli@chromium.org Change-Id: I7ee7cd0783d641940e0ccafc0c9dc772eeaf2793 Reviewed-on: https://chromium-review.googlesource.com/580252Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#488769}
-
Morten Stenshorne authored
This rids us of some crufty code, and also fixes bugs. The approach was also broken for multicol, because we started UpdatePaginationRecursive() in the middle of the tree without looking for a containing flow thread (pagination layer). This would result in the new layer erroneously not becoming paginated. Also had to update a unit test, to satisfy its requirement that the style change won't trigger layout. BUG=616596 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I50ed61a7174e360259b7b786bab01cf74616fc32 Reviewed-on: https://chromium-review.googlesource.com/542915 Commit-Queue: Morten Stenshorne <mstensho@opera.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#488768}
-
Alok Priyadarshi authored
Change-Id: I0f40eb26f3f74cf3effc08aa37dff5caff407e61 Reviewed-on: https://chromium-review.googlesource.com/580671 Commit-Queue: Alok Priyadarshi <alokp@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#488767}
-
Zhen Wang authored
Bug: 747024 Change-Id: I2ec5eb2de893890ca2543240970019c92a3c3644 Reviewed-on: https://chromium-review.googlesource.com/581928Reviewed-by:
rnephew <rnephew@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#488766}
-
Charles 'Buck' Krasic authored
Increase the size of QuicHttpStream::raw_request_body_buf_ based on the size of the body. For large bodies and fast networks, this give a nice reduction in CPU (or boost throughput if CPU bound) (~10-20%). R=rch@chromium.org Bug: 709144 Change-Id: If4fc69f9f89866b75b6d09d728e53a7bfa2054e4 Reviewed-on: https://chromium-review.googlesource.com/581877Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Buck Krasic <ckrasic@chromium.org> Cr-Commit-Position: refs/heads/master@{#488765}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/926c65a49ca4..d0856ba49c2b $ git log 926c65a49..d0856ba49 --date=short --no-merges --format='%ad %ae %s' 2017-07-20 thestig Fix nits from commit 67ccef7. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I66ae6e2cf456d549f69879e81ac8ba4ddd24815b Reviewed-on: https://chromium-review.googlesource.com/581933 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#488764}
-
pdr@chromium.org authored
The CQ bot was down for a few days (https://crbug.com/746119) and some failures crept in. some of these are for new tests (border radius test) and some are new faiures (filter, https://crbug.com/747511) and some I did not triage. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I26175466116a30b7eb98225215bc6e9f926ad66f Reviewed-on: https://chromium-review.googlesource.com/581609Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#488763}
-
Kyle Horimoto authored
This reverts commit 2e75e890. Reason for revert: Breaks build for veyron_minnie and probably other devices. Sample of the compiler errors below: ../../ui/ozone/platform/drm/gpu/drm_thread.cc:120:15: error: use of undeclared identifier 'GBM_BO_USE_TEXTURING'; did you mean 'GBM_BO_USE_RENDERING'? flags = GBM_BO_USE_TEXTURING; ^~~~~~~~~~~~~~~~~~~~ GBM_BO_USE_RENDERING ../../../.cros_cache/chrome-sdk/tarballs/veyron_minnie+9588.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/gbm.h:230:4: note: 'GBM_BO_USE_RENDERING' declared here GBM_BO_USE_RENDERING = (1 << 2), ^ Original change's description: > ozone: set the right GBM_BO_ flags > > minigbm doesn't allow to pass no flags to gbm_bo_create(). GBM_BO_USE_TEXTURING > implies texture, so use GBM_BO_USE_TEXTURING to create texture buffer. > > GBM_BO_USE_TEXTURING implies GPU_READ. GBM_BO_USE_RENDERING implies GPU_WRITE. > BufferUsage::SCANOUT needs both of them because it implies GPU_READ_WRITE. > > TEST=run chrome on amd64-generic > BUG=683347 > > Change-Id: I7431be6f5b4a8d95e6be11d86cfbf0c14b919668 > Reviewed-on: https://chromium-review.googlesource.com/549095 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> > Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> > Cr-Commit-Position: refs/heads/master@{#488709} TBR=marcheu@chromium.org,reveman@chromium.org,dnicoara@chromium.org,dongseong.hwang@intel.com,glevin@chromium.org,dcastagna@chromium.org,gurchetansingh@chromium.org Change-Id: I2a8327004c3ba78ca406d08b02b28515c2b2dcf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 683347 Reviewed-on: https://chromium-review.googlesource.com/582347Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#488762}
-
Amirhossein Simjour authored
Add tracking of suppression of the popup ui elements in tab_web_contents_delegate_android. The logging should be removed once we have proper implementation of UI elements in VR. BUG=746979 Change-Id: I75997b9aa644b75e4b673f5ca34335138003f3bd Reviewed-on: https://chromium-review.googlesource.com/579947Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#488761}
-
John Abd-El-Malek authored
Also disable a payments test which is flaky. TBR=kinuko@chromium.org NOTRY=true Change-Id: I7fa7059a7e0c0d0f82ecaa7b0b064537ea778cfe Reviewed-on: https://chromium-review.googlesource.com/581673 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#488760}
-
Nathan Fairhurst authored
Was caused by touchscreen_gesture_target_queue_ + prevent default. The webview target was calculated on TouchStart and pushed to the the queue. It was removed on its corresponding GestureTapDown. However, if the TouchStart had default behavior prevented, no GestureTapDown would ever occur, and the queue would forever have an extra element. Fixed by converting touchscreen_gesture_target_queue_ to a map with unique_touch_event_id as keys and gesture target data as values. Also updates AUTHORS file. Bug: 736623, 739831 Change-Id: If3bf844e2bcfb9a1ca6d6a56cdc7575e0767e6b6 Reviewed-on: https://chromium-review.googlesource.com/547669 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#488759}
-
Ahmed Fakhry authored
The feedback uploader can spam the server with tons of instances of the exact same report due to the following: 1) Corrupted reports will be retied once every 60 minutes and on every login. Each retry will fail with the exact same ClientError, so there's no point in retrying. 2) FeedbackProfileObserver and FeedbackUploader were using two different types of task runners with different threads from their blocking pools. This can lead to a race condition (when corrupted reports are being resent on login) between the thread that reads the unsent file, and the thread that rewrites the file before it's attempted to be resent. This CL: - Fixes (1) by introducing an exponential backoff delay on failures other than ClientErrors, and not retry on Client Errors. - Fixes (2) by using the same type of SingleThreadTaskRunner for all feedback background tasks to ensure sequencing and thread affinity. - Adds some tests. BUG=739885 TEST=adds new tests. Change-Id: Ia80afbb77349444a02321f22754d3d89cd536507 Reviewed-on: https://chromium-review.googlesource.com/564304Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#488758}
-
Michael Thiessen authored
Bug: 746504 Change-Id: Ia7296889916aac759edfef72c34beb01770d79ca Reviewed-on: https://chromium-review.googlesource.com/581851Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#488757}
-
John Chen authored
Change-Id: Ie44eb482868022111fc52ff490702e0a97d0f4d4 Reviewed-on: https://chromium-review.googlesource.com/580053Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#488756}
-
Eugene But authored
Disabling and enabling web usage has the same effect of evicting tabs. Bug: 732525 Change-Id: I2ecafe2ddaf419aaeea81500f94d8b5893dee95e Reviewed-on: https://chromium-review.googlesource.com/581848Reviewed-by:
Mike Baxley <baxley@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#488755}
-