- 04 Oct, 2016 19 commits
-
-
michaelpg authored
Imports in <body> cause undefined behavior: crbug.com/638074 We have a bunch of hacks to try to avoid doing things with an invalid DOM. Instead of these hacks, sidestep the problem by moving the i18n import to <head> (yeah, this probably breaks i18n-foo in <body>). The code is less haphazard now, but still a minefield because: * Basic and Advanced attempt to control the scroller simultaneously * settings-main updates the overscroll with no regard for section transitions * settings-main eagerly removes overscroll on "scroll" events, but can't differentiate between user scrolls and Basic/Advanced-initiated scrolls BUG=637508,537359,589681 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2259163002 Cr-Commit-Position: refs/heads/master@{#422625}
-
dfalcantara authored
* Force the Custom Tab Intent to use the same package as Chrome when opening the media viewer. * Open media downloads inside of the internal media viewer when opening the file in the notification or via the snackbar. * Shuffle code around for creating media viewer Intents in the hopes of consolidating them in places that makes sense. BUG=650448 Review-Url: https://codereview.chromium.org/2376893006 Cr-Commit-Position: refs/heads/master@{#422624}
-
xhwang authored
Recently we see some changes in the pipeline start success rate. However, we can only get this statistics indirectly through some other UMAs. This CL adds a UMA directly for this. Note that if the media pipeline is destroyed during the starting process, this UMA will NOT be reported. This should be relatively rare. Also, in this case, the result won't affect user experience anyways. TEST=Manually tested to make sure the metric is reported. Review-Url: https://codereview.chromium.org/2383493004 Cr-Commit-Position: refs/heads/master@{#422623}
-
kozyatinskiy authored
We need to use last arrived script for ResourceScriptFile. Otherwise _isDiverged check will always return true in case of: eval("source1 //# sourceURL=foo.js") eval("source2 //# sourceURL=foo.js") BUG=617450,623150 R=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2384953002 Cr-Commit-Position: refs/heads/master@{#422622} -
nasko authored
In cases of out-of-process iframes, RetargetingDetails doesn't currently contain enough information to find the correct RenderFrameHost. This CL adds the RenderProcessHost id in the RetargetingDetails struct to allow consumers of it to correctly discover RenderFrameHost that created the new WebContents. BUG=649855 Review-Url: https://codereview.chromium.org/2385363002 Cr-Commit-Position: refs/heads/master@{#422621}
-
lazyboy authored
StringValue already accepts StringPiece as constructor. Get/SetWithoutPathExpansion readily takes StringPiece, so don't covert StringPiece -> std::string then back to StringPiece for these. Searching token can be done within StringPieces, without needing to create temporary strings. BUG=None Test=None, internal change. Review-Url: https://codereview.chromium.org/2383013004 Cr-Commit-Position: refs/heads/master@{#422620}
-
enne authored
R=vmpstr@chromium.org BUG=646032 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2385253002 Cr-Commit-Position: refs/heads/master@{#422619}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2388303002 Cr-Commit-Position: refs/heads/master@{#422618}
-
jrummell authored
BUG=563793 Review-Url: https://codereview.chromium.org/2385213003 Cr-Commit-Position: refs/heads/master@{#422617}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/bd5814787caa..2363045762a7 $ git log bd5814787..236304576 --date=short --no-merges --format='%ad %ae %s' 2016-10-03 alexandermont Use enums for the InitiatorTitles in IRs instead of strings. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2388653003 Cr-Commit-Position: refs/heads/master@{#422616}
-
sky authored
Adds OnChildWindowVisibilityChanged to ui::WindowObserver as well as making all visible functions take the 'visible' to match usage of aura. OnChildWindowVisibilityChanged() is unfortunate given OnWindowVisibilityChanged() is also sent, but it's the only way I can match existing behavior. I came across this ordering dependency as part of getting workspace tests running. It may be we end up adding a LayoutManager to mus and pulling OnChildWindowVisibilityChanged into it. But for now I'm going with just the OnChildWindowVisibilityChanged. BUG=none TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2387013003 Cr-Commit-Position: refs/heads/master@{#422615}
-
yhirano authored
SharedMemoryDataConsumerHandle::Context posts tasks while its lock_ locked. That means a lock held by the TaskRunner will be locked after |lock_| is locked. On the other hand, the Context may be destructed in the middle of TaskRunner destruction, which means we cannot lock |lock_| in the Context destruction. Otherwise, a lock-order-inversion problem will be introduced. This CL stops locking |lock_| in the destructor. It is safe because no one accesses to Content's member variables without a valid scoped_refptr to the Context. BUG=651747 Review-Url: https://codereview.chromium.org/2391513002 Cr-Commit-Position: refs/heads/master@{#422614}
-
csharrison authored
The previous canonical way to convert an Origin to a GURL was to call GURL(origin.Serialize()). This is expensive and often in the critical path of user perceived page loads. One such caller has been converted to the new method, and the rest will be converted in a followup patch. BUG=651554 Review-Url: https://codereview.chromium.org/2378323003 Cr-Commit-Position: refs/heads/master@{#422613}
-
dtseng authored
By typing into an editable, aria attributes do often change (e.g. aria label). Read the attributes on demand (e.g. when a user navigates back to the control or requests a summary of the current element). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=621324 Review-Url: https://codereview.chromium.org/2389793002 Cr-Commit-Position: refs/heads/master@{#422612}
-
sammiequon authored
Fix bug where disabled backspace button would be a bit too small. Also fix bug where chrome user pods were not transitioning. BUG=651954,633542 TEST=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2389013002 Cr-Commit-Position: refs/heads/master@{#422611}
-
dtseng authored
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=639068 Review-Url: https://codereview.chromium.org/2386563003 Cr-Commit-Position: refs/heads/master@{#422610}
-
dtseng authored
In the case where a very lengthy live region fires on a foreground tab, and a background live region fires, don't interrupt the first live region. Also, note that a background webView does lose focus state (even when focus goes to a new window). BUG=619280 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2388193003 Cr-Commit-Position: refs/heads/master@{#422609}
-
chrishtr authored
TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2393433002 Cr-Commit-Position: refs/heads/master@{#422608}
-
dtseng authored
Notificaiton center now fires a focus event on a view that has no role (i.e. a client node). Allow for this so that we pick up on the window ax obj's name "notification center" and override client output to be $name (avoiding the role which provides no value). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=643995 TEST=alt+shift+n Review-Url: https://codereview.chromium.org/2383103003 Cr-Commit-Position: refs/heads/master@{#422607}
-
- 03 Oct, 2016 21 commits
-
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2389973004 Cr-Commit-Position: refs/heads/master@{#422606}
-
cblume authored
It is possible to only have some of the image downloaded and attempt to display an animation frame at the end. When this happens, we would purge important frames. BUG=652046 Review-Url: https://codereview.chromium.org/2382143004 Cr-Commit-Position: refs/heads/master@{#422605}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/cfa4d68b0 BUG=640256 TBR=malaykeshav@chromium.org Review URL: https://codereview.chromium.org/2391533004 . Cr-Commit-Position: refs/heads/master@{#422604}
-
horo authored
Revert of cc/blimp: Add a LayerTreeHostRemote implementation. (patchset #16 id:300001 of https://codereview.chromium.org/2362073002/ ) Reason for revert: cc_unittests on Mac-10.9 failing on chromium.mac/Mac10.9 Tests (dbg) BUG=652502 BeginFrameArgsTest.Helpers (run #1): [ RUN ] BeginFrameArgsTest.Helpers ../../cc/output/begin_frame_args_unittest.cc:66: Failure Value of: ::testing::PrintToString(args1) Actual: "64-byte object <B6-66 E8-02 01-00 00-00 F6-73 E8-02 01-00 00-00 16-00 00-00 A9-7F 00-00 E1-9C BD-01 01-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 FF-FF FF-FF FF-FF FF-FF 01-00 00-00 01-7F 00-00>" Expected: std::string("BeginFrameArgs(NORMAL, 0, 0, -1us)") Which is: "BeginFrameArgs(NORMAL, 0, 0, -1us)" ../../cc/output/begin_frame_args_unittest.cc:68: Failure Value of: ::testing::PrintToString(args2) Actual: "64-byte object <B6-66 E8-02 01-00 00-00 F6-73 E8-02 01-00 00-00 1A-00 00-00 01-00 00-00 3B-9F BD-01 01-00 00-00 01-00 00-00 00-00 00-00 02-00 00-00 00-00 00-00 03-00 00-00 00-00 00-00 01-00 00-00 01-7F 00-00>" Expected: std::string("BeginFrameArgs(NORMAL, 1, 2, 3us)") Which is: "BeginFrameArgs(NORMAL, 1, 2, 3us)" [ FAILED ] BeginFrameArgsTest.Helpers (1 ms) Original issue's description: > cc/blimp: Add a LayerTreeHostRemote implementation. > > This sets up the framework for a LayerTreeHostRemote that implements > the LayerTreeHost API when the compositor is running across a network > boundary. > > This change only sets the framework for running/scheduling main frame > updates and pushing the serialized state using the > CompositorProtoStateSink. Subsequent patches will add state > serialization. > > BUG=648442 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/8d31bac41bbabd01f14eff89f0fc37cd9016c225 > Cr-Commit-Position: refs/heads/master@{#422555} TBR=wez@chromium.org,dtrainor@chromium.org,danakj@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=648442 Review-Url: https://codereview.chromium.org/2384333002 Cr-Commit-Position: refs/heads/master@{#422603}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/5556b4bf5 BUG=637264 TBR=malaykeshav@chromium.org Review URL: https://codereview.chromium.org/2392783002 . Cr-Commit-Position: refs/heads/master@{#422602}
-
horo authored
Revert of bluetooth: Add device list retrieval for chrome://bluetooth-internals (patchset #16 id:280001 of https://codereview.chromium.org/2357383002/ ) Reason for revert: generate_build_files failing on chromium.chrome/Google Chrome Win BUG=652494 C:\b\c\b\win_chrome\src\buildtools\win\gn.exe gen //out/Release --check -> returned 1 ERROR at //build/split_static_library.gni:27:7: Dependency not allowed. static_library(current_name) { ^----------------------------- The item //chrome/browser/ui:ui_0 can not depend on //device/bluetooth/public/interfaces:experimental_interfaces because it is not in //device/bluetooth/public/interfaces:experimental_interfaces's visibility list: [ //device/bluetooth:mojo //chrome/browser:browser //chrome/browser/ui:ui ] GN gen failed: 1 step returned non-zero exit code: 1 @@@STEP_FAILURE@@@ Original issue's description: > bluetooth: Add device list retrieval for chrome://bluetooth-internals > > Changes WebUI setup to a MojoWebUI for chrome://bluetooth-internals page. > Adds mojom files for Bluetooth service definition and internals page handler. > Adds basic Bluetooth device retrieval using starter Bluetooth service > implementation for logging on web front end. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > BUG=651282 > > Committed: https://crrev.com/e619ab633a89f1c845f5fdd7584344a5914b30a9 > Cr-Commit-Position: refs/heads/master@{#422570} TBR=dpapad@chromium.org,dcheng@chromium.org,ortuno@chromium.org,scheib@chromium.org,mbrunson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=651282 Review-Url: https://codereview.chromium.org/2389053002 Cr-Commit-Position: refs/heads/master@{#422601}
-
kozyatinskiy authored
BUG=chromium:632933 R=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2380413002 Cr-Commit-Position: refs/heads/master@{#422600}
-
erg authored
Revert of mus: Use TooltipManagerAura in NativeWidgetMus. (patchset #9 id:160001 of https://codereview.chromium.org/2379073003/ ) Reason for revert: sky@ reports that TooltipControllerCaptureTest.Capture is failing on local chromeos builds. Original issue's description: > mus: Use TooltipManagerAura in NativeWidgetMus. > > mash now shows tooltips on hover over items. > > BUG=599558 > > Committed: https://crrev.com/1b3d5f1878974c14c21a29a13a93ef630c74d1f6 > Cr-Commit-Position: refs/heads/master@{#422562} TBR=sky@chromium.org,jonross@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=599558 Review-Url: https://codereview.chromium.org/2384083005 Cr-Commit-Position: refs/heads/master@{#422599}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2388983002 Cr-Commit-Position: refs/heads/master@{#422598}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/9dbb17e17 BUG=645938 TBR=robhogan@gmail.com Review URL: https://codereview.chromium.org/2391643003 . Cr-Commit-Position: refs/heads/master@{#422597}
-
jrummell authored
The current EME spec has added defaults for some fields in MediaKeySystemConfiguration, so update the code to specify the defaults and match the latest algorithm. As well, at least one of 'audioCapabilities' or 'videoCapabilities' should be specified, so add a UseCounter if none are provided to help determine when this can be enforced in the future. Also update some of the EME tests to provide either 'audioCapabilities' or 'videoCapabilities' (or both) when calling requestMediaKeySystemAccess(). BUG=616233 TEST=EME tests pass Review-Url: https://codereview.chromium.org/2349813002 Cr-Commit-Position: refs/heads/master@{#422596}
-
sunnyps authored
Revert of cc: Remove frame queuing from the scheduler. (patchset #14 id:400001 of https://codereview.chromium.org/2339633003/ ) Reason for revert: Highly likely that this is causing the flakes we are seeing in http://crbug.com/645736 Original issue's description: > Reland of cc: Remove frame queuing from the scheduler. (patchset #1 id:1 of https://codereview.chromium.org/2336493002/ ) > > Reason for revert: > Reland after fixing screenshot grabber test and perf issues. > > Original issue's description: > > Revert of cc: Remove frame queuing from the scheduler. (patchset #3 id:40001 of https://codereview.chromium.org/2323063004/ ) > > > > Reason for revert: > > Broke ChromeScreenshotGrabberTest.TakeScreenshot on Linux ChromiumOS Tests (dbg)(1): https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/18015. > > > > Original issue's description: > > > cc: Remove frame queuing from the scheduler. > > > > > > CC scheduler has a frame queuing mechanism called "retro frames". This > > > has been responsible for a lot of complexity and hard to fix bugs. The > > > original intent for adding retro frames was to allow the scheduler to > > > handle multiple frames in flight but that goal doesn't seem feasible or > > > even desirable any more. This CL removes the retro frames queue and > > > instead makes the Scheduler end the previous frame when it receives a > > > BeginFrame message. > > > > > > One surprising behavior was that SyntheticBFS MISSED frames would be > > > queued as retro frames and this would convert the synchronous begin > > > frame call (inside Scheduler::ProcessScheduledActions) to an > > > asynchronous retro frame PostTask. To work around this the Scheduler > > > keeps track of a single CancelableClosure that's used for MISSED frames. > > > > > > The above behavior was also causing the BeginFramesNotFromClient tests > > > to work even though there was an extra MISSED frame in the queue. This > > > is more elegantly solved in another way by using frame number to advance > > > the task runner instead of just running pending tasks. > > > > > > Lastly SchedulerStateMachine is modified so that it's possible to end > > > the previous frame and still have the same behavior as before in the > > > commit to active tree (browser compositor) mode. > > > > > > R=brianderson@chromium.org,enne@chromium.org,danakj@chromium.org > > > BUG=602485, 644992 > > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > > > > > Committed: https://crrev.com/559280b26cc5672f5f054e8ac35281e804c14d78 > > > Cr-Commit-Position: refs/heads/master@{#417764} > > > > TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sunnyps@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=602485, 644992 > > > > Committed: https://crrev.com/95beb47e50065959ee2f5b43cf431431e32e14cd > > Cr-Commit-Position: refs/heads/master@{#417895} > > TBR=enne@chromium.org,brianderson@chromium.org,danakj@chromium.org,sammc@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=602485, 644992 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/864a70f6f93a87ff374bf2aea2494d4d7d0150d7 > Cr-Commit-Position: refs/heads/master@{#421268} TBR=enne@chromium.org,danakj@chromium.org,brianderson@chromium.org BUG=602485, 644992 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2386183003 Cr-Commit-Position: refs/heads/master@{#422595}
-
dpapad authored
BUG=651513 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2383513003 Cr-Commit-Position: refs/heads/master@{#422594}
-
kozyatinskiy authored
If new XHR breakpoint with existing url is added then we need to enable existing breakpoint. BUG=chromium:532411 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2391773002 Cr-Commit-Position: refs/heads/master@{#422593}
-
fmalita authored
fast/borders/border-radius-with-box-shadow.html requires a trivial rebaseline after https://chromium.googlesource.com/skia.git/+/a3b45d4f7db953472df4f11ab1595964b65175f9 BUG=630695 TBR=bsalomon@chromium.org,reed@google.com NOTRY=true Review-Url: https://codereview.chromium.org/2389043002 Cr-Commit-Position: refs/heads/master@{#422592}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2387053003 Cr-Commit-Position: refs/heads/master@{#422591}
-
yuweih authored
This CL: * Removes the Credits item from the menu since it will be merged into Help's overflow menu. * Refactors the item layout so that we only needs one XML and specifying icon and text in the code. BUG=613604 Review-Url: https://codereview.chromium.org/2383283002 Cr-Commit-Position: refs/heads/master@{#422590}
-
rdevlin.cronin authored
An extension function error should be set only through the use of the response (i.e., ExtensionFunction::Error()), and setting it directly can lead to confusion and incorrect results. Remove ExtensionFunction::SetError(). Other subclasses (like AsyncExtensionFunction) still have accessors, but will be updated as they are converted. Also disable two more input IME API tests that were always failing, but silently passed because of passing success despite having an error. BUG=648275 Review-Url: https://codereview.chromium.org/2386823002 Cr-Commit-Position: refs/heads/master@{#422589}
-
msw authored
Support the ShelfID window property in mash. (ShelfWindowWatcher uses this to find existing items) Allow WM clients to set ShelfItemType and ShelfIconResourceId. Define aura property keys in a shared location for chrome and ash. Notify WmWindowObserver of certain white-listed property changes. Add WmWindowProperty::INVALID_PROPERTY for key translation checks. Add property utility functions to c/b/ui/ash for aura/ui windows. Use SettingsWindowObserver in ChromeLauncherController (cash&mash). Use separate aura/ui window trackers to watch for name changes. (Can't use ash::WmWindow in Chrome... depends on ash internals) Early return from Window::SetTitle if the values match. TODO: Use ash/mus/property_util.h (move some to ash/public/cpp)? TODO: Automatically propagate some props with an observer? BUG=634150 TEST=chrome --mash shows task manager and settings shelf icons. R=jamescook@chromium.org,sky@chromium.org,tsepez@chromium.org, Review-Url: https://codereview.chromium.org/2381183002 Cr-Commit-Position: refs/heads/master@{#422588}
-
jam authored
This fixes BrowserTest.ClearPendingOnFailUnlessNTP. BUG=504347 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2380383004 Cr-Commit-Position: refs/heads/master@{#422587}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8341c698..9c1db96f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2390023002 Cr-Commit-Position: refs/heads/master@{#422586}
-
