GitLab

This needs to be enabled by Finch instead of disabled by finch.
This in principle reverts but revision exceptions were blocking the merge:
https://chromium-review.googlesource.com/1176475

BUG=chromium:889118

Change-Id: I401312d32188ff6a0fd97b7fe8838b4371521b95
Reviewed-on: https://chromium-review.googlesource.com/c/1288709
Commit-Queue: Allen Webb <allenwebb@google.com>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600780}

There's a few bug fixes in this CL but it seems ok to lump them
together since each bug is in a separate file.

CustomTabActivity.java - don't show AMP UI on a Preview

ToolbarManager.java - also update Previews UI on commit

ToolbarModel.java - explicity remove the scheme from Previews

Bug: 896478
Change-Id: Id8353a8787481bf4fcbfa322994d8b0ec998d6df
Reviewed-on: https://chromium-review.googlesource.com/c/1287289
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600779}

TBR=agrieve@chromium.org

Bug: 620034
Change-Id: I1e0b1d665692cc727453c7c974402d71aa4bc01b
Reviewed-on: https://chromium-review.googlesource.com/c/1288889Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600778}

Before the keyboard accessory was visible on password fields only,
it was correct to suppress the InfobarContainer until the accessory
disappeared.

Now that the accessory can disappear while keeping the keyboard open,
the Infobar would be shown with an open keyboard. This CL fixes this
unwanted state by checking keyboard visibility explicitly.

This is an intermediate solution until crrev/c/1286426 lands.

Bug: 895779
Change-Id: I1d24b5c71ce094102e9860cd415277d9570c19df
Reviewed-on: https://chromium-review.googlesource.com/c/1286820
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600777}

https://chromium.googlesource.com/angle/angle.git/+log/25843dd65181..945dea36ab8a


git log 25843dd65181..945dea36ab8a --date=short --no-merges --format='%ad %ae %s'
2018-10-18 jsaarhelo@nvidia.com Clamp glClearDepthf and glDepthRangef


Created with:
  gclient setdep -r src/third_party/angle@945dea36ab8a

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I571b1ab2f8e9033d5d560b0572996237583daa64
Reviewed-on: https://chromium-review.googlesource.com/c/1288690Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600776}

Bug: b/117813236
Change-Id: I5f4d9753463e66fed0c336fa546ef80805586847
Reviewed-on: https://chromium-review.googlesource.com/c/1287049
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600775}

The iframe support has been developped.
I tested locally and the test passes in the conditions described in
crbug.com/857129
Renable WebStateTest.MessageFromIFrame tentatively.

Bug: 857129
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifab8070aa3c70447aa49f6b65ca2010fb5f49573
Reviewed-on: https://chromium-review.googlesource.com/c/1283073
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600774}

This CL is adding a renderers specific tracing scenario.

The previous tracing scenario was BENCHMARK_IPC which is not given
enough details to make renderers traces actionnale. We are making a
specific scenario and will add the required category to debug
renderers issues.

R=gab@chromium.org, oysteine@chromium.org

Change-Id: I8e0dbce3f18a403de6f0f7bb4c63abf4a1b53f66
Reviewed-on: https://chromium-review.googlesource.com/c/1286770
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600773}

Re-run testing/buildbot/generate_buildbot_json.py

BUG=868024

Change-Id: Iae857082985de453d256150f2ef653f9f570337f
Reviewed-on: https://chromium-review.googlesource.com/c/1286757
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600772}

* FooBarNames::FooBarNamesCount -> FooBarNames::kNamesCount
* FooBarNames::FooBarTagsCount -> FooBarNames::kTagsCount
* FooBarNames::FooBarAttrsCount -> FooBarNames::kAttrsCount
* FooBarNames::getFooBarTags() -> FooBarNames::GetTags()
* FooBarNames::getFooBarAttrs() -> FooBarNames::GetAttrs()

This CL has no behavior changes.

Bug: 889726
Change-Id: Ic9af4a9e267b816456e85c22bbd6079f5581c599
Reviewed-on: https://chromium-review.googlesource.com/c/1288519
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600771}

Right now the CSSPaintDefinition::Paint takes a IntSize which is the
container size with subpixel snapping. At this moment there are two type
cast:
1. The call site of the CSSPaintDefinition::Paint converts a FloatSize
to IntSize
2. Inside the CSSPaintDefinition::Paint, GetSpecifiedSize is called
which type casts the IntSize to float and uses it.

This CL cleans it up by passing a FloatSize. That is, the Paint function
takes a FloatSize such that type casting can be avoided at the
GetSpecifiedSize. When we need to use the subpixel snapped size in the
Paint function, we then conver the FloatSize to an IntSize.

This CL should not introduce any behavior change.

Bug: None
Change-Id: I1387145c03b60380a0e0a53f2686647a54327e71
Reviewed-on: https://chromium-review.googlesource.com/c/1286440Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600770}

According to the spec, responseReady in BackgroundFetchRecord should
throw an AbortError DOMException if the fetch was abandoned.

https://wicg.github.io/background-fetch/#create-record-objects (2.4.3)

Change-Id: Ieadf278acd061e05b8822014d0934f050fcac702
Reviewed-on: https://chromium-review.googlesource.com/c/1283692
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600769}

In addition, MatchAll should return all records, including unprocessed
ones. To support this, the following changes were made:
- Creating a registration also stores all the requests with an empty
response in the cache.
- When an individual request is processed, the failure reason (if any)
is stored in the metadata.
- The logic of GetSettledFetchesTask was moved to
MarkRegistrationForDeletionTask. It checks the metadata rather than the
cache itself to find a failure reason (if any).
- Match/MatchAll logic was moved to a new database task
(MatchRequestsTask). A new API call was added to the cache storage to
allow querying request/response pairs. If a response is found to be
empty it will be exposed as a nullptr.

Change-Id: I631a3ef3da95117aed759a675fe591da5201eeca
Reviewed-on: https://chromium-review.googlesource.com/c/1280851Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600768}

This is possible now that there is //chrome-level infrastructure for
glueing an IdentityTestEnvironment instance to a Profile.

Note that this particular test is somewhat unusual in that it builds
multiple Profiles but does not require IdentityTestEnvironment to
interact with those Profiles beyond doing initial configuration. For
simplicity, we use local variables for the IdentityTestEnvironment
associated with each Profile; otherwise, we would need to introduce
distinct instance variables for the two.

This CL also modifies the relevant
IdentityTestEnvironmentProfileAdaptor APIs to return the
TestingProfiles that they create as TestingProfiles; this avoids a
cast that this test would otherwise require and clarifies the APIs.

TBR=droger@chcromium.org

Bug: 896180
Change-Id: Icba8cdc67c1667949636a96078f05e15fd79649c
Reviewed-on: https://chromium-review.googlesource.com/c/1283038
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600767}

Cast needs both render process ID and render frame ID for
resolving URL requests to owning render frame / web contents.

Bug: internal b/116784351
Test: Build cast_shell and run unittests
Change-Id: Ib1913e41f33410241fe4d63fffa6c1ee68e18be3
Reviewed-on: https://chromium-review.googlesource.com/c/1280930Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Tavis Maclellan <maclellant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600766}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/dom_distiller.

This CL was uploaded by git cl split.

R=bengr@chromium.org

Bug: 809610
Change-Id: I30fc5cf421d359ac3072b38b940a783737e66f38
Reviewed-on: https://chromium-review.googlesource.com/c/1259023Reviewed-by: Ben Greenstein <bengr@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600765}

All the functionality is in ContentSettingBlockedImageModel. This
CL should have no behavior changes.

Bug: None
Change-Id: I7694d5968cbb514c0959d821bf0888a770477a0c
Reviewed-on: https://chromium-review.googlesource.com/c/1287314
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600764}

BackgroundFetchSettledFetch isn't exposed to JavaScript so we can remove this.

Bug: 875201
Change-Id: Ic306b0f64897a7d7c1fbd61f64b6c635620d7bd3
Reviewed-on: https://chromium-review.googlesource.com/c/1288357Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600763}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/sockets_udp.

This CL was uploaded by git cl split.

R=rkc@chromium.org

Bug: 809610
Change-Id: Id800ae4bd2e053483b447457cd78cb50657d8ace
Reviewed-on: https://chromium-review.googlesource.com/c/1259032Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600762}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=emircan@chromium.org

Bug: 681136
Change-Id: I860ea8a950d3802572c22aaeecba23f716f55d5b
Reviewed-on: https://chromium-review.googlesource.com/c/1288339Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600761}

This also updates how we compute the default for 'configuration'. First, we try to look for the
configuration definition (args.gn) & use that value. If that doesn't succeed, we guess the
value of configuration using the target value.

Reviewers: the main change is in third_party/blink/tools/blinkpy/web_tests/port/base.py, the rest are followed by.


Bug: 893618
Change-Id: I578c977bcaccd6294596f8cf7079748809698db6
Reviewed-on: https://chromium-review.googlesource.com/c/1281043Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#600760}

Add SearchEngineTabHelper without any functionality. This TabHelper will
be the main worker for custom search engines feature.

Bug: 433824
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ie18b9237d0f1df52d94ff2c9b4e70b299ab426b1
Reviewed-on: https://chromium-review.googlesource.com/c/1288431
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600759}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286016

This CL was uploaded by git cl split.

R=sdefresne@chromium.org

Bug: 753973
Change-Id: Ia8531202caddd46a45169eae9b5b8af77585ab80
Reviewed-on: https://chromium-review.googlesource.com/c/1288173Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600758}

This CL implements footers in the Autofill dropdown on legacy
(Jellybean - Marshmallow) Android. It does so by implementing an
interface method which is currently empty. This also required
AutofillPopup to be changed slightly, as the new implementation cannot
be invoked after show()ing the popup.

Change-Id: I9387be794382a32a3abd92a267c7de9e7b04d8b1
Bug: 896693
Reviewed-on: https://chromium-review.googlesource.com/c/1281723
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600757}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=xiyuan@chromium.org

Bug: 681136
Change-Id: I54485b40c1808525659f4af61369a04819c40e06
Reviewed-on: https://chromium-review.googlesource.com/c/1288493Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600756}

Bug: 891908
Change-Id: I5bbe921e0cf8462abe9be3c75c594e4a507d3118
Reviewed-on: https://chromium-review.googlesource.com/c/1280613
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600755}

BUG=242216

Change-Id: I6f897509727b026b9d1f17227b0621b30821cc56
Reviewed-on: https://chromium-review.googlesource.com/c/1286937
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600754}

Bug: 798719
Change-Id: I371d41833373fe54efeb844a338840b7d862784c
Reviewed-on: https://chromium-review.googlesource.com/c/1287188Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600753}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/413a5120b915..2d0fa5b17840


Created with:
  gclient setdep -r src-internal@2d0fa5b17840

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I9f6b61884ad88120573c736f2ebc486871527544
Reviewed-on: https://chromium-review.googlesource.com/c/1288681Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600752}

A feature and flag is added to control adding an incognito window
counter to the incognito icon on toolbar.

Bug: 896235
Change-Id: Ic0766f2344d9caefc7ede1e5266df053d32ef2d5
Reviewed-on: https://chromium-review.googlesource.com/c/1286423
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600751}

This eliminates the use of V8CallBoolean.

Bug: 670615
Change-Id: Ifaaa803e47b08018546d30ad633f861f38a8d645
Reviewed-on: https://chromium-review.googlesource.com/c/1288673Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600750}

The reason we're now splitting this module into its own target is
to avoid dependency cycles when migrating certain bits to the
Identity service: since AuthService lives in google_apis/drive,
we can't port it to the IdentityManager without incurring in a
cycle caused by the identity service depending on the signin
component which, in turn, depends again on google_apis.

Note that we now need to make some GN targets under chrome/browser
directly depend on //google_apis/drive as well in order to prevent
build failures caused from happening because of such targets including
headers files from //google_apis/drive. This was not required before
doing this split since those targets would implicitly pull //google_apis
through some of their direct dependencies' public_deps anyway. However,
the new //google_apis/drive target is not listed as a public_dep anywhere,
and so explicitly depending on it from those places is now required.

Making this change now allows us to break the cycle since the signin
component does not depend on anything in google_apis/drive, allowing
us to reimplement AuthService in terms of the IdentityManager.

Bug: 809440
Change-Id: Iec117d39beb073a094c180a1d855b7f33353e0b2
Reviewed-on: https://chromium-review.googlesource.com/c/1273074
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600749}

TBR=liaoyuke@chromium.org,robertocn@chromium.org

Change-Id: I783b07eacca213f2815f6c0f66bfb77c55b9435f
Bug: 896556
Reviewed-on: https://chromium-review.googlesource.com/c/1288689Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600748}

This CL tests that authentication tokens are revoked when the Gaia cookie
is cleared, unless there is a ScopedSyncedDataDeletion in which case the
Sync account is not invalidated.

Change-Id: Ia0d5470eb3d41d67a93671a1d7a58bbddc23e8a3
Reviewed-on: https://chromium-review.googlesource.com/c/1258167
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600747}

When the user opted into unified consent and then the feature is
rolled back, all off-by-default services are disabled.

Bug: 894504
Change-Id: I50adddb41cab7c38162344a538eef52e04dfa999
Reviewed-on: https://chromium-review.googlesource.com/c/1280445
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600746}

Bug: 896193
Change-Id: I046d763c004b2fafa66df76704489a1ab5d5821d
Reviewed-on: https://chromium-review.googlesource.com/c/1286415
Commit-Queue: Minyue Li <minyue@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600745}

test-25fps.*.frames.md5 contains the golden md5 values on decoded video frames
in VDA unittest. These values must be identical on any platforms.

BUG=chromium:856562
TEST=VDA unittest at eve, veyron_minnie, hana

Change-Id: I3c63b92dcc52b8a3a6cc1dc4a2dd9e9147e5ec7b
Reviewed-on: https://chromium-review.googlesource.com/c/1172271
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600744}

This reverts commit 1e0ee862.

Reason for revert: Don't use popen() as it is not available on Windows.

Original change's description:
> Revert "[Cronet] Create a sample app for native api."
>
> This reverts commit b54f7c7f.
>
> Reason for revert: breaking the tree
>
> Original change's description:
> > [Cronet] Create a sample app for native api.
> >
> > Bug: 786559
> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> > Change-Id: I56fa2a6f9f6277fe33ea78e7dc01beffd32cbed6
> > Reviewed-on: https://chromium-review.googlesource.com/c/1274426
> > Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> > Commit-Queue: Misha Efimov <mef@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600438}
>
> TBR=pauljensen@chromium.org,mef@chromium.org
>
> Change-Id: I3cc86a29982f4479a3260ec2522847416fe6547b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 786559
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
> Reviewed-on: https://chromium-review.googlesource.com/c/1286935
> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600444}

TBR=tguilbert@chromium.org

Change-Id: I4935a11d8f20e97122fccd9451a201d135d5db8a
Bug: 786559
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Reviewed-on: https://chromium-review.googlesource.com/c/1286745Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600743}

Currently, this method is simply calling ResetChildren() on the current
RenderFrameHost. It used to do more, but this is no longer the case.

This CL removes this method. Seeing RenderFrameHostImpl::ResetChildren()
in the code is more explicit about what happens. It is easier to
understand.

Bug: 609963
Change-Id: Ia82726f445b127ccca3758d7578e71eb32a49cbc
Reviewed-on: https://chromium-review.googlesource.com/c/1286421
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600742}

Adds flags on all browser layers which are used for enabling in a Finch
trial.

Tbr: jochen@chromium.org
Bug: 843903
Change-Id: I50d9aa479b1fb6e27588eae000138564f377b523
Reviewed-on: https://chromium-review.googlesource.com/c/1286854
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600741}