GitLab

The opt-in assistant menu is interfering with some tast tests. Tast
tests use --oobe-skip-postlogin to skip dialogs that appear after
a new user has logged in, so let's just use that flag too.

Bug: 929396
Change-Id: I16dd55a68f6e68ed4780e99d68afdc24a1b0002e
Reviewed-on: https://chromium-review.googlesource.com/c/1459865Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630145}

This view provides the UI for in-Assistant notifications. Currently the
labels/buttons for this view are stubbed in but a follow up CL will wire
this view up to actual mojom::AssistantNotifications.

Screenshot: http://shortn/_MYjBlqDoku

Bug: b:118654460
Change-Id: I1a436c33466aff9db0c92595a988170c99456e0f
Reviewed-on: https://chromium-review.googlesource.com/c/1453547
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630144}

This reverts commit 6c2e6729.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=929793#c6

Original change's description:
> Third try of ResourceLoadViaDataPipe
> 
> Flipping the flag revealed a couple of issues which were fixed:
> - OnTransferSizeUpdated(): https://crrev.com/c/1454344
> - One more PostTask() made tests more flaky: https://crrev.com/c/1454345
> 
> I hope third try will go well.
> 
> Bug: 894819
> Change-Id: Icc6159622aacd5c4a4c250a0834bf4c3641d916a
> Reviewed-on: https://chromium-review.googlesource.com/c/1454062
> Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629089}

TBR=kinuko@chromium.org,shimazu@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 894819
Change-Id: I9aca1329997e4f2517cd72bc79020bf2d147af35
Reviewed-on: https://chromium-review.googlesource.com/c/1459584Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630143}

Bug:837156

Change-Id: I4456e92e52cf503843da3190661b9de6cf5029ae
Reviewed-on: https://chromium-review.googlesource.com/c/1460276Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Leo Zhang <googleo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630142}

Some of the NTP DLOGs trigger quite often, and none of them are
very useful to see on every NTP load. Convert them all to DVLOG(1)
so as not to spam the output, they can still be triggered with --v=1.

Bug: 929875
Change-Id: Ie1fb98a357c23a4ba67c6b105b0d640f372fbb65
Reviewed-on: https://chromium-review.googlesource.com/c/1460107Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630141}

This fixes the build with libstdc++:

    ../../ui/gfx/color_utils.cc: In function ‘SkColor color_utils::SetDarkestColorForTesting(SkColor)’:
    ../../ui/gfx/color_utils.cc:434:12: error: ‘sqrtf’ is not a member of ‘std’
           std::sqrtf((dark_luminance + 0.05f) * (kWhiteLuminance + 0.05f)) - 0.05f;
                ^~~~~
    ../../ui/gfx/color_utils.cc:434:12: note: suggested alternative: ‘sqrt’
           std::sqrtf((dark_luminance + 0.05f) * (kWhiteLuminance + 0.05f)) - 0.05f;
                ^~~~~
                sqrt

sqrtf() is not formally part of C++14 as far as I can see even though libc++
has it in <cmath>. Additionally, we're only dealing with floats in all parts
of the expression above, so using the float sqrt() overload should be
harmless anyway.

Bug: 819294
Change-Id: If6c7bf31819df97a761e6963def6d6506154c34d
Reviewed-on: https://chromium-review.googlesource.com/c/1458193
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#630140}

The Polymer observer which updates the header visibility was not
executing on startup because |showingSubpage_| is initially undefined.
Worked fine in Polymer 2 because of different observer behavior
semantics.

Bug: 929834
Change-Id: I9061bf701d90411bf76e1dc2d12a3830ca6199be
Reviewed-on: https://chromium-review.googlesource.com/c/1459798
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630139}

Test: test_runner.py instrumentation ... --use-webview-provider /path/to/webview/apk

Bug: 914553
Change-Id: I061e69e4484442055a74a14f225a5cefd0419a2e
Reviewed-on: https://chromium-review.googlesource.com/c/1396849
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630138}

Use the same text as for a11y name.

Bug: 794441
Test: manual
Change-Id: Ifdbf19b20d2ded8071dd8187083af832c1357f22
Reviewed-on: https://chromium-review.googlesource.com/c/1460074
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630137}

This changes FidoRequestHandlerBase to potentially instantiate a caBLE
discovery even when the native Windows WebAuthn API is present. Previously, we
did not support caBLE in that environment due to the native UI not being
integrated with Chrome's own WebAuthn UI.

ChromeAuthenticatorRequestDelegate now controls dispatch for the Windows API
authenticator. For requests where TransportAvailabilityInfo indicates that both
caBLE and the native API are available, it will show the caBLE UI and only
dispatch to the native API after the decides to do so via the transport
selection dropdown menu. If caBLE is not available, the request is dispatched
to the Windows API immediately without additional Chrome UI.

Bug: 905111
Change-Id: I1a00b0c9f0772eb97de954b38319b599e8d6c5ac
Reviewed-on: https://chromium-review.googlesource.com/c/1455647
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630136}

- Add a new private autotest Api SetWhitelistedPerf to toggle user pref based
  on perf_name by calling PrefService* profile->Set(pref_name, value).
- Update the existing arc++ autotest Api SetPlayStoreEnabled by calling
  SetWhitelistedPerf (arc::pref::kArcLocationServiceEnabled, params->enabled)
  instead.

Bug: b/123427495
Test: local compile and manually tested with existing arc++ autotest:
      test_that -b DUT cheets_AuthPerf.

Change-Id: Ia6e77bad6f489b58ecac25c6ea1dfeb9676b76f9
Reviewed-on: https://chromium-review.googlesource.com/c/1437709
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630135}

Seems that we may not get the webglcontextlost event unless a GL command
happens to fail after the context loss has occurred. Use a 250ms timer
to tickle the context until the webglcontextlost event occurs.

BUG=929012,929429

Change-Id: I191b2338f633612fc3b8206bf27f9a14c968bd23
Reviewed-on: https://chromium-review.googlesource.com/c/1459780
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630134}

The former non-overloaded variants are deprecated.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: I0dbef366e8c10731904f12ea68ea4656b7748519
Reviewed-on: https://chromium-review.googlesource.com/c/1459536Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#630133}

CL which actually implements images is forthcoming.

Bug: 928954
Change-Id: I55e829aed86c8a5d8a7ad3e644bd722216a336d1
Reviewed-on: https://chromium-review.googlesource.com/c/1455656
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630132}

This improves the adb_command_line tool as follows:

 * For WebView, throw an exception if someone tries to use this on a
   user device (WebView won't respect the flags anyway)
 * For Chrome, log a warning on user devices (Chrome is slightly more
   relaxed, but usually won't respect flags)
 * Minor refactoring to use already-existing helper methods to add some
   flags (no significant change to behavior here though).

R=agrieve@chromium.org

Bug: 918727
Test: Manual (try to write flags on user and userdebug emulators)
Change-Id: I78dc223bd882fc41d47d19bac6b2b2a26a6a53ac
Reviewed-on: https://chromium-review.googlesource.com/c/1458369
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630131}

Current code allows large numbers of empty samples in a trun, with
consequent overhead for allocating and populating their metadata. Such
overhead impacts both production and fuzzer MSE parsing paths.

This change adds histograms to gather metrics to hopefully allow
realistic constraints on number of zero-sized samples in a trun or length
of sequences of zero-sized samples in a trun.

BUG=907268

Change-Id: I78d5c8ea43fb0c023d951267debf66f168e5c4af
Reviewed-on: https://chromium-review.googlesource.com/c/1449158
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630130}

This patch modifies the dialog plate to match the UX mock.
Main changes:
1. Move the dialog plate to top.
2. Adding a back arrow.
3. Adding a molecule animating logo.

Bug: 924624
Test: manual
Change-Id: I5bae7d4bec2f096d3c17a7b47a7ac34e71089e21
Reviewed-on: https://chromium-review.googlesource.com/c/1457022Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630129}

When a CSS selector matches many elements in a DOM ancestor path,
Styles sidebar can be flooded with many sections with the exact same
stylesheetId and range. This CL dedupes sections in this case.

Screenshot: https://imgur.com/a/Zc3jkQm

Bug: 929536
Change-Id: I4f76b0df9052df34b6d42028a038c65a22c8fac1
Reviewed-on: https://chromium-review.googlesource.com/c/1451675Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630128}

Seen to intermittently crash the GPU process with the passthrough
command decoder on Win/Intel as well.

Bug: 929009
Change-Id: I98f3fc6ebf89ee22835a5769ec7db9c0bf2d5cc6
Tbr: geofflang@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/1460418Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630127}

Tests were using this inconsistantly and there was a lot of boilerplate
to support one test case that I addressed with an override.

Bug: none
Change-Id: I808d413184eabf8de11fcd0edea4f3aa52fc9d08
Reviewed-on: https://chromium-review.googlesource.com/c/1457723Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630126}

This patch will set the click or tap event in assistant_page_view to be
handled to prevent app_list_view changing state.

Bug: 924624
Test: manual
Change-Id: I5bcdca18a7980f85803556b282227eeeb87c46c1
Reviewed-on: https://chromium-review.googlesource.com/c/1455271
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630125}

This reverts commit 18ff8e77.

Reason for revert: Breaking win32-rel compile
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/10878

Original change's description:
> [image_decode_bench] Use //base CommandLine to process arguments
> 
>  - use //base CommandLine to process the command line arguments
>  - add support for benching multiple input image files
>  - include the input file file name in the output
>  - add program usage and help arguments -h --help
>  - retain the -i iterations option for now
>  - remove an old TODO
> 
> Bug: 601198
> Change-Id: Ib4e942dcc89ef9ff7eda6271f0cb3d0f93c5cca1
> Reviewed-on: https://chromium-review.googlesource.com/c/1454104
> Reviewed-by: Leon Scroggins <scroggo@chromium.org>
> Commit-Queue: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630123}

TBR=scroggo@chromium.org,noel@chromium.org,adenilson.cavalcanti@arm.com

Change-Id: Ic3aadcb231ceccbbe11a1b591de655a33f8d696e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 601198
Reviewed-on: https://chromium-review.googlesource.com/c/1459869Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630124}

 - use //base CommandLine to process the command line arguments
 - add support for benching multiple input image files
 - include the input file file name in the output
 - add program usage and help arguments -h --help
 - retain the -i iterations option for now
 - remove an old TODO

Bug: 601198
Change-Id: Ib4e942dcc89ef9ff7eda6271f0cb3d0f93c5cca1
Reviewed-on: https://chromium-review.googlesource.com/c/1454104Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630123}

Instead of immediately switching browsers, Chrome will now navigate to
chrome://browser-switch, which takes care of switching browsers and
closing the tab.

Bug: 887005
Change-Id: I195b6ad80b18b7cd6fd2c42a42d03853c14a80a1
Reviewed-on: https://chromium-review.googlesource.com/c/1456680
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630122}

The former non-overloaded variants are deprecated.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: I2fae8217f120f3c8ded26d6466b888d89d9fda64
Reviewed-on: https://chromium-review.googlesource.com/c/1459617
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630121}

Some reworking how the "DNS race" works now that the initial resolve
can handle both stale and fresh and we only need to spawn a separate
call if it actually does return a stale result.

Also fix some tests that were relying on a custom HostResolver mock
that gave unintended behavior when CreateRequest() was used instead of
Resolve().

Bug: 922699
Change-Id: I349b5995f2fc5c9042f1a0387bac4018461717d4
Reviewed-on: https://chromium-review.googlesource.com/c/1435710Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630120}

This makes it safe to use property trees and LayerState
on GraphicsLayers.

Bug: 929028

Change-Id: I5b6ca533b0c3c4c30e5f6f75132064f0d4b7b987
Reviewed-on: https://chromium-review.googlesource.com/c/1459518Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630119}

This CL adds UiUtils.getTintedDrawable and removes several snippets that
were doing the same thing.

Bug: None
Change-Id: Ia32b8ca25524f4e7bf2e431bb52436ec0f852110
Reviewed-on: https://chromium-review.googlesource.com/c/1456743Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630118}

This is apparently a good practice since these macros can generate
quite a bit of code, which I didn't know at the time of writing this.

Change-Id: If28af80c07200562f029e2c588ffc5666a5e8326
Reviewed-on: https://chromium-review.googlesource.com/c/1459579Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630117}

If the closes run in parallel, there is some non-determinism in timing of
when they re-acquire FDs to finalize writes to disk and release FDs
afterwards, making exact behavior of FD limiter dependent on execution
schedule, especially on number of threads ScopedTaskEnvironment uses.

Change-Id: Id0da08ba64d24816835b155440cb7327dfcdf889
Reviewed-on: https://chromium-review.googlesource.com/c/1459519Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630116}

This converts the following service manifests from JSON to C++:

- Chrome no-op service (for network service testing)
- Chrome printing service
- Removable storage writer service
- Misc Windows utilities service
- Windows WiFi utilities service
- Chrome profile import service

These are the last of the JSON manifests under src/chrome/.

Bug: 895616
Change-Id: I0c890f68d50441841e6a3e6a74d4f5fbc04c4d16
Reviewed-on: https://chromium-review.googlesource.com/c/1456976
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630115}

Screenshot in bug.

Bug: 928174
Change-Id: I55fb4d0226fd623a4d377ed95928891744e55cef
Reviewed-on: https://chromium-review.googlesource.com/c/1459578Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630114}

CL unintentionnal removed a break line (behavior unchanged).
This CL reintroduce this line.

Change-Id: I1962dd3f8edf18f8a93a527d5ec629f79ddfa463
Reviewed-on: https://chromium-review.googlesource.com/c/1458685Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630113}

The former non-overloaded variants are deprecated.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: I2f4f54db79e158e0136d57b2ee5e1553784079e2
Reviewed-on: https://chromium-review.googlesource.com/c/1454535
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#630112}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/20be13b329a2..b9ae2ca9a55d


git log 20be13b329a2..b9ae2ca9a55d --date=short --no-merges --format='%ad %ae %s'
2019-02-07 thestig@chromium.org Fix get_toolchain_if_necessary.py --nodownload message formatting.
2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@b9ae2ca9a55d

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I0c1dc7f3fb764a92f2a089228281b21bbca19be4
Reviewed-on: https://chromium-review.googlesource.com/c/1459936Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630111}

Reland: Reland: Network Service: Use histograms instead of chartjsons for network service performance tests

The initial upload of this CL is the same as:
https://chromium-review.googlesource.com/c/chromium/src/+/1456694

New changes in this CL from the above original CL:
The linux-perf-fyi bot failed at:
https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/1769
And it is because test_results.json is null. This file is generated when
"--output-format=json-test-results" is set. In the above original CL, it uses:
finder_options.output_formats = ['chartjson']
and this removes other entries in the output_formats. This CL keeps the
original finder_options.output_formats while replacing 'histograms' with
'chartjson' when feed it into the story_runner.

This CL modifies the network service performance tests to generate
histograms instead of chartjsons so that the Pinpoint can automatic
bisect CLs.

TBR=crouleau@chromium.org, jam@chromium.org, simonhatch@chromium.org, benjhayden@chromium.org

Bug: 927155
Change-Id: I1e49a9d3e5e6ff8b085fda6bb2005b79993a4cf1
Reviewed-on: https://chromium-review.googlesource.com/c/1457730Reviewed-by: Jun Cai <juncai@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630110}

NetworkContextConfigurationBrowserTest currently enables the network
service for the /1 tests, and leaves it in its default state for /0. If
the network service is enabled by default, leaving it in its default
state will result in it being enabled when it shouldn't.

This doesn't fix broken or flaky tests, just makes them behave as
intended.

Bug: 927293
Change-Id: Icda641679b42cba1c81061c00f82e35cf8a88500
Reviewed-on: https://chromium-review.googlesource.com/c/1457479
Auto-Submit: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630109}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9b6ba4d1c57e..cf21146137cf


git log 9b6ba4d1c57e..cf21146137cf --date=short --no-merges --format='%ad %ae %s'
2019-02-07 greg@lunarg.com Expand bindless bounds checking to runtime-sized descriptor arrays (#2316)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@cf21146137cf

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5c9a20493e5474ef83787899b90c648066c16a54
Reviewed-on: https://chromium-review.googlesource.com/c/1459196Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630108}

Changes:
1. Use |announcement_view_| in app list to announce all alerts instead
of creating such view in different places.
2. Aggregate all usages of announcing open/close folder in one place.
3. Remove kAlert role from AppsGridView to avoid extra vox announcement
   "Alert".

Bug: 929775
Change-Id: I8ce053d055c6afbf4fa349f9d449a4d069f4854b
Reviewed-on: https://chromium-review.googlesource.com/c/1459796
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630107}

[1] changed overview to release overview session and then pass that
object to its observers. Splitview was querying overview controller
for overview session which would be null, so it wouldnt remove the snap
window from overview list, which would cause its animation to be
supressed.

This cl change splitview to remove the window in OnOverviewEnded and
use the overview session object before snapping.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1406169

Test: manual
Bug: 929658
Change-Id: Iabab38034bea49cdafd1a3ad24310298ca8826de
Reviewed-on: https://chromium-review.googlesource.com/c/1459066Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630106}