- 02 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f8e5aadbd424..898bbfac2e35 git log f8e5aadbd424..898bbfac2e35 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 michaelludwig@google.com Update gms to use new image filter factories 2019-08-02 stani@google.com Delete unused variant of MakeBackendTexture 2019-08-02 egdaniel@google.com Add table for supported colortypes in GrVkCaps. 2019-08-02 senorblanco@chromium.org Dawn: implement sk_app window contexts for all backends. Created with: gclient setdep -r src/third_party/skia@898bbfac2e35 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: chromium:b/138674291 Change-Id: I4d4783c1816e62448c1bfc21b072a3262315d1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733033Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683773}
-
Antonio Gomes authored
... instead of /media_stream.mojom-shared.h BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I6c493da78b25be83c80c93fb81028aa457b0bedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731873 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#683772}
-
Mason Freed authored
In some cases, ScopedReadLockSkImage is not able to read back the texture, because it does not know the hardware supports texture rectangles. In that case, fall back to using CopyTextureCHROMIUM to copy the mask texture into an SkImage. Bug: 984766 Change-Id: I0a348a98767405f61810b03217ef96bb2b5bba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730291Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#683771}
-
Hesen Zhang authored
- Add switch to enable/disable helpful/unhelpful buttons. - Complete the logic to build helpful/unhelpful buttons if switch is on. - TODO: Replace the button text from GRD. Bug: 988117 Change-Id: Ia46ca3781fb036de4143193031d5906333158cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730254 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683770}
-
Theresa authored
BUG=951455 Change-Id: I0e112271dd6cf0d31c06ec3a135643b7da05aa7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730864Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#683769}
-
Bo Liu authored
Make VizCompositorThreadRunner into an abstract interface and move the existing implementation to VizCompositorThreadRunnerImpl. Then add VizCompositorThreadRunnerWebView which will be webview's entry point into creating and establishing viz objects. Add code paths to ContentGpuClient so that webview can optionally override the default instance. Currently VizCompositorThreadRunnerWebView doesn't do much, except it uses TaskQueueViz and exposes a simple API to run and block for work on viz while allowing viz to schedule tasks on the render thread. Bug: 805739 Change-Id: Ic5d2c45666ebc1fc9381c8cd5c71b0de57dd0136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731135Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Maksym Onufriienko authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. EarlGrey2 has multiprocess architecture, where Chrome Test and Chrome App are separate processes Change-Id: Ib41116bb8df8c8383ad8a76460d5643560983716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732157 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#683767}
-
Gang Wu authored
For enabling "Text you copied" on Clank, we need this function to provide Text in Android's clipboard. Bug:989143 Change-Id: I35032a6468f3bbae87b0027caa3924aa8af070b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726276Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683766}
-
Matt Menke authored
Doesn't actually modify the method bodies at all. Change-Id: I7354db324deeee4bfeb497038a704d9cbb98d961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733789Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#683765}
-
Lei Zhang authored
Only depend on content/public/common when building for Chrome OS. Since that is the only time when the dependency is actually needed. Bug: 990184 Change-Id: Ie7e04f317510b3bcb099acfb81379919b96ffccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732389Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#683764}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/116752315474..0fca4beb4959 Created with: gclient setdep -r src-internal@0fca4beb4959 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic231f5d2eec85dee7cab81b0de81453547252c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733714Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683763}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/be9e4bf1b538..8c79db8a0702 git log be9e4bf1b538..8c79db8a0702 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 miahsanchez@google.com device_unitest: the set up and tests for RunCommand 2019-08-02 achuith@chromium.org command_vm_test: Re-enable TestDeploy 2019-08-02 cjmcdonald@chromium.org Fix settings typo in vscode/settings.json 2019-08-02 omkarvijay@google.com Mark mistral important Created with: gclient setdep -r src/third_party/chromite@8c79db8a0702 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I71a1ee8b2185b5863739ab031a7b5bc8842e1b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733927Reviewed-by:
-
Yuly Novikov authored
TBR=kbr Bug: 948902 Change-Id: Ida8080795b334b59db61ff688aaae7d909d8a446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733463Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#683761}
-
David Benjamin authored
Rather than have SpdySessionPool and the socket pools listen to both SSLClientContext and the CertDatabase separately, lump them both under SSL-external notifications of SSL state changing. (Note ClientSocketPoolManagerImpl's SSLClientContext::Observer counterpart is TransportClientSocketPool. Also note this fixes an inconsistency between HTTP/1.1 and HTTP/2. HTTP/2 had a ERR_NETWORK_CHANGED vs ERR_CERT_DATABASE_CHANGED distinction while HTTP/1.1 did not. I've made them both match.) Change-Id: Ibde71856fc1d605757dbf869ce1eba482a6bbafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703232 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#683760}
-
Mustafa Emre Acer authored
Bug: 990428 Change-Id: I65f3b0b3c2b0f3ed71a5431257636a3bd6bcd735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733806Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#683759}
-
Joe Mason authored
Also take ownership of all SoftwareReporter.* histograms. Always use current joenotcharles@google.com email address. R=rkaplow@chromium.org Bug: 969962 Change-Id: I61bb0cf0972191ba461df9f9a701f84ae0774bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732890 Auto-Submit: Joe Mason <joenotcharles@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#683758}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1dc9ce56c488..93ee550c1fe8 git log 1dc9ce56c488..93ee550c1fe8 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 rmhasan@google.com Revert "Telemetry: add trace_processor_shell to binary dependencies" Created with: gclient setdep -r src/third_party/catapult@93ee550c1fe8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:944418 Change-Id: I4cdde616c3d1fc0ba94ab996e1158249aa9487ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733414Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ad77f55e0183..4c118cb3d371 git log ad77f55e0183..4c118cb3d371 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 hckim.kim@samsung.com Vulkan: Add support for OES_vertex_half_float 2019-08-02 timvp@google.com Vulkan: Implement framebuffers without attachments Created with: gclient setdep -r src/third_party/angle@4c118cb3d371 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I4b8fa77e01dd6c23428ed6c4d35743a3011cdd8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733413Reviewed-by:
-
Antonio Gomes authored
Apart from the fact that it is not being used anywhere, it is also an inconvenience, since this file is in the process of being migrated to Blink [1], where the header is banned. This CL cleans it up. [1] https://crrev.com/c/1731644 BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie8626c1d139733787b867293c46d768d1ea66eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731872 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Kyle Milka authored
If a user already has a custom background the refresh timestamp and collection id in the pref would be initialized causing a crash when we attempt to access them. Bug: 850317, 990265 Change-Id: Ic34e3a34516be41b96e279d3c135a4a1912a251a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731922 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#683754}
-
Chris Sharp authored
It appears that https://chromium-review.googlesource.com/c/chromium/src/+/1731947 caused some tests to just fail instead of crashing, which lead to failures on WebKit Linux Leak. The tests still seem to crash on the trybots though. Sample failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/2713 TBR=mstensho@chromium.org Change-Id: If27c2ac16c86df5d2ecd3682161ab1b9872bf934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732796 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683753}
-
smut authored
Changes to mb.py: 371e55885 Fix many misspellings 28bae5501 [vpython] Support vpython3 mode in vpython-native, include symlinks 4a77b0e65 [vpython] Support vpython3 mode Changes to run-swarmed.py: 371e55885 Fix many misspellings 28bae5501 [vpython] Support vpython3 mode in vpython-native, include symlinks 4a77b0e65 [vpython] Support vpython3 mode 3adcb7a14 [vpythonsmoketest] Add a simple smoke test Bug: 898348 Change-Id: Iff26b08ddfeeb7827d28b75f3e36c09b1a493295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730868Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#683752}
-
Gabriel Charette authored
This is a mechanical change and will be TBR'ed after base/OWNERS review per policy. TBR=kylechar@chromium.org Bug: 905412 Change-Id: I8003ea7c4137efdfa5390193d165f80f33f855b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732708 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=kbr@chromium.org Bug: 968047 Change-Id: I063d952e16d56b738ee19e8e773d74c1269c0bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729087 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Kenneth Russell <kbr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683750}
-
Matt Menke authored
It would trigger a preferences write on load error, to overwrite the bad preferences. However, if we don't overwrite bad prefs, we'll load them the same way we did before, so it doesn't seem like there's an actual problem here. It's not a huge amount of code to track when there's an error in loaded preferences, but it doesn't seem to get us anything, either. In some cases, some fields having errors cancels short-circuits reading other fields. That logic still happens, so the results of loading bad data should always be the same as before, we just no longer write repaired data until there have been meaningful changes to it. Bug: 984996 Change-Id: Ic035646d37f33cecdd267d2815c70ce804461e07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726956 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#683749}
-
Changwan Ryu authored
Bug: 990208 TBR=boliu@chromium.org Change-Id: If2222cf76edf31860fcc1f4271c2c85a082d1088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734006 Commit-Queue: Changwan Ryu <changwan@chromium.org> Auto-Submit: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#683748}
-
Robert Sesek authored
It was only needed for ChannelPosix because Mach ports could not be transferred with the message data. Now that ChannelMac exists, just TakeHandles() is needed. Bug: 973882 Change-Id: I83e754ea9877f4d355654ee069b5a6be0a14c1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733926Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#683747}
-
Eugene But authored
PassKit text is not rendered because of iOS 13 system bug. EG1 test can't test the text (only presentation) so it passes. EG2 is a better test and fails because of a real bug. Bug: 989816 Change-Id: I946b862daa244ab3b2ba4c795e6f7e433b254a04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733453 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#683746}
-
Chris Mumford authored
OnConnectionError should have been resetting both the data producer as well as the client. Bug: 958796 Change-Id: Ibc60dc05f7763e4ac61b43e445b5f2b40adc9246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733018Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#683745}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/17b9d1d1deaf..f8e5aadbd424 git log 17b9d1d1deaf..f8e5aadbd424 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 csmartdalton@google.com Remove 'dst' argument from GrOpList::copySurface 2019-08-02 michaelludwig@google.com Move SkImageFilter functionality into private SkImageFilter_Base 2019-08-02 mtklein@google.com no need to increment uniform pointers by zero 2019-08-02 robertphillips@google.com Revert "Increase specificity of GrColorType computed for YUV planes" 2019-08-02 mtklein@google.com select, {eq,lt,gt}_i32 on x86 Created with: gclient setdep -r src/third_party/skia@f8e5aadbd424 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: Ia8eb3ff0c2edd4eb12f5cb60da0a79ec02a4d849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733848Reviewed-by:
-
Matt Menke authored
After some of my refactors, if properties were learned before prefs had been loaded, they would only be saved in response to other property changes or on shutdown, which could hteoretically lead to never saving them on Android, where we never shutdown cleanly. Bug: 984996 Change-Id: Ica0ebaced0edcb8c2f83429a02000579317c2537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726761 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Ken Rockot authored
The heap profiling service only runs in-process and its lifetime is effectively managed by the heap_profiling::Supervisor singleton. This removes the Service Manager from between the Supervisor and the service implementation. ProfilingClient receivers are bound in child processes through |ChildProcess.mojom.BindReceiver()| instead of through a Connector to the child process's Service impl. The necessary logic already exists in child processes via ContentClient::BindChildProcessInterface(), so no changes are needed in child process code here. Some Service Manager dependencies remain only to acquire Resource Coordinator interfaces before injecting them into the heap profiling service implementation. These will be removed when Resource Coordinator is moved off of Service Manager. Bug: 977637 Change-Id: Ifb2c2cf404ac7e3db6a0e7b60fc99ed87dee097a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732696Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#683742}
-
Fabrice de Gans-Riberi authored
Change-Id: I172fb7f98693cd2b8e46b7510b9160b4e49cdae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733854 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#683741}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/029a36c7cbfc..060fcf777159 git log 029a36c7cbfc..060fcf777159 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 swiftshader.regress@gmail.com Regres: Update test lists @ f63c4e51 Created with: gclient setdep -r src/third_party/swiftshader@060fcf777159 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I1f7317a609dca70d1e5101de6958ae15e81aed8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733411Reviewed-by:
-
Mohammad Refaat authored
Sessions should be saved when there are no webStates at all, right now Chrome doesn't save the session if there is no active webState which include cases where there are no webStates at all. Bug: 989482 Change-Id: I96538dbf21be6d20730dd8800988379f0882c8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730166 Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#683739}
-
James Cook authored
Instead of the download icon, use a new icon with the outline of a folder. http://screen/e8nJioNs5bP Bug: 990063 Change-Id: I01d31aaed41ab433460fe389dadf2b5b58ea615d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731104 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#683738}
-
Annie Su authored
In the current version of AppMenu, the InMenuButtonBackground does not depend on the state of other views, so there is no need to invalidate all the other views (forcing a paint-all). When the comment justifying the SchedulePaintInRect() override was written, the MenuButtonBackground varied its painting depending on the state of other views, left_button_ and right_button_. Whenever the state of one of the other buttons changed, any other views using a MenuButtonBackground needed to paint too, which is why SchedulePaintInRect() very heavyhandedly forced a paint-all. Change-Id: Id3030139ca0cb31e34d610078cfdd13e94494ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733460Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Annie Su <anniesu@google.com> Cr-Commit-Position: refs/heads/master@{#683737}
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=kylechar@chromium.org Change-Id: Ib3a70b497ba1117d20f30399903e40ce204f996f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733534 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
Brandon Wylie authored
Bug: 988891 Change-Id: Ifcafee429c75da79a9f980b022a9524795922f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726954Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Mia Bergeron authored
The CrOS lock screen media controls can now be swiped up on to dismiss. If the controls are dragged past a certain height or are swiped with a large enough velocity, the controls will be animated off the screen and playback will stop. The opacity of the controls changes as they are dragged up and down. If the controls are not swiped high or fast enough, they will be animated back down to their initial position. See bug for video examples. Bug: 965575 Change-Id: I2bc264ec45c82772a17a926dfbe3e04ad59d01a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730132Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mia Bergeron <miaber@google.com> Cr-Commit-Position: refs/heads/master@{#683734}
-
