GitLab

This CL is a followup to:
https://chromium-review.googlesource.com/c/chromium/src/+/1865616

It should prevent renderer-initiated or browser startup focus events
from triggering on-focus suggestions in the omnibox.

Bug: 1013287, 996516
Change-Id: I5bb000a6ce37a2adbd9dec9b1ef2f3a78da1ac42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867307Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707443}

The fuzzer for HandleMessage discovered a heap buffer overflow.  This
is not super serious because an evil kernel is outside of our threat
model.

It turns out that the NLMSG macros in netlink.h and RTA macros in
rtnetlink.h assume a signed integer type. Because we used size_t, the
*_NEXT macros were actually underflowing the size, causing the *_OK
macros to erroneously return true.

In excruciating detail: consider a loop using the RTA macros and
|size_t length| to represent the number of bytes remaining in the
buffer. RTA_OK(rta, length) checks whether rta->rta_len <= length.
Then, RTA_NEXT(rta,length) subtracts RTA_ALIGN(rta->rta_len) from
|length|. Supposing rta->rta_len == 9 and |length| == 10, RTA_NEXT
will actually subtract *12* from |length|. Yikes!

Bug: 1015070
Change-Id: I687bba0b814d7e76082e9f53b12a1f90fb59180d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865671
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707442}

This patch means disable save button when 'card expired' error message
is seen in chrome://settings/payments.

Bug: 917812
Change-Id: Icc5d2b85160faddd050b405146acfa62d718d33d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832181
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707441}

ChromeEarlGreyAppInterface returns NSError*
to indicate test failure, not BOOL.

Bug: 1015549
Change-Id: I4d8478910c6914e94f07ea1ba0fa28ac7378ea2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866956
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707440}

While the Blink tests for the speech synthesis API that we wrote use
internals to mock the speech engine, the speech synthesis Web Platform Tests
do not, so they were exercising real platform speech APIs on some platforms.
Fix that by providing a testing implementation of TtsPlatform specifically
for web tests.

This change doesn't try to get any new WPTs to pass, it just hopefully
introduces some more stability and consistency.

Bug: 1003410
Change-Id: I45972c4717978a52427fce06bfe2e236b67cfab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821741
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707439}

http/tests/devtools/a11y-axe-core/performance/landing-page-a11y-test.js
is failing on WebKit Linux MSAN.
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN


TBR=juxiao@microsoft.com, yangguo@chromium.org

Bug: 1015859
Change-Id: I61ac9a670f1d403d334f2e27e0e995ad1644ec2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869033Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707438}

Fix password change events for sign-in non-syncing passwords.
Previously, we were double counting password-change events where
if the user first signs into an account, a password change event
would trigger. This checks to see if a password hash already
exists for the username first before triggering.

Bug: 1015515
Change-Id: Ic8027f7c68fe1803a295a730812569dc0d4faf2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866911Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707437}

This reverts commit 10cddf87.

Reason for revert: This original change is causing flaky failures locally on some device and might be causing flaky infra failures on CI bots. Will investigate locally and redo this change. See crbug/1013462 .

Original change's description:
> Change location of ensureAppLaunchedWithFeatures call for test case.
> 
> Moved ensureAppLaunchedWithFeatures from -setUp to overriding
> launchAppForTestMethod to eliminate unnecessary relaunches. CQ bot run
> results show significant improvement without the relaunches.
> 
> BUG: 1009017, 1010463
> 
> Change-Id: I650304daaa9e4271310e180635a8fb6ff865f717
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854786
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706521}

TBR=lindsayw@chromium.org,gambard@chromium.org,zhaoyangli@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I41e945fec5166c3d5cd487244775a40c4ec0ad4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868983Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#707436}

Bug: 1014122
Change-Id: I32dcb21d17d962c26ae02bd167330abc9fe39a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863839
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707435}

https://android.googlesource.com/platform/external/perfetto.git/+log/2e43102c54d1..b78fa92a5114

git log 2e43102c54d1..b78fa92a5114 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 lalitm@google.com trace_processor: fix starting on the correct bit for set bits iter
2019-10-18 lalitm@google.com Merge "trace_processor: use packet ts if power rail ts is empty"

Created with:
  gclient setdep -r src/third_party/perfetto@b78fa92a5114

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: chromium:135177627
Change-Id: I8ae77dab22fe869b36e5cf06554f875f84731315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868978Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707434}

Bug: 988753,988788,988800,988807
Change-Id: Ia07028ee94a734236463563070523e6f493be8d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845996Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707433}

This commit adds a call to ShouldSkipTest() to the early return in
the new GLCopyTextureCHROMIUMES3Test.BigTexture tests.

Bug: 991668
Change-Id: I898a3559cf6285055336d8ef6f77d8f3be25e5e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868835Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707432}

Rename the interface and remove the FrameImpl class and have
LocalFrame implement the mojo interface directly.

BUG=1008432

Change-Id: Id5e817ab6d2e266690cdd8687d9cad71662655ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863718Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707431}

In a few cases, the preferences for realtime reporting are enabled, but
client_ is still null. For example, if the SafeBrowsingRealtimeReporting
feature is disabled. This can lead to crashes when trying to report events.

Bug: 1015849
Change-Id: I4ee0a042da4379ab4878c34ec8d726a3661c0aec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869292Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707430}

In order to ensure homogeneous fleets, we need to have more specific
dimension values when looking for bots. This set of CLs updated some
existing dimensions, and added the synthetic_product_name values for
dimensions if appropriate.

This CL updated the dimensions for mac-10_13_laptop_high_end-perf:
 - Added synthetic product name 'MacBookPro11,5_x86-64-i7-4870HQ_AMD Radeon R8 M370X 4.0.20 [3.2.8]_Intel Haswell Iris Pro Graphics 5200 4.0.20 [3.2.8]_16384_1_475936.0';
 - Updated OS from 'Mac-10.13' to 'Mac-10.13.3'
 - Updated GPU from '1002:6821' to '1002:6821-4.0.20-3.2.8' (This shows
   a equivalent list as using '8086:0d26-4.0.20-3.2.8'. Those bots seem
   having two graphic cards. E.g., https://chrome-swarming.appspot.com/bot?id=build139-a7)

Please check the link below for the available bots based on the
old/new dimensions:
https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=gpu%3A1002%3A6821&f=os%3AMac-10.13&f=cpu%3Ax86-64&f=pool%3Achrome.tests.perf&s=gpu

Bug: chromium:996830
Change-Id: Ia88a6af8f543f90cf28528ad293f0d0479f6e8b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865141
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707429}

Change-Id: I0611b41a7f428204c9bf92b7a0438271edc7846a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864408
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707428}

* Skip the scheme redirect check for rewritten data URLs.
* Do not append query and ref to rewritten data URLs.

Bug: 1014237

Change-Id: Ied4b9495031c2f86c196b036aeeb6d599cd98560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846811Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707427}

Overview items now match the aspect ratio of the window bounds if they
get snapped. This will happen if splitview is active on either side, or
if the window is getting dragged close enough to an edge. A videos of
before and after this patch is in the bug.

Follow up:
Make this work for tablet mode with 6 or more windows. In that case
the positioning logic follows a different path.
Match the exact dimensions in the spec, this patch only does rough
clipping.

Test: added tests, manual
Bug: 1011973
Change-Id: I3d9d341c54b58d0e86440045ad1408ca3a0fd27d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849175
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707426}

With Translate moving to Messages, it will have a similarly named
TranslateInfobarCoordinator that will replace TranslateInfobarController.
Move the current TranslateInfobarCoordinator to LegacyTranslateInforbarCoordinator
since it won't be used in the new Messages logic.

Bug: 1014959
Change-Id: I6d5fb835cd0c826db1ffa7bac9fd48338c6ec894
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864399Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707425}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b582d244f316..68efdcdaefe2

git log b582d244f316..68efdcdaefe2 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 jrosenth@chromium.org lib/cros_build_lib: don't try and encode bytes
2019-10-18 jrosenth@chromium.org lib/gob_util: return bytes from FetchUrl

Created with:
  gclient setdep -r src/third_party/chromite@68efdcdaefe2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ie2db7dd31dfe6a9994aa12b05c6e4cb4f39337d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869114Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707424}

Right now, the feedback doesn't have any label at all and is read as
"image" by ChromeVox.

BUG=chromium:1005521
TEST=Loaded onto an eve with chromevox, observed correct description.

Change-Id: Idfd8f2946dbfaf3929b095bbc914a4954afcf6dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864093
Commit-Queue: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: J Kardatzke <jkardatzke@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Jeffrey Kardatzke <jkardatzke@google.com>
Auto-Submit: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707423}

This command will be used by developers to debug their CL quickly. It
allows them to specify only certain test suites to run.

Bug: 1015682
Change-Id: I22e30c1cc29e31d4e484808d5a8302813cc4a386
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856822Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707422}

This CL implements the feature that the scrollable shelf is able to
show a new page when an app icon is dragged to the shelf's edge
and stays for enough time. It will not change any behavior if the
scrollable shelf is disabled.

Bug: 1009500
Change-Id: I0bc7cb187031f77a4d332f06744d313a335b2508
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859588
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707421}

https://webrtc.googlesource.com/src.git/+log/55d19e590d9a..3f7e0ede1e71

git log 55d19e590d9a..3f7e0ede1e71 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 asapersson@webrtc.org Add option to make first scale factor depend on input resolution.
2019-10-18 nisse@webrtc.org Reland "Delete methods EncodedImage::Allocate and EncodedImageBufferInterface::Realloc"

Created with:
  gclient setdep -r src/third_party/webrtc@3f7e0ede1e71

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:none
Change-Id: I91f4dad7c97d2521df63fbf74dc486bbe8753842
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869113Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707420}

BUG=1015204

Change-Id: Id63ee4da3c8e51db06da0a306e90adeef7f5618a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866972Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707419}

2fb4e9e6a432 mac: Update the process_types version of
             dyld_all_image_infos for 10.15
c009b85449cb Use GTEST_SKIP() instead of custom DISABLED_TEST()
d8f85829b07b linux: fix split stack test
7289acb78a6d linux: don't assume vdso exists
47a342133d60 linux: use boringssl in chromium
661a07a41b88 linux: add deps for boringssl in chromium

Change-Id: Iae1ed525a228c4de3b879ac06097fd026ea01004
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869397Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707418}

Bug: 1014652
Change-Id: Ic902b03346ba9eb96fd77e0f449dfd951036bae2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866980
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707417}

Instead, use ArcSessionImpl's delegate.

BUG=b:142144019
TEST=ran the unit tests

Change-Id: I982d34ba82e93a31ea1e158a5d170e86eaf27a05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864326Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707416}

Any AccessibilityNodeInfo can include extra information in a Bundle of
key/value pairs. Some external developers requested that we expose the
target url for a link or image, so we can just include it in the bundle
of extras without needing a formal API for it.

Bug: 961865
Change-Id: I0edb75bc8320a5ee3bf166072a0a061e46786600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862862
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707415}

pointerevent_coalesced_events_attributes.html is flaky on Mac10.13
Tests (dbg).

https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29

TBR=nzolghadr@chromium.org

Bug: 1015254
Change-Id: Idd8a879393d643d5ea74e93666823acc20be52f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867183Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707414}

Add static thread-safety checks to DiscardableSharedMemoryManager to
ensure lock is acquired before using fields which require
synchronization.

Change-Id: I063676b6d4a03b96c24dde6b509cb368f1f7010e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862861Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Gordon Guan <gordonguan@google.com>
Cr-Commit-Position: refs/heads/master@{#707413}

Copies logic from GLRenderer with InProcCommandBuffer:
https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?rcl=04fbda1c2420a137a9f85889084a166f8a66b5d9&l=5866

Bug: 1012472
Change-Id: Iaca1be33e548c8987a06729a3571dbb2aed9c04d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867191Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707412}

R=skyostil@chromium.org,ahemery@chromium.org

Change-Id: I9b4b874f8de4800dbf5d1e9b50c6c94e86be44e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868959
Commit-Queue: Alexander Timin <altimin@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707411}

Deprecate the following policies, because the redundancy with PowerManagementIdleSettings and ScreenLockDelays is distracting and misleading.
- ScreenDimDelayAC
- ScreenDimDelayBattery
- ScreenOffDelayAC
- ScreenOffDelayBattery
- ScreenLockDelayAC
- ScreenLockDelayBattery
- IdleWarningDelayAC
- IdleWarningDelayBattery
- IdleDelayAC
- IdleDelayBattery
- IdleActionAC
- IdleActionBattery
- IdleAction

Bug: 346229
Change-Id: Ib50ad8c0c6b723c15b684b8af4b70758210922eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839957Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Cr-Commit-Position: refs/heads/master@{#707410}

Creates elements for constructors.
Our new compiler supports constructors in the new style as
interface members, and do not support extended attributes'
style.


Bug: 839389
Change-Id: I42ec9acda2c41baf3dadb18e2221364279b633dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847598Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707409}

ArticleEntry used to be an alias for sync_pb::ArticleSpecifics. However,
the Sync data type for articles doesn't exist anymore, and we'd like to
delete the protos. So this CL replaces the alias with a simple struct.
This lets us remove all build dependencies from dom_distiller to sync.

Bug: 1007942
Change-Id: Ia9eb2cb3256a540ab3b2f63e8ae621f92121ed1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869223
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707408}

Updates to use the new backwards-compatible header and modifies some
calls that have changed syntax in EG2.  With this CL, the tests
themselves remain running as EG1 tests.

BUG=987646

Change-Id: I9957c69cfa042224b55015d93236a133f2e7c9e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869470Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707407}

Bug: 995256
Change-Id: I1b4c1941df162a1946b1e63204be98ea679821aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869509Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707406}

This CL fixes WebappSplashScreenTest on Android L that the original CL
(https://chromium-review.googlesource.com/c/chromium/src/+/1857205)
missed

This CL matches the status bar behaviour of WebAPKs to that of TWAs by:
- Changing the status bar colour used by WebAPKs when the Web Manifest
  does not provide a "theme_color" to white. This requires increasing
  MINIMUM_REQUIRED_CHROMIUM_VERSION_NEW_SPLASH
- Making the status bar use dark icons if the Web Manifest provides
a light colour.

BUG=997793

Change-Id: Ib8fc5ac61536fd8dd4c4c309ce35027a8fc0c872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867306
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707405}

This reverts commit e41bbad7.

Reason for revert: Breaks dragging to/from overflow bubble.
There was a test for that, but it was skipped due to kShelfScrollable
enabled by default.

Original change's description:
> Fix double app icon when dragging app to shelf
>
> When an app is being dragged from app list to shelf,
> a new shelf item is created and made hidden by setting
> its size to (0,0). It is supposed to stay at this size
> until the drag is complete.
>
> However, if a drag started very soon after some other shelf
> manipulation (e.g. drag leaving the shelf and re-entering quickly),
> it is possible for AnimateToIdealBounds to be called asynchronously.
> The hidden item's bounds will be animated to full size, resulting
> in a visible icon.
>
> This CL makes AnimateToIdealBounds ignore shelf items with (0,0) size.
>
> Bug: 985631
> Test: manual
> Change-Id: Ieb23beb6ecf635ae60613f5f6217219f7963999b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862507
> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
> Reviewed-by: Manu Cornet <manucornet@chromium.org>
> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706148}

TBR=kaznacheev@chromium.org,manucornet@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 985631, 1015688
Change-Id: Idbf8910c6d495a59b398592919a7e2ebb21823e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868976Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707404}