GitLab

BUG=641413

Review-Url: https://codereview.chromium.org/2367543002
Cr-Commit-Position: refs/heads/master@{#420623}

Because Chooser tests interact with the UI they should be marked as
@LargeTests

> As a rule of thumb most functional UI tests are large tests.

https://developer.android.com/reference/android/support/test/filters/LargeTest.html

Also remove the flaky and disabled annotations.

BUG=646097,629579

Review-Url: https://codereview.chromium.org/2354183002
Cr-Commit-Position: refs/heads/master@{#420622}

BUG=501432
R=csharrison@chromium.org

Review-Url: https://codereview.chromium.org/2363743005
Cr-Commit-Position: refs/heads/master@{#420621}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/547cdab7f263971624422ea5b8ac665981c26514 Add Windows 10 location for debugger in process_dumps.py (pschmidt@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=649291

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2366883003
Cr-Commit-Position: refs/heads/master@{#420620}

Updated several Handler instances to use static inner classes with
WeakReferences to the outer class to avoid memory leaks. Created
TidyHandler to make this cleaner.

BUG=635567

Review-Url: https://codereview.chromium.org/2327833002
Cr-Commit-Position: refs/heads/master@{#420619}

https://pdfium.googlesource.com/pdfium.git/+log/917d24852841..3f4111fbff12

$ git log 917d24852..3f4111fbf --date=short --no-merges --format='%ad %ae %s'
2016-09-23 tsepez Make CPDF_Font::Create() return a std::unique_ptr.

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2361423002
Cr-Commit-Position: refs/heads/master@{#420618}

BUG=646384

Review-Url: https://codereview.chromium.org/2361643004
Cr-Commit-Position: refs/heads/master@{#420617}

Reland of HTMLImageElement: do not use fallback content for ImageDocument (patchset #1 id:1 of https://codereview.chromium.org/2365523003/ )

Reason for revert:
As per comment #8, this CL wasn't the cause of bot failures.
https://codereview.chromium.org/2365523003/#msg8

Original issue's description:
> Revert of HTMLImageElement: do not use fallback content for ImageDocument (patchset #2 id:20001 of https://codereview.chromium.org/2343613002/ )
>
> Reason for revert:
> Speculatively reverting to fix broken layout tests on Windows (https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10, https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7)
>
> Tests are
>
> fast/backgrounds/border-radius-split-background-image.html
> fast/backgrounds/border-radius-split-background.html
> fast/borders/border-styles-split.html
> paint/invalidation/background-resize-height.html
>
> Original issue's description:
> > HTMLImageElement: do not use fallback content for ImageDocument
> >
> > After https://codereview.chromium.org/1879793003,
> > ImageLoader::hasPendingActivity() became false for ImageDocument and thus
> > HTMLImageElement::selectSourceURL() didn't consider the image as still loading
> > during load (|imageStillLoading| became false).
> > This caused ImageDocument not to be displayed progressively.
> >
> > This CL makes HTMLImageElement to use primary content for ImageDocument.
> > This causes ImageDocument not to be replaced with fallback content, but I
> > expect that is more acceptable than images not displayed progressively.
> >
> > BUG=632495
> >
> > Committed: https://crrev.com/c5e43f7edf4e55155fcda51be0285f37b20c2e76
> > Cr-Commit-Position: refs/heads/master@{#420432}
>
> TBR=yhirano@chromium.org,japhet@chromium.org,ellyjones@chromium.org,hiroshige@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=632495
>
> Committed: https://crrev.com/70e44d10fc52150a6af5a7de760cb9181587fbb4
> Cr-Commit-Position: refs/heads/master@{#420499}

TBR=yhirano@chromium.org,japhet@chromium.org,ellyjones@chromium.org,gcasto@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=632495

Review-Url: https://codereview.chromium.org/2364073002
Cr-Commit-Position: refs/heads/master@{#420616}

BUG=

Review URL: https://codereview.chromium.org/2365693003 .

Cr-Commit-Position: refs/heads/master@{#420615}

(Primarily) because of their inclusion in the SVGTests interface, these
two make their way into a lot more compilation units than has use for
them. The principal access to this data is the SVGTests::isValid()
method, so only the actual bindings should need any deeper insight into
these. Shuffle declarations and definitions to make their inclusion more
scarce. (From ~194 -> ~13 total dependencies for the latter, based on
"ninja -t deps".)

Review-Url: https://codereview.chromium.org/2360383003
Cr-Commit-Position: refs/heads/master@{#420614}

BUG=600717

Review-Url: https://codereview.chromium.org/2362113002
Cr-Commit-Position: refs/heads/master@{#420613}

BUG=541543

Review-Url: https://codereview.chromium.org/2364733004
Cr-Commit-Position: refs/heads/master@{#420612}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/7e4eda9791069bd4c447040611fa0554869e804c V8: Archive builds of node integration bot. (machenbach@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=v8:5378

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2364783003
Cr-Commit-Position: refs/heads/master@{#420611}

BUG=649633
TBR=grunell@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2353393005
Cr-Commit-Position: refs/heads/master@{#420610}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/1fb4c10e66e8a0c4c445e2a28a5bd66752a4634c Split dart2js test steps into observatory, co19, and others. (whesse@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=https://github.com/dart-lang/sdk/issues/27412

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2361853004
Cr-Commit-Position: refs/heads/master@{#420609}

Reland of Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called (patchset #1 id:1 of https://codereview.chromium.org/2365463004/ )

Reason for revert:
Relanding this CL because the fix to the original crash has been landed in https://codereview.chromium.org/2364693005/

Original issue's description:
> Revert of Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called (patchset #11 id:200001 of https://codereview.chromium.org/2317483005/ )
>
> Reason for revert:
> Speculatively reverting for https://crbug.com/649272
>
> Original issue's description:
> > Clear LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called
> >
> > This CL clears LifecycleObserver::m_context when LifecycleObserver::contextDestroyed gets called.
> > This means that LifecycleObserver::context() starts returning false after the context gets destroyed.
> >
> > The new behavior makes a lot of more sense, but the problem is that some existing code is assuming that
> > LifecycleObserver::context() keeps returning the context even after the context gets destroyed.
> > This CL fixed the problematic code to make all layout tests pass, but I'm not sure if I've updated all of the problematic code
> > (because the coverage of the layout tests is not sufficient).
> > However, the worst thing that can happen is that code that had been assuming that LifecycleObserver::context()
> > returns a context even after the context gets destroyed will stop working (it may cause a null-deref crash).
> > I think the risk is low.
> >
> > BUG=610176
> >
> > Committed: https://crrev.com/b729a998b05ec916731171d59de95e0aea31bbac
> > Cr-Commit-Position: refs/heads/master@{#419951}
>
> TBR=haraken@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=610176,649272
> NOTRY=true
>
> Committed: https://crrev.com/04b1826356a37de2a322e7e6e0e80f07d05f210f
> Cr-Commit-Position: refs/heads/master@{#420498}

TBR=wfh@chromium.org,dcheng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610176,649272

Review-Url: https://codereview.chromium.org/2367753002
Cr-Commit-Position: refs/heads/master@{#420608}

Revert of Roll Syzygy DEPS to v0.8.21.0 (patchset #1 id:1 of https://codereview.chromium.org/2364613002/ )

Reason for revert:
Break the official builders.

BUG=644608

Original issue's description:
> Roll Syzygy DEPS to v0.8.21.0
>
> Committed: https://crrev.com/b7f4d860d580c5b0c2981356b181859d219bbe0d
> Cr-Commit-Position: refs/heads/master@{#420491}

TBR=siggi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2369483002
Cr-Commit-Position: refs/heads/master@{#420607}

I never quite found what the original issues were, but apparently they've been fixed in the mean time.

Revert "Disable faiilng tests under mac/asan"
This reverts commit 6585cde1.

BUG=

Review-Url: https://codereview.chromium.org/2364593002
Cr-Commit-Position: refs/heads/master@{#420606}

Ensure the GAIA Id is attached for Drive domains even when the path
isn't empty.
Follow-up of http://crrev.com/2343073002.

BUG=647260

Review-Url: https://codereview.chromium.org/2353923003
Cr-Commit-Position: refs/heads/master@{#420605}

If BaseTextInputType::patternMismatch() was called twice, the second call
skipped ScriptRegexp::isValid() check.

BUG=639324

Review-Url: https://codereview.chromium.org/2366803002
Cr-Commit-Position: refs/heads/master@{#420604}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3721449f..8358e322

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2364823002
Cr-Commit-Position: refs/heads/master@{#420603}

This patch also removes the Editor::firstRectForRange(const Range*)
overload because it has no call site.

BUG=647219

Review-Url: https://codereview.chromium.org/2352763004
Cr-Commit-Position: refs/heads/master@{#420602}

The introduced 'emplaceAppend()' method provides more efficient code path when a new object instance requiring multiple constructor arguments is appended to a vector.

Note: the existing 'append()' method is already implicitly emplacing new items for a single constructor argument case.
Review-Url: https://codereview.chromium.org/2365533003
Cr-Commit-Position: refs/heads/master@{#420601}

This CL invalidates the serialized page state any chrome:// URLs,
causing the page to get reloaded rather than restored. This will prevent
the upgrade to MD History from breaking things since it lives at a
different physical URL than classic history.

BUG=614758
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2355543003
Cr-Commit-Position: refs/heads/master@{#420600}

The CacheCounter class in chrome/browser/browsing_data could not be
componentized (unlike other counters in components/browsing_data) because
of its usage of StoragePartitionHttpCacheDataRemover that has a dependency
on content/.

This CL implements a separate CacheCounter class for iOS with the same
functionality. The core of the implementation, a series of IO thread
callbacks, is delegated to the private IOThreadCacheCounter class that
mimics StoragePartitionHttpCacheDataRemover.

BUG=620317

Review-Url: https://codereview.chromium.org/2354643002
Cr-Commit-Position: refs/heads/master@{#420599}

This CL is connected to Issue 2312093003, which generates bindings for
IDL callback functions. This CL exteneded implementation to be able to
use not only string or long but also interface as arguments of callback
functions.

BUG=569301

Review-Url: https://codereview.chromium.org/2367543004
Cr-Commit-Position: refs/heads/master@{#420598}

No change in behavior.

BUG=631960
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2352563002
Cr-Commit-Position: refs/heads/master@{#420597}

We report deprecation warnings when the old
motion* property names are used.

Discussed in the offset-path Intent To Ship,
https://groups.google.com/a/chromium.org/d/msg/blink-dev/o1C5NzGf9Q0/sbaLF1MbAgAJ

BUG=637543

Review-Url: https://codereview.chromium.org/2366493002
Cr-Commit-Position: refs/heads/master@{#420596}

Layout inflation on the UI thread triggers StrictMode violations on some
devices. Temporarily allow disk reads, as the inflation should happen on
the UI thread, and the reads are inside the framework's code.

BUG=644243

Review-Url: https://codereview.chromium.org/2355263002
Cr-Commit-Position: refs/heads/master@{#420595}

Review-Url: https://codereview.chromium.org/2358303003
Cr-Commit-Position: refs/heads/master@{#420594}

This is part 1 of removing non-material top chrome support.

BUG=649368

Review-Url: https://codereview.chromium.org/2361153002
Cr-Commit-Position: refs/heads/master@{#420593}

This CL unifies worker thread shutdown sequences to fix a crash and simplify
shutdown.

<Problem>

When termination is requested on the main thread before WorkerThread is
initialized on the worker thread, shutdown sequence runs in a different way from
regular shutdown sequence: initialization sequence seamlessly switches to
shutdown sequence and asks the main thread to destroy WorkerThread
(see WorkerThread::initializeOnWorkerThread).

This causes a crash in a following scenario:

  1) Request to start the worker thread from the main thread.
  2) Post a task to the worker thread from the main thread.
  3) Request to terminate the worker thread from the main thread.
  4) Start initialziation sequence and switch to shutdown sequence on the worker
     thread.
  5) WorkerThread is destroyed on the main thread.
  6) The posted task runs on the worker thread and crashes.

<Solution>

This CL makes the initialization sequence complete regardless of termination
request and defer to the regular shutdown task posted from the main thread.
Other tasks also posted from the main thread(*) are guaranteed to be drained
until the shutdown task runs.

<Appendix>

Regarding (*), you might wonder if tasks posted from/to the worker thread cannot
be guaranteed to be drained until the shutdown tasks run. This case is covered
by other mechanism. Let's consider it in following 2 cases:

  1) An uninitialized worker thread does not post a task to itself, so there
     should be no tasks when termination happens before initialization.
  2) Otherwise, WorkerBackingThread::shutdown drains all tasks.

Therefore, we can ensure that tasks posted from the worker thread also never run
after shutdown.

BUG=632810, 640843

Review-Url: https://codereview.chromium.org/2280523002
Cr-Commit-Position: refs/heads/master@{#420592}

FontFaceSet::document() gets Document from getExecutionContext(),
so the returned value should be checked after r419951.

BUG=610176,649272
NOTRY=true

Review-Url: https://codereview.chromium.org/2364693005
Cr-Commit-Position: refs/heads/master@{#420591}

app-route is a fairly heavy-weight element, supporting complex routing
patterns designed for large pages. This is unnecessary for MD History,
which currently has one routing pattern and one query parameter.

This CL replaces app-route with a custom router, <history-router>, which
is responsible for two-way binding between the page state and the page
URL. This also refactors handling of search terms elsewhere in the app
to ensure that changes to the search term are reflected correctly across
the page.

This CL has a small positive impact on load time (~20ms on a Z620), code
health (all routing is handled in one place) and binary size (app-route
can be deleted from the binary).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2352293002
Cr-Commit-Position: refs/heads/master@{#420590}

BUG=614320

Review-Url: https://codereview.chromium.org/2360723002
Cr-Commit-Position: refs/heads/master@{#420589}

Bluetooth needs to use document->frame() in ContextLifecycleObesrver::contextDestroyed().
Hence this CL moves m_frame=nullptr to after dispatching contextDestroyed().

See https://groups.google.com/a/chromium.org/d/topic/blink-dev/sfpRQc4LB_I/discussion for more motivation of this CL.

BUG=610176

Review-Url: https://codereview.chromium.org/2362173002
Cr-Commit-Position: refs/heads/master@{#420588}

BUG=624095

Review-Url: https://codereview.chromium.org/2353333005
Cr-Commit-Position: refs/heads/master@{#420587}

We applied OPTION's style incorrectly.

BUG=649320

Review-Url: https://codereview.chromium.org/2361113003
Cr-Commit-Position: refs/heads/master@{#420586}

This CL make sure the downloads of the entries start with the delay associated
with the entry and retry to download them if the failure is recoverable.

BUG=629771

Review-Url: https://codereview.chromium.org/2351113003
Cr-Commit-Position: refs/heads/master@{#420585}

The original DCHECK was asserting on float equality. This was too strict
and was firing for small negligible differences. This change flattens
specified Lengths into a single float and compares them with a constant
slack allowance.

This check is intended to pick up on differences like -5 vs 0 due to
different clamping behaviour, small differences in floating point
arithmetic is fine.

BUG=649525

Review-Url: https://codereview.chromium.org/2366823003
Cr-Commit-Position: refs/heads/master@{#420584}