- 09 Oct, 2020 40 commits
-
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I3af15a8ff257a242396a8cc58ba8c0b1df74c934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459387Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815677}
-
Alice Wang authored
This CL dismisses the account picker bottom sheet when the bottom sheet controller is null. Bug: 1136799 Change-Id: I9814c10f6becb07c3e95ab93f0d81b69af936853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463307 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#815676}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09f602317f2b..b3c2e9be46bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC flackr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1114729 Tbr: flackr@google.com Change-Id: Ic51bdf7fffe793afd40e6d26f30755c04c95dd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463258Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815675}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/58919b4db13b..723d5437e6a0 2020-10-09 bmeurer@chromium.org Improve scope information for language plugins. 2020-10-09 alexrudenko@chromium.org Enable TypeScript for LocationsSettingsTab.js 2020-10-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-09 aerotwist@chromium.org TypeScriptify RadioSetting.js 2020-10-09 sigurds@chromium.org Prepare console/ConsoleView.js for TypeScript.. 2020-10-09 sigurds@chromium.org [ts] Type-check console/ConsoleViewport.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1135143,chromium:1136484 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4781d7efd5f74fef565ef0b58508c2a0283fb5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463390Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815674}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I6c89922f34472a5e06fb88b68ecbf5996de37c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459051Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815673}
-
Regan Hsu authored
The NotoficationAccessSetupOperation::Status enums were out of sync by 1, because the multidevice_notification_access_setup_dialog.js enums include a NOT_STARTED state to accommodate the initial dialog state. This CL fixes that. Bug: 1106937 Change-Id: I3d27cac52adb20cd5775a238355f2aaa9aae722c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462608Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815672}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I63ccd3a15d31ab2633b874193fe26c24628bff81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460891Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815671}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602212356-910f3b9c14ad8fb9eb002bc49aff02d2bc68cf6f.profdata to chrome-win64-master-1602244639-9ed9777b412f549b6770ee430e4768c83e1e2c1e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Icf450c9bdc47183118a87513368db4a54c93327e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462504Reviewed-by:
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I4f96c26c813abcb8e6825c0dfe2b1d4fa3f2653a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463227Reviewed-by:
-
Ian Kilpatrick authored
This patch uses WritingModeDirection for: - NGBoxStrut::ConvertToPhysical - NGPhysicalBoxStrut::ConvertToLogical - NGFragment - NGBoxFragment There should be no behaviour change. Bug: 1091797 Change-Id: I5b6a99f12707c7b92d5e7fc4f1dc4c977ee68007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456849 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815668}
-
Justin Cohen authored
Preload appears to trigger an edge-case crash in WebKit when a restore is triggered and cancelled before it can complete. This isn't specific to preload, but is very easy to trigger in preload. As a speculative fix, if a preload is in restore, don't destroy it until after restore is complete. This logic should really belong in WebState itself, so any attempt to destroy a WebState during restore will trigger this logic. Even better, this edge case crash should be fixed in WebKit: https://bugs.webkit.org/show_bug.cgi?id=217440. The crash in WebKit appears to be related to IPC throttling. Session restore can create a large number of IPC calls, which can then be throttled. It seems if the WKWebView is destroyed with this backlog of IPC calls, sometimes WebKit crashes. See crbug.com/1032928 for an explanation for how to trigger this crash. Note the timer should only be called if for some reason session restoration fails to complete -- thus preventing a WebState leak. Bug: 1032928 Change-Id: I217918437d5cdc6f610f3331634791699dd678ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461571Reviewed-by:Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#815667}
-
Mike Jackson authored
DesktopPWAsWithoutExtensions has shipped. Cleaning up the code to remove the variation to support Bookmark apps Bug: 1065748 Change-Id: Ifd9c276bf2466b02de4eac3e8ffadfae33b1c995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462343 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#815666}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I9ba052ae97bfc618224f84271de28f8f4c81443c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459269Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815665}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ia6b83a737c7507b1ff260f7ef76ebc426c35b7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462643Reviewed-by:
-
Ken Rockot authored
This allows interfaces to be tagged with a UUID within mojom files. The UUID is propagated to a base::Token constant nested within the generated interface class for C++ bindings. This allows consumers to establish stable runtime identifiers for interfaces that can persist independently from other interface details, including the superficial name of the definition. Bug: 1136652 Change-Id: Ib69bc116015606e029a02a663a578e08b0755e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462378Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#815663}
-
Zentaro Kavanagh authored
- Currently empty element - Will later add the test section of a diagnostics card such as button to run tests and a routine-result-list to show results. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I64597f5f89c478f74a7900d46b415948d3c1d27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461636 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#815662}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/7c2e104ffbe4..a84f9718f35f $ git log 7c2e104ff..a84f9718f --date=short --no-merges --format='%ad %ae %s' 2020-10-09 junyer Ensure that RE2::Arg works even with overloaded ParseFrom(). Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org Change-Id: I6dc8022ea1f2d99535f9938f7a1027171cd3eb11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461698 Commit-Queue: Paul Wankadia <junyer@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#815661}
-
David Bokan authored
UMA isn't enabled on most devices that use spatial navigation and no one is actively looking at this so let it expire in M85. Bug: 1088658 Change-Id: I4aa10d3fd2cb1d9b6dc6d7318c3a1bbfe605bd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443498Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#815660}
-
Ella Ge authored
The crash report shows the IllegalArgumentException is because of package name is null. Add a null check before getting the installer package name. Bug: 1136018 Change-Id: I90f38bfcf67cf5de41996b3bf463633e2db2bca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457369 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#815659}
-
Clark DuVall authored
There are various bugs with resources in isolated splits including: - RemoteViews can't access them - Splash screens for activities with themes defined in the isolated split fail - Bugs like crbug.com/1133898 (not strictly isolated split related though, but this fixes it for the chrome split) - Possibly more... For now I think it makes sense to move all resources to the base module to avoid these and any not yet uncovered bugs. Later we can see if it makes sense to move these back into the chrome split. Bug: 1126301 Change-Id: Id4b3d20b8d88dcea9b7ba2d090c07714324cee1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463642Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815658}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010090700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/TGyqQ0i-VwfJWUWkmWGzsrQ0c-MmVg_nP2-LKMWnCQYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ib0de79c4a78956cad601d2a029a7916e8389d53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463388Reviewed-by:
-
Benjamin Beaudry authored
This change makes the AXPlatformNodeTextRangeProviderWin endpoints helper class a tree observer, allowing it to keep its stored |start_| and |end_| position valid. By observing the trees that the |start_| and |end_| position are in, the AXPlatformNodeTextRangeProviderWin::TextRangeEndpoints can adjust its endpoints if the node they are on is deleted. When this is the case, the position is then moved to the parent node. Known issue: In some cases, a node can get deleted alongside its parent. When this is the case, moving the position to its parent wouldn't solve the issue of the invalid position as the parent, itself deleted, wouldn't be a valid anchor. I have not observed this issue in practice, but I think it could be a good idea to keep that in mind. Change-Id: Ib0fd7bef9040b8744a0b1e0d7ea2d6b58c7477d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432805 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815656}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c251d370b65e..0ad07c924552 2020-10-09 treehugger-gerrit@google.com Merge "Fix slice combining in RAIL mode metric" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic9e4158db4d225c0f02a20fb36951572df98a271 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463387Reviewed-by:
-
Haiyang Pan authored
It has been running at 100% since crrev.com/c/2446513 and so far works fine. The test pool http://shortn/_382OI523IF and host pool http://shortn/_ro7oQn8de4 both looks healthy. Bug: 1111436 Change-Id: If373ba784928488f2c4a4c0e089ae42f212f2e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461599Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#815654}
-
Scott Violet authored
The specific case this exercises is the overflow:visible axis. I couldn't find any wpt tests for this, and it seems worth adding. BUG=1087667 TEST=wpt/css/css-overflow/overflow-clip-hit-testing.html Change-Id: Iafe042a02737f69f47750900fe7027e711d96004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458726Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#815653}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010090700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/P-2JwDZls8V1LNOlmHoxgPlVs68icpTYuJyIwCQQ-okC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Iaa49700f25310cfcd8ead0b15ada91c5b38dbc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463522Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2bf76269e147..c251d370b65e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I14a699ee2568d519969e8d52d0b52754c6ade947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461917Reviewed-by:
-
Becca Hughes authored
Change-Id: I362f36de0759cb75892a102c3658885b3dd9b7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410738Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#815650}
-
Clark DuVall authored
We are investigated using isolated splits for Chrome, and splitting //chrome code into a DFM. Due to b/169196314, all service classes must be present in the base module. See go/isolated-splits-clank for more details. This change creates a new minimal target for PaymentDetailsUpdateService which the base module will depend on. Bug: 1126301 Change-Id: Ib4396073bbc4254c0400bccec1f4acac3ba88ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459508Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#815649}
-
Dirk Pranke authored
This converts the two test suites from 'script' tests to 'generated_script' tests, pushing more of the command line logic into GN targets (and the generated wrapper scripts). Bug: 816629 Change-Id: I0ebca0c54d61c6c60734147ebfef1673bd262ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462623Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
-
Sahir Vellani authored
New feature (off-by-default) will enable smoothness mode for wheel scrolling. This will allow us to experiment and measure the impact on user scrolling. Instead of only considering precise scrolls as 'actively scrolling' we will consider all scroll updates for which delta was consumed on the compositor. Bug: 1056460 Change-Id: I21ccfdb3c4e67e7738ec568f48d750e950d5f43f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443550 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815647}
-
Wenbin Zhang authored
crrev/c/2459799 added [Skip] tag for the stories: animometer_webgl_indexed, animometer_webgl_indexed_multi_draw_base_vertex_base_instance, animometer_webgl_indexed_multi_draw Though, even if they're skipped, the current logic still checks their achieve status. This CL will set those stories as DESKTOP_ONLY. Synced with Shrek and these stories will not be ready for mobile for now. Expectation file needs to be update to pass the PRESUBMIT, which complains that the tag on expecation does not apply to those stories. Will be another CL to update the logic to skip the achieve checking logic. Bug: chromium:1136227 Change-Id: I52f4b10b6c3399634611cb69d7b33f66c843ae52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462226 Auto-Submit: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#815646}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/aa8c4617869e..658ae8fc6aba 2020-10-09 johnstiles@google.com Reland "Put top level FPs into their own functions" 2020-10-09 ethannicholas@google.com refactored more SkSL IRNodes 2020-10-09 egdaniel@google.com Reland "Rename GrStencilAttachment class to generic GrAttachment" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I1879227438e14b155bb10b8fc2f5883c47382f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463255Reviewed-by:
-
ckitagawa authored
Paint Preview Player Test is failing due to how threading is different in that test. This works in prod so let's just remove the checks for now. Bug: 1136888, 1136712 Change-Id: I5aa0623dbd7465b2069d9534b299a3e23668b9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463327Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#815644}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: Icf2da5098a87d00798cd01cf53e5ebdf04354582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461380Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#815643}
-
Morten Stenshorne authored
Bug: 294205 Change-Id: I579500a705436e6c36b8b56c241ab5f8b5e9018e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462260Reviewed-by:
-
Mohamed Amir Yosef authored
This CL uses a smaller arrow (and different arrow) in the move bubble to be aligned with the arrow used in move bubble in chrome://settings/passwords It also adds some margins around the new smaller arrow. Screenshot: https://screenshot.googleplex.com/3ApL5zYMe8A2HQi Bug: 1100814 Change-Id: I83caa8ad0ec2d78a65cc9bd5517b17068d6cce6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461318Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#815641}
-
Mikel Astiz authored
No behavioral changes: this class groups the two preexisting observing functions in a single interface to improve readability. On iOS, some temporary code is introduced to avoid breaking the build or the behavior for downstream implementations of ChromeTrustedVaultService. Change-Id: I28e8a78148ce65f69e07ff4782e3570e266d3c10 Bug: 1081649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461007 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium cd5015ec. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I3b0b5b19e4ab834b78f26825ff3183729644c59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460950Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815639}
-
Olivier Robin authored
In side by side mode, it is possible to switch the keyboard focus between 2 applications. In that case, no notification is sent to Chrome. But the keyboardView is recreated on getting the focus back, and it is possible to use this signal to retrigger accessory view. Bug: 1125095 Change-Id: I06e8301ab6aec8fa58a78fed2c94516a1d2fa3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445410 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#815638}
-
