- 19 Jan, 2021 40 commits
-
-
Daniel Hosseinian authored
Certain UI elements, such as the thumbnails and the annotations dialog, require the number of rotations on the PDF content. Currently, that value is tracked both on the UI and the plugin backend, but they can go out of sync because: - The UI value is updated synchronously whenever the rotate button is clicked. - The plugin value updates when a rotate request comes from the UI or the context menu. Therefore, the true value is held in the plugin, as the rotate requests from the context menu do not go through the UI. Furthermore, the number of rotations from the plugin is already sent to the UI on the 'documentDimensions' message. Use that value instead. Fixed: 1166590 Change-Id: Ia7fa111ae338a863828fd1196715684301d7b5c3 Bug: 1166590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630428 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#844746}
-
Viktor Semeniuk authored
This change allows syncing compromised credentials whenever local state of compromised credentials changes. Whenever Compromised credentials are added/removed password_store will notify PasswordSyncBridge about affected PasswordForms. This change also includes updating local state of compromised credentials during merge when remote password is more recent. Integration tests are added to test new behaviour. Bug: 1167109 Change-Id: I4681bf47aaf1376699680dacd502d8e37076a9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626439 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#844745}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ee927aaa..035dfc7b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieeb136822d1e1bea0875a823a955900a9b54ce57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844744}
-
Chinglin Yu authored
The security sandbox forbids making socket connections directly from within most child processes (except the network utility process). Trace data for renderers are missing from a tracing session with Chrome data sources on non-Android Posix platforms. This change introduces a new Mojo interface, SystemTracingService, that is shared between the browser and child processes for making a socket connection to the system tracing service daemon. A child process receives a Mojo remote interface and then invokes the OpenProducerSocket method to open the socket connection in the browser process. The browser process then passes the socket connection to the child in the response. The child process then adopts the connected socket in initializing the connection in PosixSystemProducer. Full design doc: go/crosetto-chrome-producer-dd SystemPerfettoTest.SandboxedOpenProducerSocket Bug: b/147789115 Test: services_unittests: SystemTracingServiceTest.*, Change-Id: Id698dc656b7b9ede723e3a887532c33544914edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435129 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#844743}
-
Ben Mason authored
Change-Id: I3071172054097f353d308f723d6deb6fc85ce1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637416 Auto-Submit: Ben Mason <benmason@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844742}
-
Alice Wang authored
This CL changes several account picker methods to package private as we already finished modularization of account picker. Bug: 1155123 Change-Id: I33252c72ac37eaa121e35aea59578390018571ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631499Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844741}
-
Finnur Thorarinsson authored
Bug: 1166410 Change-Id: Ifea16684b7d1d653ca2447b907eb217d09ce0abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632764 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844740}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ea4488d496b4..b81bf5f2ec4b 2021-01-19 tvanderlippe@chromium.org Fix styling of Developer Resources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5b1660d580eb253ed6bec165aaf2f588e65eb935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636755Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844739}
-
Kyle Williams authored
Create a new form factor for Meeting Room Hardware Workspace Devices, also known as Chromebox for Meetings, to allow finch support for CfM specific experiments. BUG=b:177442621 TEST=ensure unit tests work correctly and test with basic logging to ensure the correct form factor chosen in chrome. Change-Id: I89af958017dfb2e68c3e423be7832ef0d7dc8a47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628108 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Kyle Williams <kdgwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#844738}
-
Jakob Ivarsson authored
These have been launched and are now the default behavior on TOT. Bug: 993325 Change-Id: Ide288a1c3c1333153799676ebc748d3bc1707a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635661 Commit-Queue: Jakob Ivarsson <jakobi@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844737}
-
Renato Silva authored
Google Assistant is usually configured during OOBE. When the user skips voice match during OOBE, an in-session UI is used to train the system to recognize the user's voice. Migrate Google Assistant in-session UI off HTML imports by using the HTML Imports polyfill. This polyfill is currently also being used for the whole OOBE. Tested on a Pixelbook. Bug: 1111849 Change-Id: I237fbb2bec88bf265610edbc6b0ed13b9bc54be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632683Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#844736}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4374.0-1610361443-benchmark-89.0.4389.5-r1 to 89-4384.0-1610966529-benchmark-89.0.4389.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4080c75232b1caa1c9c17c2f754eb2154441c17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636757Reviewed-by:
-
Rushan Suleymanov authored
This CL adds a test to check that sessions will be synced when all tabs are closed. Normally this is the case when all tabs are closed on Android platform. However it is also possible that the new window has been opened without any tabs and this state should be synced. Bug: 1039234 Change-Id: I8f0df377bc72ee505090ad7243ba24067a964af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606231Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#844734}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4380.0-1610362181-benchmark-89.0.4389.5-r1 to 89-4384.0-1610969724-benchmark-89.0.4389.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2b0039d54c504e9b9057bb84b578924fd4a8fcc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636756Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/81430e11c81e..b69f54069cbf 2021-01-19 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 55486659 to f3626a1b (232 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ic4668e53fd21714a4cfee77cc3304d754add1c12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637301Reviewed-by:
-
Rainhard Findling authored
The test is flaky. TBR=sunnyps@chromium.org Bug: 1164391 Change-Id: Icb6902cbad5e898c9abae14f46d69e83b004aa1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637554Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#844731}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I4a0a92a9c84c9ad08c6a2efe95c10b1bacbbbccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637303Reviewed-by:
-
harrisonsean authored
Redesigned site settings page enabled/disabled strings. Bug: 1113642 Change-Id: I4b16629fdf0997fae00d0b5bfc9a541330de902a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461013 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#844729}
-
Owen Min authored
This matches the behavior of RemapRenamedPolices function in PolicyServiceImpl Change-Id: I7a38bb6f286c6ae873373454e379ec4103cbf58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636278 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844728}
-
Saurabh Nijhara authored
The C++ style guide suggests that enums should be named like constants, not like macros. This CL adapts the new style for ExtensionStatus enum in force_installed_tracker. Bug: 1167661 Change-Id: If74d7b647c9d484d510fdae04df722fda5b43cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633270Reviewed-by:
Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#844727}
-
Yoshisato Yanagisawa authored
Bug: b/168080931 Bug: b/147265909 Change-Id: Ib2248ce249427ed4af1cc769416da28089c79c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637713 Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844726}
-
Robbie Gibson authored
This test makes sure that the ViewRevealingVerticalPanHandler can handle two gestures at once. Specifically, if a second gesture is received while processing a first gesture, the second gesture is ignored. Bug: 1161209 Change-Id: I2b4f4ea1553e2cc11a51a6430485ecb900ac9d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632692Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#844725}
-
Shik Chen authored
This reverts commit 6d262811. Reason for revert: https://crbug.com/1168057 Original change's description: > CCA enables multiple streams > > Chrome camera app enables multiple streams while recording. > > also pass type checking > > Bug: b:151047537 > Test: Manually test. preview is 640x360 and recording is 1280x720. > Change-Id: I8171b0061a94ca8653c044857da2598eece43e5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409683 > Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> > Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> > Reviewed-by: Inker Kuo <inker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844700} TBR=jcliang@chromium.org,shik@chromium.org,henryhsu@chromium.org,inker@chromium.org,wtlee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6fd3a938699b0a57f95554bd620e0dd5f4e9f6db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:151047537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637100Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#844724}
-
Alice Wang authored
This CL moves the method called by native code launchSigninActivity() from SigninPromoUtil to SigninBridge. Bug: 1165772 Change-Id: Id684316cd759379235651511d34216fcbb74337d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632950Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844723}
-
Alice Wang authored
This CL cleans up the abstract method SigninFragmentBase#getSigninArgument(). It's simpler to use Fragment#setArgument() directly in code. Bug: 1045473 Change-Id: I40023d4b6c03db65aba29b7f8b596201aecdaa99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633263 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844722}
-
Marc Treib authored
LocalSync means that Sync is not actually talking to the Sync server, but instead to a local server. There might not even be a signed-in account. In this situation, it makes no sense to offer the account-scoped storage - it's not going to work anyway. Bug: 1147165 Change-Id: Ib2a50c493e03756b9ee3948907ffabf974491ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637573Reviewed-by:
-
Rainhard Findling authored
The test is flaky. TBR=justinmiron@google.com Bug: 1168036 Change-Id: I51e479cc3f30953bc33143dd723db96ee1be2a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637634Reviewed-by:
-
Mathias Carlen authored
Before this patch AutofillAssistant flows would lose a non significant percentage of users that do not yet have the feature module installed. This patch adds two countries (US, GB) to the conditional install tag for the dynamic feature module so that this percentage will be lowered. Due to technical limitations around isolated splits this is only made available for Android O+ devices. Also note that this patch had to introduce a slightly different manifest for trichrome since those modules require min-sdk version 29. Bug: b/174305656 Change-Id: I49767dc9516e8e383f17c94697d44d3ad65305c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627372 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#844719}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eddf4e758768..d1684427cdca 2021-01-19 dberris@chromium.org Revert "Reland "chromeperf: Anomaly configs in subscriptions"" 2021-01-19 dberris@chromium.org chromeperf: Remove broken logging 2021-01-19 dberris@chromium.org chromeperf: Use an empty dict for default config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1158326 Tbr: skyostil@google.com Change-Id: I88b81ed738decf37449736dff7923a283910102d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637298Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/111e01a4ac13..ea4488d496b4 2021-01-19 sigurds@chromium.org Refactor ErrorWarningCounter to use a new CounterButton component 2021-01-19 wolfi@chromium.org Add sources_panel_icon If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1140516 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1e94f474f5f99d431c3312ad84b3477b96388f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637299Reviewed-by:
-
Yusuke Sato authored
BUG=None TEST=try Change-Id: Ia7fe05b5c8f5038edc1d2f41a93d1ebd5c3b23ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632392Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844716}
-
Shik Chen authored
Some devices do not support the pointsOfInterest control and there is no standard Web API can query it without trying to apply it. This CL catches the exception from applyConstraints() and simply ignores it. Bug: b/172345418 Test: Manually Change-Id: Ied24770a1eddf8e6f3772287da6fd55c818b85e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637434 Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#844715}
-
Robbie Gibson authored
When the thumb strip is open in peeked state, switching tabs should not close the thumb strip. This added EGTest checks that is the case. Bug: 1155211 Change-Id: Ifc530731b69e3572e0d3f6837cd68b857b1c08cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636393Reviewed-by:
-
Rainhard Findling authored
The test is flaky. TBR=lukasza@chromium.org Bug: 1163630 Change-Id: I63691605c11a1ab5cc0adafaa03544d6fb6a974f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637494Reviewed-by:
-
Titouan Rigoudy authored
I have promised a few times that I would extract these tests once they reached a critical mass and I had a minute. That time has come. Bug: chromium:1167697 Change-Id: I5808dfa7bfac32190c39354895096c9e0679a398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632681 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#844712}
-
Jan Wilken Dörrie authored
This change fixes an issue inside IsContiguousIterator that would fail compilation if it was instantiated with an iterator to a container that has a non-trivial value_type. This was because `IsContiguousIterator<It>` instantiated `std::basic_string<iter_value_t<It>>` to determine whether `It` was an iterator for a `std::basic_string`. This would then trigger a static_assert inside basic_string if `iter_value_t<It>` was not a trivial type. Now IsContiguousIterator<It> only attempts to instantiate a std::basic_string if `iter_value_t<It>` is a trivial type, avoiding this issue. Bug: 828324 Change-Id: I1ab8d10b1847cca09041cc3f2fe623d2a04602fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632958 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#844711}
-
Robbie Gibson authored
The cause of this DCHECK (and resulting broken UI) was that as part of closing the tab grid, the tab strip is snapshotted. As it has changed (new tab added), everything, including the tab grid has to be re-laid out. This causes the tab grid to scroll back to the recent tabs page, causing the bvc to be removed after it was added correctly earlier. This ends up with a broken UI and a black screen. The fix is that the tab grid coordinator should alert the tab grid that its content will disappear before changing the pan handler state. Bug: 1094335 Change-Id: Ie9062766952b6a5957046b472515223010b6c58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632654Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#844710}
-
Yoshisato Yanagisawa authored
Bug: b/168080931 Bug: b/147265909 Change-Id: I6cdcd2fb6a5813b453ef809011d6c09d9ee169a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637302Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
-
Victor-Gabriel Savu authored
Bug: None Change-Id: I07b8ff33ca484cbc88d369b6ff74fcdeb1e20c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635671 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1cb592d4efd1..cc7aa8e318bb 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 68635b431b3c to 81430e11c81e (12 revisions) 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 149733cead63 to 8da0f82baf35 (2 revisions) 2021-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1d3066a6 to 00da91bb (227 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I5929eaba68d292c36e7d82879dc40a1353aceeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636995Reviewed-by:
-
