- 11 Nov, 2019 40 commits
-
-
James MacLean authored
This reverts commit 5e7d8eb8. Reason for revert: This CL disabled the wrong test. Original change's description: > Disable ExternalProviderImplTest.BlockedExternalUserProviders on Linux. > > Disabling this test to reduce jank on the bots. > > TBR=domfc@chromium.org > > Bug: 1023391 > Change-Id: I26243bb6acba2af947357222ac1fa5664601b1e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908063 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714232} TBR=wjmaclean@chromium.org,domfc@chromium.org Change-Id: Ice16cb05e8e047380bba533e9b0cfda37204f316 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1023391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909642Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#714272}
-
Victor Hsieh authored
Spec: https://spec.googleplex.com/crosux-spec/feature-specs/start-screen-auth-methods.html#start-screen-auth-methods-bottom-status-indicators Test: turn on/off, see correct result Bug: chromium:893332 Change-Id: I40c34b50e297f46fca8102403ed4b81d6821e576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900135 Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714271}
-
James Cook authored
The build flag was introduced when we supported the app list on Windows, Mac and Linux. However, the app list currently only works on Chrome OS and it's been that way for years. Finish cleanup of //chrome/test/BUILD.gn and chrome_paks.gni and remove the flag altogether. Bug: 1022886 Change-Id: If7a312207376abed4e6e56efa2c75e2c53852bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907547Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#714270}
-
sczs authored
- These new strings will be used to configure the new Infobar modal on iOS. Bug: 1014652 Change-Id: I2f79de8bef51c38d37947c25fb5b55dce825901f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904948Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#714269}
-
Xing Liu authored
Android starts to resize big icon size on notification. We now check version O for exact icon size match instead of O MR1, that we suspect the Android CL to resize icons is included in some pre MR1 O versions. TBR=peter@chromium.org, dtrainor@chromium.org Bug: 1009855 Change-Id: I5eac5e0c2218797419fb82de59c2ed6763e23fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900395Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#714268}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1abb0dd1324b..f18ff947360d git log 1abb0dd1324b..f18ff947360d --date=short --no-merges --format='%ad %ae %s' 2019-11-11 jmadill@chromium.org Minor tweaks to SampleApplication. Created with: gclient setdep -r src/third_party/angle@f18ff947360d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I38a188b7da704555043a23599a24ea5189dd086f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910300Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714267}
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/7cde68f10cdf..64a45be5198f $ git log 7cde68f10..64a45be51 --date=short --no-merges --format='%ad %ae %s' 2019-11-09 ebrahim [ubsan] Don't decrease pointer if match_glyph_data is null (#2048) 2019-11-05 don.j.olmstead [cmake] Add harfbuzz-icu library 2019-11-06 ebrahim [fuzz] Remove just added case 2019-11-05 ebrahim [fuzz] Upload testcase of https://crbug.com/oss-fuzz/18529 Created with: roll-dep src/third_party/harfbuzz-ng/src TBR=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 1023070 Change-Id: I9bc02abe3f177adfd8afe6eb439fb47d68158ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910222Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#714266}
-
Martin Robinson authored
This support is required for ATs on AuraLinux, so fall back instead of triggering an assertion failure and a null position. We can remove this workaround once sentence boundary analysis support is added to AXPosition. Bug: 1000049 Change-Id: I00c4eee451c75e7efe8e132d15995899eccca049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832811Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#714265}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a4c1aaad8d5f..26f7dde56c90 git log a4c1aaad8d5f..26f7dde56c90 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 mbonadei@webrtc.org Revert "Whitespace change" 2019-11-11 alessiob@webrtc.org APM runtime setting: fix kPlayoutVolumeChange not dispatched 2019-11-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5145d23f..e2cf3bc0 (714086:714186) 2019-11-11 philipel@webrtc.org Add allowCodecSwitching flag to RTCConfiguration.mm 2019-11-11 mbonadei@webrtc.org Whitespace change 2019-11-11 asapersson@webrtc.org Add field trial for rampup in quality based on available bandwidth. Created with: gclient setdep -r src/third_party/webrtc@26f7dde56c90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:none Change-Id: Ia447ff234f35bbb597531725a443fb25ab304a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910167Reviewed-by:
-
Fan Yang authored
Change-Id: I5e9a81c98270b5acb68899c13fc75c22c74bebc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909888 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#714263}
-
Dan Elphick authored
Uses new V8::GetSharedMemoryStatistics API to report stats on shared memory in V8 (i.e. not per isolate) such as read_only_space's size. Bug: v8:7464 Change-Id: I139e084c51703dd5cf1239a59128de874aea62c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905547 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#714262}
-
Sergio Villar Senin authored
As part of the rewriting of Blink Animation Engine we're replacing the way the elapsed time is represented inside a TransitionEvent. The spec mentions it must be a double but we can use AnimationTimeDelta as the internal representation. This change reduces a little bit the number of required conversions between AnimationTimeDelta and double. Bug: 737867 Change-Id: Ide96f3906c3937c6d4af893a9677211c7f8de8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907247Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#714261}
-
Francois Beaufort authored
This CL adds a menu item named "NFC" to Android site settings and page info. It allows websites to query the NFC permission which can be set only by user from site settings for now. A future CL will allow websites to prompt in-page user to grant access to NFC. Screenshots: https://photos.app.goo.gl/k7wz55v9ELVTS19i8 Bug: 520391 Change-Id: I64aefeb26e0a849422a21fe6eb2217817d101060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891415 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#714260}
-
Sergio Villar Senin authored
As part of the rewriting of Blink Animation Engine we're replacing the way the elapsed time is represented inside an AnimationEvent. The spec mentions it must be a double but we can use AnimationTimeDelta as the internal representation. Bug: 737867 Change-Id: I38041957586d2d151eea6dddc908bb176eadf97d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907248Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7980e5ea3e34..51516f076308 git log 7980e5ea3e34..51516f076308 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 fmayer@google.com Merge "Do not count roots as unique_retained." 2019-11-11 rsavitski@google.com Merge "compact_sched: remove "unstable" notices" 2019-11-11 rsavitski@google.com Merge "compact sched_waking: event decoding in trace_processor" 2019-11-11 rsavitski@google.com Merge "compact sched_waking: writer (traced_probes)" Created with: gclient setdep -r src/third_party/perfetto@51516f076308 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I85e20b4475481af1fd2c2c1eaca3b224e6cbba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910168Reviewed-by:
-
Yusuke Sato authored
This is to support unibuilds, and the content of the class is the exact copy of platform2's. We don't expect that the original functions will be updated often, and once we stop supporting ARC container, we'll move their unit tests to Chromium and delete the platform2 code. BUG=b:123309049 TEST=try Change-Id: I5b4d2fe39f9177a177ac1d98e33581dec7b15c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904874Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#714257}
-
Vadym Doroshenko authored
FieldInfoManager is a KeyedService which keeps password related field information. Namely it contains map: (FormSignature, FieldSignature)->field type (FormSignature, FieldSignature) is unique identifiers of fields, type is PASSWORD, USERNAME, NEW_PASSWORD etc. Bug: 959776 Change-Id: I21d2044d619a6ad3b1788c8c98ed75cd58316bf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872224 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714256}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/78441455a3f7..eab1e281fa5e git log 78441455a3f7..eab1e281fa5e --date=short --no-merges --format='%ad %ae %s' 2019-11-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 652dbfc63e70..012d15196023 (9 commits) 2019-11-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2019-11-11 mtklein@google.com add assert_true() 2019-11-11 bsalomon@google.com C++17 Created with: gclient setdep -r src/third_party/skia@eab1e281fa5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None Change-Id: Ibbdb86d1e79fc3bbd52d6ea0c270cb854fc20738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910166Reviewed-by:
-
Rouslan Solomakhin authored
The line between instruments and payment apps is blurred in the current implementation of Web Payment in Chrome. With the exception of Autofill, each payment app contains exactly one instrument. This typically results in both payment app and payment instrument being implemented in the same class, because that is easiest. To alleviate the confusion, this patch has only payment apps and no payment instruments on desktop implementation of Web Payment. The payment sheet displays exactly one entry per payment app. In the case of autofill credit cards, each one is technically a payment app, although its UX look and feel has not changed. Previous Name New Name ----------------------------------------------------------- PaymentInstrument PaymentApp ServiceWorkerPaymentInstrument ServiceWorkerPaymentApp AutofillPaymentInstrument AutofillPaymentApp This patch corresponds to steps 1-3 in Phase I of go/cross-platform-pay-app-factory The Android code is affected because of the shared browser tests. The iOS code is affected because it re-uses PaymentInstrument and AutofillPaymentInstrument, but the iOS changes in this patch are meant to be minimal. Bug: 1022512 Change-Id: I2ea83fcb81a7cf862a559d011686c6b2c170b6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904532Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#714254}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f0bfbce62d42..f4cf10c66fbf git log f0bfbce62d42..f4cf10c66fbf --date=short --no-merges --format='%ad %ae %s' 2019-11-11 rharrison@google.com Correct Unicode issue with add_copyright.py (#876) Created with: gclient setdep -r src/third_party/shaderc/src@f4cf10c66fbf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I88a68115bd0c2f6cb0aa1091f68903c3c9d598c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910165Reviewed-by:
-
Alexei Svitkine authored
All DiskCache histograms that are not marked <obsolete> and several top histograms by data size that are not owned are moved to open source repository and marked as expired, so that they no longer send data. Also adds units to them to satisfy presubmits, but some are added as ? since they were not obvious from the description. Corresponding internal change: cl/279355826 Change-Id: I21fd9ee61753852872d765be27da9d6e5ab433f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907146Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#714252}
-
Mila Green authored
Bug: 1020650 Change-Id: I8da0968e81d86646f62fda300bb783142a4d6236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898613 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714251}
-
Donn Denman authored
Removes some booleans and methods for visibility of shadows that are now always visible. The Bar shadow was probably switched so we could draw a banner (which we no longer ever do). The Panel shadow was switched due to not being needed on the new layout, but now we do use it. Change-Id: Idf90fbe52841ba49e7760425768795b378c24e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906316 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714250}
-
Weiliang Chen authored
For Windows overlay, we DCHECK that the output surface supports dc layer overlay. In one of the GL Renderer unit tests for overlays, we didn't set up the bool for support dc layer overlay and it was crashing on bots. R=rjkroege@chromium.org Bug: 1022911 Change-Id: I0881615115e62c92e83e8239fc69631fb54c877e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907202 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#714249}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/414f99e0be8a..524459562448 git log 414f99e0be8a..524459562448 --date=short --no-merges --format='%ad %ae %s' 2019-11-11 sugoi@google.com Avoid sync issues by removing global android swapchain map Created with: gclient setdep -r src/third_party/swiftshader@524459562448 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/143902189 Change-Id: I0cda0b4fa4bda345e5526187f777479244835ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910164Reviewed-by:
-
Hans Wennborg authored
Bug: 1022718 Change-Id: I4eca834414883ffac786d1f4310261b67929a8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904175 Commit-Queue: Reid Kleckner <rnk@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#714247}
-
Aaron Leventhal authored
Windows screen readers that inject into our process cannot be allowed to call back into a destroyed RenderFrameHostImpl. NOTRY=true Bug: 1012643 Change-Id: I9a86462941fe7f330d9047e0aa6a2913e7758d19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904308 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#714246}
-
Guillaume Jenkins authored
- Makes Chrome/ium point to the latest sh-4-0 and sr-4-0 Hunspell dictionaries - Fixes associated spell check component unit tests: - In SH, "Google" has been changed to "Gugl" - In SR, "Гоогле" ("Google") has been changed to "Гугл" ("Gugl") - In both test cases, the wording has also been updated based on Google Translate translations - Lorry payloads have been created here: https://lorry.corp.google.com/?live_filter=&text_filter=%28sh-4-0%29%7C%28sr-4-0%29&access_filter=&entries=20&output_format=standard&descending=true Bug: 997228 Change-Id: I0227666eda96efba37c8d5287d2d12a6e9cd65bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906782Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#714245}
-
Rodney Ding authored
- declare BuildJSONValue in report_body as virtual - make all sub-class implement override implementation add toJSON to report_body, making it serializable - Includes 4 different reports - and parent class LocationReportBody Bug: 917945 Change-Id: I2ef281aad171ec6a477ae562fab3257847ee4f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895957Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Rodney Ding <rodneyding@google.com> Cr-Commit-Position: refs/heads/master@{#714244}
-
Xianzhu Wang authored
I'm no longer working on and familiar with it. Change-Id: I782454acffa5650700a0de0ea95fcdd170770a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909440 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#714243}
-
Carlos Caballero authored
MessageLoopForIO is going away soon so get rid of it. Also its replacement has support for mock time so there is no need for base::TestMockTimeTaskRunner. Bug: 891670 Change-Id: Ice3a129784431b73f9a9d6c9d4fef6bd1a619f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800309 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#714242}
-
Rohit Agarwal authored
If the user started the browser in incognito mode and triggered a restart in regular mode, the browser was started in the incognito mode. The restart now always brings back a regular mode. Bug: 999085 Change-Id: Ib05ff1830371995e8814a87dbbadd2cc86b40e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833973 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
A comment above BasicStringPiece definition currently suggests against using that class directly, confusingly mentioning BasicStringPiece again as one of the alternatives. This confusion comes from http://crrev.com/187793004: before that change, the comment was attached to StringPieceDetail, thus advising to replace the use of StringPieceDetail with (among others) BasicStringPiece. However, that CL replaced StringPieceDetail with BasicStringPiece, making the comment obsolete. This CL just deletes the obsolete sentence. Change-Id: I516e2a14ee846ecf2644097f2ecbc201d2b6f022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908267 Auto-Submit: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#714240}
-
Kaan Alsan authored
Use the kIgnoreScrollOffset flag when calculating a snap area's rect relative to its snap container, rather than adding the scroll offset later in the calculation. Bug: 1016785 Change-Id: Ifbc1c46c5f95e0d8871286be260c2ee219e15e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902008Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
-
kylechar authored
TBR=kainino@chromium.org Bug: none Change-Id: Icde92cb02d520936a439afcae4da7cdaafdc304f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908717Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#714238}
-
Marc Treib authored
- Update some comments. - Remove some dead code. - Rename |local_state_| to |prefs_|. Bug: 1021092 Change-Id: I5a52e39223547bc71e83fa306a50fb94fc20b22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910086 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#714237}
-
Alex Turner authored
We add a web platform test for the cache when it is partitioned by top- frame origin. The test caches a resource, then attempts to load it in a popup window. With the split cache, if the popup window is cross-origin, we would expect that request to be a cache miss. We compare the number of requests that hit the server to our expectations. To enable these tests, the existing framework is slightly refactored, including to respond to CORS preflight requests. The virtual test suites virtual/split-http-cache and virtual/not-split-http-cache explicitly test the cases of a split and not-split cache, respectively. The default test is disabled as its result depends on whether the split cache feature is enabled. Bug: 981970 Change-Id: I049fdaec4aebcbdeebdd3c77d13d6ca420d1bd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890952Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#714236}
-
Garrett Beaty authored
This reverts commit 428151a2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Move goma builders to their own bucket. > > The delegation for goma bucket into luci.chromium.ci pool has been > fixed. > > Change-Id: I08368f1db383e1b94f8f9bf731642e8d5f4a80f2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887656 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Cr-Commit-Position: refs/heads/master@{#714230} TBR=agable@chromium.org,jbudorick@chromium.org,gbeaty@chromium.org Change-Id: Ia8c6010881ba31c6785893a6f29601facfc94268 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910280Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#714235}
-
Miguel Casas authored
This CL continues substituting LOG_ASSERT()s to avoid crashing the test binary in Tast test runs. This last patch in the list intervenes image_processor-client.cc, by adding a local macro ASSERT_TRUE_OR_RETURN_NULLPTR. This CL also takes the chance to rename ASSERT_TRUE_AND_RETURN to ASSERT_TRUE_OR_RETURN in video_frame_helpers.cc, since that name makes more sense (it was introduced in this series of patches in crrev.com/c/1900559). Bug: 1020776 Change-Id: I7f2a9c19d3eba474e8f7551854b3ec6ebd0fc943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907130 Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#714234}
-
Yao Xiao authored
Fixes the following tests: URLRequestHttpJobWithMockSocketsTest.TestSuccessfulCachedHeadRequest URLRequestTestHTTP.BasicAuth URLRequestTestHTTP.BasicAuthLoadTiming URLRequestTestHTTP.CacheRedirect URLRequestTestHTTP.HeadersCallbacks URLRequestTestHTTP.HeadersCallbacksAuthRetry URLRequestTestHTTP.NetworkAccessedClearOnCachedResponse URLRequestTestHTTP.NetworkErrorLogging_304Response URLRequestTestHTTP.NetworkErrorLogging_DontReportIfNetworkNotAccessed URLRequestTestHTTP.VaryHeader Bug: 1021617 Change-Id: I4fa9b35c8424d3da584e8f21d176cddba5a08113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900549 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
