GitLab

Bug: 1011908
Change-Id: I5c0ab0c93178bfbacaa920b5bb2b130ac2aa633c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865536Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707074}

It seems there's some confusion about exactly how the policy should behave,
so disable it for M79 while we clarify the semantics.

Bug: 1015484
Change-Id: I21f62e06277ec34bc64c611324234fdf8e5949be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867089Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707073}

These changes simplify migrating to starlark by removing spurious diffs
from the semantic diff.

The repo_url, refs and header_id fields have no effect when
builder_view_only is true because builder views do not display headers
and do not display a list of changes being tested.

lucicfg enforces referential consistency, so a couple of non-existent
builders were removed. It also prevents a builder from being duplicated
in a builder view, so there was one repeated builder removed from
tryserver.chromium.mac console.

Bug: 1011908
Change-Id: Iec1ee893e27b6c4edec3ab546ab9485453cacede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851911
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707072}

This increases coverage somewhat, though there's still a ways to go.

Bug: 1009106
Change-Id: Ia569e7b3630380a5f0abb2401b180550dd321328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865425Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707071}

Update matchers to not use GREYMatchers anymore
Remove -testInvocations call for iOS 10.2
Add support for shared EarlGreyScopedBlockSwizzler.
Add helper util to call -presentSafeMode.

Bug: 987646
Change-Id: I783e84af095b87f84d2502c14a308dc41a6eef54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863950Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707070}

Fix accessibility bug: In the sensors tool, when the reset button under Device orientation was clicked, the screen reader did not read anything out to inform user that the orientation was changed.

Now whenever the device orientation updates, the new setting is read out. If the update was only read out when reset button was pressed, the experience would not be consistent, and the alert wouldn't be read out for subsequent resets, which is why the update is read out on every change.

Gif: https://imgur.com/a/1YeTX2l

Bug: 963183
Change-Id: Id4f82c4af8db1857af832d4b221d60cd1eea578c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750194
Commit-Queue: Anubha Mathur <anubmat@microsoft.com>
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707069}

Currently, the process of reverting to the user text is broken for
on-focus suggestions.

After using the arrow keys to choose a match, pressing Escape does not
work. Escape selects the top match, which normally works, but in
ZeroSuggest, the textfield contents could be a non-prefix of the first
suggestion.

This CL reverts the textfield to the input that was sent to the
Autocomplete controller, which should work for on-focus suggestions.

This also adds a test.

Bug: 1012990, 996516, 963173
Change-Id: Id19aaf961591dc0c81bf9083b639233c5f8e4420
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865551Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707068}

Move layer list dumping to a format and code that is aligned between CAP
and non-CAP code paths.  This will smooth the transition for enabling
CAP.  Additionally, this will remove some of the dependencies on
stale/deprecated GraphicsLayer information for those dumps.

Bug: 999336
Change-Id: I0f1a1715a4d73802c3cb05333dafc9d85d0cf15c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809659Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Sam Fortiner <samfort@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#707067}

https://chromium.googlesource.com/angle/angle.git/+log/48aa52f7305a..f483d4ee4696

git log 48aa52f7305a..f483d4ee4696 --date=short --no-merges --format='%ad %ae %s'
2019-10-17 jmadill@chromium.org Vulkan: Move SwiftShader ICD json to root_out_dir.

Created with:
  gclient setdep -r src/third_party/angle@f483d4ee4696

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@google.com

Bug: chromium:b/142756865
Change-Id: Ia3afc491beaf59973fb97d2fec3d8e693165b92a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867037Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707066}

There is some stuttering when viewing protected content with a DP MST
dongle attached.

Looking at a trace it looks like we spend a lot of time (200ms)
in DrmDisplay::GetHDCPState, in particular in drm_->GetConnector.

This patch caches the connector used to check if HDCP is available.

It additionally downgrades log severity when the HDCP properties
is not found to INFO, since it can happen every 2 seconds.

Bug: 1001211
Change-Id: I77eb86b2e55f0fd4640560ae2e38d64d5e2b2174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864354Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707065}

Bug: 1013598
Change-Id: I19dbb6981eae07d45c0d760f41f4f42508b80929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856799Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707064}

Added fuzzy padding to the Key value generation, plus included two known
colliding values to be used with approximately 1% chance.

I was trying to discover crbug.com/973943 with this improvement, but have not
succeeded so far. However, the fuzz target seems to be running much faster now
and keeps discovering new coverage starting from the existing corpus. This is
a good indicator that the change makes sense. I've also compared the code
coverage reports locally to make sure those pieces of code under key size checks
are now getting executed, such as:

https://chromium-coverage.appspot.com/reports/706240_fuzzers_only/linux/chromium/src/net/disk_cache/blockfile/entry_impl.cc.html#L449

and

https://chromium-coverage.appspot.com/reports/706240_fuzzers_only/linux/chromium/src/net/disk_cache/blockfile/entry_impl.cc.html#L793

Also fixed a presubmit warning regarding the use of std::to_string.

Bug: 990644, 973943
Change-Id: I0c7560f700ccaf5e25bda2e1d56f3cb613bbe91f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865408Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707063}

https://pdfium.googlesource.com/pdfium.git/+log/1f088ab877cb..94e600d98301

git log 1f088ab877cb..94e600d98301 --date=short --no-merges --format='%ad %ae %s'
2019-10-17 thestig@chromium.org Verify font resource dictionaries.
2019-10-17 thestig@chromium.org Add a JavaScript test for AFDate_FormatEx().

Created with:
  gclient setdep -r src/third_party/pdfium@94e600d98301

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=pdfium-deps-rolls@chromium.org

Bug: chromium:1013868,chromium:572901
Change-Id: I7c900f247a67da175eabf06115ad04fe1f9d3f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867029Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707062}

This reverts commit eda4c3ea.

Reason for revert: This change is masking some exception failures.

Original change's description:
> [ios] Speed up egtest failures by skipping _recordFailure.
> 
> _recordFailure internally spends a very long time symbolicating
> on iOS13. Skipping this seems to be safe.
> 
> Bug:991338
> 
> Change-Id: I74c2872cd82de0840a6bcdd0f799703b5eb9bdb0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725137
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684557}

TBR=rohitrao@chromium.org,justincohen@chromium.org,monufriienko@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 991338
Change-Id: I66223c64e6236dbea9feb8ac74e7c29b832e2eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866990Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707061}

This reverts commit 2d943658.

Reason for revert: feature got all the approvals.

Original change's description:
> Revert "[Lock screen media controls] Enable by default"
> 
> This reverts commit 00d10067.
> 
> Reason for revert: feature not ready to launch in M78, reverting in trunk then merging.
> 
> Original change's description:
> > [Lock screen media controls] Enable by default
> > 
> > Enable the lock screen media controls by default
> > since these are shipping in M78.
> > 
> > BUG=965546
> > 
> > Change-Id: I159052753625fe4eb8bf3653bf2c7bdffe09615e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773325
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Commit-Queue: Becca Hughes <beccahughes@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#690893}
> 
> TBR=jamescook@chromium.org,beccahughes@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 965546
> Change-Id: I97211dd536f71ee8fed4b08b1124089343f797a9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826043
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#700041}

TBR=jamescook@chromium.org,mlamouri@chromium.org,beccahughes@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 965546
Change-Id: I567d6fa05394e31df3d5e9a35f9c3bcc8af600ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867196Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707060}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/930722709254..3e2416ee17a9


Created with:
  gclient setdep -r src-internal@3e2416ee17a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:1011937)
Change-Id: I4c3a166f46df3ff8a22b8f9d0764ab7c02492453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866433Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707059}

The crashes is becaued color spaces of DDL recorder colorspace and
framebuffer sk surfaces do not match.

Bug: none
Change-Id: Ib970536c78eb2a9452528b0f99deecc067446247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866738Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707058}

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a959deb00750..834ee546f93d

git log a959deb00750..834ee546f93d --date=short --no-merges --format='%ad %ae %s'
2019-10-17 johnkslang@users.noreply.github.com Merge pull request #1937 from jeffbolznv/volatile_atomics

Created with:
  gclient setdep -r src/third_party/glslang/src@834ee546f93d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com,jmadill@google.com

Bug: None
Change-Id: Icd6d999b7245ae7761cacce2cf8cd7d71e057486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866432Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707057}

screenshot: https://screenshot.googleplex.com/dFAHtHLKDVX

Bug: 1004420
Change-Id: I9b3c509cb2cb3dfd2dbbf2f8007173f3abb96b75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866019Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707056}

Bug: 1007294
Change-Id: I99b7b3cc46e12c0fb060f76e086f5f31bd4cb812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865216
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Auto-Submit: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707055}

Change expectation file of pointerevent_coalesced_events_attributes.html to match the output on Mac 10.13

The wpt test pointerevent_coalesced_events_attributes.html is flaky on
Mac10.13 Tests bot, because its running result is different from the
default expectation file. I add a new expectation file for Mac10.13.

TBR=lanwei@chromium.org,nzolghadr@chromium.org

Bug: 1015254
Change-Id: I0795c7154d33689a80c8fa9a99433d7134678589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866993Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707054}

This patch implements |TextType()| and its utility functions
for |NGFragmentItem|. This fixes symbol marker and other
painting failures due to incorrect |TextType()|.

Only one is removed from FlagExpectation because the bot is
not ready yet. I will clean it up once the bot is ready.

Bug: 982194
Change-Id: Ic99c9eb564b002682fefdb590d42679dbedeae60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865738Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707053}

This CL mark UKM metrics to aggregate and also add enumeration
information to all metrics.

Bug: 1001588
Change-Id: I67d78d364c726074dbfc75a239aba7b086f8a718
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862891Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707052}

- An OWNERS file added
- Some tests are failing currently as the update to Confidence intervals
of Mac bots were not correct:
https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Release%20%28Intel%29/17407
https://ci.chromium.org/p/chromium/builders/ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/18108

To fix this, based on values recorded on gpu.fyi bots, limits are updated.


Bug: chromium:1011969
Change-Id: Ifc54ef48caaa976aec67960f6c53738a07fe36d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866616Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707051}

This CL just prevents the user from foot gunning themselves by pasting 10 MB of
text into chrome://settings/addresses.

Bug: 1007442
Change-Id: I9ab3aa526b5ca20fcfc207c3248e9c5df5045ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855961
Auto-Submit: Dominic Battré <battre@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707050}

https://chromium.googlesource.com/openscreen/+log/af60f62955c6..d0f315b3fac8

$ git log af60f6295..d0f315b3f --date=short --no-merges --format='%ad %ae %s'
2019-10-16 jophba Rename task_runner to GetTaskRunner
2019-10-14 mfoltz [Open Screen] Add linux64_gcc_debug  to the LUCI waterfall page.
2019-10-15 jophba Change JsonCpp reader to use strict mode
2019-10-15 btolsch Add cast sender socket factory
2019-10-10 jophba Add Mac OS X ScopedWakeLock implementation
2019-10-14 mfoltz [Open Screen] Final round of gcc fixes.
2019-10-02 jophba Add frame agent config files
2019-10-11 mfoltz [Open Screen] Fix gcc build errors in osp/impl/discovery/mdns
2019-10-11 rwkeane PlatformClient: Use In Existing Classes
2019-10-11 mfoltz [Open Screen] Remove CDDL compiler dependencies on platform/.
2019-10-10 mfoltz [Open Screen] BUILD cleanups.
2019-10-11 rwkeane TcpSocket: Implement TlsWriteBuffer
2019-10-10 rwkeane PlatformClient: Add Threading Support
2019-10-10 mfoltz Use recursive deps for buildtools/.

Created with:
  roll-dep src/third_party/openscreen/src

Change-Id: Ie4bfe652f32e9fc2e55003da894a6759c957c335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865041Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707049}

It is now implicitly enabled by default.
Also updated OfflinePageAutoFetchTest to give more friendly output.

TBRing reviewers:
holte@chromium.org: Please review changes to fieldtrial_testing_config.json

TBR=holte@chromium.org

Bug: 887670

Change-Id: I30e169730b31f6ab804b125d4adbb3c5dfe9dde7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832630
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707048}

We plan to add a confirmation dialog (or other similarly useful UI) to
either confirm that the user wants to delete autocomplete matches or do
then undo (depending on where we land UX-wise).

R=tommycli@chromium.org

Bug: 1013837
Change-Id: I8ec1942cbc519b2da18e23b04dcb00884719c6ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866061
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707047}

Bug: none
Change-Id: I60a3cdad143ac8e414415c1d03c34e59e843e34b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864779
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707046}

If Device Apps bit is disabled, we should not send the list of installed
apps to the server. Also disable the open app feature.

Bug: b/140584925
Test: Manual Test
Change-Id: Id998a23b9d5e34cf3515a4ef07fda538c16fa2ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854819
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707045}

Keystore key rotation is triggered by Sync server. In this case client
receives new keystore keys together with old NigoriSpecifics.

After keystore key rotation NigoriSpecifics should contain last
keystore key and its keybag should be encrypted with this key. Because
syncing with rotated keystore NigoriSpecifics is already supported,
the only thing we need to do is to implement NigoriState transition:
last keystore key should be added into |cryptographer| and used as
the default encryption key.

Additionally, we trigger keystore key rotation inside
NigoriSyncBridgeImpl ctor, because it might be not completed in between
of SetKeystoreKeys() call and browser restart.

Bug: 922900
Change-Id: Ie67a922edf3f573fb6c7c768df789138804d5012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863936Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#707044}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I2f5c76a70e0f6092c3aa480a5c60b3be40897936
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866698Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707043}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/7c836ccb431d..a2b2fc8164dc

git log 7c836ccb431d..a2b2fc8164dc --date=short --no-merges --format='%ad %ae %s'
2019-10-17 ziegs@google.com excelsior: add signing for factory shim

Created with:
  gclient setdep -r src/third_party/chromite@a2b2fc8164dc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: I9c6c11ce3fedfcaa7f3216e7481a4330a4d33445
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866877Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707042}

FingerprintSetupTest.FingerprintSetupCancel is very flaky on ChromeOS
since 2019/10/16.

https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTQsSBUZsYWtlIkJjaHJvbWl1bUBicm93c2VyX3Rlc3RzQEZpbmdlcnByaW50U2V0dXBUZXN0LkZpbmdlcnByaW50U2V0dXBDYW5jZWwM&show_all_occurrences=1

TBR=tbarzic@chromium.org

Bug: 1015014
Change-Id: Id4210e6317067a5716212a12937ee079f562b4e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867198Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707041}

Also adds helpers for isCompactHeight and isSplitToolbarMode in
ChromeEarlGreyImpl.

Bug: 987646
Change-Id: Id8f48a0e126faab215ffb6ed8d2e306b13f33bbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864355
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707040}

Dictionary mistakenly used "\n" instead of encoding as hex ("\x0a")
causing exceptions on ClusterFuzz.

Bug: 1015442
Change-Id: Id27fb1de4c08ad9fbfc40ddcf1caac915a828259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866878Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Auto-Submit: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707039}

Change-Id: I7d0ebe844fe5396665e17e0202698a5ff25afbc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857299
Commit-Queue: Bryan McQuade <bmcquade@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707038}

https://quiche.googlesource.com/quiche.git/+log/780eaa6043f2..13753e667da5

$ git log 780eaa604..13753e667 --date=short --no-merges --format='%ad %ae %s'
2019-10-17 bnc Use IETF QPACK error codes on the wire.
2019-10-16 rch gfe-relnote: Send QUIC connection close packets at all available encryption levels.
2019-10-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_fix_rto_retransmission3.
2019-10-16 wub gfe-relnote: (n/a) Always handle MSG_TOO_BIG when sending buffered packets. Protected by existing --gfe2_reloadable_flag_quic_treat_queued_packets_as_sent.
2019-10-16 fayang gfe-relnote: Remove QUIC v39.
2019-10-16 rch Remove broken code from ToyQuicClient which was landed in cr/275026885.

Update flag definition per the "Send QUIC connection..." change.

Remove QUIC_VERSION_39 references. Many seem to really be "the lowest
available/implemented/... QUIC version", and thus were changed to refer to V43.

Changed versions used in quic_http_utils_test.cc,
FilterSupportedAltSvcVersions to reflect removal of version 39.

Update components/domain_reliability/quic_error_mapping.cc to reflect
addition of QPACK error codes.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I04d14224215bf4efe5bd3ffa95c6d7e45ed1f8e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865560
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707037}

Clamshell mode behavior will remain the same, i.e., tapping on the
overview background will return to its previous state, it can either be
in-app or home screen.

Bug: 997885

Change-Id: I2dae82657d4d92876c834c78dd62d53830fbe6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865264
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707036}

We introduced additional padding for the search engine icon experiment
focused state. This additional padding happens post-layout, so we don't
have to re-layout the view tree during the animation. As a result, the
UrlBar's width=match_parent makes the UrlBar too wide and the end of
the UrlBar's text is cut off by the next view.

Bug: 1012436
Change-Id: I5f46a2dd530783b002c529d3c4cdccbdd81e1b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856868
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707035}