- 17 Apr, 2020 40 commits
-
-
Robbie Gibson authored
Because the name was incorrect here, when Finch sends a config for this Feature, both the gws_id from Finch and the gws_id defined in about_flags were sent back to gws. If an enabled and a disabled ID are sent to gws, the disabled id is the one that takes affect, so the feature ends up disabled. Bug: 1071078 Change-Id: Ic67f1d5415ac5895a84ee41adc8b2c98d1c38456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153106Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#759983}
-
Yoshifumi Inoue authored
This patch changes |NGBoxFragmentPainter::NodeAtPoint()| to set offset in containing block instead of offset in underlying element for inline element as legacy layout to make hit testing on inline element with ::after pseudo class with adapting |PositionForPoint()|. The document[1] contains investigation notes of this CL. [1] https://bit.ly/2REZ7P9 Hit Test with ::after Bug: 1043471 Change-Id: I81ada0ccd7bff31a84ce4746785ea83eb175937c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151775 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759982}
-
Nikita Podguzov authored
Bug: 1015690 Change-Id: Ia80de70a421e39515060a873a1ddb77c4c77eeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138071 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#759981}
-
Swapnil authored
installed but not loaded According to the current UMA statistics, some of the force installed extensions are installed successfully but failed to load due to some reasons. To investigate this, we report disable reasons for forced installed extensions. When extension is disabled due to several reasons, only one is reported. Following histogram is added: Extensions.ForceInstalledNotLoadedDisableReason Bug: 1063024 Change-Id: If384aa15c5f2ec56dcb4d0510ef6a1a610a8ea6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139760Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#759980}
-
Jérôme Lebel authored
When the coordinator is interrupted, the ChromeIdentityInteractionManager needs to be dismissed. Once it is dismissed, the manager can be set to nil. Bug: 971989 Change-Id: I0da58b71e3e151d71e76fce5d9a8f53c00e66b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154185Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#759979}
-
Koji Ishii authored
As a preparation to add |NGTextType| to |NGInlineItem|. This patch has no behavior changes. Bug: 982194 Change-Id: Iec07f6606458fe16a1fe2d3f0e16a2069944af46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153459Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759978}
-
Alice Wang authored
This CL extracts an interface for AccountManagerFacade to decouple the dependency to the AccountManagerFacade implementation in most places. Bug: 1063869 Change-Id: I97496438cecd571b36b212ee510c408f8b4af702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144193Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759977}
-
Colin Blundell authored
This reverts commit 0c7bb0a0. Reason for revert: Broke the build Original change's description: > WebLayer: Close tabs on launching external intents when instructed > > This CL augments WebLayer with closing of tabs when the external > intent launching code asks to do so (namely, when an initial navigation > in a Tab results in the launch of an external intent). To do so we > invoke BrowserImpl#destroyTab(). As clients < 84 are not necessarily > expecting the last tab to be closed by the WebLayer implementation, we > do this only when the client is 84+. > > As part of this CL we looked at hardening WebLayer against the case > where the client calls Browser#destroyTab() from within > TabListCallback#onTabRemoved() (which itself is received after the Tab > destruction process has started in the implementation). It turns out > that WebLayer will already fail fast in this case: > Browser#onTabRemoved() sets the removed Tab's Browser to null, and > Browser#destroyTab() raises an exception if the passed-in Tab's Browser > is not equal to |this|. > > Bug: 1031465 > Change-Id: I87e1464d3be4b0fe138ab7aa14fe700b8b930722 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144120 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759969} TBR=sky@chromium.org,boliu@chromium.org,blundell@chromium.org Change-Id: Icf90ed217d0586b22fe3f55452c0ab6878d57118 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152809Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759976}
-
Denis Kuznetsov authored
After changes in issue 1058022 the tests are much less likely to time out on dgb/*san bots. If tests will flake again, please disable them indvidually rather then by reverting this CL. Bug: 1049789, 1025926, 990362 Bug: 1058022 Change-Id: I5f20659b798ad1604d82df4b028453bfe93811e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152586Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#759975}
-
Andrei Salavei authored
Add missing else in if-else statement in HTTP error handling Change-Id: I1da56170c43948af598a03ac9876f4a9ba257196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151510Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Andrei Salavei <solovey@google.com> Cr-Commit-Position: refs/heads/master@{#759974}
-
Rainhard Findling authored
* This is done as preparation for a subsequent refactoring of the safety check WebUi code. It moves the source of truth for the safety check parent status from the JS side to the C++ side. This removes some of the interdependencies of parent to children (and vice versa), and allows for a subsequent splitting of parent and children into individual parts on the WebUi side. * This CL is part 2 of the change and updates the WebUi to use the parent state received from the backend, instead of holding and computing its own. Bug: 1015841 Change-Id: I3a6f1c1bb195c6c050e14b31564316d4a9e2323d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150429 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#759973}
-
Alex Rudenko authored
Documents how to use lldb to debug Chromium processes Change-Id: I39beec3addc5c9360a0120e4d8d1f4e9e46a390a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153074 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#759972}
-
Wanming Lin authored
This CL only classifies existing tests to subfolders (motion, orientation) respectively. Bug: 816462 Change-Id: If4b3a41466d51ed4a044502683303b413344b262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147008Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#759971}
-
Tomasz Moniuszko authored
Change-Id: I8ac39de179577d73789d1a46f470dc885c7992d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148780Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#759970}
-
Colin Blundell authored
This CL augments WebLayer with closing of tabs when the external intent launching code asks to do so (namely, when an initial navigation in a Tab results in the launch of an external intent). To do so we invoke BrowserImpl#destroyTab(). As clients < 84 are not necessarily expecting the last tab to be closed by the WebLayer implementation, we do this only when the client is 84+. As part of this CL we looked at hardening WebLayer against the case where the client calls Browser#destroyTab() from within TabListCallback#onTabRemoved() (which itself is received after the Tab destruction process has started in the implementation). It turns out that WebLayer will already fail fast in this case: Browser#onTabRemoved() sets the removed Tab's Browser to null, and Browser#destroyTab() raises an exception if the passed-in Tab's Browser is not equal to |this|. Bug: 1031465 Change-Id: I87e1464d3be4b0fe138ab7aa14fe700b8b930722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144120 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759969}
-
Marc Treib authored
They're used as guiding metrics which should not expire, in line with other Session.TotalDuration* metrics. Also change ownership of these two plus a few other Session.TotalDuration.* metrics from feuunk (who originally implemented them but isn't working on this anymore) to bsazonov,droger,msarda (for signin) and treib,tschumann (for sync). Bug: 1059805 Change-Id: I7ba1de54cc65a407c79f2b6eac130ac2427422ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146547Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#759968}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I19f918e44fd8978d7137e2d672234121a6a629ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152783Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#759967}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dac43e8ad366..748197e6959a git log dac43e8ad366..748197e6959a --date=short --first-parent --format='%ad %ae %s' 2020-04-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 59d22330..41c6b825 (406 commits) 2020-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2430d665d3f2..d25ce8725224 (18 commits) Created with: gclient setdep -r src/third_party/skia@748197e6959a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I4742654b30f9dde48805cd26e815b890b5bd953e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153669Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759966}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 41c6b825. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 6c8523d2 "[scroll-timeline] Implement element-based scroll offset" 36adda96 "[COEP] Fix malformed .headers in WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I1522cc4cdcd9e5acdac5da81d76aa5f8976fffad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153728Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759965}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I4779bdcef67e71cb4798cef5aa5e241d93578d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153168Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759964}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/acac5d6f9d72..0173ae54a67a git log acac5d6f9d72..0173ae54a67a --date=short --first-parent --format='%ad %ae %s' 2020-04-17 szuend@chromium.org [issues] Rework how issues are associated with affected resources Created with: gclient setdep -r src/third_party/devtools-frontend/src@0173ae54a67a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070577 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6cfcae578f4c32f17d73c8fcc09af866cf34d9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153667Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759963}
-
Giovanni Ortuño Urquidi authored
On most OSs these properties are stored in the OS itself, e.g. in Windows an app is added to a folder so that it shows up in the Applications Menu. For ChromeOS, we need to implement our own way of storing this. This CL adds a new property to WebApps: ChromeOSData, which holds properties specific to Chrome OS and needed to integrate with various UI surfaces. Bug: 1054195 Change-Id: I23dab5aeb5f30c94d28db0062bb82b4f173047da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132900 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#759962}
-
Eric Willigers authored
PendingAppManagerImplBrowserTest.RegistrationTimeout was sometimes reporting successful service worker registration, instead of the expected timeout. Early in the test, InstallApp executes a run loop. The service worker had opportunity to register during this run loop, so the WebAppRegistrationWaiter late in the test would sometimes report successful service worker registration even with a timeout of 0. We now test an app that has no service worker. Bug: 1071317 Change-Id: I75c3ca39417c70af874b1b44f1c5398864f7e1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153457 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759961}
-
Timothy Loh authored
This CL prevents downloads by the internal download service from being shown in the extensions API. The motivation comes from running the Plugin VM installer while using ChromeVox -- the download progress is reported to the user with a guid as a name, which is a bit confusing and clashes with updates from the installer's progress bar. In general, it seems like these internal downloads shouldn't be exposed to the extensions API. chrome://download-internals uses a different API to access this data so it will continue to display this data. Bug: 1021414 Change-Id: Idabbd4548a672fe9b773289a7809c32013dda56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143186Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#759960}
-
Saho Kobayashi authored
refactor arc_accessibility_helper_bridge_unittest.cc by moving FilterTypeChange to after TaskAndAXTreeLifecycle. Bug: b/153618572 Test: ArcAccessibilityHelperBridgeTest.* Change-Id: Id36aec7ff5698857f9a67c18411cebd5f3759a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152051Reviewed-by:
Sara Kato <sarakato@chromium.org> Commit-Queue: Saho Kobayashi <sahok@chromium.org> Cr-Commit-Position: refs/heads/master@{#759959}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9ad01787a88f..dac43e8ad366 git log 9ad01787a88f..dac43e8ad366 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/dawn 0721c1cf2a52..53f694b34a8d (8 commits) Created with: gclient setdep -r src/third_party/skia@dac43e8ad366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I58405ec436abc803884290175bdc23d501975c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154100Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759958}
-
phillis authored
Add UMA metrics to record possible errors that can happen during file handler registration process. We should come back at this later and try to consolidate different platform errors after we have a better understanding of the stability of this feature Bug: 1051670 Change-Id: Ie97f7ee168129b206a56cf79576e13997651df2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134587 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#759957}
-
Hiroki Sato authored
When ARC node has input focus but it doesn't have any name or text, the node was ignored because HasImportantProperty checked focusability only from whether it's FOCUS actionable or not. This CL fixes this by adding more conditions so that such a node becomes important. Bug: b:154173452 Test: manual. Open talkback-test-app "Common Widgets" and input focused Sliders are accessible. Change-Id: I3fcb57f42647a428bd4f7de73a30c4901b1a6efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153450 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#759956}
-
Philipp Hancke authored
Enables the gcm cipher suites for SRTP by default. Since these ciphersuites are not the first choice this does not change the default behaviour when talking to other Chrome instances. BUG=chromium:713701 Change-Id: I133da5b9fabc4605e557f0b787fe63ffa5c1746a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917095Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#759955}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd63f0e0..71edd921 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0f222189d2effa4604da70fe6810666a7f2b0837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153727Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759954}
-
Jeremy Roman authored
1. Disabling clang-format isn't really necessary for these fairly short strings. 2. There is no need to allocate an AtomicString for the intermediate value; a StringView can be used instead. 3. The CreateFilterDataUrl function isn't declared in the header and should have static (file-local) linkage. Change-Id: I2c8c8ce506d530911dfebbdbede5a7ca2e1736e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153000 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#759953}
-
Yuki Shiino authored
Supports Python's multiprocessing on platforms that do not support 'fork'. Bug: 839389 Change-Id: I2dbe28686c3d73badcbf6e07e403079a981f6b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153166Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759952}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I3bb87303919579766c46a42d8d98dd0b8ee5449e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150354Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759951}
-
Peter Kasting authored
* Make SetScreenInstance() return the previous screen instance. This will easily let callers save/restore screen instances. * Use ProcessDisplayChanged() in an applicable spot. * Stop overriding GetDisplayMatching() in DesktopScreenWin. The parent class definition is more accurate, and this looks to be an ancient artifact. * Replace some DISALLOW_COPY_AND_ASSIGN. * Various other stuff Bug: none Change-Id: Ic6d545c828e5ec68f015cc7677b6ce74cc14e286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145631 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759950}
-
Yuki Shiino authored
{Canvas,Offscreen}RenderingContext APIs are missing default values of IDL dictionary types. Adds them. No behavioral change. Bug: 839389 Change-Id: I03ab9c8d7b568174a31561a54f698fad2a6812aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153169Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#759949}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames flex-shrink-large-value-crash.html. Bug: 1063749 Change-Id: I859a090a35780bfab5cc7cc3418316f2721ddcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152059Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#759948}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5470988c4033..d25ce8725224 git log 5470988c4033..d25ce8725224 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 digit@google.com Fix LLVM-based Arm64 build. Created with: gclient setdep -r src/third_party/swiftshader@d25ce8725224 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ieb49afc25f04516b288033c247f11d09859b1fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154097Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759947}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames inline-flex-editing-crash.html. Bug: 1063749 Change-Id: I1a939dbf754630836798938dd35728324048f16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152332Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#759946}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to filter-turbulence-invalid-001.html. Bug: 1063749 Change-Id: Ie2a06923c2cf533807c807cbba73873d11353c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134034 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#759945}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6144906469fe..9a846fe623f6 Created with: gclient setdep -r src-internal@9a846fe623f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: I17ca99a5ee7248119e9fd641b5a5ee32d8f9a016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154092Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759944}
-