- 25 Mar, 2020 40 commits
-
-
Dominic Battre authored
The experiment is not launched so we still need the metircs. Bug: 1053276 Change-Id: I2d96f5b3c61e32f7168c27e86dcbd9706bbccf48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117119 Auto-Submit: Dominic Battré <battre@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#753098}
-
nancy authored
Modify ExtensionApps to call UI Extensions application_launch API OpenApplication directly to launch apps. Add extension enable flow to LaunchAppWithIntent. Move RecordUninstallCanceledAction after construction and deconstruction functions following coding convention. BUG=1061843 Change-Id: Iee27aecd57d4c0cf955bafb4085cad01fe94fe8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114596 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#753097}
-
David Rees authored
Bug: 152233113 Change-Id: I5a4a55c9e9bee40ca29b1089757a2eee4a5d2a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118691Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: David Rees <drees@google.com> Cr-Commit-Position: refs/heads/master@{#753096}
-
Shakti Sahu authored
This CL adds the JNI conversion methods for the query tiles. Change-Id: Ie8bfedc262d26885b925d45c0530da08dc9b3511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117061 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753095}
-
Peter Kasting authored
More simplification. GetScreenWinDisplayNearestDIPRect() calls SquaredDistanceBetweenRects() up to twice as often as before, but since the number of displays is small and this function is cheap, that won't have any meaningful performance effect, and this was the simplest, clearest way to write the code. (The previous patch set used a longer form that involved transform() to avoid calling this function more times than necessary, but if we cared about perf, that would probably be worse on net, given the cost to allocate/deallocate an extra vector and read/write different objects in the loop.) There is one behavioral change here: previously, IsWindowUnderCursor(nullptr) would return true if GetCursorPos() failed. This seems incorrect (if unlikely). The current version returns false in this case. (If WindowFromPoint() returns nullptr, IsWindowUnderCursor(nullptr) will still be true.) Bug: none Change-Id: I0f051a6f0da23eff37ecfb24f1057f4b1fb4e3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104369 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#753094}
-
Maria Villarreal authored
This change moves STYLE_HINT from chrome/ to ui/ to be used as textfield placeholder text color constant. The current color used for the placeholder fails the contrast ratio. For enabled state, this placeholder would have a color similar to #8F9091 with a contrast ratio of 3.2. For disabled state, the color would be similar to #B8BBBD with a ratio of 1.93. With this change, the placeholder will have a text color constant with a value similar to #5F6368 and a contrast ratio of 6.05. Bug: 1056950 Change-Id: I66133508491fc79b2e91f1d8cb3013683d088722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113796Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Maria Villarreal <mavill@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753093}
-
Gyuyoung Kim authored
This CL moves anonymous-block.html test from css/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs and a ref test link. Bug: 1063749 Change-Id: Ie3ec6c8f4e6b2f096137d4a28f3519ffecaf9891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116161 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753092}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e9013eeb3d1d..e3a49aa40576 git log e9013eeb3d1d..e3a49aa40576 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 ehmaldonado@google.com git-cl: Remove unused and duplicate functions. 2020-03-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@e3a49aa40576 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Iec672b834ee990b6c61c8232f743e2b9293405a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119192Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753091}
-
Scott Violet authored
This adds 'android_weblayer' to nearly all places that have 'android'. The only places I did not add weblayer are ones that are defined in chrome. I did not check every feature, so that it's entirely likely some of these features aren't triggered at all in weblayer. BUG=1049426 TEST=test only change Change-Id: I75514fbf5c2f471f9dd8449395e288aa4cb896fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116786 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#753090}
-
Toby Huang authored
In response to the global COVID-19 crisis, many schools have closed. Many supervised users are also students. We want to temporarily enable supervised users to install extensions from ExtensionInstallWhitelist user policy without parent approval. This way, supervised users can install extensions such as Zoom for video conferencing and distance learning. We plan on back porting this change to M80. We will revert this change after the parent permission dialog launches. This CL improves upon the solution in crrev.com/c/2111055 by removing the hard-coded client side allowlist. Bug: 1063099 Change-Id: I7633b2a5e945cdfb9db61a0aac0ee85c6a58e0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109977Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#753089}
-
Toby Huang authored
We're reverting the extensions light solution with a hard-coded allowlist because we're proceeding with a better solution with a policy allowlist. Bug: 1063099 Change-Id: Ie13c3477540913d1076d03e3ce0a4b55820a63be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118877Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Evan Stade authored
This consists of enabling the protected media id permission and hooking up MediaDrmStorageImpl. Chrome's ProtectedMediaIdentifierPermissionContext is not reused because the majority of it is Chrome OS specific and the rest of it is functionality WebLayer doesn't need. The default for Android M+ is allow, so no prompt is shown. See GetInitialDefaultContentSettingForProtectedMediaIdentifier() Test: https://shaka-player-demo.appspot.com/demo/ > Sintel video should play (widevine) Bug: 1062474 Change-Id: I0e68cb78b9d88ad97d272253b62c3722fd7e3f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116550Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#753087}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0113d29ea0c4..9a378addafad git log 0113d29ea0c4..9a378addafad --date=short --first-parent --format='%ad %ae %s' 2020-03-24 mtklein@google.com refactor apply_transfer_function() Created with: gclient setdep -r src/third_party/skia@9a378addafad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I0ea29c9d83d7828021ab8b72b25345e4c698961e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119190Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4c6c40d47dc5..b867e14cac14 git log 4c6c40d47dc5..b867e14cac14 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 enga@chromium.org Add DAWN_NO_DISCARD to ErrorData Created with: gclient setdep -r src/third_party/dawn@b867e14cac14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1063810 Tbr: cwallez@google.com Change-Id: Ib146fb30ea49b6244cb2b171de12ea84428a56ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119191Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6d61ce6edb195f7c2159970a8c02a2c4dc6e5973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119133Reviewed-by:
-
Rohit Rao authored
The PolicyTest fixture supplies PrefServices that are managed by policy. It also supplies a MockConfigurationPolicyProvider that can be updated with test-specific policy values. Individual tests (to be written in the future) can use this infrastructure to verify that preferences are properly set based on policy data. BUG=1024115 Change-Id: I5ad4e9ae0089eb55253701806e371680f608d81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117317 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#753083}
-
Alex Moshchuk authored
This CL re-enables six previously disabled tests for how password-triggered isolation and strict origin isolation interact with field trials, memory thresholds, and manual overrides. These include *PasswordSiteIsolationFieldTrialTest* and *StrictOriginIsolationFieldTrialTest*. These tests were previously disabled due to runtime usage of ScopedFeatureList (see https://crbug.com/846380). This is a problem for browser tests, but less so for unit tests, where such usage is still allowed. This CL converts these tests to unit tests in site_isolation_policy_unittest.cc. This makes more sense anyway, as the tests purely check the state of site isolation policy in different configurations, without relying on any browsertest support. An added bonus is that they now also run on Android try bots, whereas previously there was no Android coverage (browser_tests don't run on Android). For that same reason, this CL also converts and moves the SitePerProcessMemoryThresholdBrowserTest* tests. This uncovered four bugs in the tests when run on Android bots, also fixed in this CL. Bug: 1009828 Change-Id: I10218fcac47284f84d102f6bf3ec1ae3893f3ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116150Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#753082}
-
Chris Hall authored
Removing usage of unsigned integer types in language detection to comply with style guide. R=dmazzoni,meredithl CC=thestig Change-Id: Ibeed71088a0ed4239f4d3c0aab8acc34b55687a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096603Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753081}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4e09751d83cc..3685fb977e15 git log 4e09751d83cc..3685fb977e15 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 treehugger-gerrit@google.com Merge "Add vts10 suite to existing vts tests" Created with: gclient setdep -r src/third_party/perfetto@3685fb977e15 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I83d3fcdb530409738cab6e4337ef9f87f28eaa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117883Reviewed-by:
-
David Black authored
For now, timers will render in a label displaying their times remaining (in seconds) but this will be updated to match the spec in a later CL. Note that this UI element is dynamic, it will update itself in response to updates to the underlying timers. Bug: b:149570650 Change-Id: I6288bba8664b702ef8e21ef96a9f58f6159ee88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109823 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#753079}
-
Brian Sheedy authored
Adds support for running the Android RenderTests with the comparison method set to Skia Gold instead of the legacy local pixel comparison approach. Also enables the functionality on the VR RenderTests in order to test stability on the CI bots. Bug: 1057845 Change-Id: Ibd38148a5449cc1c961a1dc224f6cacaef458ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934783 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#753078}
-
Nate Chapin authored
Use GetExecutionContext(), which should ~always be non-null, instead of domWindow(), which is null for non-attached Document. Bug: 1029822 Change-Id: I907cb2da8f851068a669f344230ce77f1a247895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118711 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
I am leaving Google. R=kbr@chromium.org Change-Id: I71c7eb22af1492cd76dd98a3526983226bc5fe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117647Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#753076}
-
Maggie Cai authored
This CL adds the delete functionality for the preferred app list. This CL also migrate relevant unit tests from the original preferred app tests. BUG=853604 Change-Id: Ib16470c0badf60f0da17fa4c3d7dae9594c5623c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117596 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753075}
-
Josh Karlin authored
What: Enable async ad tagging by default again. I reverted it last time due to performance regressions on the perf bots. This time, it should have less overhead since it skips checking the top of the v8 stack. I'll watch the bots after landing again. Why: Async ad tagging is necessary to capture ad script doing things like loading image resources in the main frame. One place we use this is to detect interstitial ads. Previously reverted CL: https://crrev.com/c/2053411 Bug: 851531 Change-Id: Ibf61388a44eadce91f322a6c07245650476b9ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078652Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753074}
-
David Munro authored
* Add a margin around the slider so the label doesn't get cut off and no scrollbar shows up * Align the max label correctly under the slider Screenshot: https://drive.google.com/open?id=1-K52YfP_4ZQ-zKkIu2ErLrprJXQM7kGY Bug: chromium:858815 Test: Manual Change-Id: I8c5b054a1df920f832e652aaa0848cd752601159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115868 Commit-Queue: David Munro <davidmunro@google.com> Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#753073}
-
Julian Watson authored
This allows the prefs to be reused elsewhere. Bug: 1049453 Change-Id: I52de2f0d7296d3bf522af5ef2aad79cf78370d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114514Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#753072}
-
Robert Liao authored
BUG=1057754 Change-Id: I268a85ff46614362b56a4501321018dc64c496cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118574 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
-
Rakib M. Hasan authored
This CL adds the _install_apks function to each WPTAdapter subclass which will install APKs for each browser. TBR=martiniss@chromium.org Bug: 1050754 Change-Id: I7cea7869ab4e498adf0e8215b8b78796f3b4df4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116779 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#753070}
-
Lei Zhang authored
Add a basic test to make sure RenderPage() works correctly for simple rendering. Change-Id: I2b2fd287167c532cb2f35c50726b880f56cb496b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117354 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#753069}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2702ad73. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6ca21db7b38ea59853e6d7b809a6b178eae43b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118591Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753068}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/012f9c0fc75e..cdbe45e832f2 git log 012f9c0fc75e..cdbe45e832f2 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 michael.liao@microsoft.com [Elements Panel]: Accounting for case where resolvedNode is null Created with: gclient setdep -r src/third_party/devtools-frontend/src@cdbe45e832f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4dad485a0598dbb79b8fc9ea71b7a2837be0192e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118467Reviewed-by:
-
Hesen Zhang authored
- Created TileInfoFetcher interface. - Implemented main logic on TileInfoFetcherImpl, need to nail down the error response and other details. - TODO: Add unittests. Bug: 1063996 Change-Id: I82c8c22c6ba56f16bb0f483ec78ff799b87e7702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115887Reviewed-by:
-
Peter Kasting authored
No other platform actually reads this, so make that clear. This will make some plumbing easier for later refactors since I don't have to worry about setting this cross-platform. Frankly, I'd love to remove the Mac usage too -- there's only one, in NativeWidgetMacNSWindowHost::CreateCompositor() -- but I'm not sure enough of all the plumbing here to try to pull that off. Bug: none Change-Id: I9f203cc8974afa68cc12f8999c3c39d8e9e05600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117333 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#753065}
-
Evan Stade authored
Bug: 1063495,1058600 Change-Id: I04ef88ef4bb9465cc933fc3d16d0405356438526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112959Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#753064}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Iceda0cfa595630a354659cdffc4132a2fcf98c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117297 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#753063}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d682fa4e329a..e9013eeb3d1d git log d682fa4e329a..e9013eeb3d1d --date=short --first-parent --format='%ad %ae %s' 2020-03-24 ehmaldonado@google.com Reland "depot_tools: Run using Python 3 by default." Created with: gclient setdep -r src/third_party/depot_tools@e9013eeb3d1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I63bc27f78f35a1fe815301e08b0d3f04d907471b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118934Reviewed-by:
-
Daniel Libby authored
Paint invalidation container information is no available in CAP, as it requires querying the compositing state to see whether a GraphicsLayer is created in a PaintLayer's ancestor chain. UpdatePaintInvalidationContainer should therefore be a no-op in CAP. This is an incremental change in pursuit of adding a DCHECK(!CAP) in LayoutObject::EnclosingCompositedContainer and removing that DisableCompositingQueryAssert from CAP codepaths. Bug: 1007989 Change-Id: I0ecd12fdf907f1746d54a67437143cb5ce7eb5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118212Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753061}
-
Caleb Rouleau authored
I am leaving Google. The TODO is unnecessary. R=johnchen@chromium.org, wenbinzhang@google.com Change-Id: Ib34659ab4f74bafc1338f50d2e263b816398b760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118670Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#753060}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4645a3f2eba0..054d61d117f0 git log 4645a3f2eba0..054d61d117f0 --date=short --first-parent --format='%ad %ae %s' 2020-03-24 bsheedy@chromium.org [Telemetry] Add minidump symbol caching Created with: gclient setdep -r src/third_party/catapult@054d61d117f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1061497 Tbr: skyostil@google.com Change-Id: Ib80382567b14ae4e3f9589be09fba71f48e310d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118931Reviewed-by:
-
