- 25 Jul, 2018 40 commits
-
-
Evan Stade authored
Bug: 854704 Change-Id: If201f772e7afeb646d619b7917f0f1e134e9edca Reviewed-on: https://chromium-review.googlesource.com/1149154Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#577974}
-
Sidney San Martín authored
Bug: 866988 Change-Id: I91084c1f34049d1b4aafdc2f1095ac30efe45fea Reviewed-on: https://chromium-review.googlesource.com/1148702Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577973}
-
Anna Offenwanger authored
Bug: 863557 Change-Id: I84e913d238dedf278b070afd9f3c79674373fc44 Reviewed-on: https://chromium-review.googlesource.com/1150290Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#577972}
-
Kush Sinha authored
Bug: 866354, 820046, 833797 Change-Id: Ib2b56a59fd9d5a7d2cc9b013a875f5d29b05b5e0 Reviewed-on: https://chromium-review.googlesource.com/1150166 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#577971}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e71d1bb7fc22..7f5175a4552d git log e71d1bb7fc22..7f5175a4552d --date=short --no-merges --format='%ad %ae %s' 2018-07-25 peah@webrtc.org AEC3: Corrected the filter adjustment during analog gain changes 2018-07-25 nisse@webrtc.org Delete root header file typedef.h. 2018-07-25 titovartem@webrtc.org Move sigslot to proper third_party directory 2018-07-25 buildbot@webrtc.org Roll chromium_revision deb63e97..f2569c57 (577752:577860) Created with: gclient setdep -r src/third_party/webrtc@7f5175a4552d The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:867373,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic9e3aaf5ed93f9a14cea51a76a0a6658e859d3a2 Reviewed-on: https://chromium-review.googlesource.com/1150300Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577970}
-
Zhenyao Mo authored
This reverts commit 568cc6a9. Reason for revert: <INSERT REASONING HERE> Original change's description: > MSE: refactor mp4 AnnexB validation to also report keyframe-ness > > In preparation for logging when there appears to be a mismatch between > MSE MP4 keyframe metadata and the encoded video bitstream's keyframe > metadata, this change incorporates basic analysis of the latter as part > of the existing Annex-B bitstream validation for MSE MP4 video. > > Note that mp4::BitstreamConverter::AnalysisResult contains > base::Optional<bool> for each of conformance and keyframe-ness fields. > If a field doesn't have a value, that portion of the result was not > analyzed. > > Note that keyframe analysis is implemented only for AVC currently, but > even that is skipped if the frame is detected as non-conformant before > enough indications of whether or not it is a keyframe are detected. > Neither AVC-DV nor HEVC AnnexB analyses do any actual keyframe analysis, > since such was either skipped or not yet implemented previously, > respectively. > > A subsequent CL will use the newly reported MSE MP4 video bitstream > converter's keyframe analysis results, if that analysis was done, in > reporting to chrome://media-internals when the bitstream keyframe-ness > mismatches that of the mp4 container for a coded frame. > > BUG=860420,584384 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I169c7774070ad232c86658bcd7803160323993ad > Reviewed-on: https://chromium-review.googlesource.com/1144456 > Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> > Reviewed-by: Sergey Volk <servolk@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577717} TBR=wolenetz@chromium.org,sandersd@chromium.org,servolk@chromium.org Change-Id: If4d14f0cb6fb0779255b9d7eb3d5b2b8c20e5be1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860420, 584384 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1150244Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#577969}
-
Zhenyao Mo authored
This reverts commit 61697367. Reason for revert: crbug.com/867520 Original change's description: > MSE: Log when MP4 keyframe-ness mismatches the compressed media > > Logs to chrome://media-internals when the container's keyframe metadata > for a frame mismatches the contents of that frame (if the latter was > determined by the respective bitstream converter's Analyze() > implementation, of whom only AVC currently does any keyframe analysis). > > BUG=860420,584384 > TEST=Repro crbug 860420 shows logs, new MP4StreamParserTest.AVC_Key* and media > > Change-Id: Ic87eab8726ad76b36b569df08ab2212b267008c2 > Reviewed-on: https://chromium-review.googlesource.com/1149153 > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577751} TBR=wolenetz@chromium.org,sandersd@chromium.org Change-Id: I8437af99f24bf04910ad56931a9e91f960a59469 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860420, 584384 Reviewed-on: https://chromium-review.googlesource.com/1150243Reviewed-by:
-
Danyao Wang authored
The short circuit skips WebStateImpl->OnTitleChanged() incorrectly on back/forward navigation because although the title in the navigation item doesn't need changing, the visible navigation item has changed. This only affects navigating to native content from web content because web state title for web content is updated separately in |-webViewTitleDidChange|. Bug: 864601 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifd74f87aff0276394def154a8410b3dd1ce6c1c8 Reviewed-on: https://chromium-review.googlesource.com/1148693 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#577967}
-
Avi Drissman authored
It wasn't showing up for dialogs on background tabs (broken in r520759). This fixes that and adds a test. BUG=860185 Signed-off-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#577966}
-
rajendrant authored
The application state is always treated as foreground. This is to check if the android x86 crashes reduce. Bug: 865373 Change-Id: I6e3ee471b4c775b719d0dce9d5ac9ac0ee1e724d Reviewed-on: https://chromium-review.googlesource.com/1149513Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#577965}
-
Dan Elphick authored
Pass Isolate* through to StringObject::New, String::Concat, Value::ToString and StackTrace::GetFrame as the non-Isolate forms are deprecated. Change-Id: Ib064eb3beba9493ba67e679118a6369c22cb92cb Reviewed-on: https://chromium-review.googlesource.com/1150030Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577964}
-
Elly Fong-Jones authored
Bug: 867511 Change-Id: I893a4d7b56d0ba4a14f54bb2fa59c33b51283316 Reviewed-on: https://chromium-review.googlesource.com/1150097Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#577963}
-
tzik authored
ThreatDetails is a ref counted object, and its first reference can be made by base::BindRepeating through ThreadDetails::StartCollection. The ref count is released when the callback instance is destroyed. As the RepeatingCallback instance created in StartCollection is destroyed after the scope out, `new ThreatDetails` may have returned a stale pointer. This CL moves the problematic StartCollection() call out of the constructor to avoid touching the ref count before its first proper reference is made. Bug: 866456 Change-Id: I82b83b9bb30cdc95cff60e3e22e79f0af17645a2 Reviewed-on: https://chromium-review.googlesource.com/1149777Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577962}
-
tzik authored
The first reference to ResourceRequestDetectorClient instance used to be made by base::Bind in its constructor, and posted to another thread. If the PostTask call failed, or the posted task ran immediately after the other thread, the RRDC instance may destroyed before the construction is completed. Though this does not actually causes a crash, as no one use the result of `new ResourceRequestDetectorClient`, this hits an assertion that being added as a false positive case. This CL adds ResourceRequestDetectorClient::Start, and makes the constructor private to ensure no one touches the fragile way. Also, this converts legacy base::Callback to base::OnceCallback, as a drive-by. Bug: 866456 Change-Id: Ifb3d8136f03e2e233cf4b0b2b0ee070db6b3093d Reviewed-on: https://chromium-review.googlesource.com/1149779Reviewed-by:
-
Avi Drissman authored
Code should use the scoped retain/release classes. BUG=none Change-Id: I0c538d7ae64127bba9b783fd08584f3164dc949d Reviewed-on: https://chromium-review.googlesource.com/1148476 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#577960}
-
Daniel Rubery authored
This test was disabled with MSAN due to the race condition in OnReceivedThreatDOMDetails. Repeated local runs with MSAN now succeed, so I think it's safe to re-enable. Bug: 860445 Change-Id: I4d01568c79562ac1125c4410dbe2c52c17056c2d Reviewed-on: https://chromium-review.googlesource.com/1149260Reviewed-by:
-
Christopher Cameron authored
This was not being saved, resulting in new child RWHViewMacs having their parent ui::Layer set to nullptr. Bug: 859834 Change-Id: I8e66370381406d8cc1dfb2aac9d81397c1775831 Reviewed-on: https://chromium-review.googlesource.com/1148940Reviewed-by:
-
Christopher Cameron authored
Enable tests that were disabled because of this functionality missing. Bug: 842325 Change-Id: I6f540460f4e5f81d7ff8dd36e4abf369f0bd4785 Reviewed-on: https://chromium-review.googlesource.com/1149612Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#577957}
-
Adrienne Walker authored
This reverts: https://chromium-review.googlesource.com/c/chromium/src/+/1123169 https://chromium-review.googlesource.com/c/chromium/src/+/1141102 ...which are the gpu and oop raster versions of the same change, respectively. There was some hope that by freeing fewer resources we would help with input latency, but this does not appear to have the desired effect in either UMA or on bots. Because this is a 4mb regression on Android (and maybe 12mb in WebView) revert these two changes. Bug: 863756, 865617 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I64eb735700ed1b704e191281ff79a01bccaff4e5 Reviewed-on: https://chromium-review.googlesource.com/1149093Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#577956}
-
Dmitry Gozman authored
This is essentially a part of InteractiveDetector, belongs to the loader. Bug: none Change-Id: I05bcf109b352c8054113003fe57b9de120af2bc0 Reviewed-on: https://chromium-review.googlesource.com/1149275Reviewed-by:
-
Peter Kasting authored
skia_paint_util* were split out from skia_util* last year. Copy danakj@ as owner since that's how skia_util* are set up. Bug: none Change-Id: I3bc5486932f0a7acfda1530f7b8ff5a85b71397c Reviewed-on: https://chromium-review.googlesource.com/1149455Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577954}
-
Ned Nguyen authored
Bug: 864565 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I8ae19f0318802404f354fc474a62299aad713afd Reviewed-on: https://chromium-review.googlesource.com/1149582 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577953}
-
Derek Cheng authored
TBR: hajimehoshi Bug: 867339 Change-Id: I7eedb205332e140722339707eb5fc4fc8f46b3c1 Reviewed-on: https://chromium-review.googlesource.com/1150289 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577952}
-
Oleh Prypin authored
Bug: 866883 Change-Id: I03fa831e8f31162217407b969eef7b4abbe2cf57 Reviewed-on: https://chromium-review.googlesource.com/1150168Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#577951}
-
Daniel Bratell authored
With constexpr you make it slightly easier for the compiler to optimize code, though the effect will be small. Also, with constexpr types the compiler becomes better at telling us when a variable is unused. This removes such variables. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b52edc7ef67167bf8b7864c97a5f57b50d85398 Reviewed-on: https://chromium-review.googlesource.com/1131509 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#577950}
-
Robert Sesek authored
- The standalone headless_shell needs to invoke the Seatbelt server in its child processes. - The --headless flag in Chrome needs to set up the CHILD_PROCESS_EXE override for finding the Helper.app. The --headless flag was incorrectly spawning the main app executable rather than the helper. Bug: 866606, 689306 Change-Id: I0e4fec109fad5577263059fd0b62dea3bb966860 Reviewed-on: https://chromium-review.googlesource.com/1148478Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#577949}
-
Gabriel Marin authored
Fixes a few small format string bugs and makes the windows library configuration #defines more friendly for chromium builds. Based on original CL: https://codereview.chromium.org/2730473002 BUG=724399,b:70905156 Change-Id: If54c6cfc5c508744d2ee18f251677b2456acda72 Reviewed-on: https://chromium-review.googlesource.com/1145626 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577948}
-
Mihai Sardarescu authored
The refresh token is updated to a new valid one in case of reauth. In this case the old and the new refresh tokens have the same device ID. When revoking a refresh token on the server, Gaia revokes all the refresh tokens that have the same device ID. This CL avoid revoking the old refresh token when to avoid Gaia revoking the new token soon after a reauth. Bug: 865189 Change-Id: I9c2a64f30e14a5376c530f3b511c212b70738f3a Reviewed-on: https://chromium-review.googlesource.com/1145073 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#577947}
-
Ella Ge authored
On touch adjustment, we do a point-base hit test after the rect-base one to make sure we find the correct target. This cl changes the point-base hit test from the iframe to the root frame. Because when we have iframe overlap by other elements, rect-base hit test might result an incorrect target in the iframe. In-frame hit-test cannot find the correct target that is outside the iframe. So, we should do the point-base hit-test on root-frame to find the correct target. Bug: 864849 Change-Id: Ib176a68e5c51eba40c504ad90190bec7fb66dccb Reviewed-on: https://chromium-review.googlesource.com/1145477Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#577946}
-
gogerald authored
Bug: 806868 Change-Id: Id1204fad26029f7358d9628590d713b9c2af01f3 Reviewed-on: https://chromium-review.googlesource.com/1143895Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#577945}
-
sczs authored
This is a preparation CL to remove animations when populating the history TableView and when performing a search. In order achieve that we need to reload all the content of the TableView instead of inserting/removing specific entries. This causes previously selected items to deselect when searching. For this reason there's no purpose to searching while editing is enabled, furthermore selecting the search bar will deselect selected items, which can be frustrating for the user. This CL disables the searchBar while the table is on Edit mode. The user can still search something and edit the results of the query, but it can't perform a new search query before exiting edit mode. This is the behavior of the legacy implementation. Screenshots: Enabled https://drive.google.com/open?id=1ZdplK968U4XgBE1cFSB9L4scblJwFeBN https://drive.google.com/open?id=1dH47e9tPHmDd2eUuOUVIt-W3Nay4v_A1 Disabled https://drive.google.com/open?id=1Gp4IXNawohaZnlwSnQTSJ0LLbvaFW6Iw https://drive.google.com/open?id=1aDPPjOd3DqX99vncP2wNXNHx_XKRyGhM Bug: 859736 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I705a936f8bb339ab29a1431d7d4d969d77337d71 Reviewed-on: https://chromium-review.googlesource.com/1148890Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577944}
-
Harald Alvestrand authored
Bug: webrtc:9532 Change-Id: Ia22b7976dc520ff968289d805de2ccc08635eb71 Reviewed-on: https://chromium-review.googlesource.com/1144149Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#577943}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58ea46ee..d729403c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I06b66ca92085d13d3fea0a10fa38da5161d5f601 Reviewed-on: https://chromium-review.googlesource.com/1149990Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577942}
-
Avi Drissman authored
All channels of Chrome should use the same preferences. This updates two preference accesses that were not updated in the original change. BUG=866750, 831577 Change-Id: Ibd0f8d2895027eb85772b3f5308ffebaef3aff32 Reviewed-on: https://chromium-review.googlesource.com/1148473Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577941}
-
spqchan authored
Remove Cocoa dependency from WebTextfieldTouchBar by moving it from TabContentsController to BrowserWindowTouchBarController. Hook up BrowserWindowTouchBarController to AutofillPopupControllerImplMac on MacViews so that the credit card touch bar can be updated. Move the the logic that listens to WebContent changes to the BrowserWindowTouchBarController. When the WebContents has changed, BrowserWindowTouchBarController will update the WebContents in BrowserWindowDefaultTouchBar and WebTextfieldTouchBarController. Modified SuggestedTextTouchBarController so that when its WebContents has changed, it'll observe the new WebContents. Bug: 856391 Change-Id: I9c29a371a0b38eb608bf8e32521abe22d5c664e0 Reviewed-on: https://chromium-review.googlesource.com/1135829Reviewed-by:
-
Elad Alon authored
Bug: 775415 Change-Id: I1184b1e058c80151cfb8226edfcb84558057bbb4 Reviewed-on: https://chromium-review.googlesource.com/1150150Reviewed-by:
-
Steven Bennetts authored
This CL eliminates NetworkingConfigDelegate by providing the captive portal provider info in NetworkState directly. This CL also: * Adds NetworkState::ProviderInfo struct for both VPN and captive portal * Renames NetworkingConfigDelegateChromeosTest -> NetworkingConfigChromeosTest since it wasn't testing the delegate per-se, but the functionality it was providing. Bug: 651157 For trivial rename in arc_net_host_impl.cc: TBR=hidehiko@chromium.org Change-Id: Iab872220aaedbcf27b4228581931e39c43dbab97 Reviewed-on: https://chromium-review.googlesource.com/1141210Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#577938}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/42c1c03334c7..b284280be4cc git log 42c1c03334c7..b284280be4cc --date=short --no-merges --format='%ad %ae %s' 2018-07-25 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 096c5296c3b0..2160821e16db (1 commits) 2018-07-25 mtklein@chromium.org temporarily disable t8888 config on *SAN bots 2018-07-25 benjaminwagner@google.com Revert "Blacklist hanging test." Created with: gclient setdep -r src/third_party/skia@b284280be4cc The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I0b95381d5167f1c034b7c481cb00ac567652dabb Reviewed-on: https://chromium-review.googlesource.com/1150049Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577937}
-
Steven Bennetts authored
Currently calls to FindPolicyByGuidAndProfile produce an error when called with an empty profile path. There are several places where this can occur, but we recently added one to the system tray UI: https://chromium-review.googlesource.com/c/chromium/src/+/1101204/12/ash/system/network/network_list.cc#813 Rather than ensure that we test for an empty profile path everywhere (which just indicates a non favorite/saved network), just return nullptr with no error when the path is empty. Bug: None Change-Id: I692babc10ae2472e8fa5dbfef1c8be170cc841b2 Reviewed-on: https://chromium-review.googlesource.com/1149096Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
-
Joshua Peraza authored
ChildProcessCrashObserver.java serves a similar purpose as CrashDumpManager.java did (which it will replace), except without the need (or ability) to check for a minidump on the filesystem. Instead of a minidump path, the process ID of the crashed child is passed to the callback which it can use to identify the correct crash dump. Bug: crashpad:30 Change-Id: I718e653acfa35b14ebaa17d0e8c76804f9856dfb Reviewed-on: https://chromium-review.googlesource.com/1150202Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#577935}
-
