- 12 Jan, 2021 28 commits
-
-
Nancy Wang authored
BUG=1146900 Change-Id: I54b5bde1b7077d9137478a6f081a876fbd4baa94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620350Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#842284}
-
Findit authored
This reverts commit d82af7a9. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 842133 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q4MmFmN2E5ZWVmYzI1ZGRmMTI0ZmMxMjg0YTM3NmVkYzdmZGNmNWMM Sample Failed Build: https://ci.chromium.org/b/8858364635543817904 Sample Failed Step: ash_unittests Original change's description: > ambient: construct photo_controller on enabled > > AmbientPhotoController and AmbientPhotoCache are only necessary > when a user is logged in and ambient mode is enabled. Construct them > at that time, and destruct them if ambient mode is disabled. > > Schedule fetching backup images when AmbientPhotoController is > constructed, rather than in OnFirstSessionStarted. > > BUG=b:176094707 > TEST=ash_unittests --gtest_filter="AmbientControllerTest.*" > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Id87bb16e6d4cc14074dd9bdb352fb5795d0f8915 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605744 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842133} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=b:176094707 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ieccf27239a7fb618deb72fe6ebe9519462df7add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623527 Cr-Commit-Position: refs/heads/master@{#842283}
-
Toni Barzic authored
Handling button press may delete the button view, so referecing the hover button after button press callback is called is not safe. BUG=1142568 Change-Id: I4b062cfc1ca632bf590df7892b58592680a38ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618577 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#842282}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/79f0fe5f0ec1..b2230ba88f16 2021-01-11 heiserya@google.com Update mojo_connection_lacros_launcher.py path to reflect installed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: sadrul@google.com Change-Id: I8b9ec8df0b4ced04deb60390940d9ae04ad131ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623239Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842281}
-
Victor Fei authored
Before this change, if we set modal="true" and role="dialog" for an AccessibleNode, the corresponding AXNode always has state modal="false". This CL fixes the above issue, by moving the logic of AXNodeObject::IsModal to AXObject so that AXVirtualObject can properly calculate dialog modal status. With this change if we set AccessibleNodes to be role="dialog" and modal="true", it now properly shows modal=true in the AXTree for the corresponding node. AX-Relnotes: n/a. Change-Id: I35e802887b7153b7d619718dc39f79a15d4cb809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619903 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842280}
-
Sara Kato authored
Bug: crbug.com/1159562 Change-Id: I6a7cf914b2f2b5c35afc5d4a48025a2aaef033c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612673Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#842279}
-
Khushal authored
This was added for Pixel 4 rollout, to have a kill switch in case rendering at higher rates has any issues. The flag is not necessary anymore. R=boliu@chromium.org Change-Id: I4dc804fee6ab162cd7dd0f5186c7f7faef41ed3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622520 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842278}
-
ssid authored
Change-Id: I160ed2450bdc3b99e1ac7047a75e69928b8f679a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622893 Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#842277}
-
Yuichiro Hanada authored
This is a reland of e73788df The original change was reverted due to the input lag. The root cause was fixed in Android side. Please also refer to go/cros-postmortem-input-lag Original change's description: > Enable ArcPreImeKeyEventSupport by default. > > Bug: b:148193316 > Test: tast run arc.PreImeKeyEvent > Change-Id: I8ba1437e5a94f3a251d9a7e658df2d995ddd3dec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391184 > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804664} Bug: b:148193316, b:174430314, chromium:1153410 Change-Id: Ic23006790fd4d5a26324acf4263616a55f383e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599683 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#842276}
-
Alan Ding authored
Provide chrome switch to disable GMS scheduling of MediaStore periodic indexing and corpora maintenance tasks. Used in performance tast to prevent running service during testing which can cause unstable results or CPU not idle pre-test failures. BUG=b:173906243 BUG=b:170071013 BUG=b:172010486 BUG=b:153866893 TEST=Used local build with https://crrev.com/c/2596242 to verify using 'getprop' that boot property is only available if chrome switch is set. Change-Id: I72704a9814061af172e5f9a892513e0f414d31a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597193 Commit-Queue: Alan Ding <alanding@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842275}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026943fd29be..53a231c0ae86 2021-01-11 treehugger-gerrit@google.com Merge "tp: Add drop if exists for all metric table/views" 2021-01-11 lalitm@google.com tp: bump versions of trace processor and traceconv If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I08608f7dcb10f9e5272867d3fa1a536f9a54f4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623237Reviewed-by:
-
Pawel Pluciennik authored
Target "//content/shell:content_shell" added to deps blocked compiling content_browsertests sources. Bug: chromium:1164349 Change-Id: Id87106b2d3197c04d66fcb06e55d3421022249fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616226Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#842273}
-
Dirk Pranke authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/0d67e272..595e3be7 595e3be7 Find python/python3 from dotfile entries Bug: chromium:1112471 Change-Id: Iaa80f88464845094a73f4e312b445dc32b963caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622896Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#842272}
-
Kenton Lam authored
A basic emoji_ordering.json was used for testing while we were waiting for emoji-metadata to be imported into third_party. Now that that is done, we can directly use the emoji ordering from there. Bug: 1152237 Change-Id: I70b58f2b6ebe712b3fad0fdb7a2a5ee2af466779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617409Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#842271}
-
Akihiro Ota authored
Consider the following scenario: Voice1.lang = "en-us" (all lower case) Voice2.lang = "en-US" (country code is upper case) Utterance.lang = "en-us" (all lower case) The user has set Voice2 as their preferred voice for English. The old code would choose voice1 as the best voice for the utterance because voice1.lang == utterance.lang. voice2.lang != utterance.lang because of the difference in casing. This was leading to issues in ChromeVox's voice switching behavior, where eSpeak was sometimes being used, even if the user had set Chrome OS US English as their preferred voice. The tangible effect of this change is that ChromeVox voice switching will respect the user's preferred voices. voices. --gtest_filter="TtsControllerTest.TestGetMatchingVoice"'. Also manually verify the bug no longer repros after the fix. Fixed: 1121592 AX-Relnotes: ChromeVox voice switching now respects the user's preferred Test: 'out/cros/content_unittests Change-Id: I0588b50fbbc4ee7f0b71741b2bb312c9d6d5b14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617511 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#842270}
-
Phillis Tang authored
Remove |FeaturePromoBubbleView::GetBubbleBounds| override as it's not needed anymore. Change-Id: I0c8ebd04982889842494c7a85b68f902a0832b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622733 Commit-Queue: Phillis Tang <phillis@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#842269}
-
Elly Fong-Jones authored
This change has RootView::AnnounceText (which is what the other Views methods to announce text use) call the platform API on Mac, via AXPlatformNode. To test this, build `views_examples_with_content` and press the button on the "Accessibility Features" page - you should hear and see VoiceOver announce "Button pressed". Bug: 1157157 Change-Id: Ia0845e29b86eb66411cd45399ba0ef340537b92c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618620 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#842268}
-
Sophie Chang authored
This also makes the component available on incognito (which was an oversight in previous support to have optimization hints be in incognito) Bug: 1154790 Change-Id: I97a427d5af0f94fa0b5282032b8cef6ce754c81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617866Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842267}
-
John Abd-El-Malek authored
Bug: 1163455 Change-Id: I48a495ef9d0cca362df9518ae952be7e80b14ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622892 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Initially the OneGoogleBar iframe is hidden. After the OneGoogleBar is loaded in the iframe, the iframe sends a 'loaded' message to ntp-app. ntp-app sets the clip-path style to the #oneGoogleBarClipPath with no rects defined (no part of the OGB is shown). It's possible to get into a broken state that stops processing changes to the OneGoogleBar. The changes seem to be paused until some part of the iframe is showing in the content area. The changes that pause I think are related to resize. From my testing, ResizeObserver and window 'resize' callbacks are not called until some part of the iframe is visible in the content area. This effect is not limited to clipPath and also includes when the iframe is scrolled out of view. This CL introduces an initial rect that will show the OneGoogleBar once loaded. It is immediately replaced with the rects sent by the iframe's 'overlaysUpdated' message. Bug: 1164733 Change-Id: I25f4bb4e448777216d78e29c1c7d645eac6f2985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621979 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#842265}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fff8e7632e28..bdc7f626dbce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8229d8f86998ce94a390ad3aea6c389a56554b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623154Reviewed-by:
-
Mitsuru Oshima authored
Bug: 1158058 Test: Added DCHECK. Updated the test to workardound the issue (crbug.com/1065281) Change-Id: I47e2c96a636d574c814df622e1b15f347053eddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622660 Auto-Submit: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#842263}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b90a077d51ec..4f62c670fe0c 2021-01-11 michael.liao@microsoft.com [Icon]: Change dropdown arrow to svg and add dark theme dropdown arrow If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1164031 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icd484ecbe036cce77fa658f954c3d3d7331ef7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623236Reviewed-by:
-
Mila Green authored
Bug: 1128060 Change-Id: I787b44462a2154119e256725fd7b8bcac7d9f74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617868Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
-
Collin Baker authored
This is a reland of e4a4b7a3 Fixes null dereference bug Original change's description: > Replace ThumbnailImage::Observer with Subscriber > > Previously, clients interested in seeing thumbnail updates had to > derive from ThumbnailImage::Observer and register themselves with > ThumbnailImage. > > Removing ThumbnailTabHelper and ThumbnailImage from the public API and > instead exposing a global ThumbnailService is a design > goal. ThumbnailImage::Observer makes this refactor difficult. > > This CL uses a callback-based subscriber model instead. > base::Callbacks replace observer methods. Hints are supplied > directly on the subscription object. The subscription models loosens > the coupling between clients and ThumbnailImage. > > Clients subscribe by ThumbnailImage::Subscribe(). Subscription can > later be pushed up easily to the ThumbnailService level by a method > like ThumbnailService::Subscribe(content::WebContents*). > > Bug: 1090038 > Change-Id: I020d848e00331d5f5bbb562f0c53aec5f8ccbc62 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593158 > Reviewed-by: Dana Fried <dfried@chromium.org> > Reviewed-by: John Lee <johntlee@chromium.org> > Commit-Queue: John Lee <johntlee@chromium.org> > Auto-Submit: Collin Baker <collinbaker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837818} Bug: 1090038 Change-Id: I3d93fc36d9725c088ba684188265df1ad1fd0905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612046 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#842260}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610376073-6f28b769fbc009549335371d81a980da57e0e846.profdata to chrome-win32-master-1610387594-3b3bb0a15d14b239dcb6d81b73ae08ab0d827c57.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2aae6c5bcdcc2146dbd9a52bef1acbc7b4289d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623232Reviewed-by:
-
Yao Xiao authored
What: Previously, a page in the history database is eligible for floc computation iff the IP was publicly routable. This CL adds another condition: either the page has an ad resource or the floc JS API is used in the page. Why: This is the new expected behavior. We want a default opt-in scope (i.e. page with ad resource) and a force opt-in mechanism (i.e. use of the JS API). How: Add a FlocEligibilityObserver that monitors page navigations, resource usages, and the floc API call. When the required conditions are met, it will call the new HistoryService API to set the "floc_allowed" bit for that page visit. Add FlocPageLoadMetricsObserver as the intermediate observer to observe "is publicly routable" and "has ad resource", and notify the FlocEligibilityObserver about those signals. Bug: 1162874 Change-Id: I19d7a887446df7b4bc165e982fc0d8f2ba781005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609789Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#842258}
-
Natalie Chouinard authored
Bug: 927655 Change-Id: I8b17e802e5c419f3d6179d690199d328f9792efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623028 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#842257}
-
- 11 Jan, 2021 12 commits
-
-
Peter Kasting authored
Bug: 1159562 Change-Id: Ie663d63641be29ac489d9cad30c7eb7b008d3745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623153 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
-
Jan Krcal authored
This CL adds a user action for the impression of the sign-in promo which is part of the new profile creation flow. Bug: 1126913 Change-Id: Ia10c218ea298858947dc8f41da667f801ca5055e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610097Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#842255}
-
Alan Cutter authored
This CL updates the default app pinned orderings to include web app variants of deprecated default Chrome apps. Without this change the new default web apps won't be pinned by default like their Chrome app counterparts. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=484094&signed_aid=UahZXk-auD7dIwQMbbhW_g==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=484095&signed_aid=LpFClJ6IhPzK__KzrVdyLA==&inline=1 Bug: 1162986 Change-Id: I8598faa868d2883b9e3c5c9168c0bde773df592b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620820 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842254}
-
Becca Hughes authored
Update the autoplay documentation to reference the policy. BUG=1152627 Change-Id: I29ff788463b4db88389cb87a2c23de9d1f6580fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622662 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842253}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610376073-2cb1d075a5ed746f73a3a1ee8fa077d597a4f418.profdata to chrome-win64-master-1610387594-34ec7be13acbaa9470ba5363f8af27b0c42697d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5df4ed971fde79be151ba4ba5e8fe9a71052d4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623231Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6a59d064a975..3549479dc4cc 2021-01-11 srisser@google.com Define static constexpr members in .cpp files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I10be5e0be20eb5a428375f8707bb1081730247a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622798Reviewed-by:
-
Mihai Sardarescu authored
The hosted domain is already stored in the AccountInfo (managed by the AccountTrackerService). This CL removes the preference |kGoogleServicesHostedDomain| as it holds duplicated information. Note: There is a slight change of behavior as GaiaInfoUpdateService::UpdatePrimaryAccount may no longer be called on start-up if the hosted domain is missing. This may lead to the profile info cache not being updated if the application crashed after the AccountInfo was stored on disk, but before the ProfileInfoCache was stored on disk (in production code, this is impossible as the GaiaInfoUpdateService updates the primary account information as soon as AccountInfo is updated by the AccountTracker). Bug: None Change-Id: I6c7697d55528198a86f2a8a1612407c4f8807817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617704Reviewed-by:
-
Matt Giuca authored
This CL: - Hides the Extensions icon in web app windows unless the Extensions menu is opened. - Adds an "Extensions" menu item to the web app three dot menu to open the Extensions menu. Bug: 1155421 Change-Id: I474a6ced0e7dd7893317bff4d4b1d8256957d80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620721 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#842249}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c1aa4ecfcc8c..722b81ef1350 2021-01-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: Iea101b47439a6da78f7b5fdf60a92ff3d31e8a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623235Reviewed-by:
-
Hiroshige Hayashizaki authored
Supressing failures while waiting for fix: https://chromium-review.googlesource.com/c/chromium/src/+/2622282 Bug: 1165324 Change-Id: I9ae0e2f38a3d0d17a6479da66907bf1dfcb9f05a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623112Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#842247}
-
Ahmed Fakhry authored
Screen recording should respect apps that request to make their surfaces secure via HDCP; i.e. video recording should not be allowed to begin while protected content is on the screen, and should not be allowed to continue if protected content appears while recording. BUG=1157997 TEST=Manually on DUT, added unit tests. Change-Id: Ia531ac8c3bd3c5374e1c6dc0487b38a218daf6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618960 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#842246}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0ccd38b2dfb..36267de97e83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hiroshige@google.com,yiyix@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1163679,chromium:9122681 Tbr: hiroshige@google.com,yiyix@google.com Change-Id: Ie9480075a13d177bf75edd833c6abbd9bf46531c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622955Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842245}
-
