GitLab

* Combines duplicate certificate chains that were named with "-ok" vs "-fail" (these predated ability to set expectations in .test files)

* Adds .test files for each chain for ANY_EKU, CLIENT_AUTH and SERVER_AUTH

Review-Url: https://codereview.chromium.org/2931053002
Cr-Commit-Position: refs/heads/master@{#481772}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/326eb241976e..e810453155c3

$ git log 326eb2419..e81045315 --date=short --no-merges --format='%ad %ae %s'
2017-06-22 dtu [pinpoint] Reduce Isolate key hash length from 512 to 256.
2017-06-22 erikchen Fix periodic dumping for memory-infra on Android.
2017-06-22 benjhayden Fix a memory leak in results.html.
2017-06-22 benjhayden Document significance in metrics-results-ui.md.
2017-06-22 eakuefner [Dashboard] Create corresponding rows for histograms
2017-06-22 benjhayden Fix and test histogram-set-table.leafHistograms.
2017-06-22 benjhayden Fix and test sorting by delta statistics.

Created with:
  roll-dep src/third_party/catapult
BUG=735124


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I20f82210195a3eba6600d6da3b14aa52513421d9
Reviewed-on: https://chromium-review.googlesource.com/545166
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481771}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b068de4b..4162e53c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2953893002
Cr-Commit-Position: refs/heads/master@{#481770}

It's failing on Mac 10.9, see https://crbug.com/734762#c11.

TBR=dgozman@chromium.org

Bug: 734762
Change-Id: I73185ad9b21f34c61976b93d02fa3ceb278d8027
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/544365Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481769}

This is temporary while we get Mac-10.12 on Intel GPU working.
During this time it will let us accurately compare 3 configurations;

 * Mac 10.9  with GPU-None  -- Currently broken
 * Mac 10.12 with GPU-None  -- Currently working
 * Mac 10.12 with GPU-Intel -- Currently broken

BUG=524758
TBR=qyearsley@chromium.org,dpranke@chromium.org,mcgreevy@chromium.org,jeffcarp@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2957503002
Cr-Commit-Position: refs/heads/master@{#481768}

This CL is part of the Mojo Video Capture work.
Design doc for dev work [1].
Design doc for launch [2].

BUG:584797,721812

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
[2] https://docs.google.com/document/d/1RLlgEdvqRA_NQfSPMJLn5KR-ygVzZ2MRgIy9yd6CdFA/edit?usp=sharing

Change-Id: I38b83efdf1e8619e3edba95df70a6b5fdae30a3f
Reviewed-on: https://chromium-review.googlesource.com/524298Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481767}

TBR=nednguyen

Bug: 736150
Change-Id: I23937789dfdd4620fa4f7ea3a96ea2fa59349d87
Reviewed-on: https://chromium-review.googlesource.com/545199Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481766}

Bug: 736125
Change-Id: Icb66b30de6a7a9b2da77a2a733c9b889871edf6e
Reviewed-on: https://chromium-review.googlesource.com/544448Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481765}

The approach ends up pretty close to what's already done for Windows.

On Mac, CTFontCreateForString() gives better fallbacks (i.e. they more
often match what native UI does) and requires RenderTextHarfbuzz to do
less work. However, it doesn't guarantee that the returned font can
display every glyph in the provided string.

So still use CTFontCopyDefaultCascadeListForLanguages (which is now a
public API - hooray) to provide a last-resort list of fallback fonts.

This CL causes a font used for Hebrew text in a test to change, which
tickled a pre-existing bug/corner case in the test for some macOS
versions.

BUG=696867, 619684, 735346

Previously landed in r481062, but tickled some OS-specific tests due to
a valid discrepancy between rounding directions.

Review-Url: https://codereview.chromium.org/2927953003
Cr-Commit-Position: refs/heads/master@{#481764}

BUG=735534
TEST=Repeat crashes when not in Incognito mode show the advice to try
Incognito mode. However the same test performed when in Incognito mode
should not offer this advice as one of the bullet points.

Review-Url: https://codereview.chromium.org/2949833005
Cr-Commit-Position: refs/heads/master@{#481763}

This CL was mostly generated mechanically with:
  $ git grep -l -i helper.*webview.*mainframeimpl -- third_party/WebKit/Source \
      | xargs -n 1 sed -i -e \
        's/helper\.WebView()->MainFrameImpl()/helper.LocalMainFrame()/g'
  # same as above, but with "helper_." instead of "helper."
  $ git grep -l -i helper.*webview.*mainframeimpl -- third_party/WebKit/Source \
      | xargs -n 1 sed -i -e \
        's/helper_\.WebView()->MainFrameImpl()/helper_.LocalMainFrame()/g'
  $ git cl format

The only manual change was to change the constness of WebViewHelper's
LocalMainFrame and RemoteMainFrame accessors.

BUG=416660

Review-Url: https://codereview.chromium.org/2945093002
Cr-Commit-Position: refs/heads/master@{#481762}

When showModal is called on a <dialog> element, the rest of the
Document becomes inert which prevents it from receiving events or taking
focus. When the Document contains an out-of-process iframe, however, its
contents are not aware of the modal dialog in a remote ancestor.

This CL caches the current inert state on each LocalFrame, which is
changed when a modal dialog because active or inactive. The bit is
plumbed to remote frame children so that OOPIFs will respect inertness.

Also it prevents having to search up the entire frame tree when an
element checks whether it is inert.

BUG=719788
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2883033003
Cr-Commit-Position: refs/heads/master@{#481761}

URLRequests can't outlast the URLRequestContext that spawned them, so
the current code can cause crashes on NetworkContext destruction.

BUG=735995

Review-Url: https://codereview.chromium.org/2951293002
Cr-Commit-Position: refs/heads/master@{#481760}

This reverts commit 861dba53.

Reason for revert: Broke blink_platform_unittests and webkit_unit_tests on WebKit Win x64 Builder (dbg).
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win%20x64%20Builder%20(dbg)/110174
https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Win%20x64%20Builder%20(dbg)/110175

Original change's description:
> Reland "[SPv2] Rework GeometryMapper transform computation"
> 
> This is a reland of afc31e81
> Fixed Windows x64 build failure. DLL export needs to be specified on
> individual explicit template instantiation:
> https://docs.microsoft.com/en-us/cpp/cpp/general-rules-and-limitations
> 
> Original change's description:
> > [SPv2] Rework GeometryMapper transform computation
> > 
> > When computing the conversion matrix between two spaces, there are two
> > types of conversion that are commonly used, but with slightly different
> > semantics:
> > 
> > m1 = destination_to_screen ^ -1 * source_to_screen
> > m2 = flatten(destination_to_screen) ^ -1 * flatten(source_to_screen)
> > 
> > The former computes the space conversion, which is useful for mapping
> > 3D points from one space to 3D points in another space. The latter
> > computes the "projection through screen", which is useful for mapping
> > 2D points from a plane to a backing that is expected to be drawn onto
> > the screen.
> > 
> > To illustrate the difference, see the following example:
> > <div style="transform:rotateY(45deg)">A</div>
> > <div style="transform:rotateY(-45deg)">B</div>
> > 
> > The space conversion from A to B is equal to rotateY(90deg), but the
> > projection between the two planes is identity.
> > 
> > Prior to this CL, GeometryMapper implemented a mixed semantics. This is
> > okay because all existing code only make queries that are co-planar, in
> > which case, either version returns identical result. This is because we
> > only make intra-compositing-layer queries, and 3D transform makes a
> > compositing boundary.
> > 
> > This CL changed the implementation to strictly return the "projection
> > through screen". The algorithm runs in amortized O(1) by caching the
> > matrix between a node and its nearest coplanar ancestor that has a
> > invertible projection.
> > 
> > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Change-Id: Ia526dc6feb60c902f27589d73e78dfea235c6a93
> > Reviewed-on: https://chromium-review.googlesource.com/534899
> > Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> > Reviewed-by: Chris harrelson <chrishtr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#481049}
> 
> Change-Id: I067a0f40f2e41a9fc282c4014975f144417d7d3b
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/543897
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Reviewed-by: Chris harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481688}

TBR=trchen@chromium.org,chrishtr@chromium.org

Change-Id: Iccc3418e798df1de4c9f907ea66868c61a355db8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/544449Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481759}

Important sites could be a performance hit, especially because it might
hit disk w/ content settings querying, enumerating all bookmarks, etc.
This change lets you disable that.

BUG=732907

Review-Url: https://codereview.chromium.org/2953853002
Cr-Commit-Position: refs/heads/master@{#481758}

Also reduce the block cache size used by localstorage.

TBR=primiano@chromium.org

Bug: 730475
Change-Id: I3439508d57a54d09d98df8cd2191448720ab19b8
Reviewed-on: https://chromium-review.googlesource.com/543439
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: siddhartha sivakumar <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481757}

Previously, the notifications stayed around after they were tapped; this made it possible to interact with them later at a time when they may be stale.

BUG=672263,730247

Review-Url: https://codereview.chromium.org/2953973002
Cr-Commit-Position: refs/heads/master@{#481756}

These tests verify that browsing data (cookie, localStorage) does not
leak between incognito and non-incognito web views.

BUG=None

Review-Url: https://codereview.chromium.org/2945563002
Cr-Commit-Position: refs/heads/master@{#481755}

Currently, there are a few keyword fields that also specify field_size.
This is misleading, because the size for keyword fields are
automatically calculated from the number of keywords, so field_size is
ignored.

This patch removes any references to field_size in keyword fields. It
also adds an assert in make_computed_style_base to prevent this from
happening in the future.

This patch does not change generated code.

Bug: 628043
Change-Id: Ie9e6bb17d084d8dc96811b2ab2ab76c0c8849e0e
Reviewed-on: https://chromium-review.googlesource.com/540935
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481754}

[CrOS Tether] Move LocalDeviceDataProvider from //chromeos/components/tether to //components/cryptauth.

This functionality is not logically coupled to the Tether component and will be used in other CryptAuth-related projects.

See a sample usage of this change as part of https://codereview.chromium.org/2953863002.

BUG=672263

Review-Url: https://codereview.chromium.org/2951303002
Cr-Commit-Position: refs/heads/master@{#481753}

On Android, the properties of what to show in the FRE are calculated
the first time it is launched.  If you leave in the middle and Chrome
is killed, we use the same properties to show it again.  For the search
engine promo, you can get your phone in a state where it is no longer
valid to be shown.  In this case, we should ensure the state is still
valid before attempting to enqueue the search engine promo screen.

BUG=736112

Review-Url: https://codereview.chromium.org/2949393002
Cr-Commit-Position: refs/heads/master@{#481752}

This patch changes |SelectClosestMisspellingFromHitTestResult()| in
|SelectionController| class to utilize early-return style for improving
readability.

# Details
|SelectClosestMisspellingFromHitTestResult() calls
|UpdateSelectionForMouseDownDispatchingSelectStart()| with non-null
|VisibleSelectionInFlatTree| if |pos.IsNotNull()| and
|marker != nullptr| are true, other wise this function calls null
|VisibleSelectionInFlatTree|.

Because |VisibleSelectionInFlatTree::AppendTrailingWhitespace()| appends a
whitespace only if selection is range, we don't need to call it for null
selection.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2952173002
Cr-Commit-Position: refs/heads/master@{#481751}

This patch makes |VisiblePosition::AfterNode()| to take |const Node&| as
|Position::AfterNode()| for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2950273002
Cr-Commit-Position: refs/heads/master@{#481750}

This fixes an issue where the multi-select toolbar would still appear
after the selected items had been moved to a different folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2946883002
Cr-Commit-Position: refs/heads/master@{#481749}

Revert of Enable ThinLTO for POSIX LTO by default on Linux. (patchset #2 id:20001 of https://codereview.chromium.org/2939373002/ )

Reason for revert:
Breaks chromium.perf builder.

BUG=735651

Original issue's description:
> Enable ThinLTO for POSIX LTO by default on Linux.
>
> This is a reland of the remaining part of
> https://codereview.chromium.org/2831213006 .
>
> The binary size regression has been addressed by disabling ThinLTO
> whole-program optimizations and improving the quality of unoptimized
> code.
>
> BUG=660216
> R=thakis@chromium.org,hans@chromium.org
>
> Review-Url: https://codereview.chromium.org/2939373002
> Cr-Commit-Position: refs/heads/master@{#480144}
> Committed: https://chromium.googlesource.com/chromium/src/+/5cb9983f12f300422c16ba812c2d5cdeb278cb74

TBR=hans@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=660216

Review-Url: https://codereview.chromium.org/2953943002
Cr-Commit-Position: refs/heads/master@{#481748}

Native heap profiling can now be run on official builds by setting a
chrome://flag.

BUG=

Review-Url: https://codereview.chromium.org/2949353004
Cr-Commit-Position: refs/heads/master@{#481747}

When the focused window is chrome browser and
not blocked profile, the URL will be sent along
with the voice interaction tree.

Also the browser's window position is sent. This
hopefully could benefit metalayer detection.

BUG=b:62872370
TEST=manual test with debug tool

Review-Url: https://codereview.chromium.org/2952293002
Cr-Commit-Position: refs/heads/master@{#481746}

Changes:
(1) Create IndicatorChipView, as it is needed for both suggested apps
and all apps.
(2) add 24px top padding for search box on start page.
(3) change start page search box width to 544px.
(4) 21px padding between search box and indicator.

WIP screenshot: https://screenshot.googleplex.com/XqW9ZXqVVnO
Note: tiles layout are not updated yet.

R=xiyuan@chromium.org
CC=newcomer@chromium.org
BUG=734164
TEST=tested with and without --enable-features=EnableFullscreenAppList
flag

Review-Url: https://codereview.chromium.org/2952303002
Cr-Commit-Position: refs/heads/master@{#481745}

Do this even without --secondary-ui-md, since we blacklisted non-MD
dialog buttons for secondary UI in r478352.

NSColor doesn't offer a color for prominent buttons. Use the Aura color,
but apply the system tint. This is a good match for the blue Cocoa uses
to draw buttons that are given a \n key equivalent.

BUG=732889

Review-Url: https://codereview.chromium.org/2948083002
Cr-Commit-Position: refs/heads/master@{#481744}

Bug: 733175,420198,420606,450639
Change-Id: I575ef6c633111c64420de7e7b3434c269066cddf
Reviewed-on: https://chromium-review.googlesource.com/540268Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481743}

Fuchsia doesn't (currently? uncertain) support mprotect(...NONE...).
Work around this by using native apis to create a memory block and a
virtual memory mapping, and then leaving a guard page unmapped at the
end of the mapping.

Bug: 706592
Change-Id: I5329cf9206e5aa8056edf0cfb50b8745b9d1c83e
Reviewed-on: https://chromium-review.googlesource.com/545155
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481742}

The firewall checks weren't running before, and with the upcoming COM
initialization change for TestBrowserThreadBundle, they'll suddenly
start running, changing all of the assumptions for the
MediaRouterMojoExtensionTest.

This change disables firewall checking for tests.

BUG=735725

Change-Id: I6e6760ab42cf9d5180cfa33028fb3fb973a45f1f
Reviewed-on: https://chromium-review.googlesource.com/544900Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481741}

Revert CL: https://codereview.chromium.org/2948943003

This Cl is to revert the revert, since the issue has been identified and not related. Detailed in crbug.com/735574

BUG=734265
TBR=mathp@chromium.org, rkaplow@chromium.org, pkasting@chromium.org, sebsg@chromium.org

Review-Url: https://codereview.chromium.org/2711543002
Cr-Commit-Position: refs/heads/master@{#481059}
Committed: https://chromium.googlesource.com/chromium/src/+/b0045cb0dec61387b7cc05049c2878b406bc298b

patch from issue 2711543002 at patchset 700001 (http://crrev.com/2711543002#ps700001)

Review-Url: https://codereview.chromium.org/2951293003
Cr-Commit-Position: refs/heads/master@{#481740}

During GPU process teardown, the GpuCommandBufferStub clears the
current surface.  ScopedMakeCurrent doesn't handle this case well.

Since the process is going away, we just skip GL cleanup.

Bug: 718117
Change-Id: I04dce5d60fbe9d3f6c060c161029d7ec724ecdb0
Reviewed-on: https://chromium-review.googlesource.com/544381Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Chris Watkins <watk@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481739}

On low-DPI displays, the pointer surface was being scaled up using
bilinear filtering, resulting in a slightly blurry cursor. This CL
sets the capture scale to the largest DSF instead of a constant.

BUG=730843
TEST=minnie,caroline: Cursor is sharp on all displays.

Review-Url: https://codereview.chromium.org/2933133002
Cr-Commit-Position: refs/heads/master@{#481738}

The __isnanf only exists on android 21+, so provide a fallback for the
fallback for versions 16-20.

BUG=735003

Review-Url: https://codereview.chromium.org/2945293002
Cr-Commit-Position: refs/heads/master@{#481737}

As part of PTS/DTS compliance, SourceBufferRange will need to
understand its presentation interval and understand whether or not a
subsequent keyframe is "continuous" with the end of that interval. This CL adds
tracking of the range's frame with highest PTS, adds a method (for test usage
only at the moment) to query whether or not a frame is continuous in PTS with
the end of the range, relocates IsNextInDecodeSequence to private scope, and
adds some better comments. It also adds some unit tests exercising the new
behavior.

This change does not switch over to using PTS for actually managing
buffered ranges, but significantly prepares for that to happen in later
CL(s).

BUG=718641

Change-Id: Iabd19071032d4508abbb9c62a5f7c897d334670b
Reviewed-on: https://chromium-review.googlesource.com/541586
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481736}

Fix thread safety issues with safe browsing DB.
The Safe Browsing DB has some sequence consistency issues, which
is caught by the stricter WeakPtr semantics detailed on CL 2908073007.

* Delete SafeBrowsingDatabaseManager on IO thread.
* Remove illegal dereferencing of IO-thread WeakPtr from DB thread in
  V4Database::VerifyChecksumOnTaskRunner
* Remove non-threadsafe accesses of |io_thread_| resident members from
  the DB thread in V4LocalDatabaseManager.
* Add IO-thread runloops to unit tests to handle database teardown.


R=nparker@chromium.org
CC=wez@chromium.org

Bug: 729716
Change-Id: I1bc620d42aca2f1cc99e482b7776a628d783d390
Reviewed-on: https://chromium-review.googlesource.com/523983
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481735}

This reverts commit a4d28004.

Reason for revert: Test is flaky failing due to UKM not getting enabled consistently.

Original change's description:
> Disable UKM in incognito mode.
> 
> Add explicit checks to make sure UKM is disabled in incognito mode,
> and add browser tests to check that behavior.
> 
> Bug: 734091
> Change-Id: Ib772d5bd5231b9ce50b3468eef213fff2f9393e5
> Reviewed-on: https://chromium-review.googlesource.com/537774
> Commit-Queue: Steven Holte <holte@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Reviewed-by: Louis Romero <lpromero@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481321}

TBR=rkaplow@chromium.org,msramek@chromium.org,holte@chromium.org,lpromero@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 734091
Change-Id: I88d012477473581ce72280e859995f898ffb5087
Reviewed-on: https://chromium-review.googlesource.com/545175Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481734}

Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (patchset #2 id:20001 of https://codereview.chromium.org/2950933003/ )

Reason for revert:
Reverting. Failed to update all perf Mac Builder slaves to 10.12.

Original issue's description:
> mac: Roll hermetic toolchain to Xcode 8.3.2.
>
> Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
> 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.
>
> To support machines running macOS versions < 10.12, but don't require building
> targets, this CL also:
>   * Does not download the hermetic toolchain if the macOS version does not
>     support the toolchain version.
>   * Does not allow building targets with the default hermetic toolchain if the
>     macOS version does not support the toolchain version.
>
> BUG=624049
>
> Review-Url: https://codereview.chromium.org/2950933003
> Cr-Original-Commit-Position: refs/heads/master@{#481225}
> Committed: https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e9ceb72d29c8e
> Review-Url: https://codereview.chromium.org/2950933003
> Cr-Commit-Position: refs/heads/master@{#481692}
> Committed: https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea5719890e7af365

TBR=dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624049

Review-Url: https://codereview.chromium.org/2957483002
Cr-Commit-Position: refs/heads/master@{#481733}