- 14 May, 2018 2 commits
-
-
Noel Gordon authored
Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN. Bug: 836254 Change-Id: Ie6ca28f923dcf70be407c8782985195874f47758 Reviewed-on: https://chromium-review.googlesource.com/1056748Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558168}
-
Noel Gordon authored
Remove TODOs (found a better way to address this in future changes). Comment only change. No-Try: true Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibfb73d564964afbaca95ac4b1125a084a7939691 Reviewed-on: https://chromium-review.googlesource.com/1056767Reviewed-by:
-
- 13 May, 2018 20 commits
-
-
Noel Gordon authored
Remove unused #include. Also update to copyright notice per style. Bug: 836254 Change-Id: Icb7bcec55d20535cdd2f0f5eb49bd1c3e22ca2ca Reviewed-on: https://chromium-review.googlesource.com/1056747Reviewed-by:
-
Jinsuk Kim authored
https://crrev.com/c/517683 introduced a bug in accessibility mode when page scale factor is not 1. Before the patch, the hover event coordinate is converted to CSS (https://goo.gl/ER8wu5) but after the patch the unit was DIP by mistake. (https://goo.gl/ER8wu5). This CL fixes it by applying the page scale factor to set the unit right to CSS. Bug: 840609 Change-Id: Iaa17882e2ffb2d5637e59df1ebe7cf677f4a76a3 Reviewed-on: https://chromium-review.googlesource.com/1055067 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558165}
-
Bence Béky authored
This platform directory is meant to make sharing code easier. //net/spdy is not shared, no need to use platform there. This change is git cl formatted. Change-Id: Ic83a923a75815c01e0eb819eeb77c669c1a54d27 Reviewed-on: https://chromium-review.googlesource.com/1054524Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#558164}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie524ebb911d34d88897b64101c6670ef486c18d6 Reviewed-on: https://chromium-review.googlesource.com/1056261 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558163}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ec48812c5a54..b06a1eb4e579 $ git log ec48812c5..b06a1eb4e --date=short --no-merges --format='%ad %ae %s' 2018-05-13 reed detect overflow for morphology Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I59a42f2941b8bf69196cc27d6ae9337e1b88a6ab Reviewed-on: https://chromium-review.googlesource.com/1056254Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558162}
-
Stefan Zager authored
BUG=841791 R=skobes@chromium.org Change-Id: I41ebc90803c4398aaaab3a8713e34fd3824595c5 Reviewed-on: https://chromium-review.googlesource.com/1055675Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#558161}
-
Wez authored
This reverts commit de03f4c9. Reason for revert: CL introduced a ReportingPermissionsChecker class which appears to be intended to safely "cancel" UI-thread work posted from the IO thread, when the class instance is destroyed. The class, however, is always destroyed on the IO thread, so this use of WeakPtrs does not have the intended effect. Original change's description: > Reporting: Use BACKGROUND_SYNC permission to control uploads > > We now use the BACKGROUND_SYNC permission to decide whether or not to > upload reports for a particular origin. Note that as currently written, > we don't use this permission to decide whether to *collect* the reports, > only whether to *send* them. Whether or not to collect is controlled > by the site's cookie settings. > > Bug: 704259 > Change-Id: I059019ab85106c26f4d156e9f5d61e2f8b8fa757 > Reviewed-on: https://chromium-review.googlesource.com/937572 > Reviewed-by: Ryan Hamilton <rch@chromium.org> > Commit-Queue: Douglas Creager <dcreager@google.com> > Cr-Commit-Position: refs/heads/master@{#540257} TBR=rch@chromium.org,juliatuttle@chromium.org,dcreager@google.com Bug: 704259 Change-Id: I9cb1990f4273f74e39de83b99a12e6bfc00e7348 Reviewed-on: https://chromium-review.googlesource.com/1056727 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#558160}
-
David Reveman authored
SetCursor should determine if cursor hotspot changed by looking at the last set hotspot and not the last captured hotspot. Bug: 842507 Test: exo_unittests --gtest_filter=PointerTest.SetCursor Change-Id: I98de185a618adeb440165f372d8127bbc0c4a6f0 Reviewed-on: https://chromium-review.googlesource.com/1056667Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558159}
-
Charlie Harrison authored
These methods aren't being used anymore. This CL also removes some tests which exercise these methods. This CL was split from https://chromium-review.googlesource.com/c/chromium/src/+/1055738 Bug: 842337 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo TBR=slan@chromium.org,jochen@chromium.org,sergeyu@chromium.org Change-Id: Ie695e2e1ab33cc13ebf8abc6e148251e0c4ec70c Reviewed-on: https://chromium-review.googlesource.com/1056108 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#558158}
-
Han Leon authored
This CL propagates change of registration's `updateViaCache` to corresponding registration objects in the renderer process to set their ServiceWorkerRegistration#updateViaCache attribute. BUG=675540 Change-Id: I6bb80dacbdd6a276f7ba8eb95f9f1e5379fbf03b Reviewed-on: https://chromium-review.googlesource.com/1002732Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558157}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xiyuan@chromium.org Change-Id: Ifef0be617da29fa1d39f06acbe6d578ac2c1a80f Reviewed-on: https://chromium-review.googlesource.com/1056121 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558156}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I4b7f7269d63430aa4e51cfd68593715f962bc825 Reviewed-on: https://chromium-review.googlesource.com/1056628 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558155}
-
https://pdfium.googlesource.com/pdfium.git/+log/82cb80962bc6..e20f0c4938f8 $ git log 82cb80962..e20f0c493 --date=short --no-merges --format='%ad %ae %s' 2018-05-13 hnakashima Add option to run safetynet_compare.py without a profiler. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idf631118eb7adb6160058fd46ca01dd43598567d Reviewed-on: https://chromium-review.googlesource.com/1056608 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558154}
-
Abhishek Arya authored
TBR=mmoroz@chromium.org,liaoyuke@chromium.org Change-Id: I7c192d6ef87ff08291574ba3c42aeeb8640d9306 Reviewed-on: https://chromium-review.googlesource.com/1056627Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#558153}
-
Alexey Baskakov authored
In low disk space scenarios, Cryptohome erases caches while target amount of free disk space is not reached. It starts from low priority categories. Cryptohome.DiskCleanupProgress histogram reports, which topmost priority was reached to fulfill a cleanup request. platform2 part: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1049986 We need to land this before Friday to get it working in M68. Bug: 835114 Change-Id: Ia89335ac64d2e94ae7298b24a96de8547d8e392e Reviewed-on: https://chromium-review.googlesource.com/1051209 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#558152}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I73e84b64b6842ff34c0f13530c9a21d7988ed8fe Reviewed-on: https://chromium-review.googlesource.com/1056021Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558151}
-
Dominic Farolino authored
Initial infrastructure changes to support Priority Hints. This includes adding a FetchImportanceMode enum to fetch_api_request.mojom, some supporting getters/setters to FetchParameters as well as ResourceRequest, and priority-modifying logic to ResourceFetcher. R=kinuko@chromium.org, yhirano@chromium.org, yoav@yoav.ws Bug: 821464 Change-Id: I5ab7f70f44e80d01b7d47ad4c00ae3f4817815ee Reviewed-on: https://chromium-review.googlesource.com/1053221 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#558150}
-
Jinsuk Kim authored
ByteArrayGenerator, CipherFactory are used by Chrome only, and don't have to be in content layer. This CL moves it to chrome directory, and deletes the corresponding DEPS exception rules. Bug: 617324 Change-Id: Iee5d8effe2148ef3e50375e8848048a58a0cc046 Reviewed-on: https://chromium-review.googlesource.com/1049769 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/96b0b46f2334..ec48812c5a54 $ git log 96b0b46f2..ec48812c5 --date=short --no-merges --format='%ad %ae %s' 2018-05-12 angle-skia-autoroll Roll third_party/externals/angle2/ 18e323ab2..66aafcb46 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Icc36391577d1663b3802986e38d96850f9a14e87 Reviewed-on: https://chromium-review.googlesource.com/1056063 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Dmitry Gozman authored
This is a reland of 500de904 Original change's description: > Merge WebClipboardImpl and Pasteboard into Clipboard > > Bug: 775830 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I3da04418bac37e0e03b63df4a8d2407296948e77 > Reviewed-on: https://chromium-review.googlesource.com/1045492 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557739} Bug: 775830 Change-Id: I921c9c3becf2acf3b169049656e898be6e4b8e1e Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1056427 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558147}
-
- 12 May, 2018 18 commits
-
-
Max Moroz authored
The test has been removed in https://chromium-review.googlesource.com/c/chromium/src/+/1053765 Bug: 789981 TBR=inferno@chromium.org,liaoyuke@chromium.org Change-Id: Ic27246e0e839557f5dab5a7238c166b16ab1dba2 Reviewed-on: https://chromium-review.googlesource.com/1056065 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558146}
-
https://chromium.googlesource.com/angle/angle.git/+log/18e323ab2cff..66aafcb4641c $ git log 18e323ab2..66aafcb46 --date=short --no-merges --format='%ad %ae %s' 2018-05-12 fjhenigman Revert "GLES1: Renderer (minimal)" Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ie5ec39db3634c878528158de50d635d80c62bd91 Reviewed-on: https://chromium-review.googlesource.com/1056062Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558145}
-
Wez authored
Bug: 838386 Change-Id: I614e823499c927704ed95d76103bf1e1c2c216f0 Reviewed-on: https://chromium-review.googlesource.com/1036445 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#558144}
-
Chris Harrelson authored
This is behind a new runtime-enabled flag called IntersectionObserverGeometryMapper. Bug:831762 Change-Id: I022e988d3abee45e767c04487e8e9662bfc109f2 Reviewed-on: https://chromium-review.googlesource.com/1055783 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
-
Daniele Castagna authored
crbug.com/789292 has been fixed, we can get rid of the log used to debug it. Additionally, the DCHECK on AddFramebuffer2 has been removed since it can fail for buffers imported via exo (crbug.com/779356) Bug: 779356, 789292 Change-Id: If25ed181dbbaabe8f1b3297c2cad3edf2bc689f5 Reviewed-on: https://chromium-review.googlesource.com/1056117Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#558142}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I4b682f120ac9aef13f63a1cb172e27fa676a4c34 Reviewed-on: https://chromium-review.googlesource.com/1056061Reviewed-by:
-
Daniele Castagna authored
AddFramebuffer2 can fail for buffers coming via exo. We should not use an invalid fb when pageflipping in those cases otherwise the GPU process will crash. Bug: 779356 Test: wayland_simple_client with crrev.com/c/1056018 Change-Id: I179ce2ddbe1fb5080f9d00989ccf96ddf3f94d68 Reviewed-on: https://chromium-review.googlesource.com/1056017Reviewed-by:
-
Nicolas Pena authored
This CL does the following: * Use TimeTicks instead of double in WebURLLoaderClient::DidFinishLoading and propagate. * Remove unused double from ThreadableLoaderClient::DidFinishLoading and from WebAssociatedURLLoaderClient::DidFinishLoading. Change-Id: If1eed191efe6c39d376f6d7c1a636bc9dcb79251 Reviewed-on: https://chromium-review.googlesource.com/1048137Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#558139}
-
Alexey Kozyatinskiy authored
With V8 side CL [1] we will start using proper break location instead of stack check location almost all the time, e.g. for async step-into and for a lot of DOM breakpoints. [1] https://chromium-review.googlesource.com/c/v8/v8/+/1054155 R=dgozman@chromium.org Bug: v8:7753 Change-Id: I550d4d43494df7abe8c5fcd0fbb1d08ca88364f6 Reviewed-on: https://chromium-review.googlesource.com/1055791Reviewed-by:
-
Lei Zhang authored
Currently, it only synthesizes a key char event, which is insufficient for the PDF plugin to produce the proper response. With the additional key up event, the PDF plugin will react correctly to keep the selected text state synchronized between the plugin and the renderer. BUG=841196 Change-Id: I331562d2f39facc9affdeac98d85306c09d56130 Reviewed-on: https://chromium-review.googlesource.com/1053164Reviewed-by:
-
Alexandros Frantzis authored
Add a parameter for an unowned GpuFence to the NativePixmap::ScheduleOverlayPlane() method. The parameter is unused at the moment, but will be used in upcoming commits to wire the overlay plane GpuFences in Ozone-DRM. Bug: 828393 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4697764c88a307b307af0ca5c1305e2d83cceec4 Reviewed-on: https://chromium-review.googlesource.com/1021737 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558136}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cfd0d899. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17392 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I0da577389513a1182cb6ec57555845e300c60d94 Reviewed-on: https://chromium-review.googlesource.com/1056016 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558135}
-
Erik Luo authored
This CL dismantles the side effect constructor blacklist, so Blink constructors (default, named, custom) all throw when evaluating with throwOnSideEffect. [Affects=Everything] is no longer a valid extended attribute. Constructors can still be invoked without side effects in one case: creating a DOM wrapper for the V8 object. Any whitelisted attribute/operation that returns an HTMLDivElement, for example, can call the constructor with ConstructorMode::kWrapExistingObject the first time it returns. Bug: 829571 Change-Id: I3ed2166da80d38a7835dc57a1ccaec23e22734e9 Reviewed-on: https://chromium-review.googlesource.com/1043655Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Stefan Zager authored
The viewport intersection shouldn't be updated for a force layout or other non-BeginMainFrame lifecycle update. BUG=842368 R=kenrb@chromium.org Change-Id: Ifd656b495e60e8b1413df8126c7b6ff95933abaf Reviewed-on: https://chromium-review.googlesource.com/1056491Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#558133}
-
Reid Kleckner authored
This reverts commit 646faed8. Reason for revert: These tests fail in official build configurations: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/84233 Original change's description: > Check that Channel ID is in use before providing Channel IDs to extensions > > Change-Id: Iabe9977651ec3e38f43d2495e790af508a43e0e5 > Reviewed-on: https://chromium-review.googlesource.com/1055676 > Commit-Queue: Nick Harper <nharper@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558096} TBR=rdevlin.cronin@chromium.org,nharper@chromium.org Change-Id: I4f0f2b194a709dd8b1a6cd690de60e24dacb7653 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1056567Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#558132}
-
erikchen authored
Change-Id: Icbfecced7e68f62c7f9eca0623ddf35a9a241c24 Reviewed-on: https://chromium-review.googlesource.com/1053960Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558131}
-
Antonio Gomes authored
Manual test: <out>/chrome --extensions-install-verification="enforce_strict" TEST=covered by existing tests. BUG=773295 Change-Id: I116d5c826935c6b5c6c9d062cf55422b7b1915f6 Reviewed-on: https://chromium-review.googlesource.com/1052867 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558130}
-
spqchan authored
Bug: 838303 Change-Id: Iba9ae89b36f711aec3e00b61fafd4c2e2672cc0d Reviewed-on: https://chromium-review.googlesource.com/1056403 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#558129}
-
