- 28 Jul, 2018 40 commits
-
-
danakj authored
Pass the DisplayMode to the RenderWidget constructor instead of setting it through set_display_mode() in RenderViewImpl::Initialize(). This makes the chosen DisplayMode explicit for all creators of RenderWidget instead of having a default value. Also store the renderer_wide_named_frame_lookup_ in RenderViewImpl directly in the constructor instead of in Initialize() since it does not need to be there (does not make use of the vtable or anything funky. Make the member const as a result. R=ajwong@chromium.org, avi@chromium.org Bug: 419087 Change-Id: I8d4354d770df8abf5273935412a3d28a98017434 Reviewed-on: https://chromium-review.googlesource.com/1153592 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578930}
-
Peter Kasting authored
This is a reland of 3b7859cb Original change's description: > Add background tab text colors for inactive and incognito windows. > > With the default behavior of Chrome being to not show a tab background, we want > to change themes to default to that as well, unless the theme author actually > supplies an image/color for this explicitly. To do this, we need to support > different tab text colors for the cases where the frame colors can vary. This > adds the framework for that support. > > Right now, the default is to use the same text colors in inactive windows as > active ones. > > This also gives themes that want normal and incognito windows to differ greatly > (as the built-in theme's does) the ability to implement that and still have > readable tab titles. > > Bug: 866672 > Change-Id: I032a72bc799d0675c517db10283513a30db23328 > Reviewed-on: https://chromium-review.googlesource.com/1152418 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578807} Bug: 866672 Change-Id: I2d80ccb2db306655b666d16588bfae59f087639b TBR: estade, bsep Reviewed-on: https://chromium-review.googlesource.com/1154149Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#578929}
-
Pavel Feldman authored
Change-Id: I5d67d97c3dc4a852ad516ebb58de1d24bae599e1 Reviewed-on: https://chromium-review.googlesource.com/1154200Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578928}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d9576eff..d050c7fa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6fde89fd7d3ff81945832165b62a61ec4ef6deeb Reviewed-on: https://chromium-review.googlesource.com/1154202Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578927}
-
Jungshik Shin authored
string-prototype-properties has an errorneous expectation. When a fix for crbug.com/v8/7958 was landed, that led to a test failure. See https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64/25165/layout-test-results/fast/js/string-prototype-properties-pretty-diff.html This CL marks the test for Skip and fix the expectation manually. Once the fix for bug v8:7958 [1] is landed and rolled to Chromium, the Skip line can be dropped. [1] https://chromium-review.googlesource.com/c/v8/v8/+/1154247 TBR=gsathya@chromium.org Bug: v8:7958 Test: fast/js/string-prototype-properties Change-Id: I7402f8a896a073a897d44a16e4ec76ea1fda61fc Reviewed-on: https://chromium-review.googlesource.com/1154289Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578926}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I7f1178ce3c1af8eb5676ce47b927d88c2002dfd3 Reviewed-on: https://chromium-review.googlesource.com/1154307Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578925}
-
Mark Pearson authored
Tested interactively using a new install (no sync), a syncing install, and a syncing install with a custom passphrase. Only the non-custom-passphrase install sends the URL to Google's servers. These tests should be re-run with unified consent enabled before starting a unified consent experiment. Bug: 857589 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic0fba71302cb04da623890daedf7c852324aae31 Reviewed-on: https://chromium-review.googlesource.com/1137096 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#578924}
-
BUG=762641 TBR=stevenjb@chromium.org Change-Id: Id322aa3ea897a50a42719bf958b55f3b258e2b97 Reviewed-on: https://chromium-review.googlesource.com/1154308 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578923}
-
Ken Buchanan authored
Currently when an OOPIF receives an updated viewport intersection rect from its parent, it schedules a lifecycle update. However if the OOPIF is now throttled it will not calculate new intersection observations based on the new viewport rect, and as a consequence any contained OOPIFs will not be throttled. This forces intersection observations whenever an OOPIF has its viewport intersection changed. Bug: 868558 Change-Id: I18c955b8cc40ec2ebe31d1f0fb35aa5a26f9f447 Reviewed-on: https://chromium-review.googlesource.com/1153838 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#578922}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Iecc22e3f634a3bfdd84192fec48c4d3d48d053c5 Reviewed-on: https://chromium-review.googlesource.com/1154312Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#578921}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1e61f6096b9a..e05f902a6929 git log 1e61f6096b9a..e05f902a6929 --date=short --no-merges --format='%ad %ae %s' 2018-07-28 nednguyen@google.com Revert "rendering: Add pipeline metrics." Created with: gclient setdep -r src/third_party/catapult@e05f902a6929 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:855328 TBR=sullivan@chromium.org Change-Id: I1ff64230a3aeebfa2a8f3749fd47053320dddcef Reviewed-on: https://chromium-review.googlesource.com/1154174Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578920}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6192d6f0f94b..dd0e9db48d2e git log 6192d6f0f94b..dd0e9db48d2e --date=short --no-merges --format='%ad %ae %s' 2018-07-28 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 306b6c168dc7..5b3b5cc126a7 (1 commits) Created with: gclient setdep -r src/third_party/skia@dd0e9db48d2e The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I34b031f5936901182ea40fcd0244edd8fcc3e5eb Reviewed-on: https://chromium-review.googlesource.com/1154173Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578919}
-
Pavel Feldman authored
Change-Id: I34db4fd1972bc42289f1f88031057ec7dfd4e5f8 Reviewed-on: https://chromium-review.googlesource.com/1154204 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e8b6729e6510..0e00185925aa git log e8b6729e6510..0e00185925aa --date=short --no-merges --format='%ad %ae %s' 2018-07-28 vapier@chromium.org portage_util: rip out concept of "primary overlay" 2018-07-28 vapier@chromium.org cros_test_lib: increase default maxDiff setting Created with: gclient setdep -r src/third_party/chromite@0e00185925aa The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I155950a97e8f8a7f0fb03d8642926a21edbdf4e5 Reviewed-on: https://chromium-review.googlesource.com/1154172Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578917}
-
Christian Fremerey authored
There are several redundant mock implementations of interface VideoCaptureDevice::Client scattered across the test code. This CL consolidates them into a single implementation that is reused where needed. This CL is part of a series, see Design Doc at https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing Bug: 768887 Change-Id: Iaec91f3ad4956eeb6a265631bf9029c2baeaf7fe Reviewed-on: https://chromium-review.googlesource.com/1124972Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#578916}
-
Yoichi Osato authored
blink creates CompositedSelection to represent rendered selection edges to show selection handles on mobile/chromeOS. Then ChromeClientImpl converts it to LayerSelection. However, since CompositedSelection type is only used there, that is redundant conversion. This patch refactors to create LayerSelection directly. TEST: webkit_unit_tests --gtest_filter=*RenderedPosition*:*CompositedSelectionBoundsTest* Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6a5d55426410e04a7ef03437af076163b1fc855f Reviewed-on: https://chromium-review.googlesource.com/1144907Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#578915}
-
Ian Kilpatrick authored
This is just a cleanup and should have no behavioral change. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If69feb08df2f5247e09654d7ae0d7d1201a2d47a Bug: 635619 Reviewed-on: https://chromium-review.googlesource.com/1150623 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578914}
-
dpapad authored
This not only results to smaller file size, but also makes the code more portable, since it is less dependent on chrome:// URLs, and can eventually lead to running those elements and tests outside the context of a browser_tests and without js2gtest. Bug: 866236 Change-Id: I26b4a22f61b10cbbd1a19c5e055bb5c0f2aaf471 Reviewed-on: https://chromium-review.googlesource.com/1150931Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#578913}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/201a484d..d9576eff Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I28dc165546b82d0a75ab68b5e87c337c901363d2 Reviewed-on: https://chromium-review.googlesource.com/1154191Reviewed-by:
-
rbpotter authored
These tooltips do not exist in the original UI and were accidentally added to the new one. Since the text is identical to the displayed title, there is no reason for them to exist. Remove them by renaming the "title" property to "listName", as the title attribute is used to create tooltips. Bug: 867838 Change-Id: Ie2e6dfa5bd38f9a7c2aea80b2742a46abd866aa1 Reviewed-on: https://chromium-review.googlesource.com/1152451 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#578911}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ee78b5c0fb0f..e8b6729e6510 git log ee78b5c0fb0f..e8b6729e6510 --date=short --no-merges --format='%ad %ae %s' 2018-07-28 vapier@chromium.org validation_pool: fix lint error in previous commit 2018-07-28 dhanyaganesh@chromium.org chromite: Starter Guide 2018-07-28 dgarrett@google.com prototype-firmwarebranch: Create/publish artifacts. 2018-07-28 vapier@chromium.org signing: convert README to markdown Created with: gclient setdep -r src/third_party/chromite@e8b6729e6510 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib0241e31f3a47f231d02a8c6363c483233fc98fa Reviewed-on: https://chromium-review.googlesource.com/1154171Reviewed-by:
-
Eric Karl authored
This reverts commit b148b478. This change was causing hangs on Android. Was able to repro locally and bisect with high confidence. I agree that this logically should be removable, but for some reason isn't. We should re-visit in a future milestone. TBR=danakj,piman Bug: 846709 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1029fa57bc3bfb919121535fc2b70f6884e88a15 Reviewed-on: https://chromium-review.googlesource.com/1154198Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#578909}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Id43ff4f2cb9fb28fa1d7e86123255e2830bbe5ee Reviewed-on: https://chromium-review.googlesource.com/1153857Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#578908}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b9813d2fdd13..1e61f6096b9a git log b9813d2fdd13..1e61f6096b9a --date=short --no-merges --format='%ad %ae %s' 2018-07-27 dtu@chromium.org [pinpoint] Use Material metrics for margins, gutters, and base font. 2018-07-27 simonhatch@chromium.org Switch to using new LUCI linux tryserver. 2018-07-27 dtu@chromium.org [pinpoint] Side-by-side commit comparisons view. Created with: gclient setdep -r src/third_party/catapult@1e61f6096b9a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:825434 TBR=sullivan@chromium.org Change-Id: Ia6d699368a00d6a132d4318a923f7fe8a4880ff8 Reviewed-on: https://chromium-review.googlesource.com/1154008Reviewed-by:
-
Aldo Culquicondor authored
The backing SkMatrix constructor is also constexpr. The change made evident unused variables by the compiler. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7a9ba10e30cd12cb35dbdb369274374c8403a550 Reviewed-on: https://chromium-review.googlesource.com/1153451Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#578906}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/865c199d93d8..42c75b14f495 git log 865c199d93d8..42c75b14f495 --date=short --no-merges --format='%ad %ae %s' 2018-07-27 buildbot@webrtc.org Roll chromium_revision 8c2846e5..743fc877 (578726:578837) Created with: gclient setdep -r src/third_party/webrtc@42c75b14f495 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2cfb614c3ebb31396205d8a5f34abf2ae7b84a8a Reviewed-on: https://chromium-review.googlesource.com/1154169Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578905}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/80eb42ba9ee8..6192d6f0f94b git log 80eb42ba9ee8..6192d6f0f94b --date=short --no-merges --format='%ad %ae %s' 2018-07-28 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 21e9baf71e6e..306b6c168dc7 (7 commits) Created with: gclient setdep -r src/third_party/skia@6192d6f0f94b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I679bc7dfd66c295f05769611c293a3d10ef22ffa Reviewed-on: https://chromium-review.googlesource.com/1154170Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0415e02db77d..8584902d81ff git log 0415e02db77d..8584902d81ff --date=short --no-merges --format='%ad %ae %s' 2018-07-28 tsepez@chromium.org Remove CXFA_TraverseStrategy_ContentLayoutItem. 2018-07-28 tsepez@chromium.org Add CPDSDK_Annot::AsBAAnnot() checked downcast method 2018-07-28 tsepez@chromium.org Add ToXML{Instruction,Text,CharData}() checked conversion functions Created with: gclient setdep -r src/third_party/pdfium@8584902d81ff The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I23a32da297352d94c9778b2d92fbce59b72c2f6f Reviewed-on: https://chromium-review.googlesource.com/1154167Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578903}
-
Jun Mukai authored
ash/shell.h is referred in the file, but it turns out unnecessary. Simply removing the include is just fine. TBR=stevenjb@chromium.org Bug: 646565 Test: build succeeds Change-Id: Ic0709c0bcb4a01b5fd2744ad89fb53c0936b2088 Reviewed-on: https://chromium-review.googlesource.com/1148931 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#578902}
-
Kenneth Russell authored
Pass --disable-features=WebRTC-H264WithOpenH264FFmpeg to viz_content_browsertests on "chromium.win:Win10 Tests x64" similarly to how it's being done for content_browsertests. Tbr: dpranke@chromium.org Bug: 867536 Change-Id: Ib04e95a3b1dd94b29027f7cda26b5780e1a16a92 Reviewed-on: https://chromium-review.googlesource.com/1154141Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578901}
-
Alexey Kozyatinskiy authored
Some clients needs to intercept messages on frontend side. BUG=none R=pfeldman@chromium.org Change-Id: Ia14cc0a88ae91eead3834a47276ddcfc6701bcf7 Reviewed-on: https://chromium-review.googlesource.com/1154036 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578900}
-
Takuto Ikuta authored
This is a part of effort to remove /wd4018 warning suppression. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1152755 This CL was uploaded by git cl split. R=ortuno@chromium.org Bug: 868248, 588506 Change-Id: I6f381e608322431356681f57a315271dca409d83 Reviewed-on: https://chromium-review.googlesource.com/1152843Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#578899}
-
Peter Kasting authored
This is a reland of 8c35e22c Original change's description: > Add background tab colors and inactive images to the theme system. > > These will eventually be used for three purposes: > (1) To allow generating different background tab images from a common tint for > the inactive and incognito cases, thus allowing background tabs that blend > into the frame for custom themes. > (2) To allow autogenerating the background tab colors from the background tab > images, thus letting us autocalculate better tab text/separator/etc. colors. > (3) To allow theme authors to customize/override this behavior more precisely. > > Reasons (1) and (2) dictated the design here; reason (3) is basically a free > bonus. I thought about not making these resources overrideable by theme > authors, but there was some technical reason that turned out to not be easily > feasible, and there seems little reason to prevent it. > > This also allows us to read THEME_TAB_BACKGROUND_INCOGNITO on Mac (Views). > > This shouldn't result in a visual change on its own. > > Bug: 862664 > Change-Id: Icc57f78fd526d68b83c692fbac669a7371bb38ff > Reviewed-on: https://chromium-review.googlesource.com/1147869 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578790} Bug: 862664 Change-Id: I341bbce16853095f17b2608a7639bf0fd105c2cc TBR: estade, oshima, bsep, kylixrd Reviewed-on: https://chromium-review.googlesource.com/1154148Reviewed-by:
-
Alexey Baskakov authored
This is a move-and-rename CL, no behavior changes. Results: - web_app_shortcut.h contains extension-independent stuff. - web_app_extension_shortcut.h contains extension-based code. - All shortcut-related code moved from shell_integration_linux.cc to web_app_shortcut_linux.cc (so no circular dependency on web_app.h) This CL untangles all circular dependencies listed in web_applications/BUILD.gn. Modernize: - Replace arraysize with base::size. - UTF8String -> SysNSStringToUTF8. - BindOnce. Bug: 862049 Change-Id: I9bf098d00f363aa8ed1a0c45514dc04cb9923e9e Reviewed-on: https://chromium-review.googlesource.com/1138042 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#578897}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/306b6c168dc7..5b3b5cc126a7 git log 306b6c168dc7..5b3b5cc126a7 --date=short --no-merges --format='%ad %ae %s' 2018-07-28 zmo@chromium.org Suppress more tests on Android for NVIDIA Shield TV bot. Created with: gclient setdep -r src/third_party/angle@5b3b5cc126a7 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Idce15cae04293f8c304882fc94690016a281cd69 Reviewed-on: https://chromium-review.googlesource.com/1154168Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578896}
-
Khushal authored
Currently skia is limited to ES 2.0 for GPU raster, also apply this limitation for OOP raster since we suspect this might be causing crashes on Adreno (TM) 405 devices. TBR=vollick@chromium.org R=piman@chromium.org Bug: 866613 Change-Id: Icd4ed5116a28a31e3b4ba2121955fa595d837f33 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1083883 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#578895}
-
Sergey Ulanov authored
Previously runner scripts were capturing debug logs from test instance only after successful SSH connection to the test device. This made it hard to debug issues that break system boot (mainly after SDK updates). This CL sets SSH connect timeout to 5 seconds (previously there was no timeout) and updates Target._WaitUntilReady() to capture logs with loglistener while waiting for SSH connection. The logs are printed to the output after second failed connection attempt. Change-Id: I4b57d3a13f3baa520d9e7bdd08a6e6a9236e7ecc Reviewed-on: https://chromium-review.googlesource.com/1148939 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Xunran Ding authored
Bug: 760102 Change-Id: I3811976622dcc06845ac970de7436d7f1fb6896e Reviewed-on: https://chromium-review.googlesource.com/1146122Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Xunran Ding <xunran.ding@samsung.com> Cr-Commit-Position: refs/heads/master@{#578893}
-
Zhenyao Mo authored
BUG=868596 TEST=GPU FYI TBR=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1e32c3dfa4a6b8ea07b92159793fe8749f6ae031 Reviewed-on: https://chromium-review.googlesource.com/1154042 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#578892}
-
Peter Collingbourne authored
This is a reland of e3971799 Fixed test failures under msan, which were caused by accessing memory which was uninitialized because the read was invalid. All such accesses are now protected with a validity check. Original change's description: > cc, gpu: Make serialization code bitness agnostic. > > With this change we use the same serialization regardless of whether > we are targeting a 32-bit or a 64-bit machine. > > Bug: 865796 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I7a9f0a3b5d25569693bb5efec73c3f5cd256c39b > Reviewed-on: https://chromium-review.googlesource.com/1139106 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Peter Collingbourne <pcc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577038} Bug: 865796 Change-Id: Id9dae1d2e5e2389ce96574c917314d63f5de5494 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1152370Reviewed-by:
-
