- 06 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5ada98d0bb33..698b56a8f024 git log 5ada98d0bb33..698b56a8f024 --date=short --no-merges --format='%ad %ae %s' 2019-08-05 afdx@google.com Add 'copy object' transformation (#2766) 2019-08-02 paulthomson@users.noreply.github.com fuzz: change output extension and fix usage string (#2778) 2019-08-01 geoff@vonture.net Remove extra ';' after member function definition. (#2780) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@698b56a8f024 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@chromium.org Bug: None Change-Id: I25899d747028e6b74209da308804b9fcc74a98ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739127Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684322}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/131b9f32457c..c802efc06a40 git log 131b9f32457c..c802efc06a40 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 perezju@chromium.org [Telemetry] Add content types to artifacts Created with: gclient setdep -r src/third_party/catapult@c802efc06a40 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:966835 Change-Id: Ie30c1734cc76cc7533e1e924c49b4289afddfb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739130Reviewed-by:
-
Antonio Gomes authored
CL also converts an instance of base::Bind, routing it to CrossThreadBindingRepeating. BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ifbc6ea703c425697f7cbfd41e854365266def511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736930 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#684320}
-
Dominic Farolino authored
This CL adds prefetch browsertests for main-resources, and subresources to ensure that the main-resource implementation doesn't break SplitCache. The tests all run with the SplitCacheByNetworkIsolationKey feature enabled to prepare for the implementation of Cross-origin Prefetch + SplitCache. The scenarios tested are as follow: - Cross-origin as=document prefetch reuse as top-level-navigation - This tests that the cross-origin resource is cached with a NetworkIsolationKey corresponding to its origin. Therefore, it can be reused for top-level-navigations - Cross-origin as=document prefetch not reused as cross-origin subresource - This tests that even though cross-origin as=document prefetches are cached under an atypical NetworkIsolationKey, their reuse is restricted to top-level-navigations. - Cross-origin prefetch subresources are not able to be reused from cache in a cross-origin context. (AKA, we didn't break SplitCache). - Cross-origin prefetch subresources are able to be reused by the frame that fetched them. (AKA, we still didn't break SplitCache). - Cross-origin prefetch subresources not reused as top-level navigations - As the comment in the code suggests, even though this is safe, a resource must be committed to a single cache partition. Therefore, if a cross-origin subresource is prefetched, it cannot be used anywhere else but in the frame that fetched it. R=kinuko@chromium.org, yhirano@chromium.org Bug: 939317 Change-Id: Ie50844463a838c5fabd5a153cd0caf720a59da4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732869 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#684319}
-
Jan Wilken Dörrie authored
This change updated leak_detection_api.proto to use the LookupSingleLeak messages. Furthermore, it drops the PasswordsLeakCheckService definition, as this is not necessary for a REST API call. Bug: 986298 Change-Id: I0ad7e48ce3892cb46b8d0ed08f4a44de6b3a7212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738693Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#684318}
-
Ren-Pei Zeng authored
Use the VAAPI frame mapper instead of the linear frame mapper (i.e. mmap()) to read the correctly synced output frame of MJDA. Bug: 991136, b:120057531 Test: jpeg_decode_accelerator_unittest Change-Id: Ibf3bee74176fa879a800bcd893ab9f222e65ebbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739306Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684317}
-
Antonio Gomes authored
... from WTF, instead of std::string and std::vector, respectively. Additionally, this CL also moves this file out of the Blink exposed API. Note that not all std::vector use from media_stream_constraints_util_audio.cc used replaced, given that it, it requires unrelated changes to media_stream_constraints_util_sets.h. BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ie2f5565fc0c320a16fc5afa4c71a27431e319881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737016 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Owen Min authored
Also rename DevicePolicy to DeviceLocalAccountPolicy in PolicyConversion. Bug: 989249, 983174 Change-Id: I05219823615a429d991d225119ffcc4541a5b790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726797Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#684315}
-
arthursonzogni authored
All the tests are failing for the same reason. The NavigatonSimulator needs to be updated to take into account the navigations using the BackForwardCache. Bug: 989924 Change-Id: If79b33ca9217771e073b06c5fab5b020d0ad598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738375Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#684314}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If2e3299848b12319ec9674c74b59222127362195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738809Reviewed-by:
-
Amr Aboelkher authored
Show the dictation accessibility feature only if one of the following conditions have meet : -Its not being controlled by any policy -Its being controlled by a policy and the value of the policy is force on Bug: 552439 Change-Id: Id76a331ecfaed2fdcf24a65bd56552287b92bb9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725640 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#684312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f3e8b89c4fe8..fc89641e4a1d Created with: gclient setdep -r src-internal@fc89641e4a1d The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic5ba4efdde08030400abb68c6641086327ccb9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739131Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684311}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd07fe70..2ec7afe6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iea41d910ecfdb5d716d58eb517c871246dd1aa92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739286Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684310}
-
Marc Treib authored
Previously, these tests were reusing TestNavigationObserver instances for multiple navigations, which apparently doesn't work. This CL moves the TestNavigationObserver stuff directly into the NavigateTabBack/Forward helpers, so that individual tests don't have to care about this. Note that the similar NavigateTab helper uses ui_test_utils::NavigateToURL which already does the waiting, so nothing else is required there. Bug: 972871 Change-Id: Iafa796be4da091afcdb279824c6c873f4e6ae62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736682Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#684309}
-
Marc Treib authored
Bug: 988161 Change-Id: I911dc2a215646fccac401d1b76324531cb59d42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738369 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7ba3b81ff5da..a22cab8a6532 git log 7ba3b81ff5da..a22cab8a6532 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 tommi@webrtc.org Calling DebugBreak() on Windows during fatal checks instead of relying on abort(). Created with: gclient setdep -r src/third_party/webrtc@a22cab8a6532 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Iea149c4af5f4fec88d397a58b2ac481e52af532a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738808Reviewed-by:
-
Gabriel Charette authored
Made equivalent to MOCK_TIME in crrev.com/683487 Usage migrated in crrev.com/683751 R=kylechar@chromium.org Bug: 905412 Change-Id: Icae6b24300a4e9a11e486244178cd34f46a73a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733931Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#684306}
-
Synthia Islam authored
Remove obsolete sconsdep attribute from Grit Bug: 961834 Change-Id: Idbc1d0b95b3e8fd4a0170ae10df8dd9c6f02eb82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736687Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#684305}
-
Robbie Gibson authored
This CL adds support for dark mode colors when in incognito mode. Before, there were specific incognito colors. Now, in incognito mode, the popup is forced into dark mode, so it will use the same colors. Bug: 976662 Change-Id: I1ed6c506b284f82810b5a85686181fc04fe69d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738587Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#684304}
-
Sergio Villar Senin authored
It's using a double to represent a duration. It's much better to represent it with a base::TimeDelta. Changing this public API implies some changes in Blink's HTTP handling code due to the changes in a few FrameScheduledNavigation() methods. There is a non trivial change in HTTP parsers as the delay is now a TimeDelta instead of a double. Errors in parsing used to be represented by NaN, they will be TimeDelta::Max() from now on. Bug: 988343 Change-Id: Iad2a2d0171cf58a4c61c1d20df8b3a168a980923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728574 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLContentElement> and DynamicTo<HTMLContentElement> as new downcast helper. 2. Use IsA<HTMLContentElement>(element) in place of IsHTMLContentElement(element) Bug: 891908 Change-Id: I8e6eae009ee88c57b3e1fada60297d86e14e6ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738137Reviewed-by:
-
Mikel Astiz authored
This allows a more controller clearing of the policy errors via the repurposed ResetDataTypePolicyErrorFor(), which doesn't have any caller as of today. Bug: 990802 Change-Id: I90aefa3437cc1ef9a130b2df62c29e6940bee8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735165Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#684301}
-
Antonio Gomes authored
BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: Icfae38257a342453542f7685d43020875c834159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736835 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Ivana Zuzic authored
Enable calling the native ChangeSavedPassword method from the Java side. Bug: 377410 Change-Id: I7d83090c9ca04032a308a61e40c0e51af1162dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735585Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bdc909653e31..7ba3b81ff5da git log bdc909653e31..7ba3b81ff5da --date=short --no-merges --format='%ad %ae %s' 2019-08-06 nisse@webrtc.org Delete class PlatformFile. 2019-08-06 kron@webrtc.org Fix RtpFrameReferenceFinderFuzzer to not generate invalid input 2019-08-06 tommi@webrtc.org Fix CallStatsUnittests to update the RTT on the process thread (as in production). 2019-08-06 nisse@webrtc.org Split out RtcpCnameCallback from RtcpStatisticsCallback 2019-08-06 nisse@webrtc.org In ChannelReceive, use AcmReceiver directly, not AudioCodingModule 2019-08-06 tommi@webrtc.org Call Call::GetStats() from the correct thread in our bandwidth tests. 2019-08-06 tommi@webrtc.org Fix RampUp tests to call Call::GetStats() from the right thread - and remove the need for a dedicated polling thread. Created with: gclient setdep -r src/third_party/webrtc@7ba3b81ff5da The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:989856 Change-Id: I53c3b88f75bf2efd62cf097aeefc3570d8ace740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738987Reviewed-by:
-
Alexander Dunaev authored
Ozone platforms used DesktopBrowserFrameAura that lacks X11 integration code, which resulted in that the frame looked wrong, and the 'Show system title bar' option didn't work. This CL switches Ozone to use DesktopBrowserFrameAuraX11 that has the aforementioned integration. As DesktopBrowserFrameAuraX11 is now used in all Linux desktop builds, it is renamed into DesktopBrowserFrameAuraLinux. Bug: 987935 Change-Id: Ibce554525eadee93e92ca8b1154f8f3bb8ab4bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726056Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#684297}
-
Antonio Gomes authored
CL also switches VideoDeviceCaptureCapabilities away from std::vector and moves media_stream_constraints_util_video_device.h out of the Blink exposed API. BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: I53997a8de421f6c30e8d0c893502ff3334fb739d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736847 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0bfd2c8eb302..f3e8b89c4fe8 Created with: gclient setdep -r src-internal@f3e8b89c4fe8 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib7486e64f6ee02f6f324c9d416137bdbb88f15bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738988Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5c00781543cc..131b9f32457c git log 5c00781543cc..131b9f32457c --date=short --no-merges --format='%ad %ae %s' 2019-08-06 perezju@chromium.org [Telemetry] Fix typo Created with: gclient setdep -r src/third_party/catapult@131b9f32457c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:985712 Change-Id: Id3deb854da8fced5f84056ced82313fef8e823ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738986Reviewed-by:
-
Dominick Ng authored
BUG=None Change-Id: I859ffac541cf895c3317579454ca21bbd8b4593d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738148 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Auto-Submit: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#684293}
-
Mugdha Lakhani authored
Allow 'periodic-background-sync' when the runtime feature is enabled. We currently deny 'periodic-background-sync' permission if the base::Feature kPeriodicBackgroundSync is disabled. Since the permission can't be parsed at all if the runtime feature is disabled, this check is unnecessary. Furthermore, this check prevents users with origin trials enabled from using the feature. Bug: 991145 Change-Id: Icf88c854ecb39d22d1878556a4c5a5b17350e321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738370 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#684292}
-
Jan Wilken Dörrie authored
This change adds a network::SharedURLLoaderFactory member to the AuthenticatedLeakCheck class and modifies the PasswordManagerClient to make this class accessible. The SharedURLLoaderFactory will be required to talk to the identity leak look-up endpoint. Bug: 986298 Change-Id: Icdf32dc2e0d8dd927294316c288b9b94a54ed9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736678 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Stephane Zermatten authored
This change adds metric to track calls to: ChromeActivity.onGetDirectActions, which is made by the system when the user triggers the assist app while Chrome is the foreground app. This is mapped to a user action. ChromeActivity.onPerformDirectAction which is made by the system when the user triggers the assist app while Chrome is the foreground app. This is mapped to a enum histogram, to be able to track the different outcomes of such a call: - the action was not recognized - the action was recognized and performed and which action that was Since the set of direct actions is open, there's a catch-all "other", which shouldn't be triggered, as all actions allowed by the DirectAction feature are part of the histogram value. Bug: 959841 Bug: b/138918753 Change-Id: I833bfbeb03e832e2c770e104685b34afb56bd55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736354 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#684290}
-
Ruslan Burakov authored
Bug: 990342 Change-Id: I54c4ca1c0212ad737d67ba67828914ebfafdc7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733488Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Ruslan Burakov <kuddai@google.com> Cr-Commit-Position: refs/heads/master@{#684289}
-
Takashi Toyoshima authored
If FileURLDirectoryLoader has a net::DirectoryLister instance running, it continues to call MaybeTransferPendingData() until the listing finishes. If a connection error happens on the mojo interface, it results in resetting |data_producer_|, and it causes a null pointer dereference. This issue was introduced after the last branch-cut. So only m78 is affected. Bug: 990579 Change-Id: I58f73d59022f89c82409e5fc10a6cb2a419b94d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735241Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
-
Yuki Shiino authored
Implements grouping of union types. Bug: 839389 Change-Id: I0b309eb5bdd3a63b719eef35e0a3cd21e8068b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733586 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#684287}
-
Omer Katz authored
With concurrent marking and without TryMark, the same object can be marked and pushed to the worklist more than once (i.e. by both mutator and visitors), meaning the object will be traced multiple times. Bug: 986235 Change-Id: I6d0d8a9da79da9d459b137082f91c9125fafd8e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731838 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#684286}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5c3c17c8711c..0bfd2c8eb302 Created with: gclient setdep -r src-internal@0bfd2c8eb302 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: If091fda4ebbcb7939434a7ae15a9b4b435dbe188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738327Reviewed-by:
-
Adam Rice authored
In the JavaScript API for underlying sinks, they usually capture the controller if they need it in the start() method. However, the C++ UnderlyingSinkBase needs to store the controller internally for its own use. It's wasteful for subclasses to take their own copy. Instead expose it to subclasses directly via a protected getter. This getter will be used by the implementation of WebSocketStream. See the design doc at https://docs.google.com/document/d/1XuxEshh5VYBYm1qRVKordTamCOsR-uGQBCYFcHXP4L0/edit. Also fix a bug in the generic version of WritableStreamDefaultControllerInterface::Error(). BUG=983030 Change-Id: I5339f9117f52b78947592b417cb595b2fa496c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734738Reviewed-by:
-
Robbie Gibson authored
Bug: 976664 Change-Id: I8b1cdcd88d5a76a91433f86c68f2a728770777d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731844Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#684283}
-
