GitLab

This patch plumbs PaintImage into PaintShaders instead of SkImage.
With the patch to not construct SkPaint and instead using PaintFlags,
it becomes possible to introspect the flags to pull off PaintImage used
to construct it.

R=khushalsagar@chromium.org, chrishtr@chromium.org

Change-Id: Ia01ce40b1586b90172421ba99009baeb604fd937
Reviewed-on: https://chromium-review.googlesource.com/576868Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488812}

R=robliao@chromium.org

Bug: 689520
Change-Id: Id5e138389b16c02a612d000007c2447cd1e2701d
Reviewed-on: https://chromium-review.googlesource.com/580527Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488811}

The w3c spec indicates that parsing an unsupported value for referrer
meta tags should not result in a referrer policy change.  However, when
WKWebView detects one of these tags, it will change the policy to
'never'.

testWebReferrerOpenInNewTab verifies this observed behavior of WKWebView
but https://codereview.chromium.org/2918313002/ updated
ReferrerPolicyFromString() to assume strict adherance to the latest spec
rather than WKWebView's actual implementation.  This change updates the
context menu param construction to use 'never' for unsupported referrer
meta tag values so that the policy is consistently defaulted to 'never'
for pages that are opened in a new Tab.

w3c spec: https://w3c.github.io/webappsec-referrer-policy/#unknown-policy-values

Bug: 733202
Change-Id: I74772f799a78c726601debddf64dd8f9ebbb2e0e
Reviewed-on: https://chromium-review.googlesource.com/580630
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488810}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/913ccf82..d725114e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I7c1bf2d1fb39c5970fa70538e96ad5e36ba533f4
Reviewed-on: https://chromium-review.googlesource.com/582078Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488809}

SwiftShader's linear texture filtering precision was insufficient to
pass some of the layout tests. In order to have the option to switch
between high precision and high performance, a new chromium extension
was added and implemented in SwiftShader. That extension is now added
in this cl, along with the appropriate usage which would trigger high
precision filtering within SwiftShader when running layout tests.

Bug: 726075
Change-Id: I69406e460595225b2436bb393f64144ff3ad7a1a
Reviewed-on: https://chromium-review.googlesource.com/579787Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: John Bauman <jbauman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488808}

The typemapping makes it super error-prone and painful to add fields and
now that we are out of base/ we don't need it anymore!

Bug: 728199
Change-Id: I1312aad0811291ec6cf69aa83d79fbb6d1a6aa84
Reviewed-on: https://chromium-review.googlesource.com/567185Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488807}

This eliminates the inconsistent 'beaker' image and replaces it with
a new image. It also merges the 'loading' image with the default image.

Bug: 709917
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I139d8555c2beb7417d1e79b128ae5ca680258084
Reviewed-on: https://chromium-review.googlesource.com/578556Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488806}

V8 change was rolled to Chromium.

TBR=dgozman@chromium.org

Bug: 744797
Change-Id: I5a22edb0c1cc76a4f13bf6b9a9ac576e3df38065
Reviewed-on: https://chromium-review.googlesource.com/582082Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488805}

This reverts commit 317adc6a.

Reason for revert: Caused MSAN test failures.

https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/1887

Original change's description:
> Implement metalayer palette tool in ash.
> 
> Add a new "highlighter" tool using the same fast
> rendering method as laser pointer (CL extracting
> the common base class is to follow).
> 
> Bug: b:63142451
> Change-Id: Id848b77f08ae95c167c527a07aec6ccdf79f49f4
> Reviewed-on: https://chromium-review.googlesource.com/558467
> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
> Reviewed-by: David Reveman <reveman@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488688}

TBR=kaznacheev@chromium.org,reveman@chromium.org,oshima@chromium.org,lhchavez@chromium.org,jdufault@chromium.org

Change-Id: Ifaf586a4374e2bde5abd8d4adecb95bd108f9dea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b:63142451
Reviewed-on: https://chromium-review.googlesource.com/582428Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488804}

Fixed the nit from:
https://chromium-review.googlesource.com/c/577114

Bug: None
Test: Compiles
Change-Id: Ic04e6748532ec6db57b9f7d73121c7b25105c6ed
Reviewed-on: https://chromium-review.googlesource.com/582199Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ryan Chung <ryanchung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488803}

Bug: 747052
Change-Id: I4312c56fc27209167437ba8188d1e2cbd5930565
Reviewed-on: https://chromium-review.googlesource.com/580359
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488802}

Add i2s loopback in order to enable the reference channel for AEC.

Bug: http://b/38428792
Test: built cast_shell_internal_apk, ran assistant with AEC
Change-Id: Ie8c1ecf09bc31050e3cfe61eddf69dc21aba1fce
Reviewed-on: https://chromium-review.googlesource.com/566063
Commit-Queue: Nat Jeffries <njeff@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488801}

HostResolverImpl used to pass all non-numeric host names it received,
including invalid ones, to the system HostResolver. That was changed
in https://chromium-review.googlesource.com/569298 (Since the bad
addresses could be sent over the wire with the async resolver, and
it generally seemed like a bad idea).  And all was right with the world.

Then a DCHECK was added to SystemHostResolverCall for invalid hostnames,
since it should no longer be called with them in production. However,
it turns out the MockHostResolver calls that method directly, bypassing
HostResolverImpl, and does so with IPv6 host names (Or whatever other
stuff is passed to it). In particular, the socks_client_socket_fuzzer
does this by passing in "::1".  This is a legal use of the
MockHostResolver API, not a bug in the fuzzer.  So this CL modifies
MockHostResolver not to do that.

Bug: 747243
Change-Id: Ib4be76f1d03f33bc65a493ac73aae6407ca3383d
Reviewed-on: https://chromium-review.googlesource.com/581788
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488800}

Use a box of six panels in lieu of a GL background color. The floor and
ceiling are now additional elements, drawn later, because they are
selecxtively enabled and disabled based on mode.

Other assorted cleanup along the way.

BUG=

Change-Id: Idbd5ad8188659bb5720ffa75c7e919ae5a2de469
Reviewed-on: https://chromium-review.googlesource.com/581850
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488799}

Bug: 725977
Change-Id: Ia44202d2c6f316fa76c32dc3d1f56f0a4b15dc68
Reviewed-on: https://chromium-review.googlesource.com/575583
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488798}

TODO(robertshield): remove this call and everything that falls off of it.

R=robertshield@chromium.org, thakis@chromium.org

Bug: 667892, 747557
Change-Id: I1ddad1db01f18db6b7121945c1313933c9e2e16b
Reviewed-on: https://chromium-review.googlesource.com/581634
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488797}

This CL rolls EarlGrey to f456370981a612d73eb79df7acf3e7303755e160 to
pick up the latest changes and prepare for iOS 11.

BUG= 747116

Change-Id: Idf15fe28e124e99f99740fdee0b79e9de969e406
Reviewed-on: https://chromium-review.googlesource.com/581930
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488796}

This surface ID should still be contained in referenced_surfaces_, but
there are crashes sometimes because the iterator from find is invalid.
Add CHECKs to see if we're attempting to remove the wrong surface id,
or if it's just not found in the structure.

Bug: 745684
Change-Id: Idf4a94f01e55ec20c51b6f72a4c7603c40226df6
Reviewed-on: https://chromium-review.googlesource.com/580404
Commit-Queue: John Bauman <jbauman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488795}

Bug: 747138
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I77e1b33f74f91e5918d9a74f9a79cd8b0de79fc6
Reviewed-on: https://chromium-review.googlesource.com/580675Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488794}

The destruction callback of a GpuMemoryBufferImpls can be called on any
thread[1]. So make sure the destruction callbacks hops onto the correct
thread before mutating local data structures or sending mojo messages.

[1] See doc for GpuMemoryBufferImpl::CreateFromHandle()
https://cs.chromium.org/chromium/src/gpu/ipc/client/gpu_memory_buffer_impl.h?l=28

BUG=733482

Change-Id: Ifc3fecd6a8bb42aa61f3d2d9667bd0e931d7261c
Reviewed-on: https://chromium-review.googlesource.com/565858
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488793}

Previously it would not search any of the native language names, resulting
in missing results.

Bug: 746880
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6fb39d532eb87bf138c22018ca81638b1083a969
Reviewed-on: https://chromium-review.googlesource.com/580250
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488792}

Otherwise if app handles a renderer crash, then all browser crashes are
incorrectly suppressed.

Change-Id: Ib092df8783de535e4d281837fcbe16abe2fb53a2
Reviewed-on: https://chromium-review.googlesource.com/582079Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Bo Liu <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488791}

In addition to simplifying the code, this allows providers to do
their initialization in parallel.  None of the providers currently
appear to depend on the order.

May avoid double initializing some providers.

TBR=olivierrobin,manzagop,boliu

Bug: 739895
Change-Id: I8ee97e9deace636c92b0ec27fe34e451798922bd
Reviewed-on: https://chromium-review.googlesource.com/576515Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488790}

Changed query ui into queries + filters
Added flaky tests query
Select all shortcut now selects only expectations.
Fixed sorting bug (dirs and files were mixed)
Speedup startup, and query display

Bug: 726520
Change-Id: I9356455c02e70424ae1e98901fe0e5f56ed675df
Reviewed-on: https://chromium-review.googlesource.com/580827
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488789}

We'd previously set opacity to 0.0 when hiding elements in the
transience manager which makes it tricky to see them when they come
back. With this change, we inform the manager of the desired "opacity
when visible" and it will restore elements to that opacity when
shown again.

Bug: None
Change-Id: I1a941c3032c35adab5afed17a8afc60bd41230f5
Reviewed-on: https://chromium-review.googlesource.com/582069
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488788}

This reverts commit da27a978.

Reason for revert: Still over capacity. Will investigate further next week.

Original change's description:
> Reenable three iOS CQ builders.
> 
> Overall cycle time and compile step time have improved signficantly
> on all three matching waterfall bots since the hardlink workaround
> landed yesterday:
>   - ios-device: http://shortn/_ow7Hr0gN6e
>   - ios-device-xcode-clang: http://shortn/_qdlv49pNuS
>   - ios-simulator-xcode-clang: http://shortn/_LlpTYE0H51
> 
> Bug: 740301, 739556
> Change-Id: Iebf1b1398273d87580d5aaa295231f2a9e33bcaf
> Reviewed-on: https://chromium-review.googlesource.com/579567
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: smut <smut@google.com>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488736}

TBR=smut@google.com,dpranke@chromium.org,jbudorick@chromium.org

Change-Id: I7f66b8f8a01d3ea235ba894063e8c0f5897fa4a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 740301, 739556
Reviewed-on: https://chromium-review.googlesource.com/582449Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488787}

This CL makes keyboard focus highlighting match the text size of a
hyperlink on the EULA screen.

Bug: 732324
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifbfed41f7c52e0089d780917a5431638a92d9476
Reviewed-on: https://chromium-review.googlesource.com/580431Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488786}

The data saver menu footer is supposed to be highlighted when the data
saver in-product help is shown but it is not. This patch fixed it by
changing the ID that is highlighted to be the inflatedID of the app menu footer
view stub.

BUG=747486

Change-Id: Iaf43badcf277dd424fc02fbafa4d27e51c03737c
Reviewed-on: https://chromium-review.googlesource.com/581879Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Angela Shao <angelashao@google.com>
Cr-Commit-Position: refs/heads/master@{#488785}

Async Create MediaDrmBridge. When persistent license support is enabled,
we need to load origin id from persistent storage before create
MediaDrmStorage.

BUG=493521
TEST=Test page, MediaDrmBridgeTest

Review-Url: https://codereview.chromium.org/2823513002
Cr-Commit-Position: refs/heads/master@{#488784}

TEST=run chrome on youtube using eve
BUG=743277

Change-Id: Ie096276779faafed71309372d4fa44ac07054c20
Reviewed-on: https://chromium-review.googlesource.com/581880
Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488783}

The Chrome Cleaner dialog is shown when unwanted software is found on
the user's computer. Currently, if errors occur during communication
with the Chrome Cleaner process or if the user starts the cleanup from
the settings page from a different browser window, the modal dialog
will remain open.

With this CL, the modal dialog is closed by Chrome if the global
ChromeCleanerController object leaves the infected state, either due
to errors or user action on the webui card in the settings page.

Bug: 747077
Change-Id: I3f8ed6288901aa3f9aaa2c2f108ca141fa3d0545
Reviewed-on: https://chromium-review.googlesource.com/578472
Commit-Queue: Ali Tofigh <alito@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Shield <robertshield@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488782}

If the app list is not opened and shelf is visible, swipe up on the shelf
should show the app list.
If the app list is opened, swipe up on the shelf should keep the app list
opened. Tap anywhere else of shelf should close the app list.

This is the basic one currently. Will add some simple animations followed.
(e.g, change the opacity of the searchbox and apps row by row according
to the dragging amount)

Bug: 735999,742461
Change-Id: I5eb8b6d4d006a50720050b34168849e9d57370f2
Reviewed-on: https://chromium-review.googlesource.com/562739
Commit-Queue: min c <minch@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488781}

Changes:
1. Change the focus behavior triggered by tab key in start page view.
Focus should move cyclically like this: search box text field ->
suggestion apps -> expand arrow view -> search box text field.
2. Add unit test for this behavior.

BUG=741015
TEST=AppListViewFullscreenTest.StartPageTabFocusTest

Change-Id: I7467d94b4028ef24422f8236e615f66b195d1f84
Reviewed-on: https://chromium-review.googlesource.com/580498
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488780}

This will revert back to software mirroring, since hardware mirroring
won't work and will result in a black screen.

BUG=b/35583078

Change-Id: Id8496c5966554f5fa866812cd87fc87e3ddd4a92
Reviewed-on: https://chromium-review.googlesource.com/575669Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488779}

inactive. Even if there is only whitespace in the searchbox, it
should still be active. In addition, clearing the searchbox from
the app list view creates easy opportunities for infinite loops.

Bug: 740662
Change-Id: I9806242ac448dfb7a2a0d2af34388aa3fa3c47d8
Reviewed-on: https://chromium-review.googlesource.com/581567
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488778}

It is a feature that allows to collect data from HashTables (e.g. rehashes,
reads, number of collisions, etc).

This change does:
- fixes the functionality for general HashTable stats
- also fixes for individual HashTables

And introduces a public member function (guarded behind a macro)
called DumpStats() that allows to dump the stats from HashMap.

Bug: 735663
Change-Id: I86f826c3d23f02f0d06dba7e0a5a157601bbd4ce
Reviewed-on: https://chromium-review.googlesource.com/556919
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488777}

This is to figure out whether we need to buffer data in the network service's URLLoaderImpl.

BUG=746144

Change-Id: I10a0b5923b8d9fefdceee98bbc07671e53ab4f8d
Reviewed-on: https://chromium-review.googlesource.com/581742
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488776}

R=thakis@chromium.org

Bug: 499415, 689520
Change-Id: I74dac5b0113def0b2c61bcd584e2588174941d4a
Reviewed-on: https://chromium-review.googlesource.com/582147Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488775}

Previously, blink was never properly notified of the browser controls
height when they are at the bottom of the screen. This change updates
Blink's concept of browser controls to include bottom controls,
allowing top and bottom controls to be considered independently as the
two have slightly different behavior. If top controls height is 0, the
manager attempts to base the calculations off the bottom controls.The
result of this is correct viewport sizing for fixed-positioned web
elements when the browser controls are at the bottom of the screen.

BUG=711828

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibcfd6aa6280d884200c03f24c07d3a214fc836c0
Reviewed-on: https://chromium-review.googlesource.com/560641
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488774}

This reverts commit 752bf750.

Reason for revert: Original CL was correct.

Original change's description:
> Revert "ozone: set the right GBM_BO_ flags"
> 
> This reverts commit 2e75e890.
> 
> Reason for revert: Breaks build for veyron_minnie and probably other devices. Sample of the compiler errors below:
> 
> ../../ui/ozone/platform/drm/gpu/drm_thread.cc:120:15: error: use of undeclared identifier 'GBM_BO_USE_TEXTURING'; did you mean 'GBM_BO_USE_RENDERING'?
>       flags = GBM_BO_USE_TEXTURING;
>               ^~~~~~~~~~~~~~~~~~~~
>               GBM_BO_USE_RENDERING
> ../../../.cros_cache/chrome-sdk/tarballs/veyron_minnie+9588.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/include/gbm.h:230:4: note: 'GBM_BO_USE_RENDERING' declared here
>    GBM_BO_USE_RENDERING    = (1 << 2),
>    ^
> 
> 
> Original change's description:
> > ozone: set the right GBM_BO_ flags
> > 
> > minigbm doesn't allow to pass no flags to gbm_bo_create(). GBM_BO_USE_TEXTURING
> > implies texture, so use GBM_BO_USE_TEXTURING to create texture buffer.
> > 
> > GBM_BO_USE_TEXTURING implies GPU_READ. GBM_BO_USE_RENDERING implies GPU_WRITE.
> > BufferUsage::SCANOUT needs both of them because it implies GPU_READ_WRITE.
> > 
> > TEST=run chrome on amd64-generic
> > BUG=683347
> > 
> > Change-Id: I7431be6f5b4a8d95e6be11d86cfbf0c14b919668
> > Reviewed-on: https://chromium-review.googlesource.com/549095
> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> > Reviewed-by: David Reveman <reveman@chromium.org>
> > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
> > Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
> > Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com>
> > Cr-Commit-Position: refs/heads/master@{#488709}
> 
> TBR=marcheu@chromium.org,reveman@chromium.org,dnicoara@chromium.org,dongseong.hwang@intel.com,glevin@chromium.org,dcastagna@chromium.org,gurchetansingh@chromium.org
> 
> Change-Id: I2a8327004c3ba78ca406d08b02b28515c2b2dcf0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 683347
> Reviewed-on: https://chromium-review.googlesource.com/582347
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488762}

TBR=marcheu@chromium.org,reveman@chromium.org,khorimoto@chromium.org,dnicoara@chromium.org,dongseong.hwang@intel.com,glevin@chromium.org,dcastagna@chromium.org,gurchetansingh@chromium.org

Change-Id: I1b8d898a5184dfe17d8f33eda533a39400c78a44
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 683347
Reviewed-on: https://chromium-review.googlesource.com/582310Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488773}