- 06 Dec, 2017 40 commits
-
-
Maria Khomenko authored
The new metric is called PrivateSwapFootprint. It records the value of VmSwap from /proc/<pid>/status and is available only on Linux and Android. This metric is useful for evaluating changes in swap use with memory ablation. BUG=791802 Change-Id: Ica436198fd00d85cd5f5896ce994547a73aea27f Reviewed-on: https://chromium-review.googlesource.com/807358 Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#522256}
-
Darren Shen authored
This patch implements StylePropertyMap.update for CSS properties using get and set. Some tests were wrong because they didn't return a value in the update callback. Spec: https://drafts.css-houdini.org/css-typed-om-1/#dom-stylepropertymap-update Bug: 785132 Change-Id: I6b8a06bfc1dcf0bb35603237d3507d5d3da96182 Reviewed-on: https://chromium-review.googlesource.com/788478Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#522255}
-
Tom Sepez authored
Consolidate comments in header. Move methods around to match order in header. Call common validation routines in broker_command.h from all places. Change-Id: I5317064bc6784d28586685ebd44802c90398abbb Reviewed-on: https://chromium-review.googlesource.com/812205Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#522254}
-
Ian Kilpatrick authored
The existing code for this LayoutBlock::ComputeBlockPreferredLogicalWidths was actually reasonably good, but due to re-use of variables, and a few things which happened over time made it a little convoluted. This hopefully is easier to follow. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6b80bc2228473108e18c5680783668259a8d91b2 Reviewed-on: https://chromium-review.googlesource.com/784675 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#522253}
-
Katie Dektar authored
This would catch a regression that happened last week where mousemove events were not passed properly to the background extension, should it re-occur in the future. Bug: 789598 Change-Id: Idd61c1e63f9dfa4f0e87603b62b0cc0a31a34902 Reviewed-on: https://chromium-review.googlesource.com/806647 Commit-Queue: Katie D <katie@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522252}
-
Evan Stade authored
This reverts commit 6e56b952. Reason for revert: I realized this crashes if a captive portal is detected during login (before there's an active profile). Original change's description: > Chrome OS - Update captive portal notification to use > NotificationDisplayService. > > Test by commenting out most of OnPortalDetectionCompleted() (in addition > to unit tests). > > Bug: 783018 > Change-Id: I403967f28883c588d9c2e5fd43effe05e41f7eda > Reviewed-on: https://chromium-review.googlesource.com/807445 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522214} TBR=stevenjb@chromium.org,sky@chromium.org,estade@chromium.org Change-Id: I951a56b8bb5a9c44e6aeed157cb6cbda88e2be93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783018 Reviewed-on: https://chromium-review.googlesource.com/812470Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#522251}
-
Charles Harrison authored
There have been chrome traces which indicate this throttle is expensive on Android. We should perform some measurements in the wild to see how often this is true. Bug: 792524 Change-Id: I4b35949e0265c9e3b291d623789cbf4fd32d85f0 Reviewed-on: https://chromium-review.googlesource.com/811828Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#522250}
-
Christopher Grant authored
- If PrepareToDraw indicates a scene change, do layout. - Trigger scene rendering if the cursor moved. - Move a static assert to live with TextInputInfo. - Add more tests. BUG= R=mthiesse, ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4f05832610c0d8e0676599bc92b9a926afbbca57 Reviewed-on: https://chromium-review.googlesource.com/809827 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#522249}
-
Reza.Zakerinasab authored
This change removes ImageData usage from toBlob/toDataURL code path from HTMLCanvasElement calls down to the CanvasAsyncBlobCreator. Bug: 792110, 657870 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3e222a68767c1a476f09c1b6188699f62449b95a Reviewed-on: https://chromium-review.googlesource.com/809097Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Olivia Lai <xlai@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#522248}
-
Xianzhu Wang authored
Using the FOR_EACH_XXX(V) pattern, the reason bits are automatically defined without holes or duplicates, with compile-time checks for ranges and validity of the strings array. This makes it easier to add or remove reasons without adjusting the numbers of bits to shift. Also define methods to access the previously exposed data structures. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib88ec47d1cf0ad548f478c30fb40436ba1db12e8 Reviewed-on: https://chromium-review.googlesource.com/811425 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#522247}
-
Dale Curtis authored
Today WTR doesn't report background audio nor anything for video only streams; this change populate UKM with this data. Additionally, audio background data is reported to UMA (because otherwise we'd just lose a large chunk of what we report today), while video only data is just reported to UKM for now. Video only can be enabled later by simply adding the histograms.xml entries and updating the filter in WatchTimeRecorder. All of this is done by essentially removing all restrictions from WatchTimeReporter. We now always construct a background reporter and we always report shown/hidden status regardless of audio/video presence. This will cause a large drop off in Audio listen time since all background time will go into a new background bucket now. While the two metrics should sum to close to the same value, some loss is expected until http://crbug.com/779192 is fixed to roll-up unreported watch time for transition states. BUG=775731,775685,775681 TEST=expanded existing tests to cover all functionality. Change-Id: I55eb69b074d00750b5bd9ed47585380f92c882ca Reviewed-on: https://chromium-review.googlesource.com/809620Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#522246}
-
Sergey Ulanov authored
This is a reland of eec981f1 Original change's description: > Add unittests for AudioOutputStream. > > Previosly there were no cross-platforms tests for AudioOutputStream. > This CL adds new tests that will run on all platforms. The tests > are based on Windows-specific tests in media/audio/win. > > Bug: 737802 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I2accac0d7dc5e5d5ac813923ec6b83c0af6c9da6 > Reviewed-on: https://chromium-review.googlesource.com/702688 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509522} Bug: 737802 Change-Id: Ia3b7953437b484f37a339a90e3db9af1f315bdd9 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/809540Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#522245}
-
Devlin Cronin authored
The Finch Features API (base::Feature and base::FeatureList) now satisfy all the requirements that FeatureSwitch needed to (the ability to toggle from command line, runtime flag, or field trial). The two FeatureSwitch items that used the Field Trial API (yield_between_content_scripts and native_crx_bindings) have been migrated to the Features API. Remove FeatureSwitch support for field trials. Bug: 784476 Bug: 585569 Change-Id: I265b5f687707aeee2e7daf2f45df44ab094e479c Reviewed-on: https://chromium-review.googlesource.com/811290Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522244}
-
Devlin Cronin authored
Add a common ScriptContext getter to retrieve a ScriptContext from a given v8::Context that works across threads. This previously existed, but only in native_extension_bindings_system.cc. Pull it out to a common file to a) make it reusable from other consumers (custom hooks will need to use this) and b) remove (direct) threading knowledge from the bindings system. Bug: 653596 Change-Id: I09a0e4ea76bb891ab1871ca1deb0d315e6e9789d Reviewed-on: https://chromium-review.googlesource.com/812173Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522243}
-
Steven Bennetts authored
Bug: 792641 Change-Id: I6fe3df805cf2efcfded5c3633d07f4931314864c Reviewed-on: https://chromium-review.googlesource.com/809931Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#522242}
-
Jay Civelli authored
Changing names in PDFToPWGRasterConverterService related files from all caps to the style guide preferred way: PDF -> Pdf, PWG -> pwg. Bug: 766451 Change-Id: I6e3329d218a98917bf0a2474d46612dcf91976db Reviewed-on: https://chromium-review.googlesource.com/811450 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#522241}
-
Peter Kasting authored
Bug: 789931, 789947 TBR: zea, qinmin Change-Id: I340a4dd9b3b1176d8bafe3a21f52e26522c41ebe Reviewed-on: https://chromium-review.googlesource.com/811990 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#522240}
-
Alexei Filippov authored
Bug: Change-Id: I55707cbd5cfd5100b72ad6f4c2cd8195ba927b8d Reviewed-on: https://chromium-review.googlesource.com/809497 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#522239}
-
Tibor Goldschwendt authored
Due to a merge mistake the VLOG for failed loading will never be executed. Fix this. Change-Id: I37fe4e2a72e22b1b84eb1fcb8d791371d883ab13 Reviewed-on: https://chromium-review.googlesource.com/812210Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#522238}
-
Marc-Antoine Ruel authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/6fd3c7b6eb7c..4bd9152f8a97 $ git log 6fd3c7b6e..4bd9152f8 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 maruel client/tools: add reproduce.py 2017-12-04 maruel client: isolated unicode fix for Windows 2017-12-04 maruel client: isolated unicode fix on Ubuntu 2017-12-04 maruel tests: more unicode 2017-12-01 maruel client: Fix emoji handling at various places 2017-12-01 maruel example: put tons of emojis in the examples 2017-11-29 maruel subprocess42: be more tolerant to unicode. 2017-11-29 maruel Fix regression in fc3c34e59202ee and bfab799cddab1 2017-11-28 maruel swarming_bot: migrate env mutation from task_runner to run_isolated. 2017-11-23 huangwe Allow None response when the item size is 0 in gRPC isolate push 2017-11-22 iannucci [swarming] Add env_prefixes TaskProperty. 2017-11-20 huangwe Raise gRPC error when gRPC calls for pushing blobs return None 2017-11-13 maruel client: fix missing lock in DiskCache.cleanup() 2017-11-08 vadimsh Refactor httpserver_mock in attempt to get rid of deadlocks. 2017-11-08 vadimsh Add minimal support for Cavium CPUs. Created with: roll-dep src/tools/swarming_client TBR=iannucci@chromium.org Bug: Change-Id: Id39cf767dc415f16c3c08e7bf8340b58a56834f5 Reviewed-on: https://chromium-review.googlesource.com/811205Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#522237}
-
Gregory Chatzinoff authored
The bubble was previously too far away from its target because the Open Tabs Button included a lot of padding around the image. Now, the bubble targets the image directly and has a smaller margin so that it is an appropriate distance away from the target. The unit tests expectations were adjusted downward by 8 to account for this reduction in margin (note that the short text case only went down to 50 px since 50 is the minimum width). Bug: 780977 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1f18df5e9b2d464e1d12b3a04ef87f8166397b18 Reviewed-on: https://chromium-review.googlesource.com/807667Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#522236}
-
Danyao Wang authored
This is the first step to removing _lastRegisteredRequestURL from CRWWebController. See crbug.com/792515 for rationale. There are two use cases for _lastRegisteredRequestURL: 1. As the URL of the pending navigation 2. Detect fast back-forward navigations in |-webViewLoadingStateDidChange| to explicitly trigger |-didFinishNavigation:| NavigationContext::GetUrl() can already support (1). NavigationContext::GetPageTransition() cannot current distinguish fast and slow back-forward navigation. Storing WKNavigationType makes this possible. Bug: 789993,792515 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4a919a48bd1d7755d006dbebff305558e885c8f2 Reviewed-on: https://chromium-review.googlesource.com/806766 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#522235}
-
Ahmed Fakhry authored
This CL adds support to use an output color matrix to transform the display output colors. BUG=749250 TEST=covered by tests Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I77e08126a3f66086885fc668a3f943f696a6215b Reviewed-on: https://chromium-review.googlesource.com/795188Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#522234}
-
Jiaquan He authored
Folders support is always enabled. Bug: 733662 Change-Id: I9c17b452eeaa849771f2c14d23c86e85b59762c9 Reviewed-on: https://chromium-review.googlesource.com/809241 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#522233}
-
Katie Dektar authored
This "mode" was actually a bug. Bug: 792557 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I888cd8c3184f42a3dc3c0fdc1c85d747a2e0090f Reviewed-on: https://chromium-review.googlesource.com/811590Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522232}
-
clamy authored
This CL fixes a security issue where a website could succeed in spoofing the URL of a cross-process navigation by issuing an endless loop of JavaScript navigations. When the cross-site navigation was ready to commit, a renderer-initiated navigation would start, causing the deletion of the speculative RenderFrameHost. However, we would not update the visible URL for the tab, even though the load of the cross-site navigation had stopped (due to the deletion of the speculative RFH). This CL ensures that the pending NavigationEntry is deleted in that case. BUG=760342 Change-Id: Ie24beda484ebd6daca5feb17f74da921eac80ce9 Reviewed-on: https://chromium-review.googlesource.com/808924 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#522231}
-
Thanh Le authored
Group navigation logs with the corresponding decisions message of the navigation. Push the group message to the top of the table when there's a new message in that group. Since navigation logs could be called called much later compared to decision logs, the message group need to float to the top of the table when new messages are added to the group. Bug: 791778 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic872fd155ca25a35286bafaaffde41c2b65a01d4 Reviewed-on: https://chromium-review.googlesource.com/809936 Commit-Queue: Thanh Le <thanhdle@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#522230}
-
Cary Clark authored
Skia upstream change keeps rounded rectangles constructed from SVG convex. This alters some existing SVG layout results. Disable the new behavior pending the rebaseline. TBR=djsollen@chromium.org Bug: b:69622768 Change-Id: Ia32b9cffff4a011bc835eb014f3943e735d6775e Reviewed-on: https://chromium-review.googlesource.com/811840Reviewed-by:
Cary Clark <caryclark@chromium.org> Commit-Queue: Cary Clark <caryclark@chromium.org> Cr-Commit-Position: refs/heads/master@{#522229}
-
Matthew Jones authored
This reverts commit 03ca6202. Reason for revert: Broke scrolling in certain cases Original change's description: > [Home] Separate swipe detecting logic from the bottom sheet > > This change moves all of the swipe detecting from the bottom sheet > into its own class. A relatively simple interface has been introduced > to prevent needing the entire bottom sheet to detect swipes. > > BUG= > > Change-Id: If8c61df4009320e016903d6f1ed0c231c9330e02 > Reviewed-on: https://chromium-review.googlesource.com/792337 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#522147} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org Change-Id: I22743cfe51fa3861d9bc2b44beef0f894fc0b30c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/812266Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#522228}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/c3da1e61bccf..2fb645091977 $ git log c3da1e61b..2fb645091 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0103bd290c6b31c7df8b00f0ceebbc10ccde1348 Reviewed-on: https://chromium-review.googlesource.com/812146Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#522227}
-
Hans Wennborg authored
Recent Clang versions started taking into account that enums are signed on Windows when emitting these warnings. Bug: 792519 Change-Id: I5029cde81ac6f1777ec2317d431d55589b814465 Reviewed-on: https://chromium-review.googlesource.com/811685 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#522226}
-
Xiaoyin Hu authored
This reverts commit 7df02c0d. Reason for revert: Failed desktopui_ScreenLocker autotest Original change's description: > Modify Autotest API to support views based lockscreen > > Bug: 781998 > Change-Id: I11a456b1341d044b1370652c337f105e0bef649a > Reviewed-on: https://chromium-review.googlesource.com/803622 > Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521137} TBR=achuith@chromium.org,jdufault@chromium.org,xiaoyinh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 781998 Change-Id: I547a15a15d2cf3b95986e8cfbf548b95cd0b3087 Reviewed-on: https://chromium-review.googlesource.com/812264Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#522225}
-
Dan Sanders authored
If the load timer fires after an error, and there are no sources, changing the network state can prevent cleanup from running on future load attempts. This CL prevents the network state from changing if a previous load got far enough to have state that requires cleanup. corrupt.* files have enough initial data to start playback, but fail with a decode error shortly after. They were generating like this: $ cp test.mp4 corrupt.mp4 $ dd conv=notrunc if=/dev/urandom of=corrupt.mp4 bs=1024 seek=20 count=20 Bug: 674716 Change-Id: I978af321921c7331829b9384772dc954c20dbc1f Reviewed-on: https://chromium-review.googlesource.com/775891 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#522224}
-
Wez authored
Bug: 792630, 772252 Change-Id: I2cd4ea498cbdd614b3469cf92bd4d7b2ee994b39 Reviewed-on: https://chromium-review.googlesource.com/812209Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#522223}
-
Gregory Chatzinoff authored
Reenable the FeatureEngagement testBadgedREadingListFeatureShouldShow test by increasing the timeout. Bug: 789943 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iace3e1e7c3beb1930ef7c85cc1184ac27665fcff Reviewed-on: https://chromium-review.googlesource.com/812218Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#522222}
-
Matt Reynolds authored
AbstractHapticGamepad encapsulates the logic for translating haptic effect descriptions into a sequence of vibration actuator commands. Users of AbstractHapticGamepad should override SetVibration so that it updates the vibration actuators on the device with the specified intensities. BUG=749295 Change-Id: I3744cd3b06efb7970bd87048996250e52c472919 Reviewed-on: https://chromium-review.googlesource.com/810006Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#522221}
-
Andrew Grieve authored
Makes it easier to add a java_annotation_processor() template This removes main_class from java_prebuilt() in favor of using java_binary() with a jar_path. Bug: 792170 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8b92addae2228398f911d9456b9c55d5ebf48529 Reviewed-on: https://chromium-review.googlesource.com/810032Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#522220}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/307c9f954dc5..a2299532b526 $ git log 307c9f954..a2299532b --date=short --no-merges --format='%ad %ae %s' 2017-12-06 simonhatch Dashboard - Fix /add_histograms from re-adding same diagnostic. 2017-12-06 rnephew [Telemetry/TADA] Make expectation parser only support raw data and not file path. 2017-12-06 perezju [Telemetry] Dump output of "ps" when failing to find PID Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3ee30516264ef4ee24e5f45f6f2c5a9e03a7c31f Reviewed-on: https://chromium-review.googlesource.com/812004 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522219}
-
Jared Saul authored
Bug: 778436 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8ba2a695880a8594a145ecfa9724907253f5ad7f Reviewed-on: https://chromium-review.googlesource.com/752074 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#522218}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4bd2ad8cf901..fd9e0b8f5f92 $ git log 4bd2ad8cf..fd9e0b8f5 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 thestig Fix nits on some font code. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4798f7891d9e82e538880fe193973022703f59cc Reviewed-on: https://chromium-review.googlesource.com/811893 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522217}
-